Re: [PATCH v1] Explanations.cc: Convert to c++ file handling

2021-06-04 Thread Chris Johns
Ok On 5/6/21 4:17 am, Ryan Long wrote: > --- > tester/covoar/Explanations.cc | 45 > --- > 1 file changed, 17 insertions(+), 28 deletions(-) > > diff --git a/tester/covoar/Explanations.cc b/tester/covoar/Explanations.cc > index d94cd2e..1449fb2 100644 >

Re: [PATCH v1 1/6] Explanations.cc: Fix resource leaks

2021-06-04 Thread Chris Johns
On 5/6/21 2:47 am, Ryan Long wrote: > We'll submit the C++ conversions as separate patches since they are larger. > That patch will be submitted shortly. Excellent and thanks. Chris ___ devel mailing list devel@rtems.org

Re: [PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

2021-06-04 Thread Chris Johns
On 5/6/21 8:11 am, Gedare Bloom wrote: > On Fri, Jun 4, 2021 at 1:17 PM Joel Sherrill wrote: >> >> On the surface, this looks OK to me. But I remember looking at this one >> and wondering if there was any cleanup required because of the various >> subroutine calls as you work down through this

Re: [PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

2021-06-04 Thread Gedare Bloom
On Fri, Jun 4, 2021 at 1:17 PM Joel Sherrill wrote: > > On the surface, this looks OK to me. But I remember looking at this one > and wondering if there was any cleanup required because of the various > subroutine calls as you work down through this method. > > Did you look into each of the

Re: GSoC - Code Formatting and Style Checking for RTEMS score

2021-06-04 Thread Ida Delphine
Okay. I will do that. On Fri, 4 Jun 2021, 10:48 pm Gedare Bloom, wrote: > On Fri, Jun 4, 2021 at 2:57 PM Ida Delphine wrote: > > > > Okay, I will take a look. > > > > Regarding me asking a question in the appropriate clang-format mailing > list should it be just regarding the parentheses and

Re: GSoC - Code Formatting and Style Checking for RTEMS score

2021-06-04 Thread Gedare Bloom
On Fri, Jun 4, 2021 at 2:57 PM Ida Delphine wrote: > > Okay, I will take a look. > > Regarding me asking a question in the appropriate clang-format mailing list > should it be just regarding the parentheses and braces being aligned? > That would be the right question to ask, if you can't find a

Re: [PATCH rtems 1/2] cpu/armv7m: Avoid regions with negative size

2021-06-04 Thread Peter Dufault
Looks good to me. > On Jun 4, 2021, at 03:47 , Christian Mauderer > wrote: > > Don't initialze regions that have a negative size (for example due to a > wrong calculation). > > Update #4450 > --- > cpukit/score/cpu/arm/include/rtems/score/armv7m.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: GSoC - Code Formatting and Style Checking for RTEMS score

2021-06-04 Thread Ida Delphine
Okay, I will take a look. Regarding me asking a question in the appropriate clang-format mailing list should it be just regarding the parentheses and braces being aligned? On Fri, Jun 4, 2021 at 8:41 PM Joel Sherrill wrote: > > > On Fri, Jun 4, 2021 at 12:39 PM Gedare Bloom wrote: > >> On

Re: GSoC - Code Formatting and Style Checking for RTEMS score

2021-06-04 Thread Joel Sherrill
On Fri, Jun 4, 2021 at 12:39 PM Gedare Bloom wrote: > On Fri, Jun 4, 2021 at 8:47 AM Joel Sherrill wrote: > > > > > > > > On Fri, Jun 4, 2021 at 12:24 AM Ida Delphine wrote: > >> > >> Hello everyone, > >> > >> I applied the configuration Sebastian used and ran clang-format on >

Re: [PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

2021-06-04 Thread Joel Sherrill
On the surface, this looks OK to me. But I remember looking at this one and wondering if there was any cleanup required because of the various subroutine calls as you work down through this method. Did you look into each of the subroutines called and make sure they didn't do further allocations?

[PATCH] cpukit/libblock/src: Add better memory handling in flashdisk.c

2021-06-04 Thread Harrison Edward Gerber
See also CID 1439298 Closes #3570 --- cpukit/libblock/src/flashdisk.c | 16 1 file changed, 16 insertions(+) diff --git a/cpukit/libblock/src/flashdisk.c b/cpukit/libblock/src/flashdisk.c index 91f99e0d52..4de6ecd807 100644 --- a/cpukit/libblock/src/flashdisk.c +++

[PATCH v1] Explanations.cc: Convert to c++ file handling

2021-06-04 Thread Ryan Long
--- tester/covoar/Explanations.cc | 45 --- 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/tester/covoar/Explanations.cc b/tester/covoar/Explanations.cc index d94cd2e..1449fb2 100644 --- a/tester/covoar/Explanations.cc +++

Re: [PATCH rtems 2/2] bsps/imxrt: Simplify linkcmds and make it flexible

2021-06-04 Thread Gedare Bloom
does this one need doco update for the option changes? On Fri, Jun 4, 2021 at 1:48 AM Christian Mauderer wrote: > > Calling the memory FLASH and EXTRAM instead of FLEXSPI and SDRAM makes > it simpler to support other types of external RAM. This patch also > removes some of the calculations and

Re: [PATCH rtems 1/2] bsps/imxrt: Allow different ARM PLL setting

2021-06-04 Thread Gedare Bloom
On Fri, Jun 4, 2021 at 1:48 AM Christian Mauderer wrote: > > Update #4180 > --- > .../nxp/boards/evkbimxrt1050/clock_config.c | 5 +++ > bsps/arm/imxrt/start/clock-arm-pll-config.c | 33 +++ > spec/build/bsps/arm/imxrt/bspimxrt.yml| 1 + > 3 files changed, 39

Re: [PATCH rtems 2/2] cpu/armv7m: Fix initialization of MPU regions

2021-06-04 Thread Gedare Bloom
ok On Fri, Jun 4, 2021 at 1:47 AM Christian Mauderer wrote: > > The write to RBAR didn't have the valid flag set. Therefore the write to > RASR had an influence on the previously set region. That means for > example that if Region 0 had been enabled but 1 should be disabled due > to a size of 0,

Re: GSoC - Code Formatting and Style Checking for RTEMS score

2021-06-04 Thread Gedare Bloom
On Fri, Jun 4, 2021 at 8:47 AM Joel Sherrill wrote: > > > > On Fri, Jun 4, 2021 at 12:24 AM Ida Delphine wrote: >> >> Hello everyone, >> >> I applied the configuration Sebastian used and ran clang-format on >> cpukit/score/src/threadqenque.c and so far these are the differences I could >>

RE: [PATCH v1 1/6] Explanations.cc: Fix resource leaks

2021-06-04 Thread Ryan Long
We'll submit the C++ conversions as separate patches since they are larger. That patch will be submitted shortly. -Original Message- From: Chris Johns Sent: Friday, May 28, 2021 8:05 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH v1 1/6] Explanations.cc: Fix resource leaks On

Re: GSoC - Code Formatting and Style Checking for RTEMS score

2021-06-04 Thread Joel Sherrill
On Fri, Jun 4, 2021 at 12:24 AM Ida Delphine wrote: > Hello everyone, > > I applied the configuration Sebastian used and ran clang-format on > cpukit/score/src/threadqenque.c and so far these are the differences I > could notice... > Below are some example areas in the code you can spot the

Re: Selection of ethernet peripheral by application

2021-06-04 Thread Joel Sherrill
On Fri, Jun 4, 2021 at 7:59 AM Kinsey Moore wrote: > On 6/4/2021 02:32, Christian MAUDERER wrote: > > Am 02.06.21 um 20:37 schrieb Kinsey Moore: > >> Hello, > >> > >> From what I’ve seen of the various BSPs supported by LibBSD that > >> have multiple ethernet peripherals, > >> > >> only one

Re: Selection of ethernet peripheral by application

2021-06-04 Thread Kinsey Moore
On 6/4/2021 02:32, Christian MAUDERER wrote: Am 02.06.21 um 20:37 schrieb Kinsey Moore: Hello,  From what I’ve seen of the various BSPs supported by LibBSD that have multiple ethernet peripherals, only one tends to be chosen and supported. I’ve encountered a situation where the majority of

[PATCH rtems 1/2] bsps/imxrt: Allow different ARM PLL setting

2021-06-04 Thread Christian Mauderer
Update #4180 --- .../nxp/boards/evkbimxrt1050/clock_config.c | 5 +++ bsps/arm/imxrt/start/clock-arm-pll-config.c | 33 +++ spec/build/bsps/arm/imxrt/bspimxrt.yml| 1 + 3 files changed, 39 insertions(+) create mode 100644 bsps/arm/imxrt/start/clock-arm-pll-config.c

[PATCH rtems 2/2] bsps/imxrt: Simplify linkcmds and make it flexible

2021-06-04 Thread Christian Mauderer
Calling the memory FLASH and EXTRAM instead of FLEXSPI and SDRAM makes it simpler to support other types of external RAM. This patch also removes some of the calculations and improves names and documentation to avoid pitfalls. It removes a unnecessary memory definition. Update #4180 ---

[PATCH rtems 2/2] cpu/armv7m: Fix initialization of MPU regions

2021-06-04 Thread Christian Mauderer
The write to RBAR didn't have the valid flag set. Therefore the write to RASR had an influence on the previously set region. That means for example that if Region 0 had been enabled but 1 should be disabled due to a size of 0, the previous code would have disabled region 0 instead. This patch

[PATCH rtems 1/2] cpu/armv7m: Avoid regions with negative size

2021-06-04 Thread Christian Mauderer
Don't initialze regions that have a negative size (for example due to a wrong calculation). Update #4450 --- cpukit/score/cpu/arm/include/rtems/score/armv7m.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/arm/include/rtems/score/armv7m.h

Re: Selection of ethernet peripheral by application

2021-06-04 Thread Christian MAUDERER
Am 02.06.21 um 20:37 schrieb Kinsey Moore: Hello, From what I’ve seen of the various BSPs supported by LibBSD that have multiple ethernet peripherals, only one tends to be chosen and supported. I’ve encountered a situation where the majority of platform examples (Zynq Ultrascale+ MPSoC