Re: [PATCH v2] rtems-utils: Change data type definition

2021-08-05 Thread Chris Johns
On 6/8/21 6:43 am, Ryan Long wrote: > Remove typedef of ostream_guard and change datatype of ostream_guards to > have the namespace in the variable declarations. > --- > linkers/rtems-exeinfo.cpp| 6 ++ > tester/covoar/CoverageMapBase.cc | 4 +--- > tester/covoar/ReportsHtml.cc |

[PATCH v2] rtems-utils: Change data type definition

2021-08-05 Thread Ryan Long
Remove typedef of ostream_guard and change datatype of ostream_guards to have the namespace in the variable declarations. --- linkers/rtems-exeinfo.cpp| 6 ++ tester/covoar/CoverageMapBase.cc | 4 +--- tester/covoar/ReportsHtml.cc | 4 +--- tester/covoar/ReportsText.cc | 4

RE: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

2021-08-05 Thread Ryan Long
We think that the best thing to do is to keep the ostream_guard in place and ignore the "Restore ostream format" issues. -Original Message- From: Chris Johns Sent: Wednesday, August 4, 2021 8:44 PM To: Gedare Bloom Cc: Ryan Long ; devel@rtems.org Subject: Re: [PATCH v1 1/5]

Re: [PATCH v3] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-05 Thread Gedare Bloom
On Thu, Aug 5, 2021 at 12:36 PM Zacchaeus Leung wrote: > > the timer_create() method can use CLOCK_MONOTONIC but there was no test for > this > The commit message needs to be improved, because this patch is doing more than adding a "test", it is implementing the functionality to create a

[PATCH v3] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-05 Thread Zacchaeus Leung
the timer_create() method can use CLOCK_MONOTONIC but there was no test for this Closes #3888 --- cpukit/include/rtems/posix/timer.h| 1 + cpukit/posix/src/psxtimercreate.c | 3 +- cpukit/posix/src/timergettime.c | 54 ++-

Re: [PATCH v2] STM32 lwIP addition and CMake support

2021-08-05 Thread Gedare Bloom
STM is not going to fix their Ultimate Liberty License at this time. https://github.com/STMicroelectronics/STM32CubeH7/issues/139#issuecomment-890806010 So, we need to avoid using their example codes. On Wed, Jun 9, 2021 at 12:16 PM Gedare Bloom wrote: > > I joined the Issue. Thanks for working

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-05 Thread Gedare Bloom
On Thu, Aug 5, 2021 at 8:56 AM zack leung wrote: > > Here you could add an assert that ptimer->clock_type == > CLOCK_MONOTONIC || ptimer->clock_type == CLOCK_REALTIME. > > Would I need to assert that the timer is not a valid timer type? Also In > psxtimer create I check if the timer is invalid.

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-05 Thread zack leung
Here you could add an assert that ptimer->clock_type == CLOCK_MONOTONIC || ptimer->clock_type == CLOCK_REALTIME. Would I need to assert that the timer is not a valid timer type? Also In psxtimer create I check if the timer is invalid. I can do a similar if statement as I did in psxtimercreate

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-05 Thread Peter Dufault
> On Aug 4, 2021, at 18:42 , Chris Johns wrote: > > On 5/8/21 2:22 am, Christian Mauderer wrote: >> On 04/08/2021 18:09, Gedare Bloom wrote: >>> On Wed, Aug 4, 2021 at 9:05 AM Christian MAUDERER >>> wrote: Am 04.08.21 um 16:55 schrieb Gedare Bloom: > On Wed, Aug 4, 2021 at 4:18 AM