Re: Scope of variables flagged by code inspector

On 11/10/21 10:14 pm, Sebastian Huber wrote: > Hello Zack, > > On 10/10/2021 20:25, zack leung wrote: >> I recently was invited to look at a new code review tool by Joel. It's used >> to help with reducing technical debt. It suggests various fixes and >> highlights various possible errors. One of

Re: [PATCH] score: Simplify _Watchdog_Next_first()

ok On Mon, Oct 11, 2021 at 5:24 AM Sebastian Huber wrote: > > --- > cpukit/include/rtems/score/watchdogimpl.h | 55 +++ > 1 file changed, 36 insertions(+), 19 deletions(-) > > diff --git a/cpukit/include/rtems/score/watchdogimpl.h >

[PATCH] rtems: Add new clock manager directives

Update #4527. --- cpukit/include/rtems/rtems/clock.h | 590 + cpukit/score/src/kern_tc.c | 56 +++ 2 files changed, 646 insertions(+) diff --git a/cpukit/include/rtems/rtems/clock.h b/cpukit/include/rtems/rtems/clock.h index 8511cb9cef..16b838a842 100644 ---

[PATCH] c-user: Document new clock manager directives

Add new clock manager directives to get all times provided by the timehands. Update #4527. --- For an updated document to review see: https://ftp.rtems.org/pub/rtems/people/sebh/c-user.pdf c-user/clock/directives.rst | 830 ++ c-user/clock/introduction.rst |

[PATCH] score: Simplify _Watchdog_Next_first()

--- cpukit/include/rtems/score/watchdogimpl.h | 55 +++ 1 file changed, 36 insertions(+), 19 deletions(-) diff --git a/cpukit/include/rtems/score/watchdogimpl.h b/cpukit/include/rtems/score/watchdogimpl.h index 7b364b8828..ba1a884a3d 100644 ---

[PATCH 1/1] v2: Implement clockrdlock / clockwrlock and test

Added implementations of the pthread_rwlock_clockrdlock and the pthread_rwlock_clockwrlock methods to cpukit/posix/src. Both of these methods have been newly added to the POSIX Issue 8 Standard. Added psxrwlock02 test to testsuites/psxtests to test the newly added methods. ---

[PATCH 0/1] v2: Implement clockrdlock / clockwrlock and test

Dr. Joel, Thanks very much for your review! Please see the updated version with pared-down test, check for invalid clock, and check for invalid abstime->tv_nsec. Sincerely, Matt Matt Joyce (1): Added implementations of the pthread_rwlock_clockrdlock and the pthread_rwlock_clockwrlock

Re: Scope of variables flagged by code inspector

Hello Zack, On 10/10/2021 20:25, zack leung wrote: I recently was invited to look at a new code review tool by Joel. It's used to help with reducing technical debt. It suggests various fixes and highlights various possible errors. One of them relates to the fact that some of the variable scopes