Re: [PATCH] mghttpd: Remove

2022-04-06 Thread Chris Johns
On 7/4/2022 3:52 am, Joel Sherrill wrote: > On Wed, Apr 6, 2022 at 12:27 PM Gedare Bloom wrote: > >> On Wed, Apr 6, 2022 at 9:23 AM Sebastian Huber >> wrote: >>> >>> On 06/04/2022 17:09, Joel Sherrill wrote: On Wed, Apr 6, 2022 at 10:03 AM Sebastian Huber >>>

Re: [PATCH] mghttpd: Remove

2022-04-06 Thread Joel Sherrill
On Wed, Apr 6, 2022 at 12:27 PM Gedare Bloom wrote: > On Wed, Apr 6, 2022 at 9:23 AM Sebastian Huber > wrote: > > > > On 06/04/2022 17:09, Joel Sherrill wrote: > > > On Wed, Apr 6, 2022 at 10:03 AM Sebastian Huber > > > > > > wrote: > > > > > > On

Re: [PATCH] mghttpd: Remove

2022-04-06 Thread Gedare Bloom
On Wed, Apr 6, 2022 at 9:23 AM Sebastian Huber wrote: > > On 06/04/2022 17:09, Joel Sherrill wrote: > > On Wed, Apr 6, 2022 at 10:03 AM Sebastian Huber > > > > wrote: > > > > On 06/04/2022 17:01, Joel Sherrill wrote: > > > This needs a ticket

Re: [PATCH] mghttpd: Remove

2022-04-06 Thread Sebastian Huber
On 06/04/2022 17:09, Joel Sherrill wrote: On Wed, Apr 6, 2022 at 10:03 AM Sebastian Huber > wrote: On 06/04/2022 17:01, Joel Sherrill wrote: > This needs a ticket and a target of 7. A ticket, yes, but do you really want to ship a

Re: [PATCH] mghttpd: Remove

2022-04-06 Thread Joel Sherrill
On Wed, Apr 6, 2022 at 10:03 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 06/04/2022 17:01, Joel Sherrill wrote: > > This needs a ticket and a target of 7. > > A ticket, yes, but do you really want to ship a completely outdated web > server with RTEMS 6? > We have no

Re: [PATCH] mghttpd: Remove

2022-04-06 Thread Sebastian Huber
On 06/04/2022 17:01, Joel Sherrill wrote: This needs a ticket and a target of 7. A ticket, yes, but do you really want to ship a completely outdated web server with RTEMS 6? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email:

Re: [PATCH] bsp/stm32h7: update FMC configuration for SRAM and SDRAM usage

2022-04-06 Thread Karel Gardas
Hello Sebastian, let me explain more motivation behind this patch. I'm working on stm32h757i-eval bsp variant and while looking into FMC support while using STM32CubeIDE I've noticed that actual changes between system_stm32h7xx.c files generated for H743i-eval and H757i-eval are pretty

[PATCH] bsp/stm32h7: update FMC configuration for SRAM and SDRAM usage

2022-04-06 Thread Karel Gardas
The patch merges differences in FMC configuration between system_stm32h7xx.c file generated by STM32CubeIDE for 743i-eval2 board and the current RTEMS ext-mem-ctl.c file. Sponsored-By: Precidata --- bsps/arm/stm32h7/start/ext-mem-ctl.c | 23 ++- 1 file changed, 14

Re: [PATCH 1/6] shell: Move line editor output check

2022-04-06 Thread Sebastian Huber
On 06/04/2022 11:50, Chris Johns wrote: @@ -869,6 +856,7 @@ bool rtems_shell_main_loop( int line = 0; FILE *stdinToClose = NULL; FILE *stdoutToClose = NULL; + FILE *line_editor_output; lineEditorOutput or line_editor_output? I prefer the

Re: [PATCH 6/6] shell: Add rtems_shell_run_main_loop()

2022-04-06 Thread Chris Johns
On 6/4/22 7:56 pm, Sebastian Huber wrote: > On 06/04/2022 11:55, Chris Johns wrote: >> On 6/4/22 5:17 pm, Sebastian Huber wrote: >>> In contrast to rtems_shell_main_loop(), this new function does not >>> perform all sorts of initialization based on environment settings.  For >>> example, due to

Re: [PATCH 6/6] shell: Add rtems_shell_run_main_loop()

2022-04-06 Thread Sebastian Huber
On 06/04/2022 11:55, Chris Johns wrote: On 6/4/22 5:17 pm, Sebastian Huber wrote: In contrast to rtems_shell_main_loop(), this new function does not perform all sorts of initialization based on environment settings. For example, due to the use of isatty() in rtems_shell_main_loop() it is

Re: [PATCH 6/6] shell: Add rtems_shell_run_main_loop()

2022-04-06 Thread Chris Johns
On 6/4/22 5:17 pm, Sebastian Huber wrote: > In contrast to rtems_shell_main_loop(), this new function does not > perform all sorts of initialization based on environment settings. For > example, due to the use of isatty() in rtems_shell_main_loop() it is > impossible to run an interactive shell

Re: [PATCH 1/6] shell: Move line editor output check

2022-04-06 Thread Chris Johns
On 6/4/22 5:17 pm, Sebastian Huber wrote: > Move call to isatty() to caller of rtems_shell_line_editor(). This > avoids a dependency on isatty() in rtems_shell_line_editor(). > --- > cpukit/libmisc/shell/shell.c | 82 +--- > 1 file changed, 38 insertions(+), 44

[PATCH 6/6] shell: Add rtems_shell_run_main_loop()

2022-04-06 Thread Sebastian Huber
In contrast to rtems_shell_main_loop(), this new function does not perform all sorts of initialization based on environment settings. For example, due to the use of isatty() in rtems_shell_main_loop() it is impossible to run an interactive shell through a socket connection. ---

[PATCH 1/6] shell: Move line editor output check

2022-04-06 Thread Sebastian Huber
Move call to isatty() to caller of rtems_shell_line_editor(). This avoids a dependency on isatty() in rtems_shell_line_editor(). --- cpukit/libmisc/shell/shell.c | 82 +--- 1 file changed, 38 insertions(+), 44 deletions(-) diff --git

[PATCH 0/6] Refactor shell main loop

2022-04-06 Thread Sebastian Huber
Sebastian Huber (6): shell: Move line editor output check shell: Refactor rtems_shell_main_loop() shell: Simplify rtems_shell_dup_current_env() shell: Add and use SHELL_MAGIC shell: Move rtems_shell_init_environment() call shell: Add rtems_shell_run_main_loop()

[PATCH 2/6] shell: Refactor rtems_shell_main_loop()

2022-04-06 Thread Sebastian Huber
Disentangle the shell main loop from setup and teardown code. Move main loop into shell_main_loop(). --- cpukit/libmisc/shell/shell.c | 284 ++- 1 file changed, 150 insertions(+), 134 deletions(-) diff --git a/cpukit/libmisc/shell/shell.c

[PATCH 3/6] shell: Simplify rtems_shell_dup_current_env()

2022-04-06 Thread Sebastian Huber
Do not assign members already provided by the global environment. --- cpukit/libmisc/shell/shell.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index 11d8ab4846..278c3dc0ae 100644 ---

[PATCH 5/6] shell: Move rtems_shell_init_environment() call

2022-04-06 Thread Sebastian Huber
Move rtems_shell_init_environment() call to rtems_shell_set_shell_env() since this function uses the POSIX key. --- cpukit/libmisc/shell/shell.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index

[PATCH 4/6] shell: Add and use SHELL_MAGIC

2022-04-06 Thread Sebastian Huber
--- cpukit/libmisc/shell/shell.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index 278c3dc0ae..9bb143dd29 100644 --- a/cpukit/libmisc/shell/shell.c +++ b/cpukit/libmisc/shell/shell.c @@ -49,8 +49,10 @@

Re: Fence for Malloc'ed Memory Characterization

2022-04-06 Thread Sebastian Huber
On 05/04/2022 00:44, Joel Sherrill wrote: Where is the memory fence for allocations added? How much? Does it adjoin at the low and high end? If you enable RTEMS_DEBUG, then there is a fence present (heap protection block). -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178

Re: [PATCH 1/2] bsps/stm32h7: let's link for flash by default on STM32H7B3I-DK BSP

2022-04-06 Thread Sebastian Huber
On 05/04/2022 14:16, Karel Gardas wrote: The patch is needed due to smaller SRAM and completely disabled SDRAM on the BSP variant. Thanks, I checked it in with a shortened subject. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email:

Re: [PATCH] user/bsps/arm: remove dangling stm32h7 bsp page

2022-04-06 Thread Sebastian Huber
On 05/04/2022 13:13, Karel Gardas wrote: The page for STM32H7 BSP is twice here, so let's keep the one providing most information. Thanks, I checked it in. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: