Re: [libbsd 10/22] Update CONTRIBUTING.rst

2022-06-26 Thread Chris Johns
On 27/6/2022 2:40 pm, Chris Johns wrote: > We was this micro-optimisations. We saw this as micro-optimisations. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [libbsd 10/22] Update CONTRIBUTING.rst

2022-06-26 Thread Chris Johns
Hi Sebastian, Thank you for this submission. It will take a time for me to work through all the changes in detail and I may need your assistance if that is OK? I am heading out of town so I am sorry it will not be this week. On 24/6/2022 4:33 pm, Sebastian Huber wrote: > +Porting Advice >

Re: [PATCH] irq/arm-gicv3.h: Enable interrupt groups 0 and 1

2022-06-26 Thread Chris Johns
On 24/6/2022 7:43 pm, Sebastian Huber wrote: > The GICv3 support is used by AArch32 (indicated by the ARM_MULTILIB_ARCH_V4 > define) and AArch64 targets. Use the existing WRITE_SR() abstraction to > access > the interrupt group 0 and 1 enable registers. This fixes the build for the > AArch32

Re: [PATCH] Proposal for new GPIO API and example implementation for STM32F4 BSP

2022-06-26 Thread Duc Doan
Hello Karel and Christian, I am thinking of this way: referring to a pin using a number. Each BSP will map that pin number to its specific port and pin. For example, for STM32F4 which has 16 pins per GPIO port, pin 6 will correspond to GPIOA pin 6, and pin 20 will correspond to GPIOB pin 4. The

Re: [PATCH] arm/gicv3: Fix building arm/r52

2022-06-26 Thread Chris Johns
On 24/6/2022 7:44 pm, Sebastian Huber wrote: > On 20.06.22 04:03, chr...@rtems.org wrote: >> From: Chris Johns >> >> --- >>   bsps/include/dev/irq/arm-gicv3.h | 5 + >>   1 file changed, 5 insertions(+) >> >> diff --git a/bsps/include/dev/irq/arm-gicv3.h >> b/bsps/include/dev/irq/arm-gicv3.h

Re: [PATCH] Proposal for new GPIO API and example implementation for STM32F4 BSP

2022-06-26 Thread Karel Gardas
On 6/26/22 10:49, Duc Doan wrote: #define rtems_gpio_get_ctrl(_driver, _arg, _out) \ _driver##_gpio_get_ctrl( _arg , _out ) In the application code: rtems_gpio_get_ctrl(stm32f4, GPIOD, _ctrl); rtems_gpio_get_ctrl(stm32f4, GPIOA, _ctrl); It's only a different method of writing the same.

Re: [PATCH] Proposal for new GPIO API and example implementation for STM32F4 BSP

2022-06-26 Thread Duc Doan
Hello Christian and Karel, On Sun, 2022-06-26 at 10:02 +0200, o...@c-mauderer.de wrote: > Hello Karel and Duc, > > Am 26.06.22 um 09:24 schrieb Duc Doan: > > Hello Karel, > > > > I came up with this solution: making a macro that returns a > > function > > depending on driver/BSP name. > > > >

Re: [PATCH] Proposal for new GPIO API and example implementation for STM32F4 BSP

2022-06-26 Thread Duc Doan
Hello Christian, On Sun, 2022-06-26 at 09:50 +0200, o...@c-mauderer.de wrote: > Is setting the pull really independent of the mode? Most controller > that > I know have a pull-Up only on Inputs. Sometimes on an Open-Drain > output. > Sometimes in another controller (but you might ignore that

Re: [PATCH] Proposal for new GPIO API and example implementation for STM32F4 BSP

2022-06-26 Thread oss
Hello Karel and Duc, Am 26.06.22 um 09:24 schrieb Duc Doan: Hello Karel, I came up with this solution: making a macro that returns a function depending on driver/BSP name. /** * @brief Get an GPIO control object. * * This macro requires BSPs/drivers to correctly implement *

Re: [PATCH] Proposal for new GPIO API and example implementation for STM32F4 BSP

2022-06-26 Thread oss
Hello Duc, Am 25.06.22 um 13:43 schrieb Duc Doan: Hello Christian, On Fri, 2022-06-24 at 17:32 +0200, o...@c-mauderer.de wrote: Be careful with everything that depends on the BSP. Again: Please think about an i2c GPIO expander. That chip can be used on different BSPs. It can be even an

Re: [PATCH] Proposal for new GPIO API and example implementation for STM32F4 BSP

2022-06-26 Thread Duc Doan
Hello Karel, I came up with this solution: making a macro that returns a function depending on driver/BSP name. /** * @brief Get an GPIO control object. * * This macro requires BSPs/drivers to correctly implement * function _gpio_get_ctrl(void *arg, * rtems_gpio_ctrl_t **out). *