Re: [PATCH] bsps/aarch64: Use MMU pages appropriately

2022-07-05 Thread Chris Johns
On 6/7/2022 5:38 am, Joel Sherrill wrote: > I'm ok with this. But Chris should speak up about the Versal. OK to push. Tested on Versal hardware and it boots as before. I have not returned to see if I can get access to at least 4G of memory in the lower 32bits of the address space. That is in the

Re: [PATCH] tester: Make the SIS time limit user configurable

2022-07-05 Thread Joel Sherrill
Optimization may affect the time but host speed is more likely Ok to commit On Tue, Jul 5, 2022, 6:51 PM wrote: > From: Chris Johns > > Let the user set the test time limit in a config file to > provide site specific overrides. Optimisation can effect > the time a test may take to run. > ---

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Chris Johns
On 5/7/2022 8:50 pm, Jiri Gaisler wrote: > > On 7/5/22 12:45, Sebastian Huber wrote: >> >> >> On 05/07/2022 12:31, Chris Johns wrote: >>> On 5 Jul 2022, at 6:23 pm, Sebastian Huber  wrote: On 05/07/2022 10:21, Chris Johns wrote: >> On 5/7/2022 4:29 pm, Sebastian Huber

[PATCH] tester: Make the SIS time limit user configurable

2022-07-05 Thread chrisj
From: Chris Johns Let the user set the test time limit in a config file to provide site specific overrides. Optimisation can effect the time a test may take to run. --- tester/rtems/testing/bsps/erc32-sis.ini | 5 +- tester/rtems/testing/bsps/gr740-sis.ini | 5 +-

[PATCH v3] gcc12/libstdc++: Fix lifetime bugs for non-TLS eh_globals

2022-07-05 Thread chrisj
From: Chris Johns - This is the fix from PR105880: https://gcc.gnu.org/bugzilla/attachment.cgi?id=53103 Closes #4661 --- .../config/tools/rtems-gcc-12-newlib-head.cfg | 29 ++- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git

Re: [PATCH] bsps/aarch64: Use MMU pages appropriately

2022-07-05 Thread Joel Sherrill
I'm ok with this. But Chris should speak up about the Versal. On Tue, Jul 5, 2022 at 2:36 PM Kinsey Moore wrote: > There were two bugs with MMU page use that were partially hiding each > other. The linker script page table section was 4x the size it needed to > be and the page table allocation

Re: [PATCH] cpukit/aarch64: Remove _CPU_ISR_install_vector

2022-07-05 Thread Joel Sherrill
OK. On Tue, Jul 5, 2022 at 2:36 PM Kinsey Moore wrote: > This function was never actually used and is dead code. > --- > cpukit/score/cpu/aarch64/cpu.c| 25 --- > .../cpu/aarch64/include/rtems/score/cpu.h | 6 - > 2 files changed, 31 deletions(-) > >

[PATCH] bsps/aarch64: Use MMU pages appropriately

2022-07-05 Thread Kinsey Moore
There were two bugs with MMU page use that were partially hiding each other. The linker script page table section was 4x the size it needed to be and the page table allocation routine was allocating pages PTRSIZE times larger than it needed to. On ILP32, this resulted in incorrect but functional

[PATCH] cpukit/aarch64: Remove _CPU_ISR_install_vector

2022-07-05 Thread Kinsey Moore
This function was never actually used and is dead code. --- cpukit/score/cpu/aarch64/cpu.c| 25 --- .../cpu/aarch64/include/rtems/score/cpu.h | 6 - 2 files changed, 31 deletions(-) diff --git a/cpukit/score/cpu/aarch64/cpu.c

Re: [PATCH 4/4] STM32F4 GPIO: Add GPIO implementation for STM32F4

2022-07-05 Thread Cedric Berger
Hello, Have you tried a tiny bit to optimize this code because at a quick glance, it sounds like for critical routines, you choose some slow and complicated ways to do simple things, see a few some example below: +static uint16_t GPIO_PIN_x[] = { +GPIO_PIN_0, +GPIO_PIN_1, +

Re: [PATCH 0/4] Creating a new GPIO API and adding implementation for STM32F4 BSP

2022-07-05 Thread Duc Doan
Hello, Please find my patches here: PATCH 1/4: https://github.com/dtbpkmte/GSoC-2022-RTEMS/commit/df255bbc3ff80a596ff329964fe0673f0141a522 PATCH 2/4: https://github.com/dtbpkmte/GSoC-2022-RTEMS/commit/5a814d4e5f8af3f78ffcf62a7e7da331843f168a PATCH 3/4:

[PATCH 4/4] STM32F4 GPIO: Add GPIO implementation for STM32F4

2022-07-05 Thread Duc Doan
--- bsps/arm/stm32f4/gpio/gpio.c | 595 ++ bsps/arm/stm32f4/include/bsp.h| 4 - bsps/arm/stm32f4/include/bsp/stm32f4_gpio.h | 37 ++ bsps/arm/stm32f4/include/bsp/stm32f4_hal.h| 17 + bsps/arm/stm32f4/start/bspstart.c | 11 +-

[PATCH 3/4] GPIO API: Add GPIO API

2022-07-05 Thread Duc Doan
--- bsps/include/bsp/gpio2.h| 538 bsps/shared/dev/gpio/gpio.c | 196 + spec/build/bsps/obj.yml | 2 +- 3 files changed, 735 insertions(+), 1 deletion(-) create mode 100644 bsps/include/bsp/gpio2.h create mode 100644

[PATCH 0/4] Creating a new GPIO API and adding implementation for STM32F4 BSP

2022-07-05 Thread Duc Doan
Hello, This patch adds a new GPIO API that aims at portability. GPIO of STM32F4 BSP has been implemented using this API. The sample application code can be found at https://github.com/dtbpkmte/GSoC-2022-RTEMS-Sample-Apps. Best, Duc Doan .gitignore |

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Jiri Gaisler
On 7/5/22 12:45, Sebastian Huber wrote: On 05/07/2022 12:31, Chris Johns wrote: On 5 Jul 2022, at 6:23 pm, Sebastian Huber  wrote: On 05/07/2022 10:21, Chris Johns wrote: On 5/7/2022 4:29 pm, Sebastian Huber wrote: On 05/07/2022 08:23, Chris Johns wrote: On 5/7/2022 4:02 pm, Sebastian

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Sebastian Huber
On 05/07/2022 12:31, Chris Johns wrote: On 5 Jul 2022, at 6:23 pm, Sebastian Huber wrote: On 05/07/2022 10:21, Chris Johns wrote: On 5/7/2022 4:29 pm, Sebastian Huber wrote: On 05/07/2022 08:23, Chris Johns wrote: On 5/7/2022 4:02 pm, Sebastian Huber wrote: On 05/07/2022 07:14, Chris

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Jiri Gaisler
On 7/5/22 12:31, Chris Johns wrote: On 5 Jul 2022, at 6:23 pm, Sebastian Huber wrote: On 05/07/2022 10:21, Chris Johns wrote: On 5/7/2022 4:29 pm, Sebastian Huber wrote: On 05/07/2022 08:23, Chris Johns wrote: On 5/7/2022 4:02 pm, Sebastian Huber wrote: On 05/07/2022 07:14, Chris Johns

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Chris Johns
> On 5 Jul 2022, at 6:23 pm, Sebastian Huber > wrote: > > On 05/07/2022 10:21, Chris Johns wrote: >>> On 5/7/2022 4:29 pm, Sebastian Huber wrote: >>> On 05/07/2022 08:23, Chris Johns wrote: On 5/7/2022 4:02 pm, Sebastian Huber wrote: > On 05/07/2022 07:14, Chris Johns wrote: >>

[PATCH] validation: Test thread idle bodies

2022-07-05 Thread Sebastian Huber
--- .../testsuites/validation/validation-0.yml| 1 + .../tc-thread-idle-body-no-return.c | 194 ++ 2 files changed, 195 insertions(+) create mode 100644 testsuites/validation/tc-thread-idle-body-no-return.c diff --git

[PATCH] validation: Always test spurious interrupts

2022-07-05 Thread Sebastian Huber
--- .../testsuites/validation/validation-intr.yml | 4 +++- .../validation/validation-smp-only-0.yml | 2 -- .../validation/tc-bsp-interrupt-spurious.c| 24 --- 3 files changed, 13 insertions(+), 17 deletions(-) diff --git

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Sebastian Huber
On 05/07/2022 10:21, Chris Johns wrote: On 5/7/2022 4:29 pm, Sebastian Huber wrote: On 05/07/2022 08:23, Chris Johns wrote: On 5/7/2022 4:02 pm, Sebastian Huber wrote: On 05/07/2022 07:14, Chris Johns wrote: On 5/7/2022 2:58 pm, Sebastian Huber wrote: On 05/07/2022 03:08, Chris Johns wrote:

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Chris Johns
On 5/7/2022 4:29 pm, Sebastian Huber wrote: > On 05/07/2022 08:23, Chris Johns wrote: >> On 5/7/2022 4:02 pm, Sebastian Huber wrote: >>> On 05/07/2022 07:14, Chris Johns wrote: On 5/7/2022 2:58 pm, Sebastian Huber wrote: > On 05/07/2022 03:08, Chris Johns wrote: >> On 5/7/2022 9:44

[PATCH] rtems: Simplify rtems_scheduler_ident()

2022-07-05 Thread Sebastian Huber
Use early returns to simplify rtems_scheduler_ident(). --- cpukit/rtems/src/schedulerident.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/cpukit/rtems/src/schedulerident.c b/cpukit/rtems/src/schedulerident.c index e73d3d743a..60e7765ccd 100644

[PATCH] validation: Test thread free of FPU owner

2022-07-05 Thread Sebastian Huber
--- testsuites/validation/tc-score-thread.c | 74 + 1 file changed, 74 insertions(+) diff --git a/testsuites/validation/tc-score-thread.c b/testsuites/validation/tc-score-thread.c index 53b939e3c5..88e86ca189 100644 --- a/testsuites/validation/tc-score-thread.c +++

[PATCH] score: Use RTEMS_SMP in _Thread_Create_idle()

2022-07-05 Thread Sebastian Huber
Conditional expressions with inline functions are not optimized away if optimization is disabled. Avoid such expressions to prevent dead branches. --- cpukit/score/src/threadcreateidle.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cpukit/score/src/threadcreateidle.c

[PATCH] validation: Test scheduler detail

2022-07-05 Thread Sebastian Huber
This particular state during a reconsider help request scheduler operation was only covered by the existing test suites under some timing conditions. --- testsuites/validation/tc-sched-smp.c | 137 ++- 1 file changed, 135 insertions(+), 2 deletions(-) diff --git

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Sebastian Huber
On 05/07/2022 08:23, Chris Johns wrote: On 5/7/2022 4:02 pm, Sebastian Huber wrote: On 05/07/2022 07:14, Chris Johns wrote: On 5/7/2022 2:58 pm, Sebastian Huber wrote: On 05/07/2022 03:08, Chris Johns wrote: On 5/7/2022 9:44 am, Joel Sherrill wrote: The limit removed in sis and tsim is the

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Chris Johns
On 5/7/2022 4:02 pm, Sebastian Huber wrote: > On 05/07/2022 07:14, Chris Johns wrote: >> On 5/7/2022 2:58 pm, Sebastian Huber wrote: >>> On 05/07/2022 03:08, Chris Johns wrote: On 5/7/2022 9:44 am, Joel Sherrill wrote: > The limit removed in sis and tsim is the simulated cpu time used. If

Re: [tools] tester: Remove hard coded time limits for SIS

2022-07-05 Thread Sebastian Huber
On 05/07/2022 07:14, Chris Johns wrote: On 5/7/2022 2:58 pm, Sebastian Huber wrote: On 05/07/2022 03:08, Chris Johns wrote: On 5/7/2022 9:44 am, Joel Sherrill wrote: The limit removed in sis and tsim is the simulated cpu time used. If not using that, the behavior of the tester is to let the