Re: [PATCH v5 2/4] bsps: New GPIO API & peripherals API framework

2022-07-31 Thread Duc Doan
Hello Christian, On Sat, 2022-07-30 at 17:50 +0200, o...@c-mauderer.de wrote: > Hello Duc, > > Am 24.07.22 um 14:01 schrieb Duc Doan: > > --- > >   bsps/include/bsp/gpio2.h    | 528 > > > >   bsps/include/bsp/periph_api.h   | 142 +++ > >  

Re: [PATCH v5 1/4] bsps/stm32f4 Include STM32F4 HAL

2022-07-31 Thread Duc Doan
Hello Christian, On Sun, 2022-07-31 at 20:01 +0200, o...@c-mauderer.de wrote: > Hello Duc, > > Am 31.07.22 um 17:07 schrieb Duc Doan: > > Hello Christian, > > > > On Sat, 2022-07-30 at 16:32 +0200, o...@c-mauderer.de wrote: > > > Hello Duc, > > > > > > general note for the patch: Please write

Re: [PATCH] rtems-tools-6.cfg: Bump hash

2022-07-31 Thread Chris Johns
OK Thanks Chris On 30/7/2022 1:47 am, Ryan Long wrote: > --- > rtems/config/tools/rtems-tools-6.cfg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rtems/config/tools/rtems-tools-6.cfg > b/rtems/config/tools/rtems-tools-6.cfg > index c032bd4..a667175 100644 > ---

Re: [PATCH v5 1/4] bsps/stm32f4 Include STM32F4 HAL

2022-07-31 Thread oss
Hello Duc, Am 31.07.22 um 17:07 schrieb Duc Doan: Hello Christian, On Sat, 2022-07-30 at 16:32 +0200, o...@c-mauderer.de wrote: Hello Duc, general note for the patch: Please write in the commit message where you got the sources from. That can be a link to a github repo including a commit ID

Re: [PATCH v5 1/4] bsps/stm32f4 Include STM32F4 HAL

2022-07-31 Thread Duc Doan
Hello Christian, On Sat, 2022-07-30 at 16:32 +0200, o...@c-mauderer.de wrote: > Hello Duc, > > general note for the patch: Please write in the commit message where > you > got the sources from. That can be a link to a github repo including a > commit ID or a link to the zip file from ST

[PATCH] cpukit/dev/can: Added CAN support (Prashanth S)

2022-07-31 Thread Prashanth S
Hi All, This is a review request for CAN support. I have addressed the review comments. The files are work in progress, I need to add few more comments in the include (*.h) files. Regards Prashanth S On Sun, 31 Jul 2022 at 17:24, wrote: > Send devel mailing list submissions to >

[PATCH] cpukit/dev/can: Added CAN support

2022-07-31 Thread Prashanth S
--- cpukit/dev/can/can.c | 514 + cpukit/include/dev/can/can-msg.h | 55 +++ cpukit/include/dev/can/can-queue.h | 127 +++ cpukit/include/dev/can/can.h | 102 ++ spec/build/cpukit/librtemscpu.yml | 6 + 5 files changed, 804