Re: [PATCH rtems-docs v4] raspberrypi4.rst: Documentation for the new AArch64 Raspberry pi 4B BSP

2022-10-06 Thread Noor Aman
New patch sent with new changes. On Fri, 7 Oct 2022 at 10:30, Mohd Noor Aman wrote: > This patch adds the relevant documentations required for booting the new > BSP. > JTAG support is added for debugging. I have built the HTML docs and > verified > them. > --- >

[PATCH rtems-docs v4] raspberrypi4.rst: Documentation for the new AArch64 Raspberry pi 4B BSP

2022-10-06 Thread Mohd Noor Aman
This patch adds the relevant documentations required for booting the new BSP. JTAG support is added for debugging. I have built the HTML docs and verified them. --- user/bsps/aarch64/raspberrypi4.rst | 111 + user/bsps/bsps-aarch64.rst | 1 + 2 files changed,

Re: [PATCH v2 06/13] score: Add CPU_THREAD_LOCAL_STORAGE_VARIANT

2022-10-06 Thread Chris Johns
On 7/10/2022 3:33 pm, Sebastian Huber wrote: > On 07.10.22 06:31, Chris Johns wrote: >> On 7/10/2022 3:23 pm, Sebastian Huber wrote: >>> On 07.10.22 05:44, Chris Johns wrote: On 6/10/2022 7:23 pm, Sebastian Huber wrote: > +#if CPU_THREAD_LOCAL_STORAGE_VARIANT == 10 > +  tls_data =

Re: [PATCH v2 06/13] score: Add CPU_THREAD_LOCAL_STORAGE_VARIANT

2022-10-06 Thread Sebastian Huber
On 07.10.22 06:31, Chris Johns wrote: On 7/10/2022 3:23 pm, Sebastian Huber wrote: On 07.10.22 05:44, Chris Johns wrote: On 6/10/2022 7:23 pm, Sebastian Huber wrote: +#if CPU_THREAD_LOCAL_STORAGE_VARIANT == 10 +  tls_data = (void *) +    RTEMS_ALIGN_UP( (uintptr_t) tls_area + sizeof( *tcb

Re: [PATCH v2 06/13] score: Add CPU_THREAD_LOCAL_STORAGE_VARIANT

2022-10-06 Thread Chris Johns
On 7/10/2022 3:23 pm, Sebastian Huber wrote: > On 07.10.22 05:44, Chris Johns wrote: >> On 6/10/2022 7:23 pm, Sebastian Huber wrote: >>> +#if CPU_THREAD_LOCAL_STORAGE_VARIANT == 10 >>> +  tls_data = (void *) >>> +    RTEMS_ALIGN_UP( (uintptr_t) tls_area + sizeof( *tcb ), alignment ); >>> +  tcb =

Re: [PATCH 06/13] config: Add rtems_malloc_task_stack_for_idle()

2022-10-06 Thread Chris Johns
On 7/10/2022 3:25 pm, Sebastian Huber wrote: > On 07.10.22 04:57, Chris Johns wrote: >> On 6/10/2022 6:35 pm, Sebastian Huber wrote: >>> On 06/10/2022 00:13, Chris Johns wrote: Will the IDLE TLS size be based on the CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE if it is not zero? This

Re: [PATCH 06/13] config: Add rtems_malloc_task_stack_for_idle()

2022-10-06 Thread Sebastian Huber
On 07.10.22 04:57, Chris Johns wrote: On 6/10/2022 6:35 pm, Sebastian Huber wrote: On 06/10/2022 00:13, Chris Johns wrote: Will the IDLE TLS size be based on the CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE if it is not zero? This effects libdl once it supports loading TLS based code.

[PATCH] libmisc/rtems-fdt: Update to support 64bit addresses

2022-10-06 Thread chrisj
From: Chris Johns - Add support to get the parent address and size cells - Propvide support to get a reg prop address map - Change getting a set of properties to uintptr_t - Improve the debug mode of the ls command to print all props Closes #4729 --- cpukit/include/rtems/rtems-fdt.h

Re: [PATCH v2 06/13] score: Add CPU_THREAD_LOCAL_STORAGE_VARIANT

2022-10-06 Thread Sebastian Huber
On 07.10.22 05:44, Chris Johns wrote: On 6/10/2022 7:23 pm, Sebastian Huber wrote: +#if CPU_THREAD_LOCAL_STORAGE_VARIANT == 10 + tls_data = (void *) +RTEMS_ALIGN_UP( (uintptr_t) tls_area + sizeof( *tcb ), alignment ); + tcb = (TLS_Thread_control_block *) ((char *) tls_data - sizeof( *tcb

Re: [PATCH v2 06/13] score: Add CPU_THREAD_LOCAL_STORAGE_VARIANT

2022-10-06 Thread Chris Johns
On 6/10/2022 7:23 pm, Sebastian Huber wrote: > +#if CPU_THREAD_LOCAL_STORAGE_VARIANT == 10 > + tls_data = (void *) > +RTEMS_ALIGN_UP( (uintptr_t) tls_area + sizeof( *tcb ), alignment ); > + tcb = (TLS_Thread_control_block *) ((char *) tls_data - sizeof( *tcb )); > + return_value = tls_data;

Re: [tools] tester: Check for begin/end of test

2022-10-06 Thread Chris Johns
OK Thanks Chris On 6/10/2022 6:29 pm, Sebastian Huber wrote: > Check for "BEGIN OF TEST" and "END OF TEST" to not use other information > blocks > such as "END OF GCOV" to determine the test status. > --- > tester/rt/report.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH 06/13] config: Add rtems_malloc_task_stack_for_idle()

2022-10-06 Thread Chris Johns
On 6/10/2022 6:35 pm, Sebastian Huber wrote: > On 06/10/2022 00:13, Chris Johns wrote: >> Will the IDLE TLS size be based on the >> CONFIGURE_MAXIMUM_THREAD_LOCAL_STORAGE_SIZE if it is not zero? This effects >> libdl once it supports loading TLS based code. > > Currently, only the actual TLS size

Re: [PATCH rtems-docs v3] raspberrypi4.rst: Documentation for the new AArch64 Raspberry pi 4B BSP

2022-10-06 Thread Kinsey Moore
On 10/6/2022 13:29, Karel Gardas wrote: On 10/6/22 20:14, Kinsey Moore wrote: +Raspberry Pi uses a different mechanism to boot. First the GPU initializes, A different mechanism as compared to what? Is this sentence important to users? Should GPU be CPU, instead? Sorry for hijacking, but

Re: [PATCH rtems-docs v3] raspberrypi4.rst: Documentation for the new AArch64 Raspberry pi 4B BSP

2022-10-06 Thread Karel Gardas
On 10/6/22 20:14, Kinsey Moore wrote: +Raspberry Pi uses a different mechanism to boot. First the GPU initializes, A different mechanism as compared to what? Is this sentence important to users? Should GPU be CPU, instead? Sorry for hijacking, but no, this sentence is right. GPU core on

Re: [PATCH rtems-docs v3] raspberrypi4.rst: Documentation for the new AArch64 Raspberry pi 4B BSP

2022-10-06 Thread Kinsey Moore
It seems like the typical contents for config.txt are scattered throughout several sections. It's good to call out the importance of those config options in those sections, but this isn't very useful for users trying to configure a system. It might be good to provide a direct description of

Re: [PATCH rtems-docs v3] raspberrypi4.rst: Documentation for the new AArch64 Raspberry pi 4B BSP

2022-10-06 Thread Noor Aman
Hey Alan, I've addressed the changes. TF-A is not required as of now. I thought earlier that TF-A is required for enabling GIC but without it, it just work fine. Now for SMP, TF-A might be crucial as SMP in the xilinx zync is handled using TF-A, so it might be the same case for Raspberry pi 4?

[PATCH rtems-docs v3] raspberrypi4.rst: Documentation for the new AArch64 Raspberry pi 4B BSP

2022-10-06 Thread Mohd Noor Aman
This patch adds the relevant documentations required for booting the new BSP. JTAG support is added for debugging. I have built the HTML docs and verified them. --- user/bsps/aarch64/raspberrypi4.rst | 104 + user/bsps/bsps-aarch64.rst | 1 + 2 files changed,

Re: [PATCH rtems-docs] user/bsps: Update riscv for PolarFire SoC

2022-10-06 Thread Padmarao.Begari
Hi Alan, Thank you for review. I will update same in Patch v2. Regards Padmarao From: Alan Cudmore Sent: Wednesday, October 5, 2022 7:52 PM To: Padmarao Begari - I30397 Cc: devel@rtems.org ; Cyril Jean - M31571 Subject: Re: [PATCH rtems-docs] user/bsps:

Re: [rtems-test] riscv/griscv: RTEMS_POSIX_API: Passed:597 Failed:7 Timeout:0 Test-Too-long:0 Invalid:0 Wrong:0

2022-10-06 Thread Sebastian Huber
On 20/09/2022 10:57, Sebastian Huber wrote: On 19/09/2022 18:39, OAR Tester wrote: ] test SHA512-224 ] 4634270f707b6a54 daae7530460842e2 0e37ed265ceee9a4 2fa08086 ] ../../../testsuites/libtests/sha/init.c: 356 memcmp([0], _sha512_224_results[i][0], sizeof(r)) == 0 This is an interesting

[PATCH v2 13/13] score: INTERNAL_ERROR_IDLE_THREAD_STACK_TOO_SMALL

2022-10-06 Thread Sebastian Huber
Ensure that the IDLE storage allocator did allocate a suffiently large area. Update #3835. Update #4524. --- cpukit/include/rtems/score/interr.h | 3 +- cpukit/sapi/src/interrtext.c | 3 +- cpukit/score/src/threadcreateidle.c | 4 +

[PATCH v2 06/13] score: Add CPU_THREAD_LOCAL_STORAGE_VARIANT

2022-10-06 Thread Sebastian Huber
Update #3835. --- bsps/powerpc/shared/cpu.c | 2 +- cpukit/include/rtems/score/tls.h | 204 -- cpukit/score/cpu/aarch64/cpu.c| 2 +- .../cpu/aarch64/include/rtems/score/cpuimpl.h | 3 + cpukit/score/cpu/arm/__aeabi_read_tp.c

[PATCH v2 08/13] score: INTERNAL_ERROR_IDLE_THREAD_CREATE_FAILED

2022-10-06 Thread Sebastian Huber
Add the INTERNAL_ERROR_IDLE_THREAD_CREATE_FAILED fatal error in case the creation of an idle thread fails. This may happen due to a failing create extension provided by the application. --- cpukit/include/rtems/score/interr.h | 1 + cpukit/sapi/src/interrtext.c | 3

[PATCH v2 05/13] config: Changeable size for IDLE stack allocator

2022-10-06 Thread Sebastian Huber
Allow the IDLE stack allocator to change the stack size. This can be used by applications with a very dynamic thread-local storage size to adjust the thread storage area of the IDLE tasks dynamically. Update #4524. --- cpukit/doxygen/appl-config.h | 2 +-

[PATCH v2 12/13] config: Add CONFIGURE_IDLE_TASK_STORAGE_SIZE

2022-10-06 Thread Sebastian Huber
By default, allocate the IDLE task storage areas from the RTEMS Workspace. This avoids having to estimate the thread-local storage size in the default configuration. Add the application configuration option CONFIGURE_IDLE_TASK_STORAGE_SIZE to request a static allocation of the task storage area

[PATCH v2 10/13] stackchk: Add rtems_stack_checker_iterate()

2022-10-06 Thread Sebastian Huber
--- cpukit/include/rtems/stackchk.h | 75 +++ cpukit/libmisc/stackchk/check.c | 158 +++- 2 files changed, 170 insertions(+), 63 deletions(-) diff --git a/cpukit/include/rtems/stackchk.h b/cpukit/include/rtems/stackchk.h index 7968211a51..c836263925

[PATCH v2 09/13] stackchk: Avoid internal header file

2022-10-06 Thread Sebastian Huber
--- cpukit/include/rtems/stackchk.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/cpukit/include/rtems/stackchk.h b/cpukit/include/rtems/stackchk.h index 22d48c9d2b..7968211a51 100644 --- a/cpukit/include/rtems/stackchk.h +++ b/cpukit/include/rtems/stackchk.h

[PATCH v2 11/13] stackchk01: Check CPU_STACK_MINIMUM_SIZE

2022-10-06 Thread Sebastian Huber
Ensure that the CPU_STACK_MINIMUM_SIZE is suffiently larger than the stack usage in simple applications. --- testsuites/libtests/stackchk01/init.c | 30 ++- testsuites/libtests/stackchk01/stackchk01.doc | 12 ++-- 2 files changed, 33 insertions(+), 9 deletions(-) diff

[PATCH v2 00/13] More robust idle thread creation and TLS handling

2022-10-06 Thread Sebastian Huber
This patch set started with an 8 byte overwrite of the interrupt stack while porting an application from RTEMS 5 to 6. The overwrite was due to a mismatch of the size returned by _TLS_Get_allocation_size() and the actual usage of the area. To fix this issue it was necessary to add a new CPU port

[PATCH v2 03/13] sptls02: Fix alignment check

2022-10-06 Thread Sebastian Huber
--- testsuites/sptests/sptls02/init.cc | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/testsuites/sptests/sptls02/init.cc b/testsuites/sptests/sptls02/init.cc index e4791cffd6..39fc2a2a24 100644 --- a/testsuites/sptests/sptls02/init.cc +++

[PATCH v2 04/13] score: Require power of two CPU_STACK_MINIMUM_SIZE

2022-10-06 Thread Sebastian Huber
For most CPU ports this was already the case. This makes it possible to use the size as an object alignment using RTEMS_ALIGNED(). --- cpukit/score/cpu/aarch64/include/rtems/score/cpu.h | 2 +- cpukit/score/cpu/moxie/include/rtems/score/cpu.h | 2 +-

[PATCH v2 01/13] sptls0*: Enable stack checker

2022-10-06 Thread Sebastian Huber
The thread-local storage area is located close to other stacks. Try to detect overwrites. --- testsuites/sptests/sptls01/init.c | 4 testsuites/sptests/sptls02/init.cc | 4 testsuites/sptests/sptls03/init.c | 4 3 files changed, 12 insertions(+) diff --git

[PATCH v2 02/13] sptls01: Disable file system and Newlib reentrancy

2022-10-06 Thread Sebastian Huber
Update #4560. --- testsuites/sptests/sptls01/init.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/testsuites/sptests/sptls01/init.c b/testsuites/sptests/sptls01/init.c index 64860ec9c9..a1c55940d9 100644 ---

[PATCH v2 07/13] score: Simplify casts

2022-10-06 Thread Sebastian Huber
--- cpukit/include/rtems/score/tls.h | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/cpukit/include/rtems/score/tls.h b/cpukit/include/rtems/score/tls.h index 9c90b6362b..abb0a748ad 100644 --- a/cpukit/include/rtems/score/tls.h +++

Re: [PATCH 06/13] config: Add rtems_malloc_task_stack_for_idle()

2022-10-06 Thread Sebastian Huber
On 06/10/2022 00:13, Chris Johns wrote: In this patch you discuss applications with "very dynamic thread-local storage size"? I have no idea what this means and under what conditions such an app is created. Could you please explain this? A scenario is a bigger organization in which one

[tools] tester: Check for begin/end of test

2022-10-06 Thread Sebastian Huber
Check for "BEGIN OF TEST" and "END OF TEST" to not use other information blocks such as "END OF GCOV" to determine the test status. --- tester/rt/report.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tester/rt/report.py b/tester/rt/report.py index d3bf1cb..21580e2