Re: [lwip 2/2] Move and rename sys_arch_data_sync_barier()

2023-03-17 Thread Pavel Pisa
Hello Kinsey and Sebastian, On Thursday 09 of March 2023 14:46:28 Kinsey Moore wrote: > Normally with rtems-lwip I would complain that this doesn't follow the > convention of using #ifdef __rtems__ to modify files from upstream sources > (each root directory except rtemslwip has an upstream

Re: [PATCH 1/2] dev/flash: Add API for Flash devices

2023-03-17 Thread Gedare Bloom
Some comments below. However, I think it will be best to first re-send just the flashdev.h file so that we can iterate on the API before you put too much more effort into implementing it. On Wed, Mar 15, 2023 at 8:56 PM wrote: > > From: Aaron Nyholm > > Updates #4896 I don't see a ticket with

Re: Flash Device API

2023-03-17 Thread Will
On Fri, Mar 17, 2023 at 4:24 PM Gedare Bloom wrote: > Thank you Aaron for contributing this. I have a few comments below, > and I'll also give some comments on your code shortly. > > On Fri, Mar 17, 2023 at 1:34 AM Sebastian Huber > wrote: > > > > > > > > On 16.03.23 23:07, Chris Johns wrote: >

Re: Flash Device API

2023-03-17 Thread Gedare Bloom
Thank you Aaron for contributing this. I have a few comments below, and I'll also give some comments on your code shortly. On Fri, Mar 17, 2023 at 1:34 AM Sebastian Huber wrote: > > > > On 16.03.23 23:07, Chris Johns wrote: > > On 16/3/2023 6:13 pm, Sebastian Huber wrote: > >> Hello Aaron, > >>

Re: [PATCH 1/3] bsps/riscv: Make SMP start more robust

2023-03-17 Thread Sebastian Huber
Hello Alan, On 16.03.23 22:33, Alan Cudmore wrote: I applied these three patches after my patches and ran them on my K210 board and simulator. I have a set of 12 tests including benchmarks, SMP01, SMP08, ticker, etc. Everything ran OK. Is there anything in particular I can try to test them

Re: [PATCH 1/3] bsps/riscv: Make SMP start more robust

2023-03-17 Thread Padmarao.Begari
> On Thu, 2023-03-16 at 09:59 +0100, Sebastian Huber wrote: > > In SMP configurations, check that we run on a configured > processor. If not, > then there is not much what can be done since we do not have a stack > available > for this processor. Just loop forever in this case. Do this in >

Re: [PATCH v2 0/3] bsps/riscv: Add kendrytek210 riscv BSP variant

2023-03-17 Thread Padmarao.Begari
I have tested it on the renode.io simulator and working fine. Regards Padmarao > On Wed, 2023-03-15 at 22:04 -0400, Alan Cudmore wrote: > > Version 2 patch updates: Separated the device tree source and encoded > device tree blob into a separate patch, added the license text to > k210.h,

Re: Flash Device API

2023-03-17 Thread Sebastian Huber
On 16.03.23 23:07, Chris Johns wrote: On 16/3/2023 6:13 pm, Sebastian Huber wrote: Hello Aaron, this API seems to be RTEMS-specific. Maybe we should simply pick up an existing solution which is in more wide spread use, for example: