Re: [PATCH 1/1] Modify Init task to print a different message!

2023-03-23 Thread Gedare Bloom
Thanks. Please discuss project ideas here (usually one email thread per topic works best) or on discord. I think there could be good interest in some FS-related improvements. On Thu, Mar 23, 2023 at 4:32 PM David Gumberg wrote: > > --- > hello.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

[PATCH rtems-lwip] lwip.py: Remove directory scanning

2023-03-23 Thread Kinsey Moore
This removes directory scanning from rtems-lwip for a more robust build system. Closes #4889 --- defs/bsps/aarch64/xilinx_zynqmp_base.json | 6 +++--- .../aarch64/xilinx_zynqmp_hardware_base.json| 8 defs/bsps/aarch64/xilinx_zynqmp_ilp32_qemu.json | 9 ++--- .../bsps/aar

Re: [PATCH 1/1] rtemsbsd/sdhci: Fix Arasan driver when no card present

2023-03-23 Thread Kinsey Moore
On Thu, Mar 23, 2023 at 7:19 PM Rick VanderWal wrote: > > On 3/23/23 10:26, Kinsey Moore wrote: > > On Wed, Mar 22, 2023 at 7:02 PM wrote: > >> >> + if (!(RD4(sc, SDHCI_PRESENT_STATE) & SDHCI_CARD_STABLE)) >> + { >> + device_printf(dev, >> + "CD fa

Re: [PATCH 1/1] rtemsbsd/sdhci: Fix Arasan driver when no card present

2023-03-23 Thread Rick VanderWal
Kinsey, Thanks for the feedback! I added the git config as recommended. Response to your comment is inline below. Regards, -Rick On 3/23/23 10:26, Kinsey Moore wrote: Hey Rick, This looks good for the most part and thanks for the contribution. For future patches, please make sure you specif

[PATCH 1/1] Modify Init task to print a different message!

2023-03-23 Thread David Gumberg
--- hello.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hello.c b/hello.c index db0a724..8a080f1 100644 --- a/hello.c +++ b/hello.c @@ -4,7 +4,7 @@ rtems_task Init(rtems_task_argument ignored) { - printf("\nHello world\n"); + printf("\nA very

[PATCH 0/1] GSOC Contributor Hello World Exercise

2023-03-23 Thread David Gumberg
Hi all, My name is David Gumberg and I am an open-source software contributor and enthusiast. I am hoping to be able to contribute to RTEMS as a part of GSOC 2023. I am very interested in firmware, microelectronics, and alternative hardware platforms. I am interested in working on improving the PO

Re: [PATCH] Add support for ELF notes

2023-03-23 Thread Chris Johns
On 24/3/2023 6:09 am, Joel Sherrill wrote: > Happy to see this but a bit concerned that there is only one architecture's > BSPs > addressed. What about the other architectures? Yes good question. I read the patch as generic with just enough support to show how it works. Chris ___

Re: [PATCH] Add support for ELF notes

2023-03-23 Thread Joel Sherrill
Happy to see this but a bit concerned that there is only one architecture's BSPs addressed. What about the other architectures? --joel On Thu, Mar 23, 2023, 12:07 PM Chris Johns wrote: > On 24/3/2023 3:57 am, Sebastian Huber wrote: > > On 23.03.23 17:52, Will wrote: > >> Great idea to store thi

Re: [PATCH] Add support for ELF notes

2023-03-23 Thread Chris Johns
On 24/3/2023 3:57 am, Sebastian Huber wrote: > On 23.03.23 17:52, Will wrote: >> Great idea to store this information in the executable itself. Does this need >> a RTEMS_TEST_STATE_LINK_ONLY test state or something similar for minimum.exe? > > With the notes you can build the test. The test runner

[PATCH rtems-lwip] rtemslwip/ifaddrs: Set loopback flag

2023-03-23 Thread Kinsey Moore
Some consumers of getifaddrs() depend on the loopback flag being set appropriately to filter interfaces. Make sure that requirement is satisfied. --- rtemslwip/bsd_compat/ifaddrs.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/rtemslwip/bsd_compat/ifaddrs.c b/rtemslwip/bsd_compat/ifadd

Re: [PATCH] Add support for ELF notes

2023-03-23 Thread Sebastian Huber
On 23.03.23 17:52, Will wrote: Great idea to store this information in the executable itself. Does this need a RTEMS_TEST_STATE_LINK_ONLY test state or something similar for minimum.exe? With the notes you can build the test. The test runner would look at the notes and then decide if it makes

Re: [PATCH] score: Simplify _Objects_Is_api_valid()

2023-03-23 Thread Sebastian Huber
On 23.03.23 17:46, Joel Sherrill wrote: On Thu, Mar 23, 2023 at 11:09 AM Sebastian Huber > wrote: On 23.03.23 17:03, Joel Sherrill wrote: > > On Thu, Mar 23, 2023 at 10:40 AM Sebastian Huber > mailto:sebastian.hu...@embedded-brain

Re: [PATCH] score: Simplify _Objects_Is_api_valid()

2023-03-23 Thread Joel Sherrill
On Thu, Mar 23, 2023 at 11:09 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 23.03.23 17:03, Joel Sherrill wrote: > > > > On Thu, Mar 23, 2023 at 10:40 AM Sebastian Huber > > > > wrote: > > > > Close #4863. > > --- > >

Re: [PATCH] score: Simplify _Objects_Is_api_valid()

2023-03-23 Thread Sebastian Huber
On 23.03.23 17:03, Joel Sherrill wrote: On Thu, Mar 23, 2023 at 10:40 AM Sebastian Huber > wrote: Close #4863. ---  cpukit/include/rtems/score/objectimpl.h | 4 +---  1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/c

Re: [PATCH] score: Simplify _Objects_Is_api_valid()

2023-03-23 Thread Joel Sherrill
On Thu, Mar 23, 2023 at 10:40 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Close #4863. > --- > cpukit/include/rtems/score/objectimpl.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/cpukit/include/rtems/score/objectimpl.h > b/cpukit/include/rtems

[PATCH] score: Simplify _Objects_Is_api_valid()

2023-03-23 Thread Sebastian Huber
Close #4863. --- cpukit/include/rtems/score/objectimpl.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cpukit/include/rtems/score/objectimpl.h b/cpukit/include/rtems/score/objectimpl.h index c58957ccb5..a1a87b5ccb 100644 --- a/cpukit/include/rtems/score/objectimpl.h +++ b

Re: [PATCH 1/1] rtemsbsd/sdhci: Fix Arasan driver when no card present

2023-03-23 Thread Kinsey Moore
Hey Rick, This looks good for the most part and thanks for the contribution. For future patches, please make sure you specify the repository in your subject line if the patch isn't for the RTEMS repository. This can be configured to occur automatically in your local per-repo git configuration usin

[PATCH] Add support for ELF notes

2023-03-23 Thread Sebastian Huber
This is a prototype patch for adding ELF notes. ELF notes can be used to attach domain-specific data to ELF files. This could be used to store for example the RTEMS version, Git commit, configuration options, expected test state, etc. in the executable ELF file. Example: readelf -n build/arm/xi