[PATCH v1] bsps/aarch64: Fix 128bit q register print bug

2023-05-15 Thread tianye
From: Tian Ye --- cpukit/score/cpu/aarch64/aarch64-exception-frame-print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/cpu/aarch64/aarch64-exception-frame-print.c b/cpukit/score/cpu/aarch64/aarch64-exception-frame-print.c index e207a5a81d..c5b477c72f 100644

Re: Static analysis

2023-05-15 Thread Sam Price
Results from cppcheck cpukit/include/sys/timetc.h:17:0: error: #error "no user-serviceable parts inside" [preprocessorErrorDirective] #error "no user-serviceable parts inside" ^ testsuites/samples/capture/test1.c:97:5: error: Uninitialized variable: i [uninitvar] i++; ^

Re: Static analysis

2023-05-15 Thread Sam Price
Thanks Alex, I was able to run cppcheck. I had to install the newest cppcheck from source to get access to the --project flag. i ran bear ./waf and then cppcheck --project=compile_commands.json It returned a few static analysis errors if interested. I'll attach the results when it finishes

Re: Static analysis

2023-05-15 Thread Joel Sherrill
Not sure if this helps but here is the script used to run Coverity https://github.com/joelsherrill/rtems-cron-helpers/blob/main/rtems-run-coverity On Mon, May 15, 2023, 10:03 AM Alex White wrote: > You should be able to use `bear` (https://github.com/rizsotto/Bear). I > have it installed via

Re: [PATCH rtems 00/12] bsp/imxrt: Update SDK and prepare for new variant

2023-05-15 Thread Chris Johns
On 15/5/2023 6:13 pm, o...@c-mauderer.de wrote: > Hello Chris, > > Am 15.05.23 um 05:18 schrieb Chris Johns: >> >> >> On 6/5/2023 2:02 am, Gedare Bloom wrote: >>> On Fri, May 5, 2023 at 9:02 AM wrote: Hello Gedare, thanks for taking a look at the patch set. Am

[PATCH rtems v2] _TOD_Adjust method is unused. Remove it.

2023-05-15 Thread Joel Sherrill
Use of this method was likely eliminated during the rework to use FreeBSD bintime/sbintime. Close #4905. --- cpukit/include/rtems/score/todimpl.h | 15 cpukit/score/src/coretodadjust.c | 73 spec/build/cpukit/librtemscpu.yml| 1 - 3 files

[PATCH rtems] _TOD_Adjust method is unused. Remove it.

2023-05-15 Thread Joel Sherrill
Use of this method was likely eliminated during the rework to use FreeBSD bintime/sbintime. Close #4905. --- cpukit/include/rtems/score/todimpl.h | 15 --- spec/build/cpukit/librtemscpu.yml| 1 - 2 files changed, 16 deletions(-) diff --git a/cpukit/include/rtems/score/todimpl.h

Re: Static analysis

2023-05-15 Thread Alex White
You should be able to use `bear` (https://github.com/rizsotto/Bear). I have it installed via my package manager. After a `./waf clean`, run `bear -- ./waf` to generate compile_commands.json. Then you should be able to run `cppcheck --project=compile_commands.json`. Alex

Re: [PATCH rtems v2 00/12] bsp/imxrt: Update SDK and prepare for new variant

2023-05-15 Thread Gedare Bloom
I'm fine with the v2 now, thanks for reducing it. Do feel free to start a separate discussion / ticket about how we should handle HALs. I think this problem will only get worse not better. On Tue, May 9, 2023 at 6:11 AM Christian Mauderer wrote: > > Hello, > > this is the second version of the

Re: cpukit/flash: Add API for Flash device

2023-05-15 Thread Gedare Bloom
Sorry for the delays. These patches look fine now other than a few small things that can be fixed either on check-in or cleaning up later. On Sun, Apr 30, 2023 at 11:21 PM wrote: > > Hi All, > > Thanks again for the feedback. I've improved the implementation of the > bit allocator in line with

Re: [PATCH v4 3/3] testsuites/libtests: Add test for flashdev

2023-05-15 Thread Gedare Bloom
On Sun, Apr 30, 2023 at 11:21 PM wrote: > > From: Aaron Nyholm > > --- > spec/build/testsuites/libtests/flashdev01.yml | 20 ++ > spec/build/testsuites/libtests/grp.yml| 2 + > testsuites/libtests/flashdev01/flashdev01.doc | 11 + > testsuites/libtests/flashdev01/flashdev01.scn |

Re: [PATCH v4 2/3] libmisc/shell: Add flashdev command

2023-05-15 Thread Gedare Bloom
On Sun, Apr 30, 2023 at 11:20 PM wrote: > > From: Aaron Nyholm > > --- > cpukit/include/rtems/shellconfig.h | 7 + > cpukit/libmisc/shell/main_flashdev.c | 592 +++ > spec/build/cpukit/objshell.yml | 1 + > 3 files changed, 600 insertions(+) > create mode

Re: [PATCH rtems 00/12] bsp/imxrt: Update SDK and prepare for new variant

2023-05-15 Thread oss
Hello Chris, Am 15.05.23 um 05:18 schrieb Chris Johns: On 6/5/2023 2:02 am, Gedare Bloom wrote: On Fri, May 5, 2023 at 9:02 AM wrote: Hello Gedare, thanks for taking a look at the patch set. Am 05.05.23 um 15:56 schrieb Gedare Bloom: On Thu, May 4, 2023 at 9:01 AM Christian Mauderer