Re: Pause on console in libmisc/shell detecting terminal size (mvme5500, beatnik)

On Thu, Jan 4, 2024, 5:47 PM zhengxiaojun <17935...@qq.com> wrote: > > > 在 2024/1/5 4:25, Peter Dufault 写道: > > I guess maybe the list went down for a while. I sent this on 12-30, and > just got a bounce message today and no "devel" mail until today. > > > > On master when I type a shell

Re: Pause on console in libmisc/shell detecting terminal size (mvme5500, beatnik)

在 2024/1/5 4:25, Peter Dufault 写道: I guess maybe the list went down for a while. I sent this on 12-30, and just got a bounce message today and no "devel" mail until today. On master when I type a shell command at the console there is a pause, rough timing: - Three second pause after

Re: [PATCH] cpukit/dosfs: Cast away ignored return

The style in existing code displays both variants and the coding standards document isn't clear on the matter that I could find other than giving a demonstration of voiding an unused function argument that does have the space. Other commentary about spaces and parens deals with conditionals. On

Re: [PATCH] cpukit/dosfs: Cast away ignored return

Don't we put a space after the (void)? On Thu, Jan 4, 2024 at 12:55 PM Kinsey Moore wrote: > An error is already being reported. Checking the return value of this > function is not useful. > --- > cpukit/libfs/src/dosfs/msdos_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH rtems-lwip - v1 10/11] FIX compiler warning due to macro redefinition

I think this line used to have an effect, but was accidentally obsoleted when I implemented rtemslwip/bsd_compat/netdb.c. This patch is good to go in. Kinsey On Thu, Jan 4, 2024 at 12:55 PM wrote: > From: Bernd Moessner > > --- > rtemslwip/common/rtems_lwip_io.c | 2 -- > 1 file changed, 2

Re: [PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

On Thu, Jan 4, 2024 at 4:40 PM Bernd Moessner wrote: > > On 04.01.2024 23:26, Kinsey Moore wrote: > > On Thu, Jan 4, 2024 at 4:03 PM Bernd Moessner > wrote: > >> >> On 04.01.2024 22:33, Kinsey Moore wrote: >> > This looks like it should be fine for now to enable installing into >> > somewhere

Re: [PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

On 04.01.2024 23:26, Kinsey Moore wrote: On Thu, Jan 4, 2024 at 4:03 PM Bernd Moessner wrote: On 04.01.2024 22:33, Kinsey Moore wrote: > This looks like it should be fine for now to enable installing into > somewhere that isn't the installed BSP directory. Longer term, >

Re: [PATCH rtems-lwip - v1 06/11] FIX: printf format spec compiler warning due to uintptr having 64bits on 64bit machines

On 04.01.2024 23:22, Kinsey Moore wrote: Comments inline. On Thu, Jan 4, 2024 at 12:54 PM wrote: From: Bernd Moessner ---  .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c     | 3 ++-  1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

On Thu, Jan 4, 2024 at 4:03 PM Bernd Moessner wrote: > > On 04.01.2024 22:33, Kinsey Moore wrote: > > This looks like it should be fine for now to enable installing into > > somewhere that isn't the installed BSP directory. Longer term, > > rtems-lwip should probably support similar options to

Re: [PATCH rtems-lwip - v1 06/11] FIX: printf format spec compiler warning due to uintptr having 64bits on 64bit machines

Comments inline. On Thu, Jan 4, 2024 at 12:54 PM wrote: > From: Bernd Moessner > > --- > .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git >

Re: [PATCH rtems-lwip - v1 05/11] FIX: remove header files which are already provided by RTEMS

This change looks good. Kinsey On Thu, Jan 4, 2024 at 12:54 PM wrote: > From: Bernd Moessner > > --- > defs/bsps/aarch64/xilinx_zynqmp_base.json | 3 +- > .../src/arm/ARMv8/64bit/xil_cache.h | 75 > .../standalone/src/arm/common/xil_exception.h | 408 --

Re: [PATCH rtems6 - v1 07/16] Flashdev: Refactor write_block_size and add function to dergister flashdev

On 04.01.2024 20:05, Kinsey Moore wrote: A few comments inline. On Thu, Jan 4, 2024 at 12:35 PM wrote: From: Bernd Moessner ---  cpukit/dev/flash/flashdev.c                   |  71 --  cpukit/include/dev/flash/flashdev.h           |  22 +-  

Re: [PATCH rtems-lwip - v1 04/11] FIX: warning variable might be used without initialization

On 04.01.2024 22:41, Kinsey Moore wrote: This is technically a false warning since rtems_interrupt_disable is a macro that expands to _ISR_Local_disable that expands to _CPU_ISR_Disable which assigns it a value, but it doesn't hurt anything, so it's OK to commit. Kinsey On Thu, Jan 4, 2024

Re: [PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

On 04.01.2024 22:33, Kinsey Moore wrote: This looks like it should be fine for now to enable installing into somewhere that isn't the installed BSP directory. Longer term, rtems-lwip should probably support similar options to rtems-libbsd such that the RTEMS path can be passed on the

Re: [PATCH rtems6 - v1 06/16] Flashdev: Make mutex name more generic

On 04.01.2024 19:55, Kinsey Moore wrote: On Thu, Jan 4, 2024 at 12:35 PM wrote: From: Bernd Moessner ---  cpukit/dev/flash/flashdev.c | 5 -  1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c

Re: [PATCH rtems-lwip - v1 04/11] FIX: warning variable might be used without initialization

This is technically a false warning since rtems_interrupt_disable is a macro that expands to _ISR_Local_disable that expands to _CPU_ISR_Disable which assigns it a value, but it doesn't hurt anything, so it's OK to commit. Kinsey On Thu, Jan 4, 2024 at 12:54 PM wrote: > From: Bernd Moessner >

Re: [PATCH rtems-lwip - v1 03/11] Clean up: remove non-existent include paths

This patch looks good. Kinsey On Thu, Jan 4, 2024 at 12:55 PM wrote: > From: Bernd Moessner > > --- > defs/bsps/aarch64/xilinx_zynqmp_base.json | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/defs/bsps/aarch64/xilinx_zynqmp_base.json > b/defs/bsps/aarch64/xilinx_zynqmp_base.json >

Re: [PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

This looks like it should be fine for now to enable installing into somewhere that isn't the installed BSP directory. Longer term, rtems-lwip should probably support similar options to rtems-libbsd such that the RTEMS path can be passed on the configure line using --rtems=. Kinsey On Thu, Jan

Re: [PATCH rtems-lwip - v1 01/11] FIX: adjust submodule path to allow checkout in restricted network environments

This change looks good. Kinsey On Thu, Jan 4, 2024 at 12:55 PM wrote: > From: Bernd Moessner > > --- > .gitmodules | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gitmodules b/.gitmodules > index 4ea46da..f6d2b63 100644 > --- a/.gitmodules > +++ b/.gitmodules >

[PATCH rtems-docs] user/bsps/arm: Add documentation for ZynqMP R5 BSP

This adds basic user documentation for running RTEMS on the Cortex-R5 processor on Xilinx Zynq Ultrascale+ MPSoC chips. --- user/bsps/arm/xilinx-zynqmp-rpu.rst | 66 + user/bsps/bsps-arm.rst | 1 + 2 files changed, 67 insertions(+) create mode 100644

Re: [PATCH rtems6 - v1 00/16] Overwork flashdev - V1

On Thu, Jan 4, 2024 at 2:44 PM Bernd Moessner wrote: > On 04.01.2024 20:40, Kinsey Moore wrote: > > On Thu, Jan 4, 2024 at 12:34 PM wrote: > >> From: Bernd Moessner >> >> Dear all, >> >> as outlined in https://devel.rtems.org/ticket/4981 I`d like to >> overwork the flashdev API. The provided

Re: [PATCH rtems6 - v1 00/16] Overwork flashdev - V1

On 04.01.2024 20:40, Kinsey Moore wrote: On Thu, Jan 4, 2024 at 12:34 PM wrote: From: Bernd Moessner Dear all, as outlined in https://devel.rtems.org/ticket/4981 I`d like to overwork the flashdev API. The provided patch series should at least serve as a fundament for the

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

On Thu, Jan 4, 2024 at 2:24 PM Bernd Moessner wrote: > Dear Kinsey, > > sry for the stupid question. What is the correct way to reference the issue > > [#4981 rtems6 - v1 05/16] FIX: Add > missing default case > > or > > [PATCH rtems6 - v1 05/16] #4981

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

https://docs.rtems.org/branches/master/eng/vc-users.html#commit-message-guidance If that is missing something, please ask questions and we can address the Software Engineering Guide. --joel On Thu, Jan 4, 2024 at 2:24 PM Bernd Moessner wrote: > Dear Kinsey, > > sry for the stupid question.

Pause on console in libmisc/shell detecting terminal size (mvme5500, beatnik)

I guess maybe the list went down for a while. I sent this on 12-30, and just got a bounce message today and no "devel" mail until today. On master when I type a shell command at the console there is a pause, rough timing: - Three second pause after hitting return; - "0q" shows up on the

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

On Thu, Jan 4, 2024 at 12:49 PM Kinsey Moore wrote: > All of the patches here need an issue reference. Beyond that, this patch > is good to go in. I'm still reviewing the remainder of the set and I'll > leave the renaming discussion to Aaron. > I have only gotten this far into the patch set but

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

Dear Kinsey, sry for the stupid question. What is the correct way to reference the issue [#4981 rtems6 - v1 05/16] FIX: Add missing default case or [PATCH rtems6 - v1 05/16] #4981 FIX: Add missing default case ?

Re: [PATCH rtems6 - v1 04/16] Flashdev: Align IOCTL and shell function names

This looks ok to me. Just more name realignment which shouldn't impact much. On Thu, Jan 4, 2024 at 12:34 PM wrote: > From: Bernd Moessner > > --- > cpukit/libmisc/shell/main_flashdev.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git

Re: [PATCH rtems6 - v1 03/16] Flashdev: Align IOCTL function and macro names

This looks ok to me. Similar naming change. On Thu, Jan 4, 2024 at 12:34 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c | 72 +-- > cpukit/include/dev/flash/flashdev.h | 12 ++-- > .../libtests/flashdev01/test_flashdev.c

Re: [PATCH rtems6 - v1 01/16] FIX: Add missing C++ include guards

This looks ok to me. On Thu, Jan 4, 2024 at 12:34 PM wrote: > From: Bernd Moessner > > --- > cpukit/include/dev/flash/flashdev.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/cpukit/include/dev/flash/flashdev.h > b/cpukit/include/dev/flash/flashdev.h > index

Re: [PATCH rtems6 - v1 02/16] Flashdev: Unify IOCTL macro names

I'm ok with this. I like the subject/verb/direct object naming of the ioctls. --joel On Thu, Jan 4, 2024 at 12:34 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c | 16 > cpukit/include/dev/flash/flashdev.h | 16 >

Re: [PATCH rtems6 - v1 00/16] Overwork flashdev - V1

On Thu, Jan 4, 2024 at 12:34 PM wrote: > From: Bernd Moessner > > Dear all, > > as outlined in https://devel.rtems.org/ticket/4981 I`d like to > overwork the flashdev API. The provided patch series should at > least serve as a fundament for the discussion. > > It includes more, but h: > > 1)

Re: [PATCH rtems6 - v1 15/16] FIX: printf size warning on 64bit systems

This should be merged with a previous patch. Kinsey On Thu, Jan 4, 2024 at 12:35 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c | 6 +++--- > cpukit/include/dev/flash/flashdev.h | 6 ++ > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH rtems6 - v1 16/16] FIX: missing return value warning

This patch should be merged with patch 12/16 that introduced the bug. Kinsey On Thu, Jan 4, 2024 at 12:35 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpukit/dev/flash/flashdev.c

Re: [PATCH rtems6 - v1 08/16] Flashdev: Add IOCTL to get the erase size

I thought that erase size was in the page information returned by the relevant IOCTLs, but I apparently overlooked that. You'll need to implement this similarly to how the page information retrieval is implemented or possibly merge block/sector information in with that returned data. IIRC, NOR

Re: [PATCH rtems6 - v1 07/16] Flashdev: Refactor write_block_size and add function to dergister flashdev

A few comments inline. On Thu, Jan 4, 2024 at 12:35 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c | 71 -- > cpukit/include/dev/flash/flashdev.h | 22 +- > cpukit/libmisc/shell/main_flashdev.c | 26 +-- >

Re: [PATCH rtems6 - v1 06/16] Flashdev: Make mutex name more generic

On Thu, Jan 4, 2024 at 12:35 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c > index 8bd3d11246..0020e8d2c1 100644 > ---

[PATCH rtems 06/14] Flashdev: Make mutex name more generic

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index 8bd3d11246..0020e8d2c1 100644 --- a/cpukit/dev/flash/flashdev.c +++ b/cpukit/dev/flash/flashdev.c @@ -34,6

[PATCH rtems-lwip - v1 09/11] FIX incompatible pointer warning

From: Bernd Moessner --- .../contrib/ports/xilinx/netif/xemacpsif.c| 21 +++ 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xemacpsif.c

[PATCH rtems 09/14] FIX: Regions must be aligned with erase size

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 35 ++ testsuites/libtests/flashdev01/init.c | 66 --- 2 files changed, 95 insertions(+), 6 deletions(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index

[PATCH rtems-lwip 02/10] FIX: add library search path to allow lwip being installed aside the RTEMS installation

From: Bernd Moessner --- lwip.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lwip.py b/lwip.py index bd743a1..65f1ead 100644 --- a/lwip.py +++ b/lwip.py @@ -137,9 +137,10 @@ def build(bld): includes=' '.join(test_app_incl)) lib_path =

[PATCH rtems-lwip - v1 10/11] FIX compiler warning due to macro redefinition

From: Bernd Moessner --- rtemslwip/common/rtems_lwip_io.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/rtemslwip/common/rtems_lwip_io.c b/rtemslwip/common/rtems_lwip_io.c index ee34774..2fed874 100644 --- a/rtemslwip/common/rtems_lwip_io.c +++ b/rtemslwip/common/rtems_lwip_io.c @@ -31,8

[PATCH] cpukit/dosfs: Cast away ignored return

An error is already being reported. Checking the return value of this function is not useful. --- cpukit/libfs/src/dosfs/msdos_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libfs/src/dosfs/msdos_file.c b/cpukit/libfs/src/dosfs/msdos_file.c index

[PATCH rtems 08/14] Flashdev: Add IOCTL to get the erase size

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 24 +++ cpukit/include/dev/flash/flashdev.h | 21 + cpukit/libmisc/shell/main_flashdev.c | 28 + testsuites/libtests/flashdev01/init.c | 14 ++---

[PATCH rtems-lwip 03/10] Clean up: remove non-existent include paths

From: Bernd Moessner --- defs/bsps/aarch64/xilinx_zynqmp_base.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/defs/bsps/aarch64/xilinx_zynqmp_base.json b/defs/bsps/aarch64/xilinx_zynqmp_base.json index c18b339..3e47434 100644 --- a/defs/bsps/aarch64/xilinx_zynqmp_base.json +++

[PATCH] cpukit/dosfs: Jump to correct error handler

When encountering an error during filesystem creation, fat_fd must be cleaned up appropriately once the file is opened. There was an opportunity for a resource leak due to jumping to the incorrect error handling label. --- cpukit/libfs/src/dosfs/msdos_create.c | 2 +- 1 file changed, 1

[PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

From: Bernd Moessner --- lwip.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lwip.py b/lwip.py index bd743a1..65f1ead 100644 --- a/lwip.py +++ b/lwip.py @@ -137,9 +137,10 @@ def build(bld): includes=' '.join(test_app_incl)) lib_path =

[PATCH rtems-lwip - v1 11/11] FIX wrong line ending for printf

From: Bernd Moessner --- .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c

[PATCH rtems 14/14] FIX: 80 char per line limit issues

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 43 +-- cpukit/include/dev/flash/flashdev.h | 3 +- cpukit/libmisc/shell/main_flashdev.c | 10 - testsuites/libtests/flashdev01/init.c | 17 ++--

[PATCH rtems 00/14] #4981 Overwork flashdev

From: Bernd Moessner Dear all, as outlined in https://devel.rtems.org/ticket/4981 I`d like to overwork the flashdev API. The provided patch series should at least serve as a fundament for the discussion. It includes more, but h: 1) Bugfixes 1.1) missing c++ include guards 1.2) missing

[PATCH rtems 02/14] Flashdev: Unify IOCTL macro names

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 16 cpukit/include/dev/flash/flashdev.h | 16 cpukit/libmisc/shell/main_flashdev.c | 12 ++-- testsuites/libtests/flashdev01/init.c | 16 4 files changed, 30

[PATCH rtems-lwip 10/10] FIX compiler warning due to macro redefinition

From: Bernd Moessner --- rtemslwip/common/rtems_lwip_io.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/rtemslwip/common/rtems_lwip_io.c b/rtemslwip/common/rtems_lwip_io.c index ee34774..2fed874 100644 --- a/rtemslwip/common/rtems_lwip_io.c +++ b/rtemslwip/common/rtems_lwip_io.c @@ -31,8

[PATCH rtems 11/14] Flashdev: Update copyright notice

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c| 1 + cpukit/include/dev/flash/flashdev.h| 1 + testsuites/libtests/flashdev01/init.c | 1 + testsuites/libtests/flashdev01/test_flashdev.c | 1 + testsuites/libtests/flashdev01/test_flashdev.h | 1 +

[PATCH rtems-lwip 09/10] FIX incompatible pointer warning

From: Bernd Moessner --- .../contrib/ports/xilinx/netif/xemacpsif.c| 21 +++ 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xemacpsif.c

[PATCH rtems-lwip - v1 00/11] RTEMS LWIP clean up - V1

From: Bernd Moessner This patch set: a) Changes the submodule paths to https so that the project can be checked out in restricted network environments b) Fixes a bug in lwip.py. The library search path wasnt set up so it was only possible to install rtems-lwip in the rtems install folder. c)

[PATCH rtems-lwip - v1 03/11] Clean up: remove non-existent include paths

From: Bernd Moessner --- defs/bsps/aarch64/xilinx_zynqmp_base.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/defs/bsps/aarch64/xilinx_zynqmp_base.json b/defs/bsps/aarch64/xilinx_zynqmp_base.json index c18b339..3e47434 100644 --- a/defs/bsps/aarch64/xilinx_zynqmp_base.json +++

[PATCH rtems-lwip 01/10] FIX: adjust submodule path to allow checkout in restricted network environments

From: Bernd Moessner --- .gitmodules | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index 4ea46da..f6d2b63 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,6 +1,6 @@ [submodule "lwip-upstream"] path = lwip-upstream - url =

[PATCH rtems-lwip - v1 01/11] FIX: adjust submodule path to allow checkout in restricted network environments

From: Bernd Moessner --- .gitmodules | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index 4ea46da..f6d2b63 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,6 +1,6 @@ [submodule "lwip-upstream"] path = lwip-upstream - url =

[PATCH rtems-lwip 06/10] FIX: printf format spec compiler warning due to uintptr having 64bits on 64bit machines

From: Bernd Moessner --- .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c

[PATCH rtems-lwip - v1 07/11] FIX: incompatible pointer warning

From: Bernd Moessner --- .../lwip211/src/contrib/ports/xilinx/netif/xemacpsif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xemacpsif.c

[PATCH rtems 01/14] FIX: Add missing C++ include guards

From: Bernd Moessner --- cpukit/include/dev/flash/flashdev.h | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/include/dev/flash/flashdev.h b/cpukit/include/dev/flash/flashdev.h index d1dc08a5c4..6759357206 100644 --- a/cpukit/include/dev/flash/flashdev.h +++

[PATCH] libio: Clean up usage of rtems_termios_device_mode

This cleans up outputUsesInterrupts usage with rtems_termios_device_mode enum values. The outputUsesInterrupts member was typed as an int, named as if it were a boolean value, and used as if it were a rtems_termios_device_mode enum. In this patch, values assigned to outputUsesInterrupts have been

[PATCH rtems 07/14] Flashdev: Refactor write_block_size and add function to dergister flashdev

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 71 -- cpukit/include/dev/flash/flashdev.h | 22 +- cpukit/libmisc/shell/main_flashdev.c | 26 +-- testsuites/libtests/flashdev01/init.c | 204 --

[PATCH rtems-lwip 00/10] RTEMS LWIP clean up

From: Bernd Moessner This patch set: a) Changes the submodule paths to https so that the project can be checked out in restricted network environments b) Fixes a bug in lwip.py. The library search path wasnt set up so it was only possible to install rtems-lwip in the rtems install folder. c)

[PATCH rtems 10/14] Flashdev: Refactoring, replace region with partition jargon and allow IOTCLs to return a value

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 1051 + cpukit/include/dev/flash/flashdev.h | 250 ++-- cpukit/libmisc/shell/main_flashdev.c |2 +- testsuites/libtests/flashdev01/init.c | 97 +-

[PATCH rtems 03/14] Flashdev: Align IOCTL function and macro names

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 72 +-- cpukit/include/dev/flash/flashdev.h | 12 ++-- .../libtests/flashdev01/test_flashdev.c | 36 +- 3 files changed, 60 insertions(+), 60 deletions(-) diff --git

[PATCH rtems-lwip 08/10] FIX incompatible pointer warning

From: Bernd Moessner --- .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c| 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c

[PATCH rtems-lwip 04/10] FIX: warning variable might be used without initialization

From: Bernd Moessner --- rtemslwip/common/sys_arch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtemslwip/common/sys_arch.c b/rtemslwip/common/sys_arch.c index 2651c9c..b97404c 100644 --- a/rtemslwip/common/sys_arch.c +++ b/rtemslwip/common/sys_arch.c @@ -372,7 +372,7

[PATCH rtems-lwip 05/10] FIX: remove header files which are already provided by RTEMS

From: Bernd Moessner --- defs/bsps/aarch64/xilinx_zynqmp_base.json | 3 +- .../src/arm/ARMv8/64bit/xil_cache.h | 75 .../standalone/src/arm/common/xil_exception.h | 408 -- rtemslwip/xilinx/xil_printf.h | 33 -- rtemslwip/xilinx/xil_smc.h

[PATCH rtems 13/14] Flashdev: Allow flash geometry beeing set from test case

From: Bernd Moessner --- testsuites/libtests/flashdev01/init.c | 9 ++-- .../libtests/flashdev01/test_flashdev.c | 51 +-- .../libtests/flashdev01/test_flashdev.h | 2 +- 3 files changed, 42 insertions(+), 20 deletions(-) diff --git

[PATCH rtems 04/14] Flashdev: Align IOCTL and shell function names

From: Bernd Moessner --- cpukit/libmisc/shell/main_flashdev.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/cpukit/libmisc/shell/main_flashdev.c b/cpukit/libmisc/shell/main_flashdev.c index 969b0687d2..516c77ae27 100644 ---

[PATCH] bsps/aarch64/cache: Clean up unused fuctions

When the CPU_CACHE_SUPPORT_PROVIDES_RANGE_FUNCTIONS definition was added to AArch64 cache management, it obsoleted the *_1_data/instruction_line functions. These have been removed since they are no longer referenced. The AArch64_instruction_cache_inner_shareable_invalidate_all function is only

[PATCH rtems-lwip - v1 04/11] FIX: warning variable might be used without initialization

From: Bernd Moessner --- rtemslwip/common/sys_arch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtemslwip/common/sys_arch.c b/rtemslwip/common/sys_arch.c index 2651c9c..b97404c 100644 --- a/rtemslwip/common/sys_arch.c +++ b/rtemslwip/common/sys_arch.c @@ -372,7 +372,7

[PATCH rtems 05/14] FIX: Add missing default case

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index 27edead968..8bd3d11246 100644 --- a/cpukit/dev/flash/flashdev.c +++ b/cpukit/dev/flash/flashdev.c @@ -390,6 +390,8 @@ static

[PATCH rtems-lwip - v1 08/11] FIX incompatible pointer warning

From: Bernd Moessner --- .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c| 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c

[PATCH rtems-lwip - v1 05/11] FIX: remove header files which are already provided by RTEMS

From: Bernd Moessner --- defs/bsps/aarch64/xilinx_zynqmp_base.json | 3 +- .../src/arm/ARMv8/64bit/xil_cache.h | 75 .../standalone/src/arm/common/xil_exception.h | 408 -- rtemslwip/xilinx/xil_printf.h | 33 -- rtemslwip/xilinx/xil_smc.h

[PATCH rtems 12/14] Add IOCTL to get the active partition idx

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 24 cpukit/include/dev/flash/flashdev.h | 9 + 2 files changed, 33 insertions(+) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index b06e7d0c2f..ee01b8b447 100644 ---

[PATCH rtems-lwip 07/10] FIX: incompatible pointer warning

From: Bernd Moessner --- .../lwip211/src/contrib/ports/xilinx/netif/xemacpsif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xemacpsif.c

[PATCH rtems-lwip - v1 06/11] FIX: printf format spec compiler warning due to uintptr having 64bits on 64bit machines

From: Bernd Moessner --- .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

All of the patches here need an issue reference. Beyond that, this patch is good to go in. I'm still reviewing the remainder of the set and I'll leave the renaming discussion to Aaron. Kinsey On Thu, Jan 4, 2024 at 12:35 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c

[PATCH rtems6 - v1 15/16] FIX: printf size warning on 64bit systems

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 6 +++--- cpukit/include/dev/flash/flashdev.h | 6 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index ee06007a53..b3cec5af35 100644 ---

[PATCH rtems6 - v1 16/16] FIX: missing return value warning

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index b3cec5af35..8b9dfc7832 100644 --- a/cpukit/dev/flash/flashdev.c +++ b/cpukit/dev/flash/flashdev.c @@ -1101,7

[PATCH rtems6 - v1 13/16] Flashdev: Allow flash geometry beeing set from test case

From: Bernd Moessner --- testsuites/libtests/flashdev01/init.c | 9 ++-- .../libtests/flashdev01/test_flashdev.c | 51 +-- .../libtests/flashdev01/test_flashdev.h | 2 +- 3 files changed, 42 insertions(+), 20 deletions(-) diff --git

[PATCH rtems6 - v1 14/16] FIX: 80 char per line limit issues

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 43 +-- cpukit/include/dev/flash/flashdev.h | 3 +- cpukit/libmisc/shell/main_flashdev.c | 10 - testsuites/libtests/flashdev01/init.c | 17 ++--

[PATCH rtems6 - v1 12/16] Add IOCTL to get the active partition idx

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 24 cpukit/include/dev/flash/flashdev.h | 9 + 2 files changed, 33 insertions(+) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index b06e7d0c2f..ee01b8b447 100644 ---

[PATCH rtems6 - v1 11/16] Flashdev: Update copyright notice

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c| 1 + cpukit/include/dev/flash/flashdev.h| 1 + testsuites/libtests/flashdev01/init.c | 1 + testsuites/libtests/flashdev01/test_flashdev.c | 1 + testsuites/libtests/flashdev01/test_flashdev.h | 1 +

[PATCH rtems6 - v1 10/16] Flashdev: Refactoring, replace region with partition jargon and allow IOTCLs to return a value

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 1051 + cpukit/include/dev/flash/flashdev.h | 250 ++-- cpukit/libmisc/shell/main_flashdev.c |2 +- testsuites/libtests/flashdev01/init.c | 97 +-

[PATCH rtems6 - v1 09/16] FIX: Regions must be aligned with erase size

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 35 ++ testsuites/libtests/flashdev01/init.c | 66 --- 2 files changed, 95 insertions(+), 6 deletions(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index

[PATCH rtems6 - v1 04/16] Flashdev: Align IOCTL and shell function names

From: Bernd Moessner --- cpukit/libmisc/shell/main_flashdev.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/cpukit/libmisc/shell/main_flashdev.c b/cpukit/libmisc/shell/main_flashdev.c index 969b0687d2..516c77ae27 100644 ---

[PATCH rtems6 - v1 08/16] Flashdev: Add IOCTL to get the erase size

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 24 +++ cpukit/include/dev/flash/flashdev.h | 21 + cpukit/libmisc/shell/main_flashdev.c | 28 + testsuites/libtests/flashdev01/init.c | 14 ++---

[PATCH rtems6 - v1 07/16] Flashdev: Refactor write_block_size and add function to dergister flashdev

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 71 -- cpukit/include/dev/flash/flashdev.h | 22 +- cpukit/libmisc/shell/main_flashdev.c | 26 +-- testsuites/libtests/flashdev01/init.c | 204 --

[PATCH rtems6 - v1 06/16] Flashdev: Make mutex name more generic

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index 8bd3d11246..0020e8d2c1 100644 --- a/cpukit/dev/flash/flashdev.c +++ b/cpukit/dev/flash/flashdev.c @@ -34,6

[PATCH rtems6 - v1 05/16] FIX: Add missing default case

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c index 27edead968..8bd3d11246 100644 --- a/cpukit/dev/flash/flashdev.c +++ b/cpukit/dev/flash/flashdev.c @@ -390,6 +390,8 @@ static

[PATCH rtems6 - v1 03/16] Flashdev: Align IOCTL function and macro names

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 72 +-- cpukit/include/dev/flash/flashdev.h | 12 ++-- .../libtests/flashdev01/test_flashdev.c | 36 +- 3 files changed, 60 insertions(+), 60 deletions(-) diff --git

[PATCH rtems6 - v1 02/16] Flashdev: Unify IOCTL macro names

From: Bernd Moessner --- cpukit/dev/flash/flashdev.c | 16 cpukit/include/dev/flash/flashdev.h | 16 cpukit/libmisc/shell/main_flashdev.c | 12 ++-- testsuites/libtests/flashdev01/init.c | 16 4 files changed, 30

[PATCH rtems6 - v1 01/16] FIX: Add missing C++ include guards

From: Bernd Moessner --- cpukit/include/dev/flash/flashdev.h | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/include/dev/flash/flashdev.h b/cpukit/include/dev/flash/flashdev.h index d1dc08a5c4..6759357206 100644 --- a/cpukit/include/dev/flash/flashdev.h +++

[PATCH rtems6 - v1 00/16] Overwork flashdev - V1

From: Bernd Moessner Dear all, as outlined in https://devel.rtems.org/ticket/4981 I`d like to overwork the flashdev API. The provided patch series should at least serve as a fundament for the discussion. It includes more, but h: 1) Bugfixes 1.1) missing c++ include guards 1.2) missing