Re: [PATCH rtems] Include support files also for Zynq7000

2024-01-08 Thread Chris Johns
I consider it is a mistake to commit this patch. We have no idea who or where this is being used by users. Chris On 6/1/2024 4:56 am, Bernd Moessner wrote: > > On 05.01.2024 18:54, Kinsey Moore wrote: >> I assume this is to support the Zynq7000 under rtems-lwip since it would need >> those

[PATCH] cpukit/dosfs: Remove unused internal function arg

2024-01-08 Thread Kinsey Moore
--- cpukit/libfs/src/dosfs/msdos_misc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpukit/libfs/src/dosfs/msdos_misc.c b/cpukit/libfs/src/dosfs/msdos_misc.c index c40988b98f..cd59c494ea 100644 --- a/cpukit/libfs/src/dosfs/msdos_misc.c +++ b/cpukit/libfs/src/dosfs/msdos_misc.c @@

[PATCH] cpukit: Remove or use unused variable assignments

2024-01-08 Thread Kinsey Moore
--- cpukit/libblock/src/media.c | 2 +- cpukit/libfs/src/dosfs/fat.c | 2 +- cpukit/libfs/src/dosfs/msdos_file.c | 5 + cpukit/libfs/src/dosfs/msdos_misc.c | 3 ++- cpukit/libfs/src/imfs/imfs_memfile.c | 1 - cpukit/posix/src/killinfo.c | 1 - 6 files changed, 9

Re: [PATCH rtems6 - v1 06/16] Flashdev: Make mutex name more generic

2024-01-08 Thread Kinsey Moore
On Mon, Jan 8, 2024 at 7:13 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 04.01.24 19:34, berndmoessne...@gmail.com wrote: > > @@ -490,7 +491,9 @@ static int rtems_flashdev_do_init( > > void ( *destroy )( rtems_flashdev *flash ) > > ) > > { > > -

Re: [PATCH rtems6 1/1] xparameters.h: fix typo in comment

2024-01-08 Thread Will
Looks good to me. There is generally no need for a 0/X email when X is small unless you think it is necessary. In this case, a message of "see patch" isn't very useful. Kinsey On Sun, Jan 7, 2024 at 12:27 PM wrote: > From: Bernd Moessner > > --- > bsps/include/xil/xparameters.h | 2 +- > 1

Re: [PATCH rtems-lwip 1/1] Add ZYNQ 7000 support

2024-01-08 Thread Kinsey Moore
A few comments inline below. For the most part, this looks good. On Sat, Jan 6, 2024 at 9:15 AM wrote: > From: Bernd Moessner > > This patch adds support for the Xilinx ZYNQ 7000 series. Please note that > this patch also affects ZYNQ Ultrascale+ as I`ve moved some functions from >

Re: CentOS 8 - no python

2024-01-08 Thread Joel Sherrill
On Mon, Jan 8, 2024 at 10:13 AM Frank Kühndel < frank.kuehn...@embedded-brains.de> wrote: > Hi Joel, > > have a great 2024! > > On 12/24/23 22:16, Joel Sherrill wrote: > > Hi > > > > Trying to bring up Coverity builds on a Centos 8 machine, I ran into > this: > > > > +

Re: CentOS 8 - no python

2024-01-08 Thread Frank Kühndel
Hi Joel, have a great 2024! On 12/24/23 22:16, Joel Sherrill wrote: > Hi > > Trying to bring up Coverity builds on a Centos 8 machine, I ran into this: > > + ../source-builder/sb-set-builder --log=l-sparc.txt > --prefix=/home/joel/rtems-cron-coverity/tools/6 --mail --mail-to= >

Re: [PATCH rtems6 - v1 06/16] Flashdev: Make mutex name more generic

2024-01-08 Thread Sebastian Huber
On 04.01.24 19:34, berndmoessne...@gmail.com wrote: @@ -490,7 +491,9 @@ static int rtems_flashdev_do_init( void ( *destroy )( rtems_flashdev *flash ) ) { - rtems_recursive_mutex_init( >mutex, "RTEMS_FLASHDEV Flash" ); + char mtx_name[19]; + sprintf(mtx_name, "FDEV_MTX_%08x", (unsigned

Re: [PATCH 24/47] bsp/tms570: Remove double pin configuration

2024-01-08 Thread Sebastian Huber
Hello Pavel, On 21.12.23 16:13, Pavel Pisa wrote: On Thursday 21 of December 2023 15:37:57 Sebastian Huber wrote: From: Tyler Miller --- bsps/arm/tms570/start/pinmux.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/bsps/arm/tms570/start/pinmux.c