Re: libbsd zynqmp cpu freq for slcr calc

2021-10-14 Thread Chris Johns
On 15/10/21 5:33 am, Kinsey Moore wrote: > On 10/14/2021 10:18, Joel Sherrill wrote: >> On Thu, Oct 14, 2021 at 9:56 AM Kinsey Moore >> wrote: >>> On 10/14/2021 01:40, Chris Johns wrote: >>>> Hi, >>>> >>>> I have

libbsd zynqmp cpu freq for slcr calc

2021-10-14 Thread Chris Johns
Hi, I have come across this define in zynqmp_slcr.h: #define ZYNQMP_DEFAULT_PS_CLK_FREQUENCY What if the cpu freq is changed by a user? If this value still valid? The CPU frequency is under the control system designer in these parts. Chris

Re: [PATCH v1] rtems-binutils: Update to 2.37 and update head

2021-10-13 Thread Chris Johns
On 14/10/21 3:20 am, Ryan Long wrote: > Update to binutils 2.37 for RTEMS 6 to fix an issue when building tests > for AArch64. Also updated the commit and hash for binutils in > rtems-binutils-head. What is the issue? Is there a ticket or something that explains what has been fixed? Chris

Re: [PATCH rtems-tools v1] TraceConverter.cc: Add catch for exception

2021-10-12 Thread Chris Johns
The change is fine. The comment is about another possible change. Thanks Chris On 13/10/21 5:22 am, Ryan Long wrote: > CID 1471639: Add catch for exception > > Closes #4501 > --- > tester/covoar/TraceConverter.cc | 45 > ++--- > 1 file changed, 29

Re: [PATCH] rtems-kernel: Implement kernel recipe using waf

2021-10-12 Thread Chris Johns
On 12/10/21 11:59 pm, Ryan Long wrote: -Original Message- > From: Chris Johns > Sent: Friday, October 8, 2021 6:44 PM > To: Ryan Long ; devel@rtems.org > Subject: Re: [PATCH] rtems-kernel: Implement kernel recipe using waf > > Hi Ryan, > > Thank you for taki

Re: Scope of variables flagged by code inspector

2021-10-11 Thread Chris Johns
On 11/10/21 10:14 pm, Sebastian Huber wrote: > Hello Zack, > > On 10/10/2021 20:25, zack leung wrote: >> I recently was invited to look at a new code review tool by Joel. It's used >> to help with reducing technical debt. It suggests various fixes and >> highlights various possible errors. One of

Re: [PATCH] rtems-kernel: Implement kernel recipe using waf

2021-10-08 Thread Chris Johns
On 9/10/21 10:49 am, Joel Sherrill wrote: > On Fri, Oct 8, 2021, 6:44 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > Hi Ryan, > > Thank you for taking this on. > > I would like see one addition, a user supplied config.ini file that > bypasse

Re: [PATCH] rtems-kernel: Implement kernel recipe using waf

2021-10-08 Thread Chris Johns
Hi Ryan, Thank you for taking this on. I would like see one addition, a user supplied config.ini file that bypasses any generated config file. The config needs to match the tool chain being built and waf will need to complain if it does not but that is not a problem for the RSB to manage. On

Re: [PATCH rtems-tools v1] rtems-tld.cpp: Remove logically dead code

2021-10-08 Thread Chris Johns
OK to push. On 9/10/21 5:45 am, Ryan Long wrote: > CID 1399595: Logically dead code in generate_traces(). > > Closes #4525 > --- > linkers/rtems-tld.cpp | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/linkers/rtems-tld.cpp b/linkers/rtems-tld.cpp > index

Re: [PATCH rtems-tools v1 0/2] Uncaught exception patches

2021-10-07 Thread Chris Johns
OK for both On 8/10/21 12:40 am, Ryan Long wrote: > Hi, > > These patches fix the "Uncaught exception" Coverity issues. To fix this, > I just added a try and catch for the exception that Coverity identified. > > Thanks, > Ryan > > Ryan Long (2): > TraceConverter.cc: Add catch for exception >

Re: [PATCH rtems-libbsd 2/2] rtemsbsd/atomic: Return a value for CMPSET

2021-10-07 Thread Chris Johns
OK On 8/10/21 7:43 am, Kinsey Moore wrote: > When the cmpset and fcmpset functions were refactored, the return value > of the operation was discarded instead of being returned for SMP builds > outside of gcc 4.x. This had the effect of turning these functions into > a long busywait loop that

Re: [PATCH rtems-libbsd 1/2] waf_libbsd: Fix typo in previous patch

2021-10-07 Thread Chris Johns
OK On 8/10/21 7:43 am, Kinsey Moore wrote: > There was a typo in the patch that added the HAVE_ definition > that prevented "./waf configure" from succeeding. This adds the missing > character. > --- > waf_libbsd.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] bsp/imx: Add cs_change support to SPI

2021-10-06 Thread Chris Johns
I think you or Sebastian are the imx maintainers so please push when you wish. :) Thanks Chris On 1/10/21 4:31 pm, Christian Mauderer wrote: > --- > bsps/arm/imx/spi/imx-ecspi.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/bsps/arm/imx/spi/imx-ecspi.c

Re: [PATCH rtems-libbsd] waf_libbsd: Account for library check results

2021-10-05 Thread Chris Johns
hi Kinsey, This change looks OK to me. Nice work. Thanks Chris On 6/10/21 7:55 am, Kinsey Moore wrote: > Conditionally compiled tests (consisting only of debugger01) were not > compiling as expected when libdebugger was present. This appears to have > occurred during the transition from header

Re: libbsd: Conditional compilation of tests

2021-10-05 Thread Chris Johns
On 5/10/21 10:27 am, Kinsey Moore wrote: > Currently debugger01 is the only user of the test-if-library in libbsd and it > doesn't seem to work as expected. The configure step that detects libdebugger > occurs and succeeds as it should for the zynq a9 qemu BSP, but debugger01.exe > never gets

Re: [PATCH v2 5/6] cpukit: Add signal mapping support

2021-10-04 Thread Chris Johns
On 5/10/21 4:29 am, Sebastian Huber wrote: > On 02/10/2021 01:44, Chris Johns wrote: >>> The fatal extensions have a well defined order (position in the >>> table). The user has the full control over the initial extensions table. >> Is it backwards compatible wh

Re: waf bsp_defaults appears to be broken

2021-10-04 Thread Chris Johns
On 4/10/21 3:06 am, Joel Sherrill wrote: > No BSP was successfully built in the build sweep Friday. All have > failures like this: > > $ ./waf bsp_defaults --rtems-bsps=powerpc/psim > There is no top-level group with UID '/grp' in the specification > > The script fetches the BSP's defaults and

Re: [PATCH 0/3] Add MicroBlaze port and BSP

2021-10-01 Thread Chris Johns
On 1/10/21 3:43 pm, Alex White wrote: > This patch set adds support for the MicroBlaze architecture along with > a basic BSP based on Xilinx's KCU105 PetaLinux BSP configuration. > > The initial architecture port was started 6 or 7 years ago, I believe. > To make authorship clear and preserve

Re: [PATCH 3/3] microblaze: Rework for RTEMS 6

2021-10-01 Thread Chris Johns
On 1/10/21 3:43 pm, Alex White wrote: > bsps/microblaze/include/common/xil_types.h| 197 +++ > bsps/microblaze/include/dev/serial/uartlite.h | 62 + > .../include/dev/serial/uartlite_l.h | 323 + > bsps/microblaze/shared/dev/serial/uartlite.c | 145 ++ >

Re: [PATCH rtems-docs] eng: Add rules for attribution

2021-10-01 Thread Chris Johns
On 30/9/21 4:55 pm, Christian MAUDERER wrote: > Am 30.09.21 um 02:23 schrieb Chris Johns: >> On 29/9/21 6:38 pm, Christian MAUDERER wrote: >>> Am 29.09.21 um 02:40 schrieb Chris Johns: >>>> On 28/9/21 11:11 pm, Christian MAUDERER wrote: >>>>> Hello J

Re: [PATCH rtems-docs] eng: Add rules for attribution

2021-10-01 Thread Chris Johns
On 30/9/21 5:33 pm, Thomas DOERFLER wrote: > Am 30.09.21 um 02:23 schrieb Chris Johns: >> On 29/9/21 6:38 pm, Christian MAUDERER wrote: >>> >>> To be honest: If sponsored work is a legal problem, we have that with or >>> without >>> a note in

Re: [PATCH v2 5/6] cpukit: Add signal mapping support

2021-10-01 Thread Chris Johns
On 1/10/21 11:33 pm, Sebastian Huber wrote: > The fatal extensions have a well defined order (position in the > table). The user has the full control over the initial extensions table. Is it backwards compatible when this new mode is enabled? Chris ___

Re: [PATCH rtems-docs] eng: Add rules for attribution

2021-09-29 Thread Chris Johns
On 29/9/21 6:38 pm, Christian MAUDERER wrote: > Am 29.09.21 um 02:40 schrieb Chris Johns: >> On 28/9/21 11:11 pm, Christian MAUDERER wrote: >>> Hello Joel, >>> >>> Am 28.09.21 um 14:48 schrieb Joel Sherrill: >>>> >>&g

Re: [PATCH] rtems: Adjust parameter names

2021-09-29 Thread Chris Johns
On 30/9/21 6:30 am, Joel Sherrill wrote: > On Wed, Sep 29, 2021, 3:24 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > Is it worth mentioning in the commit message the reserved nature of time > is the > reason for the change? > > > Do you mean

Re: [PATCH] rtems: Adjust parameter names

2021-09-29 Thread Chris Johns
Is it worth mentioning in the commit message the reserved nature of time is the reason for the change? Otherwise OK. On 30/9/21 12:10 am, Sebastian Huber wrote: > Adjust parameter names to match with the declaration. > > Close #4035. > --- > cpukit/rtems/src/clockgettod.c| 20

Re: [PATCH] rtems: Justify integer conversions

2021-09-29 Thread Chris Johns
OK On 29/9/21 11:24 pm, Sebastian Huber wrote: > Close #2548. > --- > cpukit/rtems/src/clockgettod.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/cpukit/rtems/src/clockgettod.c b/cpukit/rtems/src/clockgettod.c > index 5058b42375..01daa3dc15 100644 > ---

Re: [PATCH] glossary: Add terms

2021-09-29 Thread Chris Johns
OK On 29/9/21 8:45 pm, Sebastian Huber wrote: > --- > c-user/glossary.rst | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/c-user/glossary.rst b/c-user/glossary.rst > index f85c08c..e91e356 100644 > --- a/c-user/glossary.rst > +++ b/c-user/glossary.rst >

Re: [PATCH rtems-docs] eng: Add rules for attribution

2021-09-28 Thread Chris Johns
On 28/9/21 11:11 pm, Christian MAUDERER wrote: > Hello Joel, > > Am 28.09.21 um 14:48 schrieb Joel Sherrill: >> >> >> On Tue, Sep 28, 2021, 1:40 AM Christian MAUDERER >> > > wrote: >> >>     Hello Joel, >> >>     Am 28.09.21 um 01:12 schrieb Joel

Re: [PATCH rtems-tools v2] rtems-bin2c.c: Check length of buffer to be copied

2021-09-28 Thread Chris Johns
Looks good. Thanks. On 29/9/21 1:18 am, Ryan Long wrote: > CID 1063892: Copy into fixed size buffer in process(). > > Closes #4424 > --- > misc/bin2c/rtems-bin2c.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/misc/bin2c/rtems-bin2c.c b/misc/bin2c/rtems-bin2c.c >

Re: [PATCH rtems-tools v3 0/7] Convert and reformat pt.3

2021-09-27 Thread Chris Johns
OK Thanks Chris On 27/9/21 10:49 pm, Ryan Long wrote: > Hi, > > For this series of patches, I > > - Removed #define for size of the discardBuff > - Fixed code preventing patchset from building > > Thanks, > Ryan > > Ryan Long (7): > CoverageRanges.cc: Fix formatting > TraceReader:

Re: [PATCH rtems-tools] rtems-bin2c.c: Check length of buffer to be copied

2021-09-27 Thread Chris Johns
On 28/9/21 7:28 am, Ryan Long wrote: > CID 1063892: Copy into fixed size buffer in process(). > > Closes #4424 > --- > misc/bin2c/rtems-bin2c.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/misc/bin2c/rtems-bin2c.c b/misc/bin2c/rtems-bin2c.c > index 8e32d25..1668063 100644

Re: [PATCHES] Fix PPP in libbsd and optimize ATSAM console

2021-09-27 Thread Chris Johns
On 27/9/21 6:24 pm, Christian MAUDERER wrote: > same like for another patch set: There is a pending discussion for this one. Yeap and so we need to resolve it. I have reordered your original post so the chat follows. I hope that is OK? > Is there still an open point left of can I push the

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-09-27 Thread Chris Johns
the right time to re-start the > discussion. > > Am 21.07.21 um 08:58 schrieb Chris Johns: >> On 21/7/21 3:51 pm, Sebastian Huber wrote: >>> On 21/07/2021 02:46, Chris Johns wrote: >>>> I think we need some guidelines. I do not agree with URL links, email >&g

Re: [PATCH v2] eng: Add register block specification types

2021-09-26 Thread Chris Johns
On 24/9/21 11:09 pm, Sebastian Huber wrote: > A register block may be used to specify the interface of devices which > use a linear address space. Register blocks consist of register block Can we please move away from the "linear address" in the definitions? As stated previously it only serves a

Re: [PATCH rtems-tools v2 2/7] TraceReader: Convert to C++

2021-09-23 Thread Chris Johns
On 24/9/21 7:26 am, Ryan Long wrote: > -bool ReadUntilFound( FILE *file, const char *line ) > +bool ReadUntilFound( std::ifstream& file, const char* line ) > { > - char discardBuff[100]; > - size_t len = strlen( line ); > + #define BUFFER_LENGTH There is no value? > + char

Re: [PATCH rtems-tools v2 5/7] TraceWriterQEMU.cc: Fix formatting

2021-09-23 Thread Chris Johns
On 24/9/21 7:27 am, Ryan Long wrote: > --- > tester/covoar/TraceWriterQEMU.cc | 47 > +--- > 1 file changed, 29 insertions(+), 18 deletions(-) > > diff --git a/tester/covoar/TraceWriterQEMU.cc > b/tester/covoar/TraceWriterQEMU.cc > index d14260f..1f0e719

Re: [PATCH rtems-tools v2 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-23 Thread Chris Johns
On 24/9/21 7:26 am, Ryan Long wrote: > --- > tester/covoar/TraceReaderLogQEMU.cc | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/tester/covoar/TraceReaderLogQEMU.cc > b/tester/covoar/TraceReaderLogQEMU.cc > index 7f72168..b1c52a9 100644 > ---

Re: [PATCH rtems-libbsd] rtemsbsd/syscalls: Remove pipe()

2021-09-23 Thread Chris Johns
On 23/9/21 7:02 pm, Sebastian Huber wrote: > On 23/09/2021 10:44, Chris Johns wrote: >> On 23/9/21 4:29 pm, Sebastian Huber wrote: >>> On 23/09/2021 07:43,chr...@rtems.org  wrote: >>>> From: Chris Johns >>>> >>>> - This call is provided

Re: [PATCH rtems-libbsd] rtemsbsd/syscalls: Remove pipe()

2021-09-23 Thread Chris Johns
On 23/9/21 4:29 pm, Sebastian Huber wrote: > On 23/09/2021 07:43, chr...@rtems.org wrote: >> From: Chris Johns >> >> - This call is provided by RTEMS and that is preferred >> >> Closes #4518 > > This removes the kqueue() support for pipe(). It does bu

Re: [PATCH v2 5/6] cpukit: Add signal mapping support

2021-09-22 Thread Chris Johns
On 23/9/21 10:16 am, Kinsey Moore wrote: > This adds a confdef option allowing an application to request mapping > machine exceptions to POSIX signals. This is required for some languages > such as Ada.> --- a/cpukit/include/rtems/confdefs/extensions.h > +++

Re: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-22 Thread Chris Johns
On 23/9/21 12:35 am, Ryan Long wrote: > I changed the definition of discardBuff to > > char discardBuff[100]{}; char discardBuff[100] = {}; ? > So that every element will be initialized to \0. This function is only used > in TraceReaderLogQEMU.cc, and the values that are passed in are > >

Re: [PATCH rtems-tools v1 5/7] TraceWriterQEMU.cc: Fix formatting

2021-09-21 Thread Chris Johns
On 22/9/21 2:45 am, Ryan Long wrote: > --- > tester/covoar/TraceWriterQEMU.cc | 48 > ++-- > 1 file changed, 27 insertions(+), 21 deletions(-) > > diff --git a/tester/covoar/TraceWriterQEMU.cc > b/tester/covoar/TraceWriterQEMU.cc > index 577acab..6f88b3d

Re: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-21 Thread Chris Johns
On 22/9/21 2:45 am, Ryan Long wrote: > --- > tester/covoar/TraceReaderLogQEMU.cc | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/tester/covoar/TraceReaderLogQEMU.cc > b/tester/covoar/TraceReaderLogQEMU.cc > index c303d08..91ed5c7 100644 > ---

Re: [PATCH rtems-docs] posix.rst: Add info for FreeBSD 13

2021-09-21 Thread Chris Johns
On 22/9/21 4:05 am, Ryan Long wrote: > Add list of additional packages needed to build RTEMS environment for > FreeBSD 13. > --- > user/hosts/posix.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/user/hosts/posix.rst b/user/hosts/posix.rst > index 6686fc9..284df48 100644

Re: Remove old build system

2021-09-21 Thread Chris Johns
On 21/9/21 6:32 pm, Sebastian Huber wrote: > So after about two years of development, there is now only the new build > system > in place. Congratulations and thank you for all the hard work it took to make this happen. It is a pleasure to use, I know I have been testing RTEMS 5 patches this

Re: [PATCH] bsp-builder: Fix mailer options exception

2021-09-20 Thread Chris Johns
Hi Alex, I prefer Python’s argparse and prefer we move the other way. The options handling originally came from the RSB and has lots of issues. I regret it. Sorry about this. Chris > On 21 Sep 2021, at 2:08 am, Alex White wrote: > > This changes the object holding the command line

Re: [PATCH] libcsupport/mount: Return the error correctly

2021-09-19 Thread Chris Johns
I think this patch is wrong. The IMFS mount tests fail. It looks like the NFS mount in LibBSD is wrong. I will look at a fix there. On 18/9/21 3:18 pm, chr...@rtems.org wrote: > From: Chris Johns > > Closes #4507 > --- > cpukit/libcsupport/src/mount.c | 2 ++ > 1 file cha

Re: RFC: Use same gdb on RTEMS 5 as RTEMS 6

2021-09-19 Thread Chris Johns
On 20/9/21 2:51 am, Joel Sherrill wrote: > Hi > > The gdb version (9.x) we are using for RTEMS 5 tools does not build > on Cygwin and hasn't for a while. > > https://sourceware.org/bugzilla/show_bug.cgi?id=26757 > > I looked at bumping minor revisions in the gdb 9 series but they still > don't

Re: RSB

2021-09-16 Thread Chris Johns
On 17/9/21 9:54 am, Joel Sherrill wrote: > On Thu, Sep 16, 2021, 6:36 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 16/9/21 10:59 pm, Joel Sherrill wrote: > > On Wed, Sep 15, 2021 at 7:08 PM Chris Johns <mailto:chr...@rtems.org>> wrote:

Re: [PATCH v4] improve the format of error reporting on i386

2021-09-16 Thread Chris Johns
On 17/9/21 12:56 am, Gedare Bloom wrote: > Although we are not currently filtering HTML on this mailing list I turned it on for this list. Is it not working? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: RSB

2021-09-16 Thread Chris Johns
On 16/9/21 10:59 pm, Joel Sherrill wrote: > On Wed, Sep 15, 2021 at 7:08 PM Chris Johns wrote: >> On 16/9/21 1:46 am, Joel Sherrill wrote: >>> On Tue, Sep 14, 2021 at 5:52 PM Chris Johns wrote: >>>> On 15/9/21 4:49 am, Joel Sherrill wrote: >>> The issue I

Re: [PATCH] eng: Add register block specification types

2021-09-16 Thread Chris Johns
On 16/9/21 3:54 pm, Sebastian Huber wrote: > Ok, so your real problem is that I wrote "bytes" in the description of the > register-block-size and offset attributes? I have listed a number of concerns, this is just an example of one. I suggest we get together and work through each statement. It

Re: RSB

2021-09-15 Thread Chris Johns
On 16/9/21 1:46 am, Joel Sherrill wrote: > On Tue, Sep 14, 2021 at 5:52 PM Chris Johns wrote: >> >> On 15/9/21 4:49 am, Joel Sherrill wrote: >>> On Mon, Sep 13, 2021, 7:02 PM Joel Sherrill >> <mailto:j...@rtems.org>> wrote: >>> On Mon, Sep 13

Re: [PATCH] eng: Add register block specification types

2021-09-15 Thread Chris Johns
On 15/9/21 3:33 pm, Sebastian Huber wrote: > On 15/09/2021 00:48, Chris Johns wrote: >> On 14/9/21 8:08 pm, Sebastian Huber wrote: >>> On 10/09/2021 16:41, Sebastian Huber wrote: >>>> A register block may be used to specify the memory-mapped interface to >>>&

Re: RSB

2021-09-14 Thread Chris Johns
On 15/9/21 4:49 am, Joel Sherrill wrote: > On Mon, Sep 13, 2021, 7:02 PM Joel Sherrill <mailto:j...@rtems.org>> wrote: > On Mon, Sep 13, 2021 at 6:54 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 13/9/21 11:20 pm, Joe

Re: [PATCH] eng: Add register block specification types

2021-09-14 Thread Chris Johns
On 14/9/21 8:08 pm, Sebastian Huber wrote: > On 10/09/2021 16:41, Sebastian Huber wrote: >> A register block may be used to specify the memory-mapped interface to >> the hardware.  Register blocks consist of register block members. >> Register block members are either instances of registers or

Re: [PATCH rtems-tools] check.py: Fix incorrect use of os.linesep

2021-09-14 Thread Chris Johns
OK and thanks Chris On 15/9/21 1:29 am, Ryan Long wrote: > Replaced a couple of calls to os.linesep() with os.linesep because > os.linesep() does not exist. > --- > tester/rt/check.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tester/rt/check.py

Re: [PATCH] c-user: Add "Cache Manager" chapter

2021-09-14 Thread Chris Johns
On 14/9/21 3:57 pm, Sebastian Huber wrote: > On 10/09/2021 10:49, Sebastian Huber wrote: >> The Cache Manager directives are available via .  Document most >> of them in the Classic API Guide. >> >> Not documented are the following directive since the API is not yet >> stable: >> >> *

Re: RSB

2021-09-13 Thread Chris Johns
On 13/9/21 11:20 pm, Joel Sherrill wrote: > Hi > > If building a bset tar file, does it matter if the installation prefix > is writable? > > ../source-builder/sb-set-builder --bset-tar-file --log=l-i386.txt > --prefix=/rtems/tools 5/rtems-i386 > RTEMS Source Builder - Set Builder, 5

Re: [PATCH] eng: Add register block specification types

2021-09-13 Thread Chris Johns
On 13/9/21 4:38 pm, Sebastian Huber wrote: > This approach is not limited to memory mapped register blocks. I think it is. I would like to understand how bus types other than "memory" are specified for a generic device driver that needs to handle bus variability. I am concerned this is bespoke

Re: [PATCH] eng: Add register block specification types

2021-09-11 Thread Chris Johns
On 11/9/21 12:41 am, Sebastian Huber wrote: > A register block may be used to specify the memory-mapped interface to > the hardware. Register blocks consist of register block members. > Register block members are either instances of registers or instances of > other register blocks. Registers

Re: [PATCH rtems-tools v2 00/10] Convert and reformat pt. 2

2021-09-10 Thread Chris Johns
Ok to push. Thanks On 11/9/21 4:03 am, Ryan Long wrote: > Hi, > > For these patches I > > - Changed the data type of bytes_before so that it builds with clang > - Replaced instances of "\n" with std::endl > - Changed .c_str() argument to just a string > > Thanks, > Ryan > > Ryan Long (10): >

Re: [PATCH] rtems: Generate

2021-09-10 Thread Chris Johns
Nice set of changes. My comments are below On 10/9/21 6:11 pm, Sebastian Huber wrote: > Remove the duplicated description which is an out dated copy and paste > from the Classic API Guide. Instead, thoroughly document the individual > extensions. > > Change license to BSD-2-Clause

Re: [PATCH rtems-tools v1 02/10] covoar.cc: Convert to C++

2021-09-09 Thread Chris Johns
On 10/9/21 12:17 am, Ryan Long wrote: > ExecutableInfo takes a const char* const parameter and initializes a string. > I tried to take off the c_str(), but it wouldn't build then. Is it alright > for that to temporarily stay there until I make a sweep through > ExecutableInfo.cc? Or do you want

Re: [PATCH v1 3/5] cpukit/aarch64: Add Exception Manager support

2021-09-08 Thread Chris Johns
On 2/9/21 3:36 am, Kinsey Moore wrote: > On 9/1/2021 10:58, Sebastian Huber wrote: >> On 01/09/2021 17:48, Sebastian Huber wrote: >>> So, my proposal would be something like this: >>> >>> 1. Processor jumps to exception prologue >>> >>> 2. Exception prologue saves the context to CPU exception

Re: [PATCH rtems-tools v1 05/10] CoverageWriterRTEMS.cc: Fix formatting

2021-09-08 Thread Chris Johns
On 9/9/21 2:44 am, Ryan Long wrote: > --- > tester/covoar/CoverageWriterRTEMS.cc | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/tester/covoar/CoverageWriterRTEMS.cc > b/tester/covoar/CoverageWriterRTEMS.cc > index 3332cd4..d6c6ca3 100644 > ---

Re: [PATCH rtems-tools v1 02/10] covoar.cc: Convert to C++

2021-09-08 Thread Chris Johns
On 9/9/21 2:44 am, Ryan Long wrote: > Got rid of C-strings, changed FILE pointer to ifstream. > --- > tester/covoar/covoar.cc | 52 > +++-- > 1 file changed, 24 insertions(+), 28 deletions(-) > > diff --git a/tester/covoar/covoar.cc

Re: [PATCH rtems-tools v1 01/10] CoverageWriter: Convert to C++

2021-09-08 Thread Chris Johns
On 9/9/21 2:44 am, Ryan Long wrote: > --- > tester/covoar/CoverageWriterBase.h| 4 +++- > tester/covoar/CoverageWriterRTEMS.cc | 26 +++--- > tester/covoar/CoverageWriterRTEMS.h | 4 +++- > tester/covoar/CoverageWriterSkyeye.cc | 33

Re: [PATCH] tester/zynqmp: Simpify the reasons to reset

2021-09-08 Thread Chris Johns
On 8/9/21 11:09 pm, Kinsey Moore wrote: > Comment below. > > On 9/6/2021 23:38, chr...@rtems.org wrote: >> From: Chris Johns >> >> - Only reset if the bootloader error is hardware related. >> --- >>   tester/rtems/testing/bsps/xilinx_zynqmp_ilp32_zu3eg.in

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-07 Thread Chris Johns
On 7/9/21 3:34 pm, Sebastian Huber wrote: > On 07/09/2021 05:11, Chris Johns wrote: >> On 6/9/21 6:11 pm, Sebastian Huber wrote: >>> On 06/09/2021 09:55, Chris Johns wrote: >>>> On 6/9/21 3:49 pm, Sebastian Huber wrote: >>>>> On 04/09/2021 06:20,

Re: Does the arm/xilinx-zynqmp BSP work?

2021-09-07 Thread Chris Johns
On 8/9/21 4:43 am, Kinsey Moore wrote: > This bit of information also applies to the aarch64/xilinx-zynqmp BSP, but > starting recommendation for that is to use the prebuilt u-boot BOOT.bin which > includes the ATF bl31 binary and so it isn't critical knowledge for getting > started. Thank you

Re: [PATCH RSB v2 2/2] rtems-gcc-head-newlib-head.cfg: Add newlib patch

2021-09-07 Thread Chris Johns
On 8/9/21 4:08 am, Gedare Bloom wrote: > Has this issue been raised with newlib? I didn't see anything on their > ml. The temporary workaround is fine with me. I would like to understand how temporary this will be. Chris ___ devel mailing list

Re: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

2021-09-07 Thread Chris Johns
On 8/9/21 3:27 am, Joel Sherrill wrote: > On Tue, Sep 7, 2021, 12:18 PM Mr. Andrei Chichak > wrote: > > Hey Joel, > > I don’t suppose this update will be in the places where the build system > decides on the instruction set that newlib uses for

Re: [PATCH] testsuites: Wrap putchar

2021-09-06 Thread Chris Johns
On 7/9/21 3:34 pm, Sebastian Huber wrote: > On 07/09/2021 05:16, Alex White wrote: >> The linker flag to wrap putchar was lost in translation from make to waf. > > Looks good. Agreed. I have just been testing it on a zynqmp. Chris ___ devel mailing

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-06 Thread Chris Johns
On 6/9/21 6:11 pm, Sebastian Huber wrote: > On 06/09/2021 09:55, Chris Johns wrote: >> On 6/9/21 3:49 pm, Sebastian Huber wrote: >>> On 04/09/2021 06:20, Joel Sherrill wrote: >>>>   > -    sc = _TOD_Validate(_tod, TOD_ENABLE_TICKS_VALIDATION); >>

Re: [PATCH 1/2] tester: Count tester header errors

2021-09-06 Thread Chris Johns
On 7/9/21 7:34 am, Kinsey Moore wrote: > These two patches look good with one minor nit below. Thanks update and post a v2 with a bunch of fixes soon. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-06 Thread Chris Johns
On 6/9/21 3:49 pm, Sebastian Huber wrote: > On 04/09/2021 06:20, Joel Sherrill wrote: >> > -    sc = _TOD_Validate(_tod, TOD_ENABLE_TICKS_VALIDATION); >> > +    sc = _TOD_Validate(_tod); >> >>     This has leaked out of the internal implementation interface. Should it? >> >>     I prefer

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-03 Thread Chris Johns
On 4/9/21 2:20 pm, Joel Sherrill wrote: On Fri, Sep 3, 2021, 11:01 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 3/9/21 11:33 pm, Sebastian Huber wrote: > > The behaviour with respect to the handling of the ticks member in the > *_when() > &g

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-03 Thread Chris Johns
On 3/9/21 11:33 pm, Sebastian Huber wrote: > diff --git a/bsps/arm/altera-cyclone-v/rtc/rtc.c > b/bsps/arm/altera-cyclone-v/rtc/rtc.c > index 779a093459..d1c12ee874 100644 > --- a/bsps/arm/altera-cyclone-v/rtc/rtc.c > +++ b/bsps/arm/altera-cyclone-v/rtc/rtc.c > @@ -353,7 +353,7 @@ static int

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-03 Thread Chris Johns
On 3/9/21 11:33 pm, Sebastian Huber wrote: > The behaviour with respect to the handling of the ticks member in the *_when() > directives was inconsistent. In all *_when() directives the ticks member is > not used to calculate the watchdog expiration time. However, the > rtems_task_wake_when()

Does the arm/xilinx-zynqmp BSP work?

2021-09-03 Thread Chris Johns
Hi, I am testing the console driver with the aarch64/xilinx_zynqmp_lp64_zu3eg BSP when I saw the BSP. Is this BSP still valid? Does this BSP work on real hardware? Who is looking after this BSP? Chris ___ devel mailing list devel@rtems.org

Re: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

2021-09-03 Thread Chris Johns
Can we please join onto this an rtems-tools update so the recent fixes I pushed can be picked up? Thanks Chris On 4/9/21 2:40 am, Joel Sherrill wrote: > You also should add the patch in the gcc-head-newlib-head > configuration as well for rtems7 tools. > > --joel > > On Fri, Sep 3, 2021 at

Re: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1

2021-09-03 Thread Chris Johns
On 3/9/21 10:07 pm, Ryan Long wrote: > I haven't been building these with clang, so I'll make sure to start doing > that. I've got a Macbook, so I can test it on there as well. This great and thanks. I am amazed how each compiler and version of that compiler generates new issues. On the positive

Re: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1

2021-09-02 Thread Chris Johns
On 3/9/21 5:24 am, Ryan Long wrote: > For this and the following series of patches I followed this series of > steps. > > 1. Convert a file from the C way of doing things to C++ > 2. Go through all the files that had to do with the converted file and > make the formatting consistent. Looks good

Re: [PATCH v1 3/3] rld-dwarf.cpp: Initialize member variables

2021-09-02 Thread Chris Johns
On 3/9/21 12:08 am, Ryan Long wrote: > I remember prototyped_ being one that the issue was complaining about, but I > can't remember the others. I just went ahead and added the rest of the member > variables because Coverity doesn't always identify all the subsequent issues. May I suggest you

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

2021-09-02 Thread Chris Johns
On 2/9/21 5:40 pm, Christian MAUDERER wrote: > Am 02.09.21 um 09:33 schrieb Chris Johns: >> On 2/9/21 5:18 pm, Christian MAUDERER wrote: >> My compromise solution was adding a report option to help you see what is >> happening with the symbols. The intention is to aid m

Re: [PATCH v2] score: Document thread queue operations

2021-09-02 Thread Chris Johns
Looks good. Thanks. Chris On 2/9/21 5:13 pm, Sebastian Huber wrote: > --- > cpukit/include/rtems/score/threadq.h | 48 +++- > cpukit/include/rtems/score/threadqimpl.h | 21 +++ > cpukit/score/src/threadqops.c| 4 +- > 3 files changed, 62

Re: [PATCH] score: Document thread queue operations

2021-09-02 Thread Chris Johns
On 2/9/21 5:09 pm, Sebastian Huber wrote: > Hello Chris, > > thanks for the review, I will send a v2 of the patch. > > On 02/09/2021 08:38, Chris Johns wrote: >>> */ >>>     Thread_queue_Enqueue_operation enqueue; >>>       /** >&

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

2021-09-02 Thread Chris Johns
On 2/9/21 4:35 pm, Christian MAUDERER wrote: > Am 02.09.21 um 04:57 schrieb Chris Johns: >> On 1/9/21 4:24 pm, Christian MAUDERER wrote: >>> Hello Gedare and Chris, >>> >>> Am 01.09.21 um 07:55 schrieb Chris Johns: >>>> On 1/9/21 7:26 am, Gedare B

Re: [PATCH] score: Document thread queue operations

2021-09-02 Thread Chris Johns
On 2/9/21 3:50 pm, Sebastian Huber wrote: > --- > cpukit/include/rtems/score/threadq.h | 44 ++-- > cpukit/include/rtems/score/threadqimpl.h | 17 + > 2 files changed, 51 insertions(+), 10 deletions(-) > > diff --git a/cpukit/include/rtems/score/threadq.h >

Re: [PATCH v1 3/3] rld-dwarf.cpp: Initialize member variables

2021-09-01 Thread Chris Johns
On 25/8/21 3:12 am, Ryan Long wrote: > Initialize member variables not listed. > > CID 1503019: Uninitialized scalar field. > > Closes #4500 > --- > rtemstoolkit/rld-dwarf.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/rtemstoolkit/rld-dwarf.cpp

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

2021-09-01 Thread Chris Johns
On 1/9/21 4:24 pm, Christian MAUDERER wrote: > Hello Gedare and Chris, > > Am 01.09.21 um 07:55 schrieb Chris Johns: >> On 1/9/21 7:26 am, Gedare Bloom wrote: >>> Sorry, i think libbsd is still a bit slushy, wait for Chris to ok thx > > I planned to wait for Chr

Key press to reset

2021-09-01 Thread Chris Johns
Hi, I know there has been a configuration option to wait for a key press before a reset in some cases, ie PC BSP. I am now seeing it on BSPs that did not do this before but do now. This is with the waf build. Has something changed that effect the default for this setting? Chris

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

2021-08-31 Thread Chris Johns
On 1/9/21 7:26 am, Gedare Bloom wrote: > Sorry, i think libbsd is still a bit slushy, wait for Chris to ok thx It is so please wait a day or so. I have just finished the last stage of target testing on PowerPC hardware. I wanted to meet with Joel today but he could not make at the last minute.

Re: [PATCH] tester: Limit simultaneous QEMU jobs to 1

2021-08-31 Thread Chris Johns
On 1/9/21 12:25 pm, Kinsey Moore wrote: > I'll work toward this solution. Thanks, I appreciate your support in this area. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] tester: Limit simultaneous QEMU jobs to 1

2021-08-31 Thread Chris Johns
On 31/8/21 6:30 pm, Sebastian Huber wrote: > On 31/08/2021 09:00, Chris Johns wrote: >> On 31/8/21 3:20 pm, Sebastian Huber wrote: >>> On 30/08/2021 20:32, Kinsey Moore wrote: >>>> On 8/30/2021 12:12, Sebastian Huber wrote: >>>>> On 24/08/2021 20:45, K

Re: [PATCH v1 2/5] cpukit: Add Exception Manager

2021-08-31 Thread Chris Johns
On 31/8/21 11:35 pm, Kinsey Moore wrote: > On 8/31/2021 04:31, Sebastian Huber wrote: >> On 30/08/2021 17:13, Kinsey Moore wrote: >>> On 8/30/2021 07:50, Sebastian Huber wrote: On 30/08/2021 14:27, Kinsey Moore wrote: > On 8/30/2021 00:42, Sebastian Huber wrote: >> Hello Kinsey,

Re: [PATCH] tester: Limit simultaneous QEMU jobs to 1

2021-08-31 Thread Chris Johns
On 31/8/21 3:20 pm, Sebastian Huber wrote: > On 30/08/2021 20:32, Kinsey Moore wrote: >> On 8/30/2021 12:12, Sebastian Huber wrote: >>> On 24/08/2021 20:45, Kinsey Moore wrote: diff --git a/tester/rtems/testing/bsps/a53_ilp32_qemu.ini b/tester/rtems/testing/bsps/a53_ilp32_qemu.ini

Re: [PATCH 0/5] Preliminary Exception Manager Work

2021-08-27 Thread Chris Johns
On 24/8/21 10:34 pm, Kinsey Moore wrote: > On 8/23/2021 21:41, Chris Johns wrote: >> On 24/8/21 9:50 am, Kinsey Moore wrote: >>> This patch set contains the result of the Exception Manager work I >>> proposed a while back to manage handling of machine exceptions along

Re: [PATCH] aarch64: Add tests that are failing intermittently

2021-08-27 Thread Chris Johns
On 27/8/21 9:36 am, Kinsey Moore wrote: > On 8/20/2021 22:06, Chris Johns wrote: >> On 21/8/21 2:38 am, Kinsey Moore wrote: >>> On 8/19/2021 18:03, Chris Johns wrote: >>> My comment in that regard was that other system >>> loading (or multiple simultaneou

<    6   7   8   9   10   11   12   13   14   15   >