Re: [PATCH v2] tester: Add MicroBlaze KCU105 QEMU BSP

Hi Alex, OK to push and thanks Chris On 26/8/21 12:44 pm, Alex White wrote: > --- > tester/rtems/testing/bsps/kcu105_qemu.ini | 38 +++ > tester/rtems/testing/qemu.cfg | 2 +- > 2 files changed, 39 insertions(+), 1 deletion(-) > create mode 100644

Re: [PATCH rtems v1 2/2] bsps/zynqmp: Added I2C support for ZynqMP

On 25/8/21 12:05 am, Stephen Clark wrote: > This approach was also used in bsps/arm/xilinx-zynq/include/bsp/i2c.h. I kept > it specifically for consistency; I assumed it was the standard approach, but > your response makes me think it's not. I am also not sure and why I asked :) > Is there a

Re: [PATCH] tester: Add MicroBlaze KCU105 QEMU BSP

On 25/8/21 7:46 am, Alex White wrote: > On Mon, Aug 23, 2021 at 9:29 PM Chris Johns wrote: >> >> Hi, >> >> Could you please explain this file? >> >> Where is the source? >> >> Why would we allow a binay blob into the tester like this? > >

Re: [PATCH 0/5] Preliminary Exception Manager Work

On 24/8/21 9:50 am, Kinsey Moore wrote: > This patch set contains the result of the Exception Manager work I > proposed a while back to manage handling of machine exceptions along > with a general feature for mapping exceptions to POSIX signals without > delving into the CPU Port-specific details.

Re: [PATCH rtems v1 2/2] bsps/zynqmp: Added I2C support for ZynqMP

On 24/8/21 8:24 am, Stephen Clark wrote: > Added I2C drivers for ZynqMP and updated build system accordingly. > --- > bsps/aarch64/xilinx-zynqmp/include/bsp.h | 4 ++ > bsps/aarch64/xilinx-zynqmp/include/bsp/i2c.h | 63 +++ > bsps/aarch64/xilinx-zynqmp/include/bsp/irq.h |

Re: [PATCH] tester: Add MicroBlaze KCU105 QEMU BSP

Hi, Could you please explain this file? Where is the source? Why would we allow a binay blob into the tester like this? This seems specific to a set up or a BSP and not the tester. I am not comfortable with this approach. Have alternative approaches have you considered? Chris On 24/8/21 4:46

Re: [PATCH] aarch64: Add tests that are failing intermittently

On 21/8/21 2:38 am, Kinsey Moore wrote: > On 8/19/2021 18:03, Chris Johns wrote: >> On 20/8/21 4:55 am, Kinsey Moore wrote: >>> On 8/19/2021 13:32, Gedare Bloom wrote: >>>> On Thu, Aug 19, 2021 at 11:43 AM Kinsey Moore >>>> wrote: >>>>&g

Re: [PATCH] gdb: prefere python3 if it is installed

On 21/8/21 4:08 am, o...@c-mauderer.de wrote: > Started to test both (MSYS2 and Cygwin) and I start to suspect that our manual > needs some minor updates. I'm taking notes ... Oh awesome, I am sooo grateful. Thanks Chris ___ devel mailing list

Re: [PATCH] gdb: prefere python3 if it is installed

On 20/8/21 5:42 pm, Christian MAUDERER wrote: > Am 20.08.21 um 09:02 schrieb Chris Johns: >> On 20/8/21 4:48 pm, Christian MAUDERER wrote: >>> Hello, >>> >>> Am 20.08.21 um 03:49 schrieb Chris Johns: >>>> On 20/8/21 3:16 am, Joel Sherrill wrote: >

Re: [PATCH] gdb: prefere python3 if it is installed

On 20/8/21 4:48 pm, Christian MAUDERER wrote: > Hello, > > Am 20.08.21 um 03:49 schrieb Chris Johns: >> On 20/8/21 3:16 am, Joel Sherrill wrote: >>> On Thu, Aug 19, 2021 at 11:51 AM Gedare Bloom wrote: >>>> >>>> I have no problem with this. I thin

Re: [PATCH v4 0/2] Add MicroBlaze tools to RSB

Hi Alex, These patches are OK to push. One minor point, the script sha512-base64 in the RSB creates a base64 encoded hash and that makes them smaller. I prefer we move to this more and more. Chris On 19/8/21 1:34 pm, Alex White wrote: > Hi, > > This patch set now depends on Joel's newlib

Re: [PATCH] gdb: prefere python3 if it is installed

On 20/8/21 3:16 am, Joel Sherrill wrote: > On Thu, Aug 19, 2021 at 11:51 AM Gedare Bloom wrote: >> >> I have no problem with this. I think it is sensible to look for >> python3 before python2. At some point we'll have to stop looking for >> python2 :) > > That is further in the future than I

Re: Using libbsd dhcpcd options

On 20/8/21 1:45 am, junkes wrote: > Hallo Peter, > I do not know if this is best practice but I run the following code: > > static void > default_network_dhcpcd(void) > { >     static const char default_cfg[] = "clientid test client\n"; >     rtems_status_code sc; >     int fd; >     int rv; >    

Re: [PATCH] aarch64: Add tests that are failing intermittently

On 20/8/21 4:55 am, Kinsey Moore wrote: > On 8/19/2021 13:32, Gedare Bloom wrote: >> On Thu, Aug 19, 2021 at 11:43 AM Kinsey Moore >> wrote: >>> I've seen these failures on my local system, in our CI, and on a build >>> server that I sometimes >>> use for development/testing so if it's a

Re: [PATCH] aarch64: Add tests that are failing intermittently

On 20/8/21 2:58 am, Gedare Bloom wrote: > I know I OK'd looking at the versal, but on second thought, I'd rather > leave the xilinx-versal/tstqemu.yml alone until the BSP is finished, > so revert that part of your patch. Sorry about that. Agreed, please leave the Versal as is. Chris

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

On 19/8/21 10:45 pm, Kinsey Moore wrote: > On 8/18/2021 18:02, Chris Johns wrote: >> On 19/8/21 5:49 am, Kinsey Moore wrote: >>> On 8/18/2021 13:20, Chris Johns wrote: >>>> On 19/8/21 3:41 am, Kinsey Moore wrote: >>>>> This is functional on the Zy

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

On 19/8/21 5:49 am, Kinsey Moore wrote: > On 8/18/2021 13:20, Chris Johns wrote: >> On 19/8/21 3:41 am, Kinsey Moore wrote: >>> This is functional on the ZynqMP board I currently have setup for testing >>> and on >>> ZynqMP QEMU except for the data c

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

On 19/8/21 3:41 am, Kinsey Moore wrote: > This is functional on the ZynqMP board I currently have setup for testing and > on > ZynqMP QEMU except for the data corruption/loss caused by the removal of the > post-baud-set null write. Thanks for the testing. I am not sure if you are saying both

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

> On 18 Aug 2021, at 4:41 pm, jan.som...@dlr.de wrote: > > Is this patch also something to backport to RTEMS5 or is this problem only > specific to the current version? I have not considered doing this as 5 works on the Zynq. If termios is the same we may look at this. And Versal is not

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

On 17/8/21 11:21 pm, Joel Sherrill wrote: > I'm only asking where and how did this get tested? BSPs? Qemu/HW? Input? I listed the testing in the covering email ... https://lists.rtems.org/pipermail/devel/2021-August/068938.html > Long overdue. I just hope it stays fixed. I agree. Chris

Re: Xilinx Zynq console rx not working

On 17/8/21 8:59 am, Chris Johns wrote: > On 16/8/21 11:03 pm, Kinsey Moore wrote: >> On 8/16/2021 04:45, Chris Johns wrote: >>> On 16/8/21 6:38 pm, Chris Johns wrote: >>>> I have taken a closer look at the driver. I am receiving RX interrupts and >>>> th

Re: Xilinx Zynq console rx not working

On 16/8/21 11:03 pm, Kinsey Moore wrote: > On 8/16/2021 04:45, Chris Johns wrote: >> On 16/8/21 6:38 pm, Chris Johns wrote: >>> I have taken a closer look at the driver. I am receiving RX interrupts and >>> the >>> characters are being queued howeve

Re: RTEMS Tools on 5 release can't be build with modern LLVM

Looks good and thank you for sorting this out. Chris On 17/8/21 1:17 am, Christian MAUDERER wrote: > Am 16.08.21 um 17:12 schrieb Joel Sherrill: >> On Mon, Aug 16, 2021 at 10:08 AM Christian MAUDERER >> wrote: >>> >>> Hello Joel, >>> >>> Am 16.08.21 um 17:03 schrieb Joel Sherrill: On Mon,

Re: Xilinx Zynq console rx not working

On 16/8/21 6:38 pm, Chris Johns wrote: > On 14/8/21 12:40 am, Kinsey Moore wrote: >> On 8/13/2021 03:05, Chris Johns wrote: >>> Hi, >>> >>> I am bring up a major app on RTEMS 6 and LibBSD on custom Zynq hardware and >>> I am >>> not getting

Re: Xilinx Zynq console rx not working

On 14/8/21 12:40 am, Kinsey Moore wrote: > On 8/13/2021 03:05, Chris Johns wrote: >> Hi, >> >> I am bring up a major app on RTEMS 6 and LibBSD on custom Zynq hardware and >> I am >> not getting any receive interrupts from the console UART. The same hardware >

Xilinx Zynq console rx not working

Hi, I am bring up a major app on RTEMS 6 and LibBSD on custom Zynq hardware and I am not getting any receive interrupts from the console UART. The same hardware works with RTEMS 4.11 and RTEMS 5. I also do not see any console input with qemu and I thought this was something in qemu but I am now

Re: [PATCH rtems-libbsd] ppp: Fix transmitting data

On 13/8/21 5:22 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 13.08.21 um 04:46 schrieb Chris Johns: >> On 12/8/21 9:42 pm, Christian Mauderer wrote: >>> The pppstart expected that a driver write would somehow magically >>> process all data passed to the wri

Re: [PATCH rtems-libbsd] ppp: Fix transmitting data

On 12/8/21 9:42 pm, Christian Mauderer wrote: > The pppstart expected that a driver write would somehow magically > process all data passed to the write function. Because ppp disables all > buffering that originally has been in termios, that assumption is not > true for all but polled drivers. >

Re: [PATCH v2] score: Replace priority prepend it with an enum

+1 On 13/8/21 3:43 am, Gedare Bloom wrote: > looks good to me. > > On Thu, Aug 12, 2021 at 8:26 AM Sebastian Huber > wrote: >> >> Use the new Priority_Group_order enum instead of a boolean to indicated if a >> priority should be inserted as the first or last node into its priority >> group. >>

Re: [PATCH 0/3] Add ostream_guard patches

OK to push. Thanks Chris On 12/8/21 7:09 am, Ryan Long wrote: > Hi, > > In this series of patches, I just added ostream_guards where there were > "Restore ostream format" errors. This won't make the error go away, but > we're going to start ignoring those errors and just placing >

Re: [PATCH 1/2] score: Replace priority prepend it with flags

On 11/8/21 3:21 pm, Sebastian Huber wrote: > On 10/08/2021 16:50, Sebastian Huber wrote: >> On 10/08/2021 16:46, Gedare Bloom wrote: >>> This is a good cleanup. The naming seems a bit off to me, but it's all >>> internal so we can always adjust it later. (I think it should be >>> singular

Re: [PATCH rtems-libbsd v3 1/3] rtemsbsd/bus: Add PCI support to the nexus bus

On 10/8/21 1:43 am, Gedare Bloom wrote: > On Sun, Aug 8, 2021 at 7:22 PM Chris Johns wrote: >> >> - Add PCI IO region support >> >> - Add support map buffers to PCI address space >> >> - Add BSP conditional IO space support. Some PC implementations &g

Re: [PATCH v2] rtems-utils: Change data type definition

On 9/8/21 10:48 pm, Ryan Long wrote: > Without the global namespace prefix, it results in the following error > > ../linkers/rtems-exeinfo.cpp: In member function ‘void > rld::exeinfo::image::output_compilation_unit(bool, bool)’: > ../linkers/rtems-exeinfo.cpp:370:14: error: ‘rld::rtems::utils’

Re: [PATCH rtems-libbsd v3 2/3] rtemsbsd: Add interface support routines

On 10/8/21 1:50 am, Gedare Bloom wrote: > On Sun, Aug 8, 2021 at 7:22 PM Chris Johns wrote: >> >> - Add the ability to check if an interface is up >> --- >> libbsd.py | 1 + >> rtemsbsd/include/rtems/bsd/iface.h | 62 >

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

On 9/8/21 5:14 pm, Chris Johns wrote: > On 9/8/21 5:02 pm, Christian MAUDERER wrote: >> Hello Chris, >> >> Am 09.08.21 um 02:34 schrieb Chris Johns: >>> On 1/8/21 9:27 pm, Christian Mauderer wrote: >>>> Hello Husni, >>>> >>>>

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

On 9/8/21 5:02 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 09.08.21 um 02:34 schrieb Chris Johns: >> On 1/8/21 9:27 pm, Christian Mauderer wrote: >>> Hello Husni, >>> >>> just tested that and it works fine. With a simple curl I can reach a

[PATCH rtems-libbsd v3 3/3] testsuite: Wait for the link to be UP

- Wait for a slow PHY to bring the link UP. If the IP address is static the test can start before the link is up and the test fails. - Make 2 tests wait. Others will need to be added. --- .../include/rtems/bsd/test/default-init.h | 29 +++

[PATCH rtems-libbsd v3 1/3] rtemsbsd/bus: Add PCI support to the nexus bus

(c) 2021 Chris Johns. All rights reserved. + * * Copyright (c) 2009, 2015 embedded brains GmbH. All rights reserved. * * embedded brains GmbH @@ -25,7 +29,7 @@ * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following

[PATCH rtems-libbsd v3 2/3] rtemsbsd: Add interface support routines

calls. + */ + +/* + * Copyright (c) 2021. Chris Johns . All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above

LibBSD - bus space support for PC PCI devices

Hello, These patches address 2 issues, PC PCI suport for non-Intel targets and tests with static IP addresses faiing. - PC PCI BSPs like MVME2700 (MVME2307) have PC PCI devices with separate IO and memory bus spaces mapped into separate address spaces. This requires the BSP provides suitable

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

On 9/8/21 6:20 am, Christian Mauderer wrote: > I think all open questions should be answered or did I miss one from your > side? > If not I would like to push the patches. As asked in another thread can they please wait? Chris ___ devel mailing list

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

On 8/8/21 6:06 pm, Christian Mauderer wrote: > Hello Husni, > > On 07/08/2021 21:56, Ahamed Husni wrote: >> Hi Christian, >> >> Are there any issues I should address in this patch set? > > I think the big open question is the one from Chris: > >

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

On 1/8/21 9:27 pm, Christian Mauderer wrote: > Hello Husni, > > just tested that and it works fine. With a simple curl I can reach about 8.5 > MByte/s sending to the beagle and 19.5 MByte/s receiving from it. > > Please take a look at the points that Chris Jo

Re: [PATCH rtems-libbsd v2 5/5] create-kernel-namespace for USB Template driver

On 2/8/21 4:24 am, Ahamed Husni wrote: > Hello Chris, > > On Thu, Jul 29, 2021 at 5:41 AM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 28/7/21 9:56 pm, Husni Faiz wrote: > > Signed-off-by: Husni Faiz <mailto:ahamedhusn...@gmail.com>>

Re: [PATCH v2] rtems-utils: Change data type definition

On 6/8/21 6:43 am, Ryan Long wrote: > Remove typedef of ostream_guard and change datatype of ostream_guards to > have the namespace in the variable declarations. > --- > linkers/rtems-exeinfo.cpp| 6 ++ > tester/covoar/CoverageMapBase.cc | 4 +--- > tester/covoar/ReportsHtml.cc |

Re: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

On 5/8/21 9:13 am, Gedare Bloom wrote: > On Wed, Aug 4, 2021 at 4:47 PM Chris Johns wrote: >> >> On 5/8/21 1:54 am, Ryan Long wrote: >>> ostream_guard did not fix the "Not restoring ostream format" Coverity >>> issues as hoped, so there's no reason to

Re: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

On 5/8/21 1:54 am, Ryan Long wrote: > ostream_guard did not fix the "Not restoring ostream format" Coverity > issues as hoped, so there's no reason to have it. Can you capture the missing pieces here? Chris ___ devel mailing list devel@rtems.org

Re: [PATCH v1 0/5] Fix ostream format errors

On 5/8/21 1:54 am, Ryan Long wrote: > > The last "Restore ostream format" patch set didn't fix the Coverity issues. > We verified that resetiosflags() will get rid of the issues complaints about > std::left and std::right changing the stream's format, I noticed that it > didn't complain if

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

On 5/8/21 2:22 am, Christian Mauderer wrote: > On 04/08/2021 18:09, Gedare Bloom wrote: >> On Wed, Aug 4, 2021 at 9:05 AM Christian MAUDERER >> wrote: >>> Am 04.08.21 um 16:55 schrieb Gedare Bloom: On Wed, Aug 4, 2021 at 4:18 AM Christian MAUDERER wrote: My preference would be to

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

On 4/8/21 6:34 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 04.08.21 um 09:28 schrieb Chris Johns: >> On 3/8/21 5:00 pm, Christian MAUDERER wrote: >>> Hello, >>> >>> Am 03.08.21 um 04:07 schrieb Chris Johns: >>>> On 3/8/21 3:24 am, S

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

On 3/8/21 5:00 pm, Christian MAUDERER wrote: > Hello, > > Am 03.08.21 um 04:07 schrieb Chris Johns: >> On 3/8/21 3:24 am, Sebastian Huber wrote: >>> On 02/08/2021 18:37, Vijay Kumar Banerjee wrote: >>>> I think there should be a high-level user manual subsectio

Re: [PATCH v2 00/13] Remove app_common

OK to push. Chris On 3/8/21 6:44 am, Ryan Long wrote: > Hi, > > In this iteration I: > > - Removed the typedef in ObjdumpProcessor.h > - Changed targetInfo to be a shared pointer > - Got rid of some of the get & set methods for targetInfo_m > - Added lastState_m to initialization list in

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

On 3/8/21 3:24 am, Sebastian Huber wrote: > On 02/08/2021 18:37, Vijay Kumar Banerjee wrote: >> I think there should be a high-level user manual subsection for >> networking that describes how the selection of the network stack >> works. We can then add another subsection about lwip since legacy

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

On 2/8/21 4:58 pm, Christian MAUDERER wrote: > Hello Husni, > > thanks for the patches. I'm sure that this will start a discussion about the > right place for that documentation. libbsd documentation is a long overdue > topic > that has been neglected by all of us (including myself) so I think

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

On 29/7/21 8:44 am, Chris Johns wrote: > On 28/7/21 4:44 pm, Sebastian Huber wrote: >> On 28/07/2021 08:43, Chris Johns wrote: >>>> Why don't we use the FreeBSD implementation one-to-one: >>>> >>>> freebsd-org/sys/kern/kern_clock.c >>>>

Re: [PATCH v1 09/13] Remove SymbolsToAnalyze global variable

On 2/8/21 1:20 pm, Joel Sherrill wrote: > > > On Sun, Aug 1, 2021, 10:11 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 2/8/21 9:23 am, Ryan Long wrote: > > - Removed SymbolsToAnalyze from app_common and replaced it with the > > 

Re: [PATCH v1 11/13] Remove TargetInfo global variable

On 2/8/21 9:23 am, Ryan Long wrote: > - Remove TargetInfo from app_common > - Created the targetInfo_m member variable in CoverageReaderBase, > TraceWriterBase, and ObjdumpProcessor > - Made functions to set the value of targetInfo_m > --- > tester/covoar/CoverageReaderBase.cc | 5 + >

Re: [PATCH v1 09/13] Remove SymbolsToAnalyze global variable

On 2/8/21 9:23 am, Ryan Long wrote: > - Removed SymbolsToAnalyze from app_common and replaced it with the > symbolsToAnalyze_m member variable in DesiredSymbols, GcovData, and > ObjdumpProcessor > - Added a parameter to constructors to initialize symbolsToAnalyze_m > - Moved the definition of

Re: [PATCH] rtems: Generate

On 30/7/21 4:52 pm, Sebastian Huber wrote: > On 30/07/2021 00:54, Chris Johns wrote: >> On 29/7/21 10:59 pm, Sebastian Huber wrote: >>> On 29/07/2021 14:51, Sebastian Huber wrote: >>>> Change license to BSD-2-Clause according to file histories and >>>

Re: doubt about 'bool is_executing'

On 29/7/21 11:07 pm, Sebastian Huber wrote: > On 29/07/2021 15:01, Gedare Bloom wrote: > It would be quite bad for interoperability if the bool type is not defined by > the ABI.  For example: > > https://developer.arm.com/documentation/ihi0055/b/ https://yarchive.net/comp/linux/bool.html Bool

Re: [PATCH] rtems-utils: Change data type definition

Why not use the namespace explicitly and avoid this shortening? Namespaces are there to help. With C++ I have a simple rule which is always use the namespace path where possible. There are a few cases, for example in a class, a function or local block where using an alias helps the formatting

Re: [PATCH] rtems: Generate

On 29/7/21 10:59 pm, Sebastian Huber wrote: > On 29/07/2021 14:51, Sebastian Huber wrote: >> Change license to BSD-2-Clause according to file histories and >> documentation re-licensing agreement. >> >> Place the group into the I/O Manager group.  Add all source files to the >> group. >> >> Update

Re: [PATCH rtems-libbsd v2 2/5] usb_template: Configure template driver only for CDC Ethernet

On 29/7/21 4:20 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 29.07.21 um 02:07 schrieb Chris Johns: >> On 29/7/21 1:10 am, Ahamed Husni wrote: >>> >>> >>> On Wed, 28 Jul 2021, 17:27 Husni Faiz, >> <mailto:ahamedhusn...@gmail.com>>

Re: [PATCH 4/4] score: Move per-CPU jobs support

On 29/7/21 5:19 pm, Sebastian Huber wrote: > On 29/07/2021 02:44, Chris Johns wrote: >>> +void _Per_CPU_Add_job( Per_CPU_Control *cpu, Per_CPU_Job *job ) >>> +{ >>> +  ISR_lock_Context lock_context; >>> + >>> +  _Atomic_Store_ulong( >done, 0

Re: [PATCH 4/4] score: Move per-CPU jobs support

On 28/7/21 9:18 pm, Sebastian Huber wrote: > Add percpujobs.c to contain the per-CPU jobs implementation. > --- > cpukit/Makefile.am| 1 + > cpukit/score/src/percpujobs.c | 124 ++ > cpukit/score/src/smpmulticastaction.c | 89

Re: [PATCH rtems-libbsd v2 5/5] create-kernel-namespace for USB Template driver

On 28/7/21 9:56 pm, Husni Faiz wrote: > Signed-off-by: Husni Faiz > --- > rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h >

Re: [PATCH rtems-libbsd v2 4/5] libbsd.py: add usb template files

On 28/7/21 9:56 pm, Husni Faiz wrote: > add the imported template files for CDC Ethernet > register the dev_usb_template module > enable usb template in default buildset > > Signed-off-by: Husni Faiz > --- > buildset/default.ini | 1 + > buildset/minimal.ini | 3 ++- > libbsd.py|

Re: [PATCH rtems-libbsd v2 2/5] usb_template: Configure template driver only for CDC Ethernet

On 29/7/21 1:10 am, Ahamed Husni wrote: > > > On Wed, 28 Jul 2021, 17:27 Husni Faiz, > wrote: > > Add the conditional macro to prevent the driver from referencing > the templates which are not imported yet. > > Include functions which adds the

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

On 29/7/21 12:27 am, Gedare Bloom wrote: > On Wed, Jul 28, 2021 at 12:50 AM Chris Johns wrote: >> >> On 28/7/21 4:38 pm, Sebastian Huber wrote: >>> On 28/07/2021 04:53, chr...@rtems.org wrote: >>>> +for sym in self.output['symbols']: >>>>

Re: [PATCH rtems-libbsd 3/7] sys/kern: Add lockmgr support

On 29/7/21 9:42 am, Gedare Bloom wrote: > On Wed, Jul 28, 2021 at 5:05 PM Chris Johns wrote: >> On 29/7/21 12:03 am, Gedare Bloom wrote: >>> On Tue, Jul 27, 2021 at 2:59 AM wrote: >>>> From: Chris Johns >>>> +static int >>>> +lockmgr_upgrade

Re: [PATCH rtems-libbsd 3/7] sys/kern: Add lockmgr support

On 29/7/21 12:03 am, Gedare Bloom wrote: > On Tue, Jul 27, 2021 at 2:59 AM wrote: >> From: Chris Johns >> >> struct lock_object { >> -#ifndef __rtems__ >> const char *lo_name; /* Individual lock name. */ >> u_int

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

On 28/7/21 4:44 pm, Sebastian Huber wrote: > On 28/07/2021 08:43, Chris Johns wrote: >>> Why don't we use the FreeBSD implementation one-to-one: >>> >>> freebsd-org/sys/kern/kern_clock.c >>> >> I am fixing the code that exists. I have no idea why ke

Re: [PATCH rtems-libbsd 5/7] kern: Add a proc0

On 29/7/21 12:22 am, Gedare Bloom wrote: > On Tue, Jul 27, 2021 at 2:59 AM wrote: >> From: Chris Johns >> @@ -135,6 +171,8 @@ rtems_bsd_initialize(void) >> sbt_tickthreshold = bttosbt(bt_tickthreshold); >> maxid_maxcpus = (int) rtems_sche

Re: [PATCH rtems-libbsd 3/7] sys/kern: Add lockmgr support

On 28/7/21 4:23 pm, Sebastian Huber wrote: > On 27/07/2021 10:58, chr...@rtems.org wrote: >> From: Chris Johns >> >> - See `man lockmgr` >> >> - Implement the lock_object and move the RTEMS mutex to that object >> >> - Add debug support t

Re: [PATCH rtems-libbsd 7/7] kern: Add kernel trace support (KTR)

On 28/7/21 4:57 pm, Sebastian Huber wrote: > On 28/07/2021 08:53, Chris Johns wrote: >> On 28/7/21 4:27 pm, Sebastian Huber wrote: >>> On 27/07/2021 10:58,chr...@rtems.org  wrote: >>>> diff --git a/rtemsbsd/rtems/rtems-kernel-thread.c >>>> b/rtemsbsd/rtems

Re: [PATCH rtems-libbsd 7/7] kern: Add kernel trace support (KTR)

On 28/7/21 4:27 pm, Sebastian Huber wrote: > On 27/07/2021 10:58, chr...@rtems.org wrote: >> diff --git a/rtemsbsd/rtems/rtems-kernel-thread.c >> b/rtemsbsd/rtems/rtems-kernel-thread.c >> index 3e1e44b9..49ec6df7 100644 >> --- a/rtemsbsd/rtems/rtems-kernel-thread.c >> +++

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

On 28/7/21 4:38 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> +    for sym in self.output['symbols']: >> +    out += ['#define %s_bsd_%s' % (sym, sym)] > > If you add a tab after the #define, then the output is in line with the > FreeBSD > style and you

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

On 28/7/21 4:03 pm, Sebastian Huber wrote: > On 28/07/2021 00:53, Chris Johns wrote: >> On 28/7/21 7:38 am, Gedare Bloom wrote: >>> On Tue, Jul 27, 2021 at 2:59 AM  wrote: >>>> From: Chris Johns >>>> >>>> Update #4475 >>> This change c

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

On 28/7/21 4:34 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> -#define    zy7_slcr_postload_pl _bsd_zy7_slcr_postload_pl >> +#define AES_CBC_MAC_Final _bsd_AES_CBC_MAC_Final > > The FreeBSD coding style has a tab after the #define. This is why it was > where. >

Re: [PATCH rtems-libbsd v3 2/4] waf: Fix clashing symbols in the user land symbols

On 28/7/21 4:29 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> From: Chris Johns >> >> Update #4475 >> --- >>   libbsd.py | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libbs

NSFv4: LibBSD VFS and FS

Hello, Ticket #4475 documents the addition of the FreeBSD NFS client to LibBSD. https://devel.rtems.org/ticket/4475 The change is large because the NFS client uses FreeBSD's VFS and this in turn requires LibBSD use FreeBSD's file descriptor and file support. Breaking this patch down into

Re: [PATCH rtems-libbsd v2 1/4] Implement portable kernel symbol namespace tool

Please ignore v2, I forgot to the rebase the fixes from the review. V3 will be posted soon. On 28/7/21 11:06 am, chr...@rtems.org wrote: > From: Chris Johns > > - The script's use of sort proved to not be portable > > - No need to check the commits as symbols are only added >

Re: [PATCH rtems-libbsd.nfs 1/4] Implement portable kernel symbol namespace tool

Thanks for the review ... On 28/7/21 7:16 am, Gedare Bloom wrote: > On Tue, Jul 27, 2021 at 2:09 AM wrote: >> +environment `PATH` variable or you can specify the top level path as an >> argument: >> +``` >> +$ ./rtems-kern-symbols --tools=/opt/work/rtems/6 >> +``` > > This is inconsistent with

Re: [PATCH 1/3] rsb: Store patches in separate directories

On 28/7/21 12:13 am, Alex White wrote: > On Tue, Jul 27, 2021 at 12:46 AM Chris Johns wrote: >> >> On 27/7/21 3:39 pm, Sebastian Huber wrote: >> > On 27/07/2021 05:30, Alex White wrote: >> >> This prevents patches with the same name from conflicting

Re: [PATCH rtems-libbsd 1/7] rtemsbsd: Catch timeout overflows

On 28/7/21 7:38 am, Gedare Bloom wrote: > On Tue, Jul 27, 2021 at 2:59 AM wrote: >> >> From: Chris Johns >> >> Update #4475 > This change could probably use its own ticket. Without the change the RPC client fails to connect in a reliable way because the conne

Re: [PATCH 1/3] rsb: Store patches in separate directories

On 27/7/21 3:39 pm, Sebastian Huber wrote: > On 27/07/2021 05:30, Alex White wrote: >> This prevents patches with the same name from conflicting and causing >> the build to fail. > > Why can't the patches have a unique file name? Yeap and if specific to Xilinx and their repos it should be

Re: ttcp only on 6-freebsd-12 and not on master of libbsd

Hi Thanks for all this and digging into the 6-freebsd-12 and master branches. I think it is clear from what has been stated and what I have experienced we need to look at how we contributing to libbsd. I am struggling with a few things that are creating issues for me. I am making large changes

Re: [PATCH 1/3] rsb: Store patches in separate directories

Hi Ryan, Why is this needed? Does this change effect all builds and does a user end up with copies of the same patches? Have you built a full release with this change? It will be required for me to consider accepting any part of these patches. Chris On 27/7/21 1:30 pm, Alex White wrote: >

Re: libbsd kernel namespace generation

On 23/7/21 5:00 pm, Sebastian Huber wrote: > Hello Chris, > > On 22/07/2021 10:44, Chris Johns wrote: >> Hello, >> >> Libbsd uses the pre-processor to map all the kernel calls into a libbsd >> kernel >> name space by prepending _bsd_ to each symbol. The

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

> On 22 Jul 2021, at 6:53 pm, Sebastian Huber > wrote: >> On 22/07/2021 10:47, Chris Johns wrote: >>> On 22/7/21 6:37 pm, Sebastian Huber wrote: >>> On 22/07/2021 10:33, Chris Johns wrote: >>>>>> and so the arch part is not &g

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

On 22/7/21 6:37 pm, Sebastian Huber wrote: > On 22/07/2021 10:33, Chris Johns wrote: >>>> and so the arch part is not >>>> really needed. My concern is this type code ... >>>> >>>> https://git.rtems.org/rtems_waf/tree/rtems.py#n758 >&g

libbsd kernel namespace generation

Hello, Libbsd uses the pre-processor to map all the kernel calls into a libbsd kernel name space by prepending _bsd_ to each symbol. The script ... https://git.rtems.org/rtems-libbsd/tree/create-kernel-namespace.sh?h=6-freebsd-12 ... generates the list and the result is pushed into the repo.

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

On 22/7/21 4:44 pm, Sebastian Huber wrote: > On 22/07/2021 08:37, Chris Johns wrote: >> On 22/7/21 4:20 pm, Sebastian Huber wrote: >>> On 22/07/2021 02:39, Chris Johns wrote: >>>> On 22/7/21 5:22 am, Sebastian Huber wrote: >>>>> BSP family and BSP va

Re: [PATCH 20/41] sparc/irq: Implement new interrupt directives

On 22/7/21 5:08 am, Sebastian Huber wrote: > On 21/07/2021 21:04, Gedare Bloom wrote: >> On Wed, Jul 21, 2021 at 12:31 PM Sebastian Huber >>   wrote: >>> On 21/07/2021 20:28, Gedare Bloom wrote: Why not throw an error here instead? In production, you wouldn't want this code... >>> The

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

On 22/7/21 4:20 pm, Sebastian Huber wrote: > On 22/07/2021 02:39, Chris Johns wrote: >> On 22/7/21 5:22 am, Sebastian Huber wrote: >>> BSP family and BSP variant names may be equal.  This prefix avoids >>> ambiguity in the enabled-by expressions. >>> --- >&

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

On 22/7/21 5:22 am, Sebastian Huber wrote: > BSP family and BSP variant names may be equal. This prefix avoids > ambiguity in the enabled-by expressions. > --- > wscript | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/wscript b/wscript > index f27dba6831..b7a0412150

Re: [PATCH] linker_set.h: Add alignof implementation for when not C11 or C++11

On 22/7/21 7:55 am, Joel Sherrill wrote: > On Wed, Jul 21, 2021, 4:31 PM Gedare Bloom > wrote: > > This seems alright to me. At least, it should get some complaints > quickly if it doesn't work :) > > The old version should have gotten complaints but didn't.

Re: [PATCH] build: Add the BSP family to the enable set

On 22/7/21 8:55 am, Joel Sherrill wrote: > On Wed, Jul 21, 2021, 5:49 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 22/7/21 8:35 am, Joel Sherrill wrote: > > On Wed, Jul 21, 2021 at 2:10 PM Sebastian Huber > > <mailto:sebastian

Re: [PATCH] bsp: Remove fatal from exit(0). Add extended heap error output

On 22/7/21 8:45 am, Joel Sherrill wrote: > On Wed, Jul 21, 2021 at 2:04 AM Chris Johns wrote: >> >> On 21/7/21 3:37 pm, Sebastian Huber wrote: >>> Hello Chris, >>> >>> thanks, this is a nice improvement. >> >> It helps find the corrupti

Re: [PATCH] build: Add the BSP family to the enable set

On 22/7/21 8:35 am, Joel Sherrill wrote: > On Wed, Jul 21, 2021 at 2:10 PM Sebastian Huber > wrote: >> >> On 21/07/2021 21:05, Gedare Bloom wrote: > The problem is that one BSP which supports SMP "riscv/griscv" is > identical to > the family "riscv/griscv" which contains BSPs which

<    7   8   9   10   11   12   13   14   15   16   >