Re: RTEMS Deployment

On Fri, May 3, 2024, 7:52 AM Joel Sherrill wrote: > > > On Thu, May 2, 2024 at 11:48 PM Chris Johns wrote: > >> Hi, >> >> This email ask for the rtems-deployment repo to be moved RTEMS/Tools in >> GitLab. >> >> It is a repo of RSB configs to build packages of common or user specific >> vertical

Re: [PATCH 5/5] bsps: Add xilinx_zynqmp_lp64_a53 BSP variant

In some other architectures we have had "generic" BSP targets. It would be good to have something following the lp64 part. I'm not quite clear on what the purpose of this generic BSP target is here. On Fri, Mar 22, 2024 at 9:48 AM Kinsey Moore wrote: > > This patch looks good. I would suggest

Re: [PATCH] rtems: Avoid -Wundef warnings in API header

ok On Fri, Mar 22, 2024 at 3:32 AM Sebastian Huber wrote: > > --- > cpukit/include/rtems/score/basedefs.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/cpukit/include/rtems/score/basedefs.h > b/cpukit/include/rtems/score/basedefs.h > index

Re: [PATCH] bsp-howto: Document clock driver arg parameter

LGTM, thanks! On Fri, Mar 22, 2024 at 1:11 AM Sebastian Huber wrote: > > Update #4862. > --- > bsp-howto/clock.rst | 34 ++ > 1 file changed, 22 insertions(+), 12 deletions(-) > > diff --git a/bsp-howto/clock.rst b/bsp-howto/clock.rst > index 043083f..ed83472

Re: [PATCH] bsps: Avoid unused argument in clock interrupt

Generally this looks ok to me, but please update https://docs.rtems.org/branches/master/bsp-howto/clock.html#initialization https://docs.rtems.org/branches/master/bsp-howto/clock.html#support-at-tick to explain how this arg works. On Wed, Mar 20, 2024 at 8:29 AM Sebastian Huber wrote: > > Pass

Re: RFC: Add API to get and set interrupt priorities for interrupt vectors

Two basic questions: Does the priority field type need to be Architecture- or BSP-defined or is uint32_t always going to be fine. Does changing (increasing) the priority of a vector from within interrupt context possibly cause a pending interrupt to post that was previously at a lower priority

Re: utf32 support

I think it would be wchar_t support in newlib. On Mon, Mar 18, 2024 at 11:56 AM Joel Sherrill wrote: > > What does support for UTF-32 entail? Do you have an idea what software > functions you are looking for? > > I see the International Components for Unicode (ICU) has a converter >

Re: GSOC Task

Thanks. Please add yourself to the table at https://devel.rtems.org/wiki/GSoC/2024 and (continue to) discuss your project ideas here/Discord. On Tue, Mar 12, 2024 at 2:10 PM Matheus Pecoraro wrote: > > Hello, I am a fresh graduate from Brazil. I have developed a simple > x86_64 kernel in Rust in

Re: [PATCH] Getting Started Task Patch

On Thu, Mar 7, 2024 at 7:32 PM Ashish Baghel wrote: > > From: never > Thanks for resending this. Please set a real user.name in your git metadata for author attribution. > --- > testsuites/samples/hello/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: Getting started Task completed

Hi Ashish Baghel, On Wed, Mar 6, 2024 at 6:30 AM ashish ashish wrote: > > Hello all, This is Ashish Baghel email: ashishashish7...@gmail.com pursuing > computer science and engineering and this is my patch for getting started task > > "hello.c" I see you are copying the contents of the files

Re: [RFC] generic CAN/CAN FD susbsytem for RTEMS from scratch (LinCAN inspired)

On Thu, Feb 29, 2024 at 6:40 AM Pavel Pisa wrote: > > Hello Gedare > > On Tuesday 27 of February 2024 22:27:43 Gedare Bloom wrote: > > On Mon, Feb 12, 2024 at 8:03 AM Pavel Pisa wrote: > > > Michal Lenc works on a new generic CAN/CAN FD subsystem for RTEMS under > &

Re: [PATCH 4/6] build: Add support to make bootloader images

On Mon, Mar 4, 2024 at 12:19 AM Chris Johns wrote: > > > > On 1/3/2024 9:57 pm, Sebastian Huber wrote: > > On 29.02.24 00:05, Chris Johns wrote: > If it is will the details be exported in the pkgconfig file and made > available > for users building applications in a consistent and

Re: Getting started task done

PS: You may add yourself to the table at https://devel.rtems.org/wiki/GSoC/2024#ContributorsProposals On Tue, Mar 5, 2024 at 2:15 PM Gedare Bloom wrote: > > Hi Atharv Dubey, > > This is acceptable. However, could you please re-do this to create a > *minimal* patch containing only

Re: Getting started task done

Hi Atharv Dubey, This is acceptable. However, could you please re-do this to create a *minimal* patch containing only a small change required to modify what the hello sample prints? The patch you sent includes many superfluous changes, including a lot of commented-out lines of code and excessive

Re: [PATCH 0/2] GSOC: ​Hello World exercise

Go ahead and add yourself to the table at https://devel.rtems.org/wiki/GSoC/2024#ContributorsProposals See the https://devel.rtems.org/wiki/GSoC/2023 page if you need guidance how to do that (Edit Button to see source). You'll need to register for a Trac account first to edit the page. On Wed,

Re: [RFC] generic CAN/CAN FD susbsytem for RTEMS from scratch (LinCAN inspired)

On Mon, Feb 12, 2024 at 8:03 AM Pavel Pisa wrote: > > Dear RTEMS community, the core developers team, > > Michal Lenc works on a new generic CAN/CAN FD subsystem for RTEMS under my > supervision. The project has reached a phase where we will be very grateful > for the review and pointing to

Re: [PATCH 0/6] Add support for optional BSP-specific tools to make bootloader images

I'm a little confused by this patch set. I think I saw Frank makes a similar kind of comment. Basically, I don't understand why we generate these tools with the RTEMS build system, inside of rtems.git, rather than inside of rtems-tools. On Tue, Feb 27, 2024 at 8:15 AM Sebastian Huber wrote: > >

GSoC24 and Mentors

Hey folks, RTEMS was accepted as an org for GSoC again. If you were a mentor in the previous two years, and would like to be a mentor again, simply go activate your 2024 mentor account at g.co/gsoc If you were not a mentor in the past, but would like to be, please send me/Joel/Chris an email and

Re: [PATCH] improved error checking in ticks per timeslice

On Sun, Feb 18, 2024 at 3:31 PM Chris Johns wrote: > > On 18/2/2024 4:42 am, Gedare Bloom wrote: > > Is there a simple way we can add some checks for modification of > > generated files into a commit hook? And then, point to a documentation > > that helps explain where

Re: [PATCH] improved error checking in ticks per timeslice

On Sat, Feb 17, 2024 at 10:35 AM Sebastian Huber wrote: > > On 17.02.24 18:11, Joel Sherrill wrote: > > > > On Wed, Feb 14, 2024, 9:54 PM zack leung > > wrote: > > > > > This file is generated from something in rtems-central. This was at > > the > > >

Re: [PATCH 3/4] dev/io: Add a CRC-24Q implementation

On Mon, Jan 22, 2024 at 11:13 AM Sebastian Huber wrote: > > Hello Gedare, > > - Am 22. Jan 2024 um 17:49 schrieb Gedare Bloom ged...@rtems.org: > > > Similar to the other patch, this looks mostly useful. > > > > I think a lot of these kind of support code ha

Re: [PATCH rtems6 0/1] libmisc/shell: Fix timeout in getting terminal

Peter, On Fri, Jan 19, 2024 at 5:18 AM wrote: > > From: Peter Dufault > > This is my first submission of a patch using format-patch and > send-email from my Linux system. Let me know if anything is wrong. > The patch itself came through great, thanks! For future single-patch submissions, you

Re: [PATCH rtems6 1/1] libmisc/shell: Fix timeout in getting terminal size

I have a couple minor notes below. More important, does this change require updating documentation? I know we have a somewhat aging shell-specific guide: https://docs.rtems.org/branches/master/shell/index.html On Fri, Jan 19, 2024 at 5:19 AM wrote: > > From: Peter Dufault > > - Fix detection

Re: [PATCH v2] cpukit/score: Avoid overflow in multiplication

On Wed, Jan 17, 2024 at 7:47 AM Sebastian Huber wrote: > > On 17.01.24 15:31, Kinsey Moore wrote: > > Change extend_count to uint32_t from uint16_t to avoid a possible > > premature integer overflow when it is later used for multiplication. > > Thanks, looks good. > I would have preferred a cast

Re: [PATCH v1] bsps/aarch64: explicit cast uint64_t to ISR_Level

On Wed, Jan 17, 2024 at 1:48 AM wrote: > > From: Chengxiang Li > > avoid pclint err > --- > cpukit/score/cpu/aarch64/include/rtems/score/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpukit/score/cpu/aarch64/include/rtems/score/cpu.h >

Re: rtems 5.3 released libbsd hash mismatch

On Sat, Jan 13, 2024 at 1:23 PM John Howard wrote: > > Greetings. New developer here. > Thanks for the report. > I used RSB 5.3 to target RTEMS to RaspberryPi with an AMD64 Debian bullseye. > > sha512sum rtems-libbsd-5.3.tar.xz listed in VERSION is hash mismatch. > This appears to be a mismatch

Re: [PATCH] bsps/clock: Fix fast idle mode

On Tue, Jan 16, 2024 at 8:44 AM Sebastian Huber wrote: > > Switch back to the idle thread if no watchdogs are active. In some tests, the > idle thread may do some non-blocking work. > --- > bsps/shared/dev/clock/clockimpl.h | 16 > 1 file changed, 16 insertions(+) > > diff

Re: [PATCH 3/4] dev/io: Add a CRC-24Q implementation

Similar to the other patch, this looks mostly useful. I think a lot of these kind of support code have been imported as libraries through cpukit/libmisc. I'd be fine if we have our own versions, to define a cpukit/lib** But cpukit/dev has so far been for device-specific frameworks and I would

Re: [PATCH rtems6 1/1] xparameters.h: fix typo in comment

Sorry, it already was pushed. On Mon, Jan 22, 2024 at 9:47 AM Gedare Bloom wrote: > > someone can push this. > > next time, add > > bsps/include: > > as the tag. We should define the set of desirable tags for the commit > messages. > > On Mon, Jan 8, 2024 at 12

Re: [PATCH rtems6 1/1] xparameters.h: fix typo in comment

someone can push this. next time, add bsps/include: as the tag. We should define the set of desirable tags for the commit messages. On Mon, Jan 8, 2024 at 12:26 PM Will wrote: > > Looks good to me. There is generally no need for a 0/X email when X is small > unless you think it is necessary.

Re: [PATCH 2/4] dev/io: Add base64 decoder

This seems to be generically useful by itself. I'd probably be OK with it, if it has a suitable (non device-related) home. On Mon, Jan 15, 2024 at 2:46 AM Sebastian Huber wrote: > > From: Matthew Joyce > > --- > cpukit/dev/iobase64decode.c | 166 >

Re: [PATCH 0/4] dev/io: Add packet processor

On Sun, Jan 21, 2024 at 4:43 PM Chris Johns wrote: > > Hi, > > There are a few things I do not understand about this addition. I brief review > of the code seems OK but I am struggling to understand the requirements > driving > this addition. Can a ticket please be created with the requirements

GSoC open projects

Hello all, We will again plan to apply to GSoC. Please take a few minutes to check on https://devel.rtems.org/wiki/Developer/OpenProjects to see if any projects should be closed/removed from that list, and whether you'd like to add any new projects. Thanks! Gedare

Re: style patches - discuss

On Thu, Dec 7, 2023 at 12:19 AM Sebastian Huber wrote: > > Hello, > > it seems we still have no tool and configuration to get satisfying > results when applied to existing RTEMS source files. May I suggest a > more pragmatic approach which focuses on new files. Would it be an > option to simply

Re: [rtems-docs PATCH] user: Automatic version number fixes

lgtm, thanks On Mon, Dec 18, 2023 at 7:59 PM wrote: > > From: Chris Johns > > Updates #4695 > --- > user/exe/initialization.rst| 3 +-- > user/tracing/captureengine.rst | 20 ++-- > user/tracing/examples.rst | 12 ++-- > 3 files changed, 17 insertions(+), 18

Re: [PATCH v2 4/4] sb: Set the uid and gid on POSIX systems

These 4 look good to me. On Wed, Dec 6, 2023 at 3:14 PM wrote: > > From: Chris Johns > > This improves performance because it avoids an exec each time > the _uid macro is referenced and that can be a number of times > for each config parsed. > --- > source-builder/sb/options.py | 6 +- > 1

Re: rtems-docs README.txt: how to specify a particular sphinx version

This looks fine to me. On Thu, Nov 9, 2023 at 4:15 AM andrew.butterfi...@scss.tcd.ie wrote: > > Adds some lines to indicate how to install a specific sphinx version > Patches are attached. > > Regards, Andrew > > > > Andrew

Re: add Formal Verification chapter v5

Andrew, Thanks for working through this. Gedare On Thu, Nov 9, 2023 at 7:19 AM andrew.butterfi...@scss.tcd.ie wrote: > > Hello Sebastian, > Thanks for that, and the fixes ! > > Regards, Andrew > > > Andrew Butterfield Tel:

Re: [PATCH] build: Add RTEMS_QUALIFIED

On Mon, Nov 6, 2023 at 1:55 PM Chris Johns wrote: > > On 6/11/2023 8:27 pm, Sebastian Huber wrote: > > On 06.11.23 01:14, Chris Johns wrote: > >> On 4/11/2023 1:31 am, Sebastian Huber wrote: > >>> On 03.11.23 15:08, Joel Sherrill wrote: > On Fri, Nov 3, 2023 at 3:58 AM Sebastian Huber >

Re: Add Formal Verification chapter v4

On Mon, Oct 9, 2023 at 9:34 AM andrew.butterfi...@scss.tcd.ie wrote: > > Eliding some stuff > >On 05/10/2023, 16:02, "Gedare Bloom" <mailto:ged...@rtems.org>> wrote: > >>On Fri, Sep 22, 2023 at 4:50 AM andrew.butterfi...@scss.tcd.ie > >

Re: Add Formal Verification chapter v4

an Huber" ><mailto:sebastian.hu...@embedded-brains.de> > >><mailto:sebastian.hu...@embedded-brains.de > ><mailto:sebastian.hu...@embedded-brains.de>>> wrote: > >On 21.09.23 17:41, Gedare Bloom wrote: > >>> On Thu, Sep 21, 2023 at 9:36 AM Sebastian Hube

Re: [net-legacy PATCH] tests: Add header for RTEMS test printer

OK On Wed, Oct 4, 2023 at 4:13 PM wrote: > > From: Chris Johns > > --- > libtest/testbeginend.c | 1 + > libtest/testwrappers.c | 1 + > testsuites/loopback/init.c | 1 + > testsuites/pppd/init.c | 4 +++- > 4 files changed, 6 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] Avoid StopIteration exception for non-rtems .pc

LGTM On Thu, Oct 5, 2023 at 7:40 AM Martin Erik Werner wrote: > > _arch_from_arch_bsp() and _bsp_from_arch_bsp() has overly optimistic > assumptions that the argument must contain a '-'-separated field which > starts with "rtems". These functions are intended to find the target > triplet or the

Re: Add Formal Verification chapter v4

On Thu, Sep 21, 2023 at 9:36 AM Sebastian Huber wrote: > > On 21.09.23 17:28, Gedare Bloom wrote: > > I've taken a look and resolved / commented. We can leave some of the > > `sis` specific bits, with the understanding that hopefully the > > simulation target

Re: Add Formal Verification chapter v4

ation Research Group > School of Computer Science and Statistics, > Room G.39, O'Reilly Institute, Trinity College, University of Dublin > http://www.scss.tcd.ie/Andrew.Butterfield/ > <http://www.scss.tcd.ie/Andrew.Butterfield/> > ---------

Re: Add Formal Verification chapter v4

Thanks, I left comments on your pull request. On Wed, Sep 6, 2023 at 7:26 AM andrew.butterfi...@scss.tcd.ie wrote: > > Ping > > (I've let this sit a while - time to wake it up!) > > > Andrew Butterfield Tel: +353-1-896-2517

Re: bsps/xilinx-zynqmp : Add BSP for RPU

By separating this from the zynqmp bsp, there should be some modification of the naming conventions to specify rpu--unless they will share the code files identically. I guess that decision must be made. These files should not be duplicated in the tree simultaneously, as they introduce name clashes

Re: (libdl) Fwd: New Defects reported by Coverity Scan for RTEMS

flag it as a false positive. g7 is a global register that is reserved for system / compiler use in the sparc ABI On Mon, Aug 21, 2023 at 2:17 PM Joel Sherrill wrote: > > Moving it back to devel@. > > It appears to be from this bit of magic in the same file which implements it > using a direct

Re: [PATCH v2] libdl: Add support to import base image TLS symbols

ok On Wed, Aug 16, 2023 at 9:00 PM wrote: > > From: Chris Johns > > This change requires an rtems-tools update for symbol generation. > > Working architectures: > - aarch64 > - arm > - powerpc > - sparc > > No newlib TLS support but checked: > - i386 > - m69k > > Updates #4920 > --- >

Re: [rtems-tools PATCH] tester/sis: Use the RTEMS SIS command

ok On Wed, Aug 16, 2023 at 9:42 PM wrote: > > From: Chris Johns > > Make sis and sis-run the same as there is no SIS support in > gdb anymore. > > Closes #4945 > --- > tester/rtems/testing/bsps/sis-run.ini | 2 +- > tester/rtems/testing/bsps/sis.ini | 6 ++ > 2 files changed, 3

Re: [PATCH rtems-tools v4] tester/rtemstoolkit: add renode implementation

On Sun, Aug 6, 2023 at 11:05 PM Muhammad Sulthan Mazaya wrote: > > Add gpl to the prom binary file name + include the leon3 prom assembly > source with licensing commented > > --- > .../testing/bsps/kendrytek210-renode.ini | 38 > tester/rtems/testing/bsps/leon3-renode.ini| 37

Re: [PATCH rtems-tools v4] tester/rtemstoolkit: add renode implementation

Daniel / Gaisler: On Sun, Aug 6, 2023 at 11:05 PM Muhammad Sulthan Mazaya wrote: > > Add gpl to the prom binary file name + include the leon3 prom assembly > source with licensing commented > > --- > .../testing/bsps/kendrytek210-renode.ini | 38 >

Re: Status of CAN API?

Hi Phil, On Wed, Aug 9, 2023 at 6:38 AM Philip Kirkpatrick wrote: > > Hello, > > Some people on our team here at Reflex are preparing to implement some CAN > drivers. Specifically for TMS570 and for ZynqMP-RPU (side note my latest > patch for that on Jun 29th is still sitting there

Re: [PATCH] libdl: Add support to import base image TLS symbols

On Mon, Aug 14, 2023 at 10:05 PM wrote: > > From: Chris Johns > > This change requires an rtems-tools update for symbol generation. > > Working architectures: > - aarch64 > - arm > - powerpc > - sparc > > Updates #4920 > --- > cpukit/include/rtems/rtl/rtl-sym.h | 23 - >

Re: libdl support for base image TLS variables

On Mon, Aug 14, 2023 at 10:05 PM wrote: > > These patches add support to rtems.git and rtems-tools.git to > provide access to TLS variables in the base from loaded code. > The changes contain the ground work to resolving #4920 which is > a blocker for the release of 6. > > This change is required

Re: [PATCH 0/3] Revert CAN API

Thanks. I checked these in with one little change for a missed line in a spec file. On Thu, Jul 27, 2023 at 12:49 PM Joel Sherrill wrote: > > OK to revert. I didn't catch that it was 3 commits to revert cleanly. > > On Thu, Jul 27, 2023 at 1:28 PM Gedare Bloom wrote: >&

Re: [PATCH 2/3] Revert "build: Fix copyright statement format"

I'm just reverting this so I can delete the file cleanly in patch 3/3. On Thu, Jul 27, 2023 at 12:29 PM Joel Sherrill wrote: > > Ok. Are there others like this? > > On Thu, Jul 27, 2023, 1:28 PM Gedare Bloom wrote: >> >> This reverts commit 5b124432e27dd91f

Re: Pushing to 6.1

I'm bumping the tickets related to non-functional changes (style, copyright line / URLs, and third party tracking) until 7. I'd rather not hold up the release on their account, although I'm getting close it will take awhile yet to get everything in good order. On Thu, Jul 27, 2023 at 11:56 AM

[PATCH 1/3] Revert "cpukit/dev/can: Resolve warnings in 64bit builds"

This reverts commit 4c0a2d47e1dce0923f270d0206d0cb93d0d58451. --- cpukit/dev/can/can.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/cpukit/dev/can/can.c b/cpukit/dev/can/can.c index 9f3fe0db98..2e6d5df65b 100644 --- a/cpukit/dev/can/can.c +++

[PATCH 3/3] Revert "cpukit/dev/can: Added CAN support"

This reverts commit cd91b37dce728b372f164355719a4e601e12e7b3. Closes #4803. --- cpukit/dev/can/can.c | 505 --- cpukit/include/dev/can/can-msg.h | 105 - cpukit/include/dev/can/can.h | 284 -

[PATCH 2/3] Revert "build: Fix copyright statement format"

This reverts commit 5b124432e27dd91f66f71464b586cc369e15ec99. --- spec/build/testsuites/libtests/can01.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/build/testsuites/libtests/can01.yml b/spec/build/testsuites/libtests/can01.yml index 7597b1fffd..b5c1e1ae5c 100644

[PATCH 0/3] Revert CAN API

The CAN API is not mature enough for a release. This patch set reverts it. See #4803. I expect to revisit this during the 7 development cycle. Gedare Bloom (3): Revert "cpukit/dev/can: Resolve warnings in 64bit builds" Revert "build: Fix copyright statement format" Re

Re: [PATCH] eng: add Apache License 2.0 restriction

This looks fine to me. On Wed, Jul 26, 2023 at 10:29 AM Karel Gardas wrote: > > --- > eng/license-requirements.rst | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/eng/license-requirements.rst b/eng/license-requirements.rst > index

Re: style patches - discuss

On Tue, Jul 25, 2023 at 11:15 PM Sebastian Huber wrote: > > On 25.07.23 23:41, Gedare Bloom wrote: > > I have sent two initial patches to begin the style reformat. The > > clang-format file is not quite 100%, and it's also not usable by > > anyone else (as I wait fo

Re: [PATCH] score/arm: style fixes

On Tue, Jul 25, 2023 at 11:11 PM Sebastian Huber wrote: > > On 25.07.23 23:38, Gedare Bloom wrote: > > diff --git a/cpukit/score/cpu/arm/aarch32-psma-init.c > > b/cpukit/score/cpu/arm/aarch32-psma-init.c > > index 93a3673a98..b30cb5e308 100644 > > --- a/cpukit/sco

Re: [PATCH] eng: add Apache License 2.0 restriction

On Wed, Jul 26, 2023 at 4:28 AM Karel Gardas wrote: > > --- > eng/license-requirements.rst | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/eng/license-requirements.rst b/eng/license-requirements.rst > index b2720f2..b9eea9a 100644 > ---

Re: [PATCH] score/arm: style fixes

On Tue, Jul 25, 2023 at 5:03 PM Joel Sherrill wrote: > > > > On Tue, Jul 25, 2023 at 5:53 PM Gedare Bloom wrote: >> >> On Tue, Jul 25, 2023 at 4:48 PM Joel Sherrill wrote: >> > >> > I may have missed something. Commented in one place. >> > >

Re: [PATCH] score/arm: style fixes

l 25, 2023 at 4:38 PM Gedare Bloom wrote: >> diff --git a/cpukit/score/cpu/arm/armv7m-isr-dispatch.c >> b/cpukit/score/cpu/arm/armv7m-isr-dispatch.c >> index ea168969ba..dfc125d545 100644 >> --- a/cpukit/score/cpu/arm/armv7m-isr-dispatch.c >> +++ b/cpukit/sc

Re: style patches - discuss

https://git.rtems.org/gedare/rtems.git/log/?h=aarch64-reformat https://git.rtems.org/gedare/rtems.git/log/?h=arm-reformat On Tue, Jul 25, 2023 at 3:56 PM Chris Johns wrote: > > On 26/7/2023 7:41 am, Gedare Bloom wrote: > > I have sent two initial patches to begin the st

Re: [PATCH] score/arm: style fixes

On Tue, Jul 25, 2023 at 3:38 PM Gedare Bloom wrote: > > --- > cpukit/score/cpu/arm/__aeabi_read_tp.c| 2 +- > cpukit/score/cpu/arm/__tls_get_addr.c | 4 +- > .../score/cpu/arm/aarch32-psma-init-default.c | 2 +- > cpukit/score/cpu/arm/aarch32-psma

style patches - discuss

I have sent two initial patches to begin the style reformat. The clang-format file is not quite 100%, and it's also not usable by anyone else (as I wait for changes to be accepted upstream). A few things to note: * We can always manually override style with good reason. If you see something like

[PATCH] score/arm: style fixes

--- cpukit/score/cpu/arm/__aeabi_read_tp.c| 2 +- cpukit/score/cpu/arm/__tls_get_addr.c | 4 +- .../score/cpu/arm/aarch32-psma-init-default.c | 2 +- cpukit/score/cpu/arm/aarch32-psma-init.c | 82 - cpukit/score/cpu/arm/arm-exception-default.c | 6 +-

[PATCH] score/aarch64: style fixes

--- .../cpu/aarch64/aarch64-exception-default.c | 22 +-- .../aarch64/aarch64-exception-frame-print.c | 155 ++ .../score/cpu/aarch64/aarch64-thread-idle.c | 2 +- cpukit/score/cpu/aarch64/cpu.c| 61 --- 4 files changed, 132 insertions(+), 108

Re: [PATCH 8/8] sys: Add files to Doxygen group

On Tue, Jul 25, 2023 at 1:17 PM Gedare Bloom wrote: > > On Tue, Jul 25, 2023 at 11:31 AM Sebastian Huber > wrote: > > > > On 25.07.23 17:55, Gedare Bloom wrote: > > > priority.h and endian.h are imported code. We should modify with care. > > > I'm n

Re: [PATCH 8/8] sys: Add files to Doxygen group

On Tue, Jul 25, 2023 at 11:31 AM Sebastian Huber wrote: > > On 25.07.23 17:55, Gedare Bloom wrote: > > priority.h and endian.h are imported code. We should modify with care. > > I'm not opposed, we just have to think twice. > > endian.h is now actually in Newlib. We should

Re: [PATCH] build: Export BSP base and family via pkg-config

On Tue, Jul 25, 2023 at 11:11 AM Sebastian Huber wrote: > > > > On 25.07.23 18:01, Gedare Bloom wrote: > > On Tue, Jul 25, 2023 at 5:13 AM Sebastian Huber > > wrote: > >> This allows application and library build systems to derive option > >>

Re: [PATCH] import Apache License 2.0 text file

ok On Tue, Jul 25, 2023 at 10:17 AM Karel Gardas wrote: > > --- > LICENSE.Apache-2.0 | 202 + > 1 file changed, 202 insertions(+) > create mode 100644 LICENSE.Apache-2.0 > > diff --git a/LICENSE.Apache-2.0 b/LICENSE.Apache-2.0 > new file mode 100644

Re: [PATCH] build: Export BSP base and family via pkg-config

On Tue, Jul 25, 2023 at 5:13 AM Sebastian Huber wrote: > > This allows application and library build systems to derive option > values from the BSP base and family names. > --- > spec/build/bsps/pkgconfig.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 7/8] timecounter: Add files to Doxygen group

Same thing here, these are imported files. On Tue, Jul 25, 2023 at 2:49 AM Sebastian Huber wrote: > > Update #3707. > --- > cpukit/include/machine/_timecounter.h | 2 ++ > cpukit/include/sys/_ffcounter.h | 9 + > cpukit/include/sys/timeffc.h | 9 + >

Re: [PATCH 0/8] Add files to Doxygen groups

Looks good except my comment about the cpukit/include/sys files imported from Bsd On Tue, Jul 25, 2023 at 2:49 AM Sebastian Huber wrote: > > Frank Kühndel (1): > bsps/sparc: Add files to Doxygen groups > > Sebastian Huber (7): > libtest: Place files into a Doxygen group > rtems: Add files

Re: [PATCH 8/8] sys: Add files to Doxygen group

priority.h and endian.h are imported code. We should modify with care. I'm not opposed, we just have to think twice. On Tue, Jul 25, 2023 at 2:49 AM Sebastian Huber wrote: > > Canonicalize brief descriptions. > > Update #3707. > --- > cpukit/doxygen/top-level-groups.h | 8 >

Re: [PATCH v2] c-user: Link task entry and global construction

OK. Next time if you can just comment on the v1 that there's a v2. thanks On Sun, Jul 23, 2023 at 11:51 PM Sebastian Huber wrote: > > --- > v2: Mention global construction in application configuration options. > > c-user/config/classic-init-task.rst | 5 - > c-user/config/idle-task.rst

Re: [PATCH] c-user: Link task entry and global construction

looks good On Sat, Jul 22, 2023 at 4:54 AM Sebastian Huber wrote: > > --- > c-user/glossary.rst | 13 + > c-user/initialization/operations.rst | 25 +++-- > c-user/rtems_data_types.rst | 2 +- > c-user/task/directives.rst | 6

Re: [PATCH] membench: Add memory benchmark programs

On Mon, Jul 24, 2023 at 2:01 AM Sebastian Huber wrote: > > On 21.07.23 09:43, Chris Johns wrote: > > On 21/7/2023 3:28 pm, Sebastian Huber wrote: > >> On 21.07.23 03:27, Chris Johns wrote: > >>> On 21/7/2023 3:51 am, Sebastian Huber wrote: > >&g

Re: [PATCH] validation: Improve sparc/leon3 shutdown test

LGTM. If this will be repeated for other architectures in the future, it may be worth defining an expected fatal code. On Thu, Jul 20, 2023 at 3:57 AM Sebastian Huber wrote: > > Test the shutdown halt separately from the SMP-specific shutdown > request. > > Update #3716. > --- >

Re: [PATCH] c-user: Add glossary terms for SPARC targets

ok On Thu, Jul 20, 2023 at 6:48 AM Sebastian Huber wrote: > > --- > c-user/glossary.rst | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/c-user/glossary.rst b/c-user/glossary.rst > index 6102d88..df3b9a3 100644 > --- a/c-user/glossary.rst > +++

Re: [PATCH] doxgen: Document build system provided files

On Thu, Jul 20, 2023 at 7:20 AM Sebastian Huber wrote: > > Update #3707. > --- > cpukit/doxygen/build.h | 82 ++ > 1 file changed, 82 insertions(+) > create mode 100644 cpukit/doxygen/build.h > > diff --git a/cpukit/doxygen/build.h

Re: [PATCH 0/2] Add two unit tests

Looks good with a couple minor typo/grammar fixes. On Thu, Jul 20, 2023 at 7:40 AM Sebastian Huber wrote: > > > Frank Kühndel (2): > unit: Test POSIX-specific message queue impl > unit: Test unlimited objects configuration > > .../build/testsuites/unit/unit-no-clock-0.yml | 2 + >

Re: [PATCH 1/2] unit: Test POSIX-specific message queue impl

Minor nits. On Thu, Jul 20, 2023 at 7:40 AM Sebastian Huber wrote: > > From: Frank Kühndel > > This unit test covers code paths of the Message Handler which are only > reached by through POSIX message queue API. > > Update #3716. > --- > .../build/testsuites/unit/unit-no-clock-0.yml | 1 + >

Re: [PATCH] membench: Add memory benchmark programs

On Thu, Jul 20, 2023 at 7:42 AM Sebastian Huber wrote: > > These memory benchmark programs are not supposed to run. Instead, they > can be analysed on the host system to measure the memory usage of > features. See the membench module of rtems-central. > This needs some kind of documentation and

Re: Repository edit

I had a local copy of the two commits that were dropped during the rewinding. I have pushed them back. We are back to the state prior to the accidental push. Hashes all look good. Thanks for handling this. Gedare On Tue, Jul 18, 2023 at 7:55 PM Amar Takhar wrote: > > There was a mistaken push

Re: [PATCH rtems-tools] tester/rtems: add renode implementation

The patch has 3 whitespace errors. I have fixed them, and I will push this soon. On Tue, Jun 27, 2023 at 8:42 PM Muhammad Sulthan Mazaya wrote: > > Hi Joel and Chris, > > Yes, and I will be working on the rsb patch for renode installation next. > > Regards, > Mazaya > > On Wed, Jun 28, 2023 at

Re: [PATCH rtems-source-builder v2] bare/config: add renode rsb installation config

This patch applies cleanly and builds renode for me. Thanks for making the changes, this recipe should be much easier to maintain for version updates of renode. i will push it if no one complains soon. We will definitely need some documentation for building this. At the least you should start

Re: [PATCH] TMS570 console driver, SCI frame error (baudrate calculation error)

No, because we don't have a reproducible test case. On Fri, Jul 14, 2023 at 7:38 PM zack leung wrote: > > hi, so do you want me make this change? > > On Wed, 12 Jul 2023 at 10:54, Gedare Bloom wrote: >> >> On Wed, Jul 12, 2023 at 8:06 AM Joel Sherrill wrote: >> &g

Re: grlib changes Fwd: New Defects reported by Coverity Scan for RTEMS

Sebastian fixed it now. The local variable was shadowed. Another good reason to keep local variables at the start of a function ;) On Sat, Jul 15, 2023 at 9:38 AM Joel Sherrill wrote: > > > The recent grlib changes introduced a Coverity issues. > > -- Forwarded message - > From:

Re: [PATCH] TMS570 console driver, SCI frame error (baudrate calculation error)

e: >> >> Hello Zack and Gedare, >> >> On Tuesday 11 of July 2023 19:52:27 Gedare Bloom wrote: >> > Thanks for the patch. Someone should probably test it, or identify in >> > the documentation why this calculation was off-by-1. Pavel, any clues? >> > On Su

Re: [PATCH rtems-source-builder] bare/config: add renode rsb installation config

On Tue, Jul 11, 2023 at 12:01 PM Gedare Bloom wrote: > > This probably requires some documentation, as it requires several > packages that are not going to be typically installed already by RTEMS > users/developers. Chris, is there any place to document required > depend

Re: [PATCH rtems-source-builder] bare/config: add renode rsb installation config

This probably requires some documentation, as it requires several packages that are not going to be typically installed already by RTEMS users/developers. Chris, is there any place to document required dependencies/packages for a build set? The patch has a whitespace problem +# Renode source +#

Re: [PATCH] TMS570 console driver, SCI frame error (baudrate calculation error)

Hi Zack, Thanks for the patch. Someone should probably test it, or identify in the documentation why this calculation was off-by-1. Pavel, any clues? Gedare On Sun, Jul 9, 2023 at 10:09 PM zack wrote: > > Fixes #4903 > diff --git a/bsps/arm/tms570/console/tms570-sci.c >

Re: Need community suggestions for a new generic GPIO API

On Tue, Jul 11, 2023 at 7:05 AM Christian MAUDERER wrote: > > Hello Utkarsh, > > please be a bit careful with GPIO and pin functions. That's a quite > difficult topic. > > Some controller manufacturers mix these functions. One such example is > the STM32 family. I'll take the STM32F410 as an

  1   2   3   4   5   6   7   8   9   10   >