[PATCH rtems-source-builder] rtems-mipstx39-gdb-head.bset: Add missing file

2023-11-17 Thread Joel Sherrill
This configuration file was missing for the mipstx39 gdb build for the head/7 tools. Closes #4935. --- rtems/config/tools/rtems-mipstx39-gdb-head.bset | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 rtems/config/tools/rtems-mipstx39-gdb-head.bset diff --git

Re: [PATCH] build: Do not use coverage for librtemstest

2023-11-03 Thread Joel Sherrill
Ok. Push this. On Fri, Nov 3, 2023, 9:19 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 03.11.23 14:56, Joel Sherrill wrote: > > Does this mean that anything under tests and bsps will not have coverage? > > The tests itself are built without covera

Re: [PATCH] build: Do not use coverage for librtemstest

2023-11-03 Thread Joel Sherrill
Seems reasonable. Does this mean that anything under tests and bsps will not have coverage? --joel On Fri, Nov 3, 2023 at 3:58 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > The goal is to get code and branch coverage from actual tests and not > the test support itself. >

Re: [PATCH] libtest: Move parts to extra files

2023-11-03 Thread Joel Sherrill
Seems ok. On Fri, Nov 3, 2023 at 3:58 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Move the RTEMS test printer and rtems_test_exit() to separate files, to > remove dependencies from the begin/end test messsage support. > > Update #4963. > --- > cpukit/libtest/testbeginend.c

Re: [PATCH] testsuites/unit: Add tests for compiler builtins

2023-11-02 Thread Joel Sherrill
I noted a few cases where I don't think the value used is interesting enough or an edge case. Hopefully I caught them all. On Thu, Nov 2, 2023 at 7:12 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Test more compiler builtins which may use integer library routins: > routines.

Re: [PATCH] doxygen: Replace and move main page

2023-10-10 Thread Joel Sherrill
Sorry. Not sure how this kept slipping through the cracks. The 13 September ping did coincide with me being on a trip and then sick. This is the only revision I see in my inbox. There is an email which says "how about this version?" but I don't see anything on it. A few comments inline. On

Re: [RSB 1/3] 6/7: Update Newlib

2023-10-09 Thread Joel Sherrill
What caused all the recently posted tool build failures? On Mon, Oct 9, 2023, 4:52 PM Chris Johns wrote: > Ok to all patches in the series. Thanks for newlib changes for ARM, they > will be > nice to use. > > Chris > > On 10/10/2023 3:58 am, Sebastian Huber wrote: > > Pick up latest changes

Re: ADA, gnat, rtems 6, ubuntu 22LTS

2023-10-04 Thread Joel Sherrill
Random thought. Is there a gnat1? Can you build a native Ada hello world? I'm not sure what that configure check is trying but looking at that is the next step. On Wed, Oct 4, 2023, 12:02 PM emanuel stiebler wrote: > I just tried to compile the tools for rtems6, > and just with "C",

[PATCH rtems] fat_fat_operations.c: Fix incorrect indentation

2023-10-03 Thread Joel Sherrill
--- cpukit/libfs/src/dosfs/fat_fat_operations.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpukit/libfs/src/dosfs/fat_fat_operations.c b/cpukit/libfs/src/dosfs/fat_fat_operations.c index 24a408f9c7..1d94beb26a 100644 ---

Visit to Sunnyvale 11-13 October

2023-09-25 Thread Joel Sherrill
Hi Vijay and I will be attending the Google Summer of Code Mentor Summit the weekend of October 14-15. We are planning to fly out a bit early to give us a chance to schedule visits with RTEMS users, see your project in action as a site visit, and just have the opportunity to talk about your

Re: [PATCH 1/1] trace: build with c++17 if building against llvm 16+

2023-09-21 Thread Joel Sherrill
Are we doing something that particularly requires C++17? AFAIK we haven't needed it yet and why wouldn't it also be needed with gcc? If the default on recent gcc versions is that, ok but we should be precise in case an older gcc with a different default is used. This may also eliminate some

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Joel Sherrill
On Thu, Sep 14, 2023 at 4:33 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 14.09.23 10:51, Chris Johns wrote: > > On 14/9/2023 5:58 pm, Sebastian Huber wrote: > >> On 14.09.23 09:38, Chris Johns wrote: > > The issue I faced was no score interface to get the TLS base

Re: [PATCH 1/1] rtems-tools: stty rename / spelling bug.

2023-09-11 Thread Joel Sherrill
Thanks Sam. This is now committed. --joel On Mon, Sep 11, 2023 at 10:35 AM Sam Price wrote: > This patch fixes a spelling/rename mistake in rtems-tools. > > --- > tester/rt/stty.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tester/rt/stty.py b/tester/rt/stty.py >

Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Joel Sherrill
-3ea0c249346fda427bf0d3c169aa3e7c2a521df8/build invalid version file: module 'shlex' has no attribute 'join' Not sure what the common factor on all this is. --joel On Tue, Aug 29, 2023 at 8:23 AM Joel Sherrill wrote: > > > On Tue, Aug 29, 2023 at 5:48 AM Frank Kühndel < > frank.kuehn...@embedded-b

Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Joel Sherrill
On Tue, Aug 29, 2023 at 5:48 AM Frank Kühndel < frank.kuehn...@embedded-brains.de> wrote: > Hello Chris, > > On 8/29/23 12:45, Chris Johns wrote: > >> On 29 Aug 2023, at 6:24 pm, Frank Kühndel< > frank.kuehn...@embedded-brains.de> wrote: > >> > >> Hello Chris, > >> > >> our continuous

Re: [RSB PATCH] rtems/tools: Shell execute fixes

2023-08-28 Thread Joel Sherrill
Looks ok to push On Mon, Aug 28, 2023, 9:14 PM wrote: > From: Chris Johns > > Updates #4951 > --- > rtems/config/tools/rtems-tools-6.cfg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rtems/config/tools/rtems-tools-6.cfg > b/rtems/config/tools/rtems-tools-6.cfg >

Re: (libdl) Fwd: New Defects reported by Coverity Scan for RTEMS

2023-08-22 Thread Joel Sherrill
Done. On Mon, Aug 21, 2023 at 8:57 PM Chris Johns wrote: > On 22/8/2023 10:02 am, Gedare Bloom wrote: > > flag it as a false positive. > > I agree. > > > g7 is a global register that is reserved for system / compiler use in > > the sparc ABI > > The reigster is set up by the operating system

Re: (libdl) Fwd: New Defects reported by Coverity Scan for RTEMS

2023-08-21 Thread Joel Sherrill
val; }) I honestly don't know how to tell Coverity or GCC that this is reading a register we trust. On Mon, Aug 21, 2023 at 2:58 PM Chris Johns wrote: > Hi > > It is code from somewhere else so sorry I have no idea. > > Chris > > On 21 Aug 2023, at 11:33 pm, Joel Sherrill wrot

[PATCH rtems v1 10/10] x86_64/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- .../score/cpu/x86_64/include/rtems/score/cpuimpl.h | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/cpukit/score/cpu/x86_64/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/x86_64/include/rtems/score/cpuimpl.h index e0e301b6bc..726a515d4e 100644 ---

[PATCH rtems v1 08/10] sparc64/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/sparc64/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/sparc64/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/sparc64/include/rtems/score/cpuimpl.h index c49c637805..a29a519644 100644 ---

[PATCH rtems v1 07/10] sh/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/sh/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/sh/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/sh/include/rtems/score/cpuimpl.h index 3e37c8f57d..ca87c61c2b 100644 ---

[PATCH rtems v1 09/10] v850/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/v850/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/v850/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/v850/include/rtems/score/cpuimpl.h index 5ec528961c..3985c3cdb9 100644 ---

[PATCH rtems v1 05/10] mips/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/mips/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/mips/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/mips/include/rtems/score/cpuimpl.h index ad6b7ae615..d619eb6213 100644 ---

[PATCH rtems v1 04/10] m68k/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/m68k/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/m68k/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/m68k/include/rtems/score/cpuimpl.h index ec90a41ae2..4bee157215 100644 ---

[PATCH rtems v1 06/10] moxie/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/moxie/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/moxie/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/moxie/include/rtems/score/cpuimpl.h index 8ded8c34e9..30c2c75f2b 100644 ---

[PATCH rtems v1 03/10] lm32/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/lm32/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/lm32/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/lm32/include/rtems/score/cpuimpl.h index 679ef452f4..870640864c 100644 ---

[PATCH rtems v1 01/10] bfin/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/bfin/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/bfin/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/bfin/include/rtems/score/cpuimpl.h index 05628a2c0b..aaf34a3ce0 100644 ---

[PATCH rtems v1 02/10] i386/include/rtems/score/cpuimpl.h: Address unused parameter warning

2023-08-21 Thread Joel Sherrill
--- cpukit/score/cpu/i386/include/rtems/score/cpuimpl.h | 4 1 file changed, 4 insertions(+) diff --git a/cpukit/score/cpu/i386/include/rtems/score/cpuimpl.h b/cpukit/score/cpu/i386/include/rtems/score/cpuimpl.h index f0e4088218..ba5d820016 100644 ---

[PATCH rtems v1 00/10] Address unused parameter warnings

2023-08-21 Thread Joel Sherrill
Some of the architecture ports do not have implementations of the context validation methods. The stubs do not reference the parameter. This series of patches addresses that. I separated them so each port is distinct. --joel Joel Sherrill (10): bfin/include/rtems/score/cpuimpl.h: Address

Re: libdl support for base image TLS variables

2023-08-16 Thread Joel Sherrill
On Wed, Aug 16, 2023, 8:30 PM Chris Johns wrote: > On 17/8/2023 6:34 am, Gedare Bloom wrote: > > On Mon, Aug 14, 2023 at 10:05 PM wrote: > >> > >> These patches add support to rtems.git and rtems-tools.git to > >> provide access to TLS variables in the base from loaded code. > >> The changes

Re: [PATCH] fixes 4942 Regulator warnings

2023-08-15 Thread Joel Sherrill
Looks ok. I will adjust the message so it closes the ticket. On Mon, Aug 14, 2023 at 7:48 PM zack wrote: > diff --git a/cpukit/libmisc/regulator/regulator.c > b/cpukit/libmisc/regulator/regulator.c > index 2071c468fd..97a48be4f5 100644 > --- a/cpukit/libmisc/regulator/regulator.c > +++

Re: [PATCH] build: Make gzip archives reproducible

2023-08-12 Thread Joel Sherrill
This looks ok. Piling on Chris' comments about where is the requirement for this. This is a topic which must be addressed in the Software Engineering Guide and accepted before it can be put into practices. A software development process of any quality cannot be changed on a whim without

Defining BSP_SHARED_HANDLER_SUPPORT

2023-08-12 Thread Joel Sherrill
Hi Some BSPs define this in bsp.h or irq.h or similar. I see redefinition warnings on psim. Where should this be defined? bsps]$ grep -r BSP_SHARED_HANDLER_SUPPORT | grep define i386/include/bsp/irq.h:#define BSP_SHARED_HANDLER_SUPPORT 1 mips/csb350/include/bsp.h:#define

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

2023-08-11 Thread Joel Sherrill
Thanks. If you do turn up something once it is merged, there is always the option to fix it. :) Chris said I addressed his bigger concerns. Deletion and statistics. On Fri, Aug 11, 2023 at 12:32 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 11.08.23 00:14, Joel

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

2023-08-10 Thread Joel Sherrill
I should have asked if you want another round of patches or just go ahead and merge. This set of changes was pretty minor. --joel On Thu, Aug 10, 2023 at 5:13 PM Joel Sherrill wrote: > I think I have addressed all of your comments and Chris'. > > The conversion to rtems-central migh

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

2023-08-10 Thread Joel Sherrill
I think I have addressed all of your comments and Chris'. The conversion to rtems-central might be nice but it isn't going to happen soon. --joel On Thu, Aug 10, 2023 at 12:10 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 09.08.23 17:42, Joel Sherrill wrote: &g

Re: [PATCH] build: Make BUILD_LIBDL configurable

2023-08-10 Thread Joel Sherrill
It looks ok but why? It isn't built if not supported. It isn't a lot of code even if it is built. And it will not be in a user executable if they don't call it. I just don't see the point. --joel On Thu, Aug 10, 2023 at 6:03 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > ---

Re: [PATCH RTEMS] spec: Add -mstrict-align to mvme2100 default build

2023-08-09 Thread Joel Sherrill
Vijay.. go ahead and push this if you don't mind. I was just wondering if we could make a blanket statement that all motorola_powerpc variants need this flag. On Wed, Aug 9, 2023 at 12:01 PM Vijay Kumar Banerjee wrote: > On Wed, Aug 9, 2023 at 11:41 AM Joel Sherrill wrote: > > &g

Re: [PATCH RTEMS] spec: Add -mstrict-align to mvme2100 default build

2023-08-09 Thread Joel Sherrill
Reading the EPICS discussion, I wonder if this should be added for all motorola_powerpc BSP variants. Gedare/Chris/anyone with another board in the family? What do you think? --joel On Wed, Aug 9, 2023 at 11:14 AM Uchenna Ezeobi wrote: > On Wed, Aug 9, 2023 at 9:22 AM Joel Sherrill wr

[PATCH rtems-examples v3] Add regulator example

2023-08-09 Thread Joel Sherrill
CONFIGURE_MAXIMUM_PARTITIONS 1 +#define CONFIGURE_MAXIMUM_PERIODS 1 + +#define CONFIGURE_UNIFIED_WORK_AREAS +#define CONFIGURE_MINIMUM_TASK_STACK_SIZE (8 * 1024) + +#define CONFIGURE_INIT +#include diff --git a/misc/regulator/wscript b/misc/regulator/wscript new file mode 100644 index 000..4a4f8de --- /dev/null +++ b/mis

[PATCH rtems-docs v3] Add Regulator documentation based on V1 functionality

2023-08-09 Thread Joel Sherrill
--- README.txt | 19 +- c-user/index.rst| 1 + c-user/regulator/background.rst | 90 c-user/regulator/directives.rst | 549 c-user/regulator/index.rst | 19 +

[PATCH rtems v3 1/1] Add the Regulator Interface and test

2023-08-09 Thread Joel Sherrill
Updates #4924. The Regulator is an application support class which is used to deal with the scenario where there is a bursty input source which needs to be metered out to a destination sink. The maximum size of bursts needs to be known and the delivery method must be configured to deliver

[PATCH rtems v3 0/1] Regulator Patch Set

2023-08-09 Thread Joel Sherrill
to the Classic API Guide. Joel Sherrill (1): Add the Regulator Interface and test cpukit/include/rtems/regulator.h | 499 +++ cpukit/include/rtems/regulatorimpl.h | 135 ++ cpukit/libmisc/regulator/regulator.c | 683 + spec/build/cpukit/librtemscpu.yml

Re: [PATCH RTEMS] spec: Add -mstrict-align to mvme2100 default build

2023-08-09 Thread Joel Sherrill
I'm ok with this if there is a known case of an alignment exception that causes this. We didn't want to force it into every PowerPC BSP. Do you have a case that failed and was resolved by adding this? On Wed, Aug 9, 2023 at 7:36 AM Uchenna Ezeobi wrote: > Update #3767 > --- >

Re: [PATCH] samples/iostream: Produce proper begin/end message

2023-08-09 Thread Joel Sherrill
Looks ok to push. On Wed, Aug 9, 2023 at 3:37 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Print the full test information. > --- > testsuites/samples/iostream/init.cc | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] testproc/gsed: update from 4.8 to 4.9.

2023-08-05 Thread Joel Sherrill
I'm ok with this. Push it. On Sat, Aug 5, 2023, 1:27 PM Karel Gardas wrote: > Fixes #4938. > --- > bare/config/textproc/gsed-4.9.cfg | 12 > bare/config/textproc/gsed.cfg | 2 +- > 2 files changed, 13 insertions(+), 1 deletion(-) > create mode 100644

Odd warnings from spstdc17 from isrlock.h and scheduler.h

2023-08-04 Thread Joel Sherrill
Hi Noticed these building RTEMS for powerpc/psim today. SMP is disabled In file included from ../../../cpukit/include/rtems/rtems/intr.h:73, from ../../../cpukit/include/rtems.h:69, from ../../../testsuites/sptests/spstdc17/init.c:32:

Re: [PATCH] psxkey07: Fix POSIX key value pair configuration

2023-08-04 Thread Joel Sherrill
This looks ok to commit. On Fri, Aug 4, 2023 at 2:59 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Make sure we have enough POSIX key value pairs available. This fixes a > test > failure on some targets. > > Make objects and functions static. Initialize variable to get rid

Re: [PATCH] psxkey07: Fix POSIX key value pair configuration

2023-08-04 Thread Joel Sherrill
On Fri, Aug 4, 2023 at 2:59 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Make sure we have enough POSIX key value pairs available. This fixes a > test > failure on some targets. > > Make objects and functions static. Initialize variable to get rid of > warnings. > --- >

Re: [PATCH] bsps/shared: Fix Coverity warning in MCP7940M

2023-08-02 Thread Joel Sherrill
history with some of these static analysis triggered fixes where they are hard to get right. --joel > > Best regards > > Christian > > On 2023-08-02 13:43, Joel Sherrill wrote: > > Ok but out the Coverity Id number in the commit long message > > > > On Wed, A

Re: [PATCH] bsps/shared: Fix Coverity warning in MCP7940M

2023-08-02 Thread Joel Sherrill
Ok but out the Coverity Id number in the commit long message On Wed, Aug 2, 2023, 1:17 AM Christian Mauderer < christian.maude...@embedded-brains.de> wrote: > Coverity warns that (buf[...] & 0x7) can't be bigger than 7. This patch > removes the unnecessary comparison. > --- >

Fwd: New Defects reported by Coverity Scan for RTEMS

2023-08-02 Thread Joel Sherrill
New Coverity issue -- Forwarded message - From: Date: Wed, Aug 2, 2023, 12:22 AM Subject: New Defects reported by Coverity Scan for RTEMS To: Hi, Please find the latest report on new defect(s) introduced to RTEMS found with Coverity Scan. 1 new defect(s) introduced to RTEMS

Re: [PATCH RTEMS] mvme3100: Add BSP fatal extension

2023-08-01 Thread Joel Sherrill
On Tue, Aug 1, 2023 at 2:52 PM Vijay Kumar Banerjee wrote: > > > On Tue, Aug 1, 2023, 12:20 Joel Sherrill wrote: > >> >> >> On Tue, Aug 1, 2023, 11:41 AM Vijay Kumar Banerjee >> wrote: >> >>> --- >>> bsps/powerpc/mvme3100/start/bspc

Re: CVA6 RISC-V support

2023-08-01 Thread Joel Sherrill
Thanks for the submission. It's a bit hard to review with the patches as attachments rather than having been sent via git send-email but here goes. Hopefully someone with more RISC-V knowledge can comment also. 0001 - long comment appears to be one line. Please break into multiple lines. 0001

Re: [PATCH RTEMS] mvme3100: Add BSP fatal extension

2023-08-01 Thread Joel Sherrill
On Tue, Aug 1, 2023, 11:41 AM Vijay Kumar Banerjee wrote: > --- > bsps/powerpc/mvme3100/start/bspclean.c| 25 +++ > .../bsps/powerpc/mvme3100/bspmvme3100.yml | 1 + > 2 files changed, 26 insertions(+) > create mode 100644 bsps/powerpc/mvme3100/start/bspclean.c > >

Re: Fwd: [rtems-bsp-builder] 2023-07-31 17:37:34: Profile(s): everything

2023-08-01 Thread Joel Sherrill
yet and fix is > already awaiting review here: > > https://lists.rtems.org/pipermail/devel/2023-July/076043.html > > If you ok that, I may push... > > Thanks, > Karel > > > On 8/1/23 15:55, Joel Sherrill wrote: > > > > I think this started b

Fwd: [rtems-bsp-builder] 2023-07-31 17:37:34: Profile(s): everything

2023-08-01 Thread Joel Sherrill
I think this started before the fix was pushed but since there is no hash in this report, it is impossible to be sure. Since it already has to know about the rtems source tree, could it include a hash? How hard is that to implement? --joel -- Forwarded message - From: OAR Tester

Re: [PATCH rtems-tools v2] tester/rtemstoolkit: add renode implementation

2023-07-28 Thread Joel Sherrill
Generally looks good. We may have to discuss my renode script comments on Discord. It would be nice to have comments and licenses in them but may not be possible. On Fri, Jul 28, 2023 at 9:09 PM Muhammad Sulthan Mazaya < msulthanmaz...@gmail.com> wrote: > Add leon3 implementation for rtems-test

Re: Pushing to 6.1

2023-07-27 Thread Joel Sherrill
rel > > On 7/27/23 19:56, Joel Sherrill wrote: > > Hi > > > > The number of tickets is unfortunately not declining as I would like. > > This is in spite of us actually closing some previous tickets. > > > > + 32 in progress > > + 10 new > > >

Re: [PATCH 0/3] Revert CAN API

2023-07-27 Thread Joel Sherrill
OK to revert. I didn't catch that it was 3 commits to revert cleanly. On Thu, Jul 27, 2023 at 1:28 PM Gedare Bloom wrote: > The CAN API is not mature enough for a release. This patch set > reverts it. See #4803. > > I expect to revisit this during the 7 development cycle. > > Gedare Bloom (3):

Re: [PATCH 2/3] Revert "build: Fix copyright statement format"

2023-07-27 Thread Joel Sherrill
Ok. Are there others like this? On Thu, Jul 27, 2023, 1:28 PM Gedare Bloom wrote: > This reverts commit 5b124432e27dd91f66f71464b586cc369e15ec99. > --- > spec/build/testsuites/libtests/can01.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Pushing to 6.1

2023-07-27 Thread Joel Sherrill
Hi The number of tickets is unfortunately not declining as I would like. This is in spite of us actually closing some previous tickets. + 32 in progress + 10 new I do not know if the milestone for any of these can be changed but we need to work on this. Please look through the tickets and see

Re: [PATCH] doxygen: Replace main page

2023-07-27 Thread Joel Sherrill
On Thu, Jul 27, 2023 at 12:52 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 27.07.23 02:13, Joel Sherrill wrote: > > > > > > On Wed, Jul 26, 2023 at 12:50 AM Sebastian Huber > > > <mailto:sebastian.hu...@embedded-brains.

Re: style patches - discuss

2023-07-27 Thread Joel Sherrill
On Thu, Jul 27, 2023, 1:13 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 26.07.23 17:17, Gedare Bloom wrote: > > On Tue, Jul 25, 2023 at 11:15 PM Sebastian Huber > > wrote: > >> > >> On 25.07.23 23:41, Gedare Bloom wrote: > >>> I have sent two initial patches to begin

Re: [PATCH] doxygen: Replace main page

2023-07-26 Thread Joel Sherrill
On Wed, Jul 26, 2023 at 12:50 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Replace the main page with a high level description of the RTEMS feature > set similar to: > > https://docs.rtems.org/branches/master/user/overview/index.html#features > > The replaced content can be

Re: [PATCH] score/arm: style fixes

2023-07-25 Thread Joel Sherrill
On Tue, Jul 25, 2023 at 5:53 PM Gedare Bloom wrote: > On Tue, Jul 25, 2023 at 4:48 PM Joel Sherrill wrote: > > > > I may have missed something. Commented in one place. > > > > It looks like mostly spaces inside () and variable/parameter declaration > changes. >

Re: [PATCH] score/arm: style fixes

2023-07-25 Thread Joel Sherrill
I may have missed something. Commented in one place. It looks like mostly spaces inside () and variable/parameter declaration changes. On Tue, Jul 25, 2023 at 4:38 PM Gedare Bloom wrote: > --- > cpukit/score/cpu/arm/__aeabi_read_tp.c| 2 +- > cpukit/score/cpu/arm/__tls_get_addr.c

[PATCH rtems-docs 2/2] common/waf.py: Add option to check maximum Sphinx version

2023-07-25 Thread Joel Sherrill
Updates #4928. --- common/waf.py | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/common/waf.py b/common/waf.py index 0bd166a..6efe038 100644 --- a/common/waf.py +++ b/common/waf.py @@ -16,7 +16,11 @@ from waflib.Build import BuildContext import latex

[PATCH rtems-docs 1/2] layout.html: Revert patch forcing Spinx to >= 6.0

2023-07-25 Thread Joel Sherrill
Unfortunately, updating past Sphinx 5.x results in unordered bullet lists not formatting correctly as show in a screen capture attached to #4928. Revert this patch until the issue is resolved and output is reviewed for other potential issues. From: Utkarsh Verma Date: Wed, 14 Jun 2023

[PATCH rtems-docs 0/2] Sphinx Version Check

2023-07-25 Thread Joel Sherrill
commit? --joel Joel Sherrill (2): layout.html: Revert patch forcing Spinx to >= 6.0 common/waf.py: Add option to check maximum Sphinx version common/sphinx_rtd_theme_rtems/layout.html | 2 -- common/waf.py | 17 ++--- 2 files changed, 14 insertions(+), 5

Re: [PATCH] build: Add optional RTEMS_VERSION_VC_KEY

2023-07-25 Thread Joel Sherrill
On Tue, Jul 25, 2023 at 12:15 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 25.07.23 19:09, Joel Sherrill wrote: > > > > On Tue, Jul 25, 2023 at 10:12 AM Sebastian Huber > > > <mailto:sebastian.hu...@embedded-brains.de>> wrote: > &

Re: [PATCH] build: Export BSP base and family via pkg-config

2023-07-25 Thread Joel Sherrill
On Tue, Jul 25, 2023 at 12:19 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 25.07.23 19:15, Gedare Bloom wrote: > > On Tue, Jul 25, 2023 at 11:11 AM Sebastian Huber > > wrote: > >> > >> > >> On 25.07.23 18:01, Gedare Bloom wrote: > >>> On Tue, Jul 25, 2023 at 5:13 AM

Re: [PATCH] build: Add optional RTEMS_VERSION_VC_KEY

2023-07-25 Thread Joel Sherrill
On Tue, Jul 25, 2023 at 10:12 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Allow the user to set the version control key. > --- > spec/build/cpukit/grp.yml | 2 ++ > spec/build/cpukit/optversionvckey.yml | 20 ++ > wscript

Re: Outdated list of BSPs in rtems-tools/config

2023-07-25 Thread Joel Sherrill
On Tue, Jul 25, 2023 at 9:08 AM Christian MAUDERER < christian.maude...@embedded-brains.de> wrote: > Hello Joel, > > On 2023-07-25 15:46, Joel Sherrill wrote: > > > > > > On Tue, Jul 25, 2023 at 5:02 AM Christian MAUDERER > > > <mailto:

Re: [PATCH] score: Add workaround for GCC bug

2023-07-25 Thread Joel Sherrill
On Tue, Jul 25, 2023 at 8:55 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 25.07.23 15:52, Joel Sherrill wrote: > > Is something similar going to be needed for architecture and BSP > > specific IDLE threads? > > You have to run gcov to figure

Re: [PATCH] score: Add workaround for GCC bug

2023-07-25 Thread Joel Sherrill
Is something similar going to be needed for architecture and BSP specific IDLE threads? --joel On Tue, Jul 25, 2023 at 1:09 AM Chris Johns wrote: > OK > > Chris > > On 25/7/2023 4:04 pm, Sebastian Huber wrote: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108658 > > > > This GCC bug leads

Re: Outdated list of BSPs in rtems-tools/config

2023-07-25 Thread Joel Sherrill
On Tue, Jul 25, 2023 at 5:02 AM Christian MAUDERER < christian.maude...@embedded-brains.de> wrote: > Hello, > > I noted that some BSPs are missing in the config files in the > rtems-tools repo. If I didn't miss one it's: > > - aarch64, raspberrypi4b > - aarch64,

Re: [PATCH] score: Move _IO_Relax() to new

2023-07-24 Thread Joel Sherrill
On Mon, Jul 24, 2023 at 10:49 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 24.07.23 17:34, Joel Sherrill wrote: > > > > What about the other io methods in score like for gcov and hashing? > > Is there a better location for those? > > We cou

Re: [PATCH] score: Move _IO_Relax() to new

2023-07-24 Thread Joel Sherrill
No comments on this. Thanks and push it. I think you sent this the day we lost power for 8 hours. :( What about the other io methods in score like for gcov and hashing? Is there a better location for those? --joel On Mon, Jul 24, 2023 at 10:13 AM Sebastian Huber <

Re: [PATCH] fix type and logic issue when libbsd checking is enforced by the user code

2023-07-22 Thread Joel Sherrill
I'm not that familiar with this logic but your change looks right to me. Please.change the title from type to typo. It looks like a typo in your commitmto fix a typo. Lol I'm ok with you pushing this. --joel On Sat, Jul 22, 2023, 10:04 AM Karel Gardas wrote: > Fixes #4930. > --- >

Re: Building leon3 prom image for testing on renode

2023-07-20 Thread Joel Sherrill
On Wed, Jul 19, 2023 at 10:30 PM Alan Cudmore wrote: > Hi Mazaya, > > On Tue, Jul 18, 2023 at 8:35 PM Muhammad Sulthan Mazaya < > msulthanmaz...@gmail.com> wrote: > >> Hi Alan, >> >> > Also, as you mentioned, the renode Zephyr example runs directly from >> RAM without a prom image. Is it that

Regulator Delete

2023-07-19 Thread Joel Sherrill
Hi Starting another thread so we can focus on this without all the code in the way. Chris' concern was that deleting the regulator includes deleting the delivery thread and that could cause the delivery function to leave resources like mutexes in an unknown state. He asked about a coordinated

Re: [rtems-docs] user/bsp-build: Fix typo in BSP set builder command

2023-07-18 Thread Joel Sherrill
Good catch. Thanks. Committed. On Tue, Jul 18, 2023 at 3:25 PM Zainab Olalekan wrote: > From: Zainab Olalekan > > changed bsp to arch/bsp > --- > user/start/bsp-build.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/user/start/bsp-build.rst

Tooling Needed to Build rtems-docs

2023-07-18 Thread Joel Sherrill
Hi I ran into an issue with the output from rtems-docs. I tracked it down to a commit which moved up the minimum version of Sphinx required but didn't change the waf check. I will get to fixing that. In the mean time, I built a new VM for documentation but the README isn't much help on some of

Re: grlib changes Fwd: New Defects reported by Coverity Scan for RTEMS

2023-07-17 Thread Joel Sherrill
e. It had shadowed global variables and parameters. And we should get a Coverity email which says it is fixed. :) --joel > > On Sat, Jul 15, 2023 at 9:38 AM Joel Sherrill wrote: > > > > > > The recent grlib changes introduced a Coverity issues. > > > > -- Fo

grlib changes Fwd: New Defects reported by Coverity Scan for RTEMS

2023-07-15 Thread Joel Sherrill
The recent grlib changes introduced a Coverity issues. -- Forwarded message - From: Date: Sat, Jul 15, 2023 at 12:22 AM Subject: New Defects reported by Coverity Scan for RTEMS To: Hi, Please find the latest report on new defect(s) introduced to RTEMS found with Coverity

[PATCH rtems-examples v2] Add regulator example

2023-07-14 Thread Joel Sherrill
file mode 100644 index 0000000..4a4f8de --- /dev/null +++ b/misc/regulator/wscript @@ -0,0 +1,15 @@ +# Copyright 2023 Joel Sherrill (j...@rtems.org) +# +# This file's license is 2-clause BSD as in this distribution's LICENSE.2 file. +# + +# Waf build script for an RTEMS Hello +import rtems_waf.rtems as

[PATCH rtems v2] Add the Regulator Interface and test

2023-07-14 Thread Joel Sherrill
Updates #4924. The Regulator is an application support class which is used to deal with the scenario where there is a bursty input source which needs to be metered out to a destination sink. The maximum size of bursts needs to be known and the delivery method must be configured to deliver

[PATCH rtems v2 0/1] Regulator Patch Series

2023-07-14 Thread Joel Sherrill
to the Sink via DMA. In this case, the buffer would be released as part of processing DMA transfer complete. Joel Sherrill (1): Add the Regulator Interface and test cpukit/include/rtems/regulator.h | 439 ++ cpukit/include/rtems/regulatorimpl.h | 103 ++ cpukit/libmisc

Re: [PATCH rtems 6/6] bsps/imxrt: Add imxrt1166_cm7_saltshaker BSP

2023-07-14 Thread Joel Sherrill
On Fri, Jul 14, 2023 at 2:09 AM Christian MAUDERER < christian.maude...@embedded-brains.de> wrote: > Hello Jacob, > > On 2023-07-14 08:36, Christian MAUDERER wrote: > > Hello Jacob, > > > > On 2023-07-13 18:59, Jacob Killelea wrote: > >> Hi Christian, > >> > >> This looks awesome! Do you have any

Re: [PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files

2023-07-14 Thread Joel Sherrill
If someone doesn't pipe up with complaints or questions in the next few days, go ahead andcommit this. --joel On Fri, Jul 14, 2023 at 3:55 AM Karel Gardas wrote: > On 7/14/23 01:24, Joel Sherrill wrote: > > On Thu, Jul 13, 2023 at 4:11 PM Karel Gardas > > wrote: > >

Re: [PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files

2023-07-13 Thread Joel Sherrill
On Thu, Jul 13, 2023 at 4:11 PM Karel Gardas wrote: > > Folks, > > please take this patch as an attempt to renew old discussion or rather > start a new one focused solely on importing new ARM CMSIS code which is > (i) under Apache 2 license but (ii) without any NOTICE file. > The absence of a

Re: [PATCH] TMS570 console driver, SCI frame error (baudrate calculation error)

2023-07-12 Thread Joel Sherrill
Pavel this was filed as https://devel.rtems.org/ticket/4903. The ticket submitter didn't give a patch, just a code change snippet and explanation. Zack turned it into a patch. You will need to post that on the ticket to get the submitter's feedback. I hope you don't mind copying that to the

Re: [PATCH rtems-source-builder] bare/config: add renode rsb installation config

2023-07-12 Thread Joel Sherrill
On Tue, Jul 11, 2023 at 1:01 PM Gedare Bloom wrote: > This probably requires some documentation, as it requires several > packages that are not going to be typically installed already by RTEMS > users/developers. Chris, is there any place to document required > dependencies/packages for a build

Re: Need community suggestions for a new generic GPIO API

2023-07-12 Thread Joel Sherrill
On Tue, Jul 11, 2023 at 12:50 PM Gedare Bloom wrote: > On Tue, Jul 11, 2023 at 7:05 AM Christian MAUDERER > wrote: > > > > Hello Utkarsh, > > > > please be a bit careful with GPIO and pin functions. That's a quite > > difficult topic. > > > > Some controller manufacturers mix these functions.

Re: [PATCH] TMS570 console driver, SCI frame error (baudrate calculation error)

2023-07-11 Thread Joel Sherrill
First, the patch commit message needs to reference the ticket (#4903). It would be nice to have Pavel's feedback but the submitter of https://devel.rtems.org/ticket/4903 provided the fix but not in patch format. What do you think we should do beyond trust the submitter of the ticket?

Re: rtems_waf Include File Detection Question

2023-07-07 Thread Joel Sherrill
Thanks. With a bit of help from Kinsey, the regulator example is conditionally built-in rtems-examples only if the regulator.h header file is installed. On Wed, Jul 5, 2023 at 6:15 PM Chris Johns wrote: > On 6/7/2023 8:24 am, Joel Sherrill wrote: > > I have a case for an addition

[PATCH rtems-examples v1] Add regulator example

2023-07-07 Thread Joel Sherrill
AXIMUM_PARTITIONS 1 +#define CONFIGURE_MAXIMUM_PERIODS 1 + +#define CONFIGURE_UNIFIED_WORK_AREAS +#define CONFIGURE_MINIMUM_TASK_STACK_SIZE (8 * 1024) + +#define CONFIGURE_INIT +#include diff --git a/misc/regulator/wscript b/misc/regulator/wscript new file mode 100644 index 0000000..4a4f8de --- /dev/nu

[PATCH rtems v1] Add the Regulator Interface and test

2023-07-07 Thread Joel Sherrill
Updates #4924. The Regulator is an application support class which is used to deal with the scenario where there is a bursty input source which needs to be metered out to a destination sink. The maximum size of bursts needs to be known and the delivery method must be configured to deliver

What Happened to _Thread_Close?

2023-07-07 Thread Joel Sherrill
Hi Building the rtems-examples, the test fat_ramdisk gets a failure from rtems-tld because _Thread_Close is still listed in the ini files it uses. What symbols should be in the sections that currently have _Thread_Close? Small patch below my signature which just removes _Thread_Close

<    1   2   3   4   5   6   7   8   9   10   >