On Tue, May 14, 2024 at 10:39 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 14.05.24 17:11, Kinsey Moore wrote:
> > On Tue, May 14, 2024 at 1:28 AM Chris Johns > <mailto:chr...@rtems.org>> wrote:
> >
> > On 14/5/2024 4:04 pm,
On Tue, May 14, 2024 at 1:28 AM Chris Johns wrote:
> On 14/5/2024 4:04 pm, Sebastian Huber wrote:
> > Hello,
> >
> > the ZynqMP APU RAM start addresses are far away from 0x0:
> >
> > cat spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml
> > SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
On Wed, May 8, 2024 at 9:36 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 08.05.24 08:17, Sebastian Huber wrote:
> > Hello,
> >
> > on the arm target, we use this:
> >
> > static inline struct Per_CPU_Control *_ARM_Get_current_per_CPU_control(
> > void )
> > {
> >struct
Looks good, thanks!
Kinsey
On Tue, Apr 16, 2024 at 5:20 AM Ning Yang wrote:
> The clock from the ARM timer is derived from the system clock. This clock
> can
> change dynamically e.g. if the system goes into reduced power or in low
> power
> mode. Thus the clock speed adapts to the overall
On Wed, Apr 24, 2024 at 6:43 AM Peter Dufault wrote:
> > On Apr 23, 2024, at 5:45 PM, Vijay Kumar Banerjee
> wrote:
> > On Tue, Apr 23, 2024 at 1:02 PM Joel Sherrill wrote:
> >
> >
> > On Tue, Apr 23, 2024, 12:56 PM Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
> > - Am
On Thu, Apr 18, 2024 at 9:18 AM Peter Dufault wrote:
> I just rebased to "6-freebsd-12". This change:
>
> ###
> commit 62e0ca8283603573d42a0f15da044cd406a2f00a
> Author: Kinsey Moore
> Date: Tue Jan 23 13:25:45 2024 -0600
>
> rtemsbsd/rtems: Check funct
On Wed, Apr 17, 2024 at 12:51 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 16.04.24 16:51, Kinsey Moore wrote:
> > This adds warnings for arm_interrupt_enable_interrupts and
> > arm_interrupt_restore_interrupts. I suspect a missing header. They als
This adds warnings for arm_interrupt_enable_interrupts and
arm_interrupt_restore_interrupts. I suspect a missing header. They also
generate a link error on the a53_lp64_qemu bsp. I also dislike the
while(true), but I don't think we officially have anything against it and
there are existing
A couple of comments inline below.
On Fri, Apr 12, 2024 at 9:33 AM Ning Yang wrote:
> The clock from the ARM timer is derived from the system clock. This clock
> can change dynamically e.g. if the system goes into reduced power or in low
> power mode. Thus the clock speed adapts to the overall
:59 AM Ning Yang wrote:
> Hi Mr. Kinsey Moore:
>
> I am using the RPi4 BSP (project of GSOC2023) written by Utkarsh Verma.
> For some reason it wasn't merged.
> https://lists.rtems.org/pipermail/devel/2023-August/076152.html
> I got the code from his github: https://github.com/
I couldn't get this patch to apply. Are you sure it came from the right
branch and has no merge commits ahead of it?
Kinsey
On Wed, Apr 10, 2024 at 9:24 AM Ning Yang wrote:
> The clock from the ARM timer is derived from the system clock. This clock
> can change dynamically e.g. if the system
Beyond the rebase issue, this patch set looks good.
Kinsey
On Wed, Apr 10, 2024 at 6:16 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> Sebastian Huber (3):
> bsps/xil-ttc: Use interrupt entry
> bsps/xil-ttc: Add XIL_FATAL_TTC_IRQ_INSTALL
> bsps/xil-ttc: Improve clock
On Wed, Apr 10, 2024 at 6:16 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> ---
> bsps/shared/dev/clock/xil-ttc.c | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/bsps/shared/dev/clock/xil-ttc.c
> b/bsps/shared/dev/clock/xil-ttc.c
>
Hi Ning,
Patch 1 looks good. Instead of renaming it, you can include bcm2711.h in
the RPi4's raspberrypi.h or in bsp.h so that the RPi4 BSP remains largely
unchanged.
Kinsey
On Wed, Apr 10, 2024 at 2:14 AM yan...@qq.com wrote:
> Hi Mr. Kinsey Moore,
>
> Thank you very much for your he
One comment inline below.
On Tue, Apr 9, 2024 at 10:02 AM Ning Yang wrote:
> This patch moves the bcm2835 system timer driver in the arm/raspberrypi
> directory to the shared directory.
>
> Made some changes in the include section to adapt to rpi4 BSP.
> ---
> .../clockdrv.c =>
Hi Ning,
This patch set creates a duplication of the rpi3 system clock driver.
Instead, I'd suggest a different organization of the patch set:
Patch 1: Move the existing implementation to shared space and adjust BSPs
that use it as necessary.
Patch 2: Add support for the now-shared clock driver
Looks good to me.
Kinsey
On Wed, Apr 3, 2024 at 6:28 PM wrote:
> From: Chris Johns
>
> ---
> source-builder/sb-rtems-pkg | 29
> source-builder/sb/download.py | 5 +-
> source-builder/sb/git.py | 12 ++
> source-builder/sb/rtemspkg.py | 287 ++
On Wed, Apr 3, 2024 at 2:11 PM Chris Johns wrote:
> On 4 Apr 2024, at 3:52 am, Kinsey Moore wrote:
>
> Looks fine overall. Minor nits:
> "host" is set to "freebsd" and is never used.
>
>
> The tool uses simhost so it could be any host listed in t
Looks fine overall. Minor nits:
"host" is set to "freebsd" and is never used.
Numeric indexes for repo config details are nice for brevity, but not for
readability.
Kinsey
On Wed, Apr 3, 2024 at 11:29 AM Joel Sherrill
wrote:
> This looks handy. I don't have an issue with it.
>
> On Tue, Apr 2,
Ping
On Tue, Mar 5, 2024 at 4:13 PM Kinsey Moore
wrote:
> The 2020.2 version of Xilinx's qemu branch does not build on AArch64 due
> to a merge conflict that was integrated into the repository and never
> corrected. This brings qemu-xilinx up to 2023.2 to resolve that issue
&g
Ping
On Tue, Mar 5, 2024 at 4:13 PM Kinsey Moore
wrote:
> This updates glib to 2.56.4 for AArch64 build support.
> ---
> bare/config/devel/glib-2.56.4-1.cfg| 30 ++
> bare/config/devel/qemu-couverture.bset | 2 +-
> bare/config/devel/qemu-xilin
adable when I add
> even more of them.
>
> Kinsey Moore schrieb am Mo., 1. Apr. 2024,
> 16:39:
>
>> The intent of this patch is fine, but changes should be purely additive
>> and properly wrapped in the __rtems__ check. The addition of thread startup
>> at th
The intent of this patch is fine, but changes should be purely additive and
properly wrapped in the __rtems__ check. The addition of thread startup at
the end should also be wrapped in !NO_SYS.
Kinsey
On Sun, Mar 31, 2024 at 5:49 PM Bernd Moessner
wrote:
> Within xemac_add, the
You might be seeing different behavior than I have if you're running
single-core. Almost all my lwIP usage has been on 4 cores on the ZynqMP.
Kinsey
On Sun, Mar 31, 2024 at 5:49 PM Bernd Moessner
wrote:
> On my side, the link_detect_thread never gets to running state.
> I assume that the
This patch set looks good to me. I'd suggest a different file for the
versal unless there's a good name that can easily cover both.
Kinsey
On Wed, Mar 27, 2024 at 9:26 PM Chris Johns wrote:
> On 28/3/2024 6:43 am, Sebastian Huber wrote:
> > This helps to provide a shared implementation of the
Constant reinitializations for BSP_output_char causes loss of output
data on QEMU. This change only initializes the UART once.
---
bsps/arm/xilinx-zynqmp-rpu/console/console-config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/bsps/arm/xilinx-zynqmp-rpu/console/console-config.c
On Mon, Mar 25, 2024 at 3:34 PM Bernd Moessner
wrote:
>
> On 25.03.2024 13:26, Sebastian Huber wrote:
> > Hello,
> >
> > the BSPs for the Xilinx Zynq/ZynqMP/Versal platforms use code from
> > Xilinx. They also install some header files from Xilinx in the
> > top-level include directory of the
This adds some information about loading the RPU TCMs from A53 u-boot
and additional information about debugging the RPU within QEMU since it
is non-standard.
---
user/bsps/arm/xilinx-zynqmp-rpu.rst | 35 ++---
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git
On Mon, Mar 25, 2024 at 3:40 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> Hello,
>
> I noticed that the aarch64/xilinx-zynqmp BSPs use -mno-outline-atomics.
> However, we don't have a corresponding multilib for this. So for
> example, the C++ standard library still uses
This patch looks good. I would suggest dropping the a53 from the BSP name
since all AArch64 ZynqMP BSPs will run on the A53 cores.
Kinsey
On Mon, Mar 18, 2024 at 11:30 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> Add a BSP variant without a board-specific name.
> ---
>
This patch looks good.
Kinsey
On Mon, Mar 18, 2024 at 11:30 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> Add a BSP variant without a board-specific name.
> ---
> .../arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml | 87 +--
>
This patch looks good.
Kinsey
On Mon, Mar 18, 2024 at 11:30 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> ---
> spec/build/bsps/objxilinxsupportr5.yml | 3 +--
> spec/build/bsps/optxilsupportpath.yml | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
The xilinx-zynqmp-rpu bsp_reset() is modified, but not included in the spec
file for the new option. Its family differs from the arm/xilinx-zynqmp BSP
family with a -rpu suffix. I'd be fine with this being enabled for the
AArch64 BSPs as well, but I imagine that's better as a separate patch.
Sorry, I didn't realize I had tests turned off in my local build when I
checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well.
Kinsey
On Mon, Mar 18, 2024 at 4:15 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> This patch breaks the build:
>
> In file included
It should be in the repo now.
On Thu, Mar 14, 2024 at 12:50 PM zack leung
wrote:
> Did you check in the code?
>
> Il mar 12 mar 2024, 21:55 Kinsey Moore ha
> scritto:
>
>> Sorry, I missed this in the deluge of emails. Looks good to me.
>>
>> Kinsey
>>
This prototype should have been removed with commit
ac4db4cec5b6b1e0a25e910851e50831afb0749d.
---
rtemsbsd/include/rtems/bsd/bsd.h | 22 --
1 file changed, 22 deletions(-)
diff --git a/rtemsbsd/include/rtems/bsd/bsd.h b/rtemsbsd/include/rtems/bsd/bsd.h
index
Sorry, I missed this in the deluge of emails. Looks good to me.
Kinsey
On Tue, Mar 12, 2024 at 8:17 PM zack leung wrote:
> ping
>
> On Fri, 8 Mar 2024 at 22:03, wrote:
>
>> From: Zack leung
>>
>> ---
>> cpukit/doxygen/appl-config.h | 3 +--
>> cpukit/include/rtems/confdefs/clock.h
On Mon, Mar 11, 2024 at 6:18 AM Xin Zheng wrote:
> Hello everyone,
>
>
>
> I’m currently working with RTEMS for ARM architecture and I’m facing
> challenges locating the implementation details for arm-rtems5-gdb in the
> RTEMS source code. Despite my efforts, I have been unable to pinpoint the
>
Looks good to me. The overall effect of this is no functional change.
Thanks for the cleanup!
Kinsey
On Mon, Mar 11, 2024 at 8:25 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> The base addresses and IRQ numbers for UART 0 and 1 were interchanged.
> Fix this and set
When unmounting a JFFS2 filesystem, any outstanding write buffers must
be flushed to disk. In some circumstances, these write buffers are
instantiated by a garbage collection pass and as such no inode number is
associated with it. Due to the way that JFFS2 processes these garbage
collection
The tools build just fine and produce the expected version numbers where
checked. An AArch64 spot check looks good on qemu built from the release.
Kinsey
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
This updates glib to 2.56.4 for AArch64 build support.
---
bare/config/devel/glib-2.56.4-1.cfg| 30 ++
bare/config/devel/qemu-couverture.bset | 2 +-
bare/config/devel/qemu-xilinx.bset | 2 +-
bare/config/devel/qemu.bset| 2 +-
The 2020.2 version of Xilinx's qemu branch does not build on AArch64 due
to a merge conflict that was integrated into the repository and never
corrected. This brings qemu-xilinx up to 2023.2 to resolve that issue
and allow it to build on AArch64 systems.
---
When resetting the QSPI FIFOs, the driver was reading write-only bits of
a register for status information when it was actually in a different
register. This corrects the driver so that it reads the correct status
bits.
---
bsps/shared/dev/spi/xqspipsu.c | 15 +++
1 file changed, 15
Add an opportunistic page cache to the xnandpsu driver since it does not
implement partial page reads and common filesystem access patterns
perform multiple reads from the same page. This has been seen to provide
a 10x speedup to read speeds and a 2x speedup on first initialization
when used with
Zack,
It looks like there's been a little confusion here. Sebastian was
requesting that you condense the pair of #ifs into a single #if with && and
the defined check still coming first. It is mostly trivial in this
instance, but virtually every other example in the related files is of a
On Fri, Mar 1, 2024 at 8:40 AM Joel Sherrill
wrote:
> On Fri, Mar 1, 2024 at 8:21 AM Kinsey Moore
> wrote:
>
>> A very similar change was made in 2017 to resolve the same warning for a
>> different variable. The only real difference is that it is wrapped in
>> _
This resovles a warning where a variable could be used before it is
initialized in some code paths.
---
testsuites/benchmarks/dhrystone/dhry_1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testsuites/benchmarks/dhrystone/dhry_1.c
b/testsuites/benchmarks/dhrystone/dhry_1.c
index
<
sebastian.hu...@embedded-brains.de> wrote:
> On 28.02.24 19:15, Kinsey Moore wrote:
> > This resovles a warning where a variable could be used before it is
> > initialized in some code paths.
>
> I am not sure if we should modify benchmark code.
>
> --
> embedded brains
Applications and libraries compiled without the benefit of the lwIP
headers may require gethostbyname() instead of lwip_gethostbyname().
This wrapper allows those applicationns and libraries to link properly.
---
rtemslwip/common/network_compat.c | 6 ++
1 file changed, 6 insertions(+)
diff
Hi Seif,
Could you also provide a screenshot of the example running? This is part of
the requirements as per https://devel.rtems.org/wiki/GSoC
Thanks,
Kinsey
On Mon, Feb 26, 2024 at 12:26 PM Seif Alrahman Ahmed Mohamed Alfakharany <
seifelfakharany011434...@gmail.com> wrote:
>
>
This unused variable causes a warning. It is never set or used.
---
cpukit/libtest/testgcovdumpinfo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/cpukit/libtest/testgcovdumpinfo.c
b/cpukit/libtest/testgcovdumpinfo.c
index 1f32ceafcb..9687280e21 100644
---
This resovles a warning where a variable could be used before it is
initialized in some code paths.
---
testsuites/benchmarks/dhrystone/dhry_1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuites/benchmarks/dhrystone/dhry_1.c
b/testsuites/benchmarks/dhrystone/dhry_1.c
Thanks for taking this step toward participating in GSoC! I took a look at
the images in the binary patch and they look good. If you need to send more
images in the future, please use a link instead of sharing them in a binary
patch.
Kinsey
On Wed, Feb 28, 2024 at 2:33 AM Ning Yang wrote:
>
This disables any usage of the on-device R/W cache since all device
cache maintenance functions are compiled out under RTEMS leaving no way
to flush the cache before system reset and making data loss possible.
---
freebsd/sys/dev/mmc/mmcsd.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
This fixes a logic inversion that was preventing creation of a Bad Block
Table (BBT) from scratch on devices that lack one. This was discovered
during upstream integration testing. The BBT management layer in this
driver is not designed to be easily testable other than on real hardware.
---
This adds a test to very that remounting a completely used, but empty
NOR JFFS2 filesystem is possible. Previously, this triggered an edge
condition in the JFFS2 scan code that prevented remount of a correctly
formed and uncorrupted filesystem.
---
.../testsuites/fstests/fsjffs2empty01.yml |
On JFFS2 file systems on NOR flash or dataflash that does not have spare
area for metadata and thus does not invoke delayed writes, it is
possible to put the file system into a state where all blocks have been
written to and all files have been deleted from the filesystem. There is
a bug in the
This adds a pthread that runs the test as well to increase test
coverage. The original test would have passed if all threads returned
the address of the Init task's errno since no additional threads or
tasks were checked.
---
testsuites/libtests/dl11/dl-load.c | 72 +++---
Change the development suggestion for booting the R5 since the R5 u-boot
is only minimally functional without significant development. This also
adds caveats when booting the R5 cores from the A53.
---
user/bsps/arm/xilinx-zynqmp-rpu.rst | 14 --
1 file changed, 12 insertions(+), 2
The RAM origin had an unnecessary alignment requirement and the RAM
lenght had a reference that couldn't possibly be used. This removes
those obsolete option specifiers.
---
spec/build/bsps/arm/xilinx-zynqmp-rpu/optramlen.yml | 2 --
spec/build/bsps/arm/xilinx-zynqmp-rpu/optramori.yml | 1 -
2
On Wed, Feb 14, 2024 at 9:14 AM Sam Price wrote:
> I was wondering if you had any notes on your process of working with
> qemu in the rtems builder.
> I imagine you have your own xilinx qemu forked to work on, and then
> take the patches and integrate them into the rsb builder?
>
Nothing so
Stacked mode doubles the number of sectors and device size while
parallel mode doubles the sector size and the device size. Make sure
that this is accounted for in the device size accessor.
---
bsps/shared/dev/spi/xqspipsu-flash-helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
When the switch to waf occurred, the SMP support in i386 was left out
causing it to accumulate a minor amount of cruft. This enables SMP for
the i386 BSPs that support it and updates them for the API drift that
has occurred since the change.
---
cpukit/score/cpu/i386/cpu_asm.S | 2
GCC 13.2.0 adds new warnings/errors when mixing ints and enums. This
changes the pminsn helper type to correctly use enums.
---
bare/config/devel/qemu-xilinx-v2020.2-1.cfg | 7 +++
1 file changed, 7 insertions(+)
diff --git a/bare/config/devel/qemu-xilinx-v2020.2-1.cfg
---
bare/config/devel/autotools-base.bset | 2 +-
bare/config/devel/libtool-2.4.7-1.cfg | 17 +
bare/config/devel/libtool.bset| 2 +-
3 files changed, 19 insertions(+), 2 deletions(-)
create mode 100644 bare/config/devel/libtool-2.4.7-1.cfg
diff --git
On Mon, Feb 5, 2024 at 2:36 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> Hello Kinsey,
>
> On 02.02.24 23:03, Kinsey Moore wrote:
> > On JFFS2 file systems on NOR flash or dataflash that does not have spare
> > area for metadata and thus doe
On JFFS2 file systems on NOR flash or dataflash that does not have spare
area for metadata and thus does not invoke delayed writes, it is
possible to put the file system into a state where all blocks have been
written to and all files have been deleted from the filesystem. There is
a bug in the
---
bare/config/devel/qemu-5.2.0-1.cfg | 7 +++
1 file changed, 7 insertions(+)
diff --git a/bare/config/devel/qemu-5.2.0-1.cfg
b/bare/config/devel/qemu-5.2.0-1.cfg
index 3c8186b..ac476ad 100644
--- a/bare/config/devel/qemu-5.2.0-1.cfg
+++ b/bare/config/devel/qemu-5.2.0-1.cfg
@@ -43,6
Modern versions of pkg-config include new architecture-specific symlinks
that are sometimes checked before "pkg-config". This causes builds to
detect the system pkg-config instead of the local overridden pkg-config
and fail to build properly. This overrides those new symlinks to restore
build
QEMU used to honor LDFLAGS and CFLAGS and has since moved to accepting
them via --extra-cflags and --extra-ldflags options to configure.
---
source-builder/config/qemu-common-2.cfg | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/source-builder/config/qemu-common-2.cfg
This alters the API for rtems_cache_coherent_add_area to allow reporting
of failures that can occur during the process of adding a new area to
the coherent cache heap.
---
cpukit/include/rtems/rtems/cache.h | 7 -
cpukit/libcsupport/src/cachecoherentalloc.c | 30
On Thu, Jan 25, 2024 at 1:04 PM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 25.01.24 16:00, Kinsey Moore wrote:
> > -void rtems_cache_coherent_add_area(
> > +rtems_status_code rtems_cache_coherent_add_area(
> > void *area_begin,
This changes the return type for rtems_cache_coherent_add_area from void
to rtems_status_code so that the function can report errors when they
occur.
---
spec/rtems/cache/if/coherent-add-area.yml | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git
This alters the API for rtems_cache_coherent_add_area to allow reporting
of failures that can occur during the process of adding a new area to
the coherent cache heap.
---
cpukit/include/rtems/rtems/cache.h | 7 +-
cpukit/libcsupport/src/cachecoherentalloc.c | 27
On Thu, Jan 25, 2024 at 2:17 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
>
>
> On 24.01.24 18:19, Kinsey Moore wrote:
> > This changes the return type for rtems_cache_coherent_add_area from void
> > to rtems_status_code so that the func
---
cpukit/libblock/src/bdbuf.c | 2 +-
cpukit/libblock/src/blkdev-imfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpukit/libblock/src/bdbuf.c b/cpukit/libblock/src/bdbuf.c
index ee98ada85f..ee6f1d9347 100644
--- a/cpukit/libblock/src/bdbuf.c
+++
This is already in the error path.
---
cpukit/libblock/src/media.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpukit/libblock/src/media.c b/cpukit/libblock/src/media.c
index 1ab7dd2034..cc6bb70f91 100644
--- a/cpukit/libblock/src/media.c
+++ b/cpukit/libblock/src/media.c
This changes the return type for rtems_cache_coherent_add_area from void
to rtems_status_code so that the function can report errors when they
occur.
---
spec/rtems/cache/if/coherent-add-area.yml | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git
This alters the API for rtems_cache_coherent_add_area to allow reporting
of failures that can occur during the process of adding a new area to
the coherent cache heap.
---
cpukit/include/rtems/rtems/cache.h | 12 -
cpukit/libcsupport/src/cachecoherentalloc.c | 27
Patches 1 and 3 look good. I need to spend more time reviewing patch 2 than
I have right at this moment.
Kinsey
On Tue, Jan 23, 2024 at 11:22 PM wrote:
> Hi All,
>
> Attached are V2 of the patches that adds a wrapper around Xilinx's$
> XQspiPsu flash driver to rtems_flashdev. This has been
---
rtemsbsd/rtems/rtems-bsd-mountroot.c | 4 ++--
rtemsbsd/rtems/rtems-bsd-rc-conf.c | 14 ++
rtemsbsd/rtems/rtems-routes.c| 4 +++-
3 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/rtemsbsd/rtems/rtems-bsd-mountroot.c
---
rtemsbsd/rtems/rtems-bsd-rc-conf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/rtemsbsd/rtems/rtems-bsd-rc-conf.c
b/rtemsbsd/rtems/rtems-bsd-rc-conf.c
index f4cc987b..d34aafd9 100644
--- a/rtemsbsd/rtems/rtems-bsd-rc-conf.c
+++ b/rtemsbsd/rtems/rtems-bsd-rc-conf.c
---
rtemsbsd/rtems/rtems-bsd-rc-conf-net.c | 10 ++
rtemsbsd/rtems/rtems-bsd-syscall-api.c | 9 ++---
rtemsbsd/rtems/rtems-kernel-init.c | 4 +++-
rtemsbsd/rtems/rtems-kernel-pager.c| 4 +++-
4 files changed, 18 insertions(+), 9 deletions(-)
diff --git
This moves the ZynqMP-specific variable initialization to the start of
the function to avoid Coverity warnings.
---
rtemsbsd/sys/dev/sdhci/arasan_sdhci.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/rtemsbsd/sys/dev/sdhci/arasan_sdhci.c
---
rtemsbsd/rtems/rtems-kernel-lockmgr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/rtemsbsd/rtems/rtems-kernel-lockmgr.c
b/rtemsbsd/rtems/rtems-kernel-lockmgr.c
index 518f6831..de5d9d8a 100644
--- a/rtemsbsd/rtems/rtems-kernel-lockmgr.c
+++ b/rtemsbsd/rtems/rtems-kernel-lockmgr.c
@@
This is the 6-freebsd-12 version of the cleanup patch set. Coverity was
actually run against 6-freebsd-12, so this patch set is slightly larger
than the master patch set.
___
devel mailing list
devel@rtems.org
---
rtemsbsd/rtems/rtems-bsd-rc-conf.c | 14 ++
rtemsbsd/rtems/rtems-routes.c | 4 +++-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/rtemsbsd/rtems/rtems-bsd-rc-conf.c
b/rtemsbsd/rtems/rtems-bsd-rc-conf.c
index d34aafd9..88d98c3e 100644
---
---
rtemsbsd/rtems/rtems-bsd-rc-conf-net.c | 10 ++
rtemsbsd/rtems/rtems-kernel-init.c | 4 +++-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/rtemsbsd/rtems/rtems-bsd-rc-conf-net.c
b/rtemsbsd/rtems/rtems-bsd-rc-conf-net.c
index 23ee15db..8ffaa914 100644
---
---
rtemsbsd/rtems/rtems-bsd-rc-conf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/rtemsbsd/rtems/rtems-bsd-rc-conf.c
b/rtemsbsd/rtems/rtems-bsd-rc-conf.c
index f4cc987b..d34aafd9 100644
--- a/rtemsbsd/rtems/rtems-bsd-rc-conf.c
+++ b/rtemsbsd/rtems/rtems-bsd-rc-conf.c
This patch set cleans up several issues found by Coverity on the master
branch.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
---
cpukit/libblock/src/media.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpukit/libblock/src/media.c b/cpukit/libblock/src/media.c
index 482cdc4fb0..1ab7dd2034 100644
--- a/cpukit/libblock/src/media.c
+++ b/cpukit/libblock/src/media.c
@@ -519,7 +519,7 @@ static
Remove and simplify __rtems__ ifdefs in files that are now
authoritatively owned by rtems-lwip.
---
rtemslwip/common/sys_arch.c | 8
rtemslwip/include/arch/sys_arch.h | 21 -
rtemslwip/tms570/include/phy_dp83848h.h | 2 --
There have been some SMP compatibility issues seen on ZynqMP systems,
even with the recent patch to manage the active pbuf pool. It was
confirmed with Xilinx that this driver was never intended to run with
multiple cores available even though lwIP has multi-core support and
there doesn't appear to
On Mon, Jan 22, 2024 at 11:05 AM Gedare Bloom wrote:
> On Wed, Jan 17, 2024 at 1:48 AM wrote:
> >
> > From: Chengxiang Li
> >
> > avoid pclint err
> > ---
> > cpukit/score/cpu/aarch64/include/rtems/score/cpu.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
Change extend_count to uint32_t from uint16_t to avoid a possible
premature integer overflow when it is later used for multiplication.
---
cpukit/score/src/objectextendinformation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpukit/score/src/objectextendinformation.c
Fair enough. I'll update the patch. Thanks!
On Wed, Jan 17, 2024 at 12:45 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 16.01.24 21:02, Kinsey Moore wrote:
> > The two operands are 16 bit and the result is being saved into a
> > larger type. R
The tmp_fat_fd variable is unconditionally opened in the branch where it
is used within the loop and so must be closed or else risk a resource
leak.
---
cpukit/libfs/src/dosfs/msdos_dir.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
---
cpukit/libmisc/uuid/gen_uuid.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/cpukit/libmisc/uuid/gen_uuid.c b/cpukit/libmisc/uuid/gen_uuid.c
index 71b8a569bb..9b8dbeaa2e 100644
--- a/cpukit/libmisc/uuid/gen_uuid.c
+++ b/cpukit/libmisc/uuid/gen_uuid.c
@@ -343,11 +343,17 @@ static
Cast getpid() before shifting to avoid truncation of upper bits before
the 64bit XOR occurs.
---
cpukit/libmisc/uuid/gen_uuid.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/cpukit/libmisc/uuid/gen_uuid.c b/cpukit/libmisc/uuid/gen_uuid.c
index 9b8dbeaa2e..5601c887c9 100644
---
1 - 100 of 1006 matches
Mail list logo
