RE: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-22 Thread Alan Cudmore
...@rtems.org; rtems-de...@rtems.org; Hesham Moustafa; William MooreSubject: Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711 Hey Alan, Sorry for the late reply. So here's my plan. I initially thought of editing the raspberrypi.h and making it compatible for every RPi bsp. But I think I'll

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-22 Thread Noor Aman
y to integrate it with the existing RISC-V BSPs. > > > > Thanks for working on this! > > Alan > > > > > > *From: *Alan Cudmore > *Sent: *Thursday, July 21, 2022 10:59 PM > *To: *j...@rtems.org > *Cc: *Noor Aman ; rtems-de...@rtems.org > ; Hesham Moustafa ;

RE: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-22 Thread Alan Cudmore
to get input for the best way to integrate it with the existing RISC-V BSPs. Thanks for working on this!Alan  From: Alan CudmoreSent: Thursday, July 21, 2022 10:59 PMTo: j...@rtems.orgCc: Noor Aman; rtems-de...@rtems.org; Hesham Moustafa; William MooreSubject: Re: [PATCH] Arm/raspberrypi.h: Added

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Alan Cudmore
Joel, I don't think we need to commit the file now. Some suggestions: - Let's not put RPI2 or RPI3 defines or ifdefs in the file if it's only going to be for the Aarch64 RPI4 BSP - If it will be only used for the RPI4, it might be confusing to have the BCM2836 defines rather than using BCM2711 -

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Noor Aman
Sorry for that. I wanted a review for this so that's why included the gist too. I think instead of writing as a patch, I'll be using review. Thank you for the info. On Fri, Jul 22, 2022, 8:14 AM Chris Johns wrote: > On 22/7/2022 12:42 pm, Chris Johns wrote: > > On 22/7/2022 1:55 am, Noor Aman

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Chris Johns
On 22/7/2022 12:42 pm, Chris Johns wrote: > On 22/7/2022 1:55 am, Noor Aman wrote: >> A brief gist of what i found compatible with the older code >> ---COMPATIBLE HEADER--- >> - BCM2835 timer >> - GPIO >> - AUX >> - GPU timer >> ---DIDNT CHECK--- >> - SPI >> - I2C >> ---MINOR CHNAGE--- >> - IRQ >>

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Chris Johns
On 22/7/2022 1:55 am, Noor Aman wrote: > A brief gist of what i found compatible with the older code > ---COMPATIBLE HEADER--- > - BCM2835 timer > - GPIO > - AUX > - GPU timer > ---DIDNT CHECK--- > - SPI > - I2C > ---MINOR CHNAGE--- > - IRQ > - FIQ > ---NOT SURE ABOUT--- > - Watchdog > - Power

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Joel Sherrill
On Thu, Jul 21, 2022 at 12:32 PM Noor Aman wrote: > I dont think this would be visible to any other application until or > unless user explicitly include this header 'raspberrypi.h' in their > application. And as of now, this header is only placed in > bsps/arm/raspberrypi/includes. > Sorry. My

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Noor Aman
I dont think this would be visible to any other application until or unless user explicitly include this header 'raspberrypi.h' in their application. And as of now, this header is only placed in bsps/arm/raspberrypi/includes. For my project I'm thinking of using this header with my project with

Re: [PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Joel Sherrill
This looks generally ok but is all this visible to any application that includes bsp.h? It might all need to be moved into a separate header to avoid contaminating everyone's namespace. On Thu, Jul 21, 2022, 10:56 AM Noor Aman wrote: > A brief gist of what i found compatible with the older

[PATCH] Arm/raspberrypi.h: Added relevant headers for the bcm2711

2022-07-21 Thread Noor Aman
A brief gist of what i found compatible with the older code ---COMPATIBLE HEADER--- - BCM2835 timer - GPIO - AUX - GPU timer ---DIDNT CHECK--- - SPI - I2C ---MINOR CHNAGE--- - IRQ - FIQ ---NOT SURE ABOUT--- - Watchdog - Power management - Mailbox register I didnt get any info about power