No, because we don't have a reproducible test case.
On Fri, Jul 14, 2023 at 7:38 PM zack leung wrote:
>
> hi, so do you want me make this change?
>
> On Wed, 12 Jul 2023 at 10:54, Gedare Bloom wrote:
>>
>> On Wed, Jul 12, 2023 at 8:06 AM Joel Sherrill wrote:
>> >
>> >
>> > Pavel this was filed
hi, so do you want me make this change?
On Wed, 12 Jul 2023 at 10:54, Gedare Bloom wrote:
> On Wed, Jul 12, 2023 at 8:06 AM Joel Sherrill wrote:
> >
> >
> > Pavel this was filed as https://devel.rtems.org/ticket/4903. The ticket
> submitter
> > didn't give a patch, just a code change snippet an
On Wed, Jul 12, 2023 at 8:06 AM Joel Sherrill wrote:
>
>
> Pavel this was filed as https://devel.rtems.org/ticket/4903. The ticket
> submitter
> didn't give a patch, just a code change snippet and explanation. Zack turned
> it into
> a patch. You will need to post that on the ticket to get the s
Pavel this was filed as https://devel.rtems.org/ticket/4903. The ticket
submitter
didn't give a patch, just a code change snippet and explanation. Zack
turned it into
a patch. You will need to post that on the ticket to get the submitter's
feedback.
I hope you don't mind copying that to the ticket
Hello Zack and Gedare,
On Tuesday 11 of July 2023 19:52:27 Gedare Bloom wrote:
> Thanks for the patch. Someone should probably test it, or identify in
> the documentation why this calculation was off-by-1. Pavel, any clues?
> On Sun, Jul 9, 2023 at 10:09 PM zack wrote:
> > Fixes #4903
> > diff --
fixes #4903 adressing an error in the TMS570 console driver
---
bsps/arm/tms570/console/tms570-sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Fixes #4903
diff --git a/bsps/arm/tms570/console/tms570-sci.c
b/bsps/arm/tms570/console/tms570-sci.c
index 768770a4c8..59a0b7e6f1 100644
---
Fixes #4903
diff --git a/bsps/arm/tms570/console/tms570-sci.c
b/bsps/arm/tms570/console/tms570-sci.c
index 768770a4c8..59a0b7e6f1 100644
--- a/bsps/arm/tms570/console/tms570-sci.c
+++ b/bsps/arm/tms570/console/tms570-sci.c
@@ -311,7 +311,7 @@ bool tms570_sci_set_attributes(
/* Apply baudrate to
First, the patch commit message needs to reference the ticket (#4903).
It would be nice to have Pavel's feedback but the submitter of
https://devel.rtems.org/ticket/4903
provided the fix but not in patch format. What do you think we should do
beyond trust the
submitter of the ticket?
bsps/arm/tm
Hi Zack,
Thanks for the patch. Someone should probably test it, or identify in
the documentation why this calculation was off-by-1. Pavel, any clues?
Gedare
On Sun, Jul 9, 2023 at 10:09 PM zack wrote:
>
> Fixes #4903
> diff --git a/bsps/arm/tms570/console/tms570-sci.c
> b/bsps/arm/tms570/conso
Fixes #4903
diff --git a/bsps/arm/tms570/console/tms570-sci.c
b/bsps/arm/tms570/console/tms570-sci.c
index 768770a4c8..59a0b7e6f1 100644
--- a/bsps/arm/tms570/console/tms570-sci.c
+++ b/bsps/arm/tms570/console/tms570-sci.c
@@ -311,7 +311,7 @@ bool tms570_sci_set_attributes(
/* Apply baudrate to
---
bsps/arm/tms570/console/tms570-sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Fixes #4903
diff --git a/bsps/arm/tms570/console/tms570-sci.c
b/bsps/arm/tms570/console/tms570-sci.c
index 768770a4c8..59a0b7e6f1 100644
--- a/bsps/arm/tms570/console/tms570-sci.c
+++ b/bsps/arm/tms570
11 matches
Mail list logo
