Re: [PATCH] bsps/shared: Fix Coverity warning in MCP7940M

2023-08-02 Thread Christian MAUDERER
On 2023-08-02 15:31, Joel Sherrill wrote: On Wed, Aug 2, 2023 at 6:45 AM Christian MAUDERER > wrote: Hello Joel, thanks. Is the ID processed somewhere automatically so that I should use a special format? Otherwise I can just

Re: [PATCH] bsps/shared: Fix Coverity warning in MCP7940M

2023-08-02 Thread Joel Sherrill
On Wed, Aug 2, 2023 at 6:45 AM Christian MAUDERER < christian.maude...@embedded-brains.de> wrote: > Hello Joel, > > thanks. Is the ID processed somewhere automatically so that I should use > a special format? Otherwise I can just just add the error message from > covertity: > > ** CID 1539495:

Re: [PATCH] bsps/shared: Fix Coverity warning in MCP7940M

2023-08-02 Thread Christian MAUDERER
Hello Joel, thanks. Is the ID processed somewhere automatically so that I should use a special format? Otherwise I can just just add the error message from covertity: ** CID 1539495: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /bsps/shared/dev/rtc/mcp7940m.c: 317 in

Re: [PATCH] bsps/shared: Fix Coverity warning in MCP7940M

2023-08-02 Thread Joel Sherrill
Ok but out the Coverity Id number in the commit long message On Wed, Aug 2, 2023, 1:17 AM Christian Mauderer < christian.maude...@embedded-brains.de> wrote: > Coverity warns that (buf[...] & 0x7) can't be bigger than 7. This patch > removes the unnecessary comparison. > --- >

[PATCH] bsps/shared: Fix Coverity warning in MCP7940M

2023-08-02 Thread Christian Mauderer
Coverity warns that (buf[...] & 0x7) can't be bigger than 7. This patch removes the unnecessary comparison. --- bsps/shared/dev/rtc/mcp7940m.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bsps/shared/dev/rtc/mcp7940m.c b/bsps/shared/dev/rtc/mcp7940m.c index