Re: [PATCH] cpukit: Prevent error with disabled stack checker

2022-01-27 Thread Sebastian Huber
On 27/01/2022 15:54, Kinsey Moore wrote: This check is insufficient in SMP configurations. It also prevents a stack report without the stack usage information. This should be sufficient for SMP because it only needs to verify that the CPU interrupt stack information has been initialized for one

Re: [PATCH] cpukit: Prevent error with disabled stack checker

2022-01-27 Thread Kinsey Moore
On 1/27/2022 01:20, Sebastian Huber wrote: On 26/01/2022 23:07, Kinsey Moore wrote: diff --git a/cpukit/libmisc/stackchk/check.c b/cpukit/libmisc/stackchk/check.c index a2b63345d9..9119f8d940 100644 --- a/cpukit/libmisc/stackchk/check.c +++ b/cpukit/libmisc/stackchk/check.c @@ -487,6 +487,12

Re: [PATCH] cpukit: Prevent error with disabled stack checker

2022-01-26 Thread Sebastian Huber
On 26/01/2022 23:07, Kinsey Moore wrote: diff --git a/cpukit/libmisc/stackchk/check.c b/cpukit/libmisc/stackchk/check.c index a2b63345d9..9119f8d940 100644 --- a/cpukit/libmisc/stackchk/check.c +++ b/cpukit/libmisc/stackchk/check.c @@ -487,6 +487,12 @@ void

[PATCH] cpukit: Prevent error with disabled stack checker

2022-01-26 Thread Kinsey Moore
When the stack checker is not enabled, the stack checker reporting function can still be called. This prevents that call from performing a null memory access in trying to find the high water mark if the stack checker was never initialized. This also introduces a test to ensure this call does not