Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Sebastian Huber
On 29/01/2021 21:08, Sebastian Huber wrote: On 29/01/2021 20:58, dufa...@hda.com wrote: On Jan 29, 2021, at 13:59 , Gedare Bloom wrote: On Fri, Jan 29, 2021 at 11:38 AM Joel Sherrill wrote: On Fri, Jan 29, 2021, 12:28 PM Sebastian Huber wrote: On 29/01/2021 18:33, Peter Dufault

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Sebastian Huber
On 29/01/2021 20:58, dufa...@hda.com wrote: On Jan 29, 2021, at 13:59 , Gedare Bloom wrote: On Fri, Jan 29, 2021 at 11:38 AM Joel Sherrill wrote: On Fri, Jan 29, 2021, 12:28 PM Sebastian Huber wrote: On 29/01/2021 18:33, Peter Dufault wrote: Do not use an enum as a bit field.

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread dufault
> On Jan 29, 2021, at 13:59 , Gedare Bloom wrote: > > > > On Fri, Jan 29, 2021 at 11:38 AM Joel Sherrill > wrote: > > > On Fri, Jan 29, 2021, 12:28 PM Sebastian Huber > wrote: > On 29/01/2021 18:33, Peter Dufault wrote: > > >>> Do not use an enum as a bit field. Document the state

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Gedare Bloom
On Fri, Jan 29, 2021 at 11:38 AM Joel Sherrill wrote: > > > On Fri, Jan 29, 2021, 12:28 PM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> On 29/01/2021 18:33, Peter Dufault wrote: >> >> >>> Do not use an enum as a bit field. Document the state flags. >> >>> >> >>> >> >>> Is

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Sebastian Huber
On 29/01/2021 18:33, Peter Dufault wrote: Do not use an enum as a bit field. Document the state flags. Is this a new style rule that needs to be documented? Into which category would you put this? Language and Compiler? https://docs.rtems.org/branches/master/eng/coding-conventions.html

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Peter Dufault
> On Jan 29, 2021, at 11:37 , Gedare Bloom wrote: > > On Fri, Jan 29, 2021 at 9:03 AM Sebastian Huber > wrote: > On 29/01/2021 16:09, Joel Sherrill wrote: > > > On Fri, Jan 29, 2021 at 9:06 AM Gedare Bloom > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Gedare Bloom
On Fri, Jan 29, 2021 at 9:03 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 29/01/2021 16:09, Joel Sherrill wrote: > > > On Fri, Jan 29, 2021 at 9:06 AM Gedare Bloom > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 12:24 AM Sebastian Huber > >

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Sebastian Huber
On 29/01/2021 16:09, Joel Sherrill wrote: On Fri, Jan 29, 2021 at 9:06 AM Gedare Bloom > wrote: On Fri, Jan 29, 2021 at 12:24 AM Sebastian Huber mailto:sebastian.hu...@embedded-brains.de>> wrote: Do not use an enum as a bit field.  Document the state

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Joel Sherrill
On Fri, Jan 29, 2021 at 9:06 AM Gedare Bloom wrote: > > > On Fri, Jan 29, 2021 at 12:24 AM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> Do not use an enum as a bit field. Document the state flags. >> > Is this a new style rule that needs to be documented? > >> This fix

Re: [PATCH] score: Use defines for Thread_Life_state

2021-01-29 Thread Gedare Bloom
On Fri, Jan 29, 2021 at 12:24 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Do not use an enum as a bit field. Document the state flags. > > This fix relates to a Coverity issue (PW.MIXED_ENUM_TYPE). > --- > cpukit/include/rtems/score/thread.h | 57

[PATCH] score: Use defines for Thread_Life_state

2021-01-28 Thread Sebastian Huber
Do not use an enum as a bit field. Document the state flags. This fix relates to a Coverity issue (PW.MIXED_ENUM_TYPE). --- cpukit/include/rtems/score/thread.h | 57 - 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/cpukit/include/rtems/score/thread.h