Re: [PATCH 04/20] libchip/serial/ns16550* and z8530*: Assert on baud number to avoid divide by 0

2014-11-26 Thread Gedare Bloom
On Tue, Nov 25, 2014 at 6:02 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: From: Josh Oguin josh.og...@oarcorp.com This was flagged by CodeSonar. It should be impossible to get an incorrect baud number back but ensure this in debug mode. The _Assert() keeps their scanner from evaluating

Re: [PATCH 04/20] libchip/serial/ns16550* and z8530*: Assert on baud number to avoid divide by 0

2014-11-26 Thread Gedare Bloom
On Wed, Nov 26, 2014 at 2:36 AM, Chris Johns chr...@rtems.org wrote: On 26/11/2014 10:02 am, Joel Sherrill wrote: From: Josh Oguin josh.og...@oarcorp.com This was flagged by CodeSonar. It should be impossible to get an incorrect baud number back but ensure this in debug mode. The _Assert()

Re: [PATCH 04/20] libchip/serial/ns16550* and z8530*: Assert on baud number to avoid divide by 0

2014-11-26 Thread Joel Sherrill
On November 26, 2014 9:33:57 AM CST, Gedare Bloom ged...@rtems.org wrote: On Wed, Nov 26, 2014 at 2:36 AM, Chris Johns chr...@rtems.org wrote: On 26/11/2014 10:02 am, Joel Sherrill wrote: From: Josh Oguin josh.og...@oarcorp.com This was flagged by CodeSonar. It should be impossible to get

[PATCH 04/20] libchip/serial/ns16550* and z8530*: Assert on baud number to avoid divide by 0

2014-11-25 Thread Joel Sherrill
From: Josh Oguin josh.og...@oarcorp.com This was flagged by CodeSonar. It should be impossible to get an incorrect baud number back but ensure this in debug mode. The _Assert() keeps their scanner from evaluating for divide by 0 past this point. --- c/src/libchip/serial/ns16550-context.c | 4