Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 16/3/21 10:00 am, Joel Sherrill wrote: On Mon, Mar 15, 2021 at 5:58 PM Chris Johns > wrote: > On 16/3/21 9:11 am, Gedare Bloom wrote: > > On Mon, Mar 15, 2021 at 3:34 PM Alex White > >

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On Mon, Mar 15, 2021 at 5:58 PM Chris Johns wrote: > On 16/3/21 9:11 am, Gedare Bloom wrote: > > On Mon, Mar 15, 2021 at 3:34 PM Alex White > > wrote: > > > > I honestly can't remember why I changed 1024 to 20,000. > > > > I've looked back at that code and

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 16/3/21 9:11 am, Gedare Bloom wrote: > On Mon, Mar 15, 2021 at 3:34 PM Alex White > wrote: > > I honestly can't remember why I changed 1024 to 20,000. > > I've looked back at that code and changed it back to 1024 without any > issues. I think I

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 16/3/21 8:34 am, Alex White wrote: > I honestly can't remember why I changed 1024 to 20,000. > > I've looked back at that code and changed it back to 1024 without any issues. > I think I might have missed that this is all happening in a loop, and at one > point during a (long) debugging

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

; "entries" array as-is? > > I think that Chris' main points here are that, as you get covoar working again and cleaning it up, it should be made more C++ (and less C). > Alex > > -Original Message- > From: Chris Johns > Sent: Sunday, March 14, 2021 7:27 PM &

RE: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

2021 7:27 PM To: Alex White ; devel@rtems.org Subject: Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop On 12/3/21 5:30 am, Alex White wrote: > There was a potential that the branch info loop never terminated. > This has been fixed by adding a more reliable termination conditio

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 12/3/21 5:30 am, Alex White wrote: > There was a potential that the branch info loop never terminated. > This has been fixed by adding a more reliable termination condition > and logging an error if it cannot find the branch target. > --- > tester/covoar/CoverageReaderQEMU.cc | 11 +--

[PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

There was a potential that the branch info loop never terminated. This has been fixed by adding a more reliable termination condition and logging an error if it cannot find the branch target. --- tester/covoar/CoverageReaderQEMU.cc | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)