Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

2021-05-12 Thread Gedare Bloom
> > These three files in bsps/ should not be calling score functions > > directly, unless they implement part of the score CPU port. These > > don't seem to be doing that. This issue exists before this patch, but > > a ticket should be opened to fix this. A new API should be added for > >

Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

2021-05-11 Thread Sebastian Huber
On 11/05/2021 22:00, Gedare Bloom wrote: diff --git a/bsps/arm/altera-cyclone-v/rtc/rtc.c b/bsps/arm/altera-cyclone-v/rtc/rtc.c index 3e8c68e789..fb30da8d66 100644 --- a/bsps/arm/altera-cyclone-v/rtc/rtc.c +++ b/bsps/arm/altera-cyclone-v/rtc/rtc.c @@ -353,10 +353,9 @@ static int

Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

2021-05-11 Thread Gedare Bloom
On Tue, May 11, 2021 at 9:38 AM Sebastian Huber wrote: > > From: Frank Kühndel > > This patch fixes bug #4403. Directives > > * rtems_timer_fire_when() > * rtems_timer_server_fire_when() > * rtems_task_wake_when() > > are documented to return RTEMS_INVALID_ADDRESS when their time-of-day >

[PATCH 1/3] _TOD_Validate(): Fix incorrect return code

2021-05-11 Thread Sebastian Huber
From: Frank Kühndel This patch fixes bug #4403. Directives * rtems_timer_fire_when() * rtems_timer_server_fire_when() * rtems_task_wake_when() are documented to return RTEMS_INVALID_ADDRESS when their time-of-day argument is NULL. But actually they return RTEMS_INVALID_CLOCK. To fix the issue