On 22/07/2014 11:38 pm, Gedare Bloom wrote:
Thanks, I have added a section at
http://www.rtems.org/wiki/index.php/Coding_Conventions#Tools and
uploaded/linked to your configuration.
Why not add to the source tree with a note ? Wiki pages are great if you
know they exist !!
Chris
On 07/21/2014 10:23 PM, Gedare Bloom wrote:
One issue with rbtree formatting is in some places if/while conditional
expressions are put on the same line as the conditional statement. We
should prefer to put them explicitly on separate lines, since that is the
prevailing style of score and I have
On 07/21/2014 10:23 PM, Gedare Bloom wrote:
/* TODO: Error message? */
- if (!the_rbtree) return;
+ if ( !the_rbtree ) return;
Like here.
Ok, this is not an uncrustify bug. It was already a one-liner (like the
other). Unfortunately there is no option to wipe out one-liner.
--
Thanks, I have added a section at
http://www.rtems.org/wiki/index.php/Coding_Conventions#Tools and
uploaded/linked to your configuration.
-Gedare
On Tue, Jul 22, 2014 at 6:32 AM, Sebastian Huber
sebastian.hu...@embedded-brains.de wrote:
On 07/22/2014 12:22 PM, Sebastian Huber wrote:
On
---
cpukit/score/src/rbtree.c| 7 +-
cpukit/score/src/rbtreeextract.c | 152 +--
cpukit/score/src/rbtreefind.c| 7 +-
cpukit/score/src/rbtreeinsert.c | 69 ++
cpukit/score/src/rbtreeiterate.c | 12 ++--
There could be something wrong here but I don't see it on a quick review.
On 7/21/2014 11:31 AM, Sebastian Huber wrote:
---
cpukit/score/src/rbtree.c| 7 +-
cpukit/score/src/rbtreeextract.c | 152
+--
cpukit/score/src/rbtreefind.c| 7 +-
One issue with rbtree formatting is in some places if/while conditional
expressions are put on the same line as the conditional statement. We
should prefer to put them explicitly on separate lines, since that is the
prevailing style of score and I have added such a convention to our style
wiki
