Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-10 Thread Cillian O'Donnell
On Thu, 10 May 2018, 16:01 Vijay Kumar Banerjee, wrote: > > > On 8 May 2018 at 00:33, Cillian O'Donnell wrote: > >> Here's the branch with work in progress for the tester. Have a look when >> you can Vijay. >> >> https://github.com/cillianodonnell/rtems-tools/tree/tester-support >> >> >> I am go

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-10 Thread Vijay Kumar Banerjee
On 8 May 2018 at 00:33, Cillian O'Donnell wrote: > Here's the branch with work in progress for the tester. Have a look when > you can Vijay. > > https://github.com/cillianodonnell/rtems-tools/tree/tester-support > > > I am going through this now. according to your last commit message, the qemu.cf

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
On Mon, May 7, 2018 at 5:09 PM, Chris Johns wrote: > On 08/05/2018 07:32, Joel Sherrill wrote: > > On Mon, May 7, 2018 at 3:58 PM, Chris Johns > > wrote: > > > > On 08/05/2018 03:56, Joel Sherrill wrote: > > > > > > I have attached a workaround. > > > > L

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Chris Johns
On 08/05/2018 07:32, Joel Sherrill wrote: > On Mon, May 7, 2018 at 3:58 PM, Chris Johns > wrote: > > On 08/05/2018 03:56, Joel Sherrill wrote: > > > > I have attached a workaround. > > Looks like a solution to me. > > > Good enough for now. All basenam

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
On Mon, May 7, 2018 at 3:58 PM, Chris Johns wrote: > On 08/05/2018 03:56, Joel Sherrill wrote: > > > > I have attached a workaround. > > Looks like a solution to me. > Good enough for now. All basename() calls should come from rld. Eventually all dirname() calls should also. Luckily no file us

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Chris Johns
On 08/05/2018 03:56, Joel Sherrill wrote: > > I have attached a workaround. Looks like a solution to me. > It seems that libgen.h has this: > > > /* Return final component of PATH. > >    This is the weird XPG version of this function. 

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Chris Johns
On 08/05/2018 05:16, Cillian O'Donnell wrote: > Heres the gdb backtrace. rld-dwarf.cpp rld-path showing up near the bottom. I > don't have valgrind, I'll get it now and see what I find there. Thank you for the backtrace. I have fixed this. The rld::path::path_abs() call does not like the relative

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
Thanks. Definitely something in rld DWARF support. On Mon, May 7, 2018 at 2:36 PM, Cillian O'Donnell wrote: > Valgrind, Invalid read of size 8 > > cpod@cpod ~/development/rtems/leon3 $ valgrind covoar -S > /home/cpod/development/rtems/test/rtems-tools/tester/rtems/ > testing/coverage/score-sym

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
Valgrind, Invalid read of size 8 cpod@cpod ~/development/rtems/leon3 $ valgrind covoar -S /home/cpod/development/rtems/test/rtems-tools/tester/rtems/testing/coverage/score-symbols.ini -O /home/cpod/coverage_test/test/score -E/home/cpod/development/rtems/test/rtems-tools/tester/rtems/testing/covera

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
On Mon, May 7, 2018 at 2:16 PM, Cillian O'Donnell wrote: > Heres the gdb backtrace. rld-dwarf.cpp rld-path showing up near the > bottom. I don't have valgrind, I'll get it now and see what I find there. > > (gdb) bt > #0 0x774aa428 in __GI_raise (sig=sig@entry=6) > at ../sysdeps/unix

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
Heres the gdb backtrace. rld-dwarf.cpp rld-path showing up near the bottom. I don't have valgrind, I'll get it now and see what I find there. (gdb) bt #0 0x774aa428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x774ac02a in __GI_abort () at abor

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
On Mon, May 7, 2018 at 1:59 PM, Cillian O'Donnell wrote: > > > On 7 May 2018 at 18:56, Joel Sherrill wrote: > >> Hi >> >> I have attached a workaround. It seems that libgen.h has this: >> >> >> /* Return final component of PATH. >> >>T

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
Here's the branch with work in progress for the tester. Have a look when you can Vijay. https://github.com/cillianodonnell/rtems-tools/tree/tester-support On 7 May 2018 at 19:59, Cillian O'Donnell wrote: > > > On 7 May 2018 at 18:56, Joel Sherrill wrote: > >> Hi >> >> I have attached a workaro

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
On 7 May 2018 at 18:56, Joel Sherrill wrote: > Hi > > I have attached a workaround. It seems that libgen.h has this: > > > /* Return final component of PATH. > >This is the weird XPG version of this function. It sometimes will >mod

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Vijay Kumar Banerjee
On Mon, 7 May 2018, 23:26 Joel Sherrill, wrote: > Hi > > I have attached a workaround. It seems that libgen.h has this: > > > /* Return final component of PATH. > >This is the weird XPG version of this function. It sometimes will >

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
Hi I have attached a workaround. It seems that libgen.h has this: /* Return final component of PATH. This is the weird XPG version of this function. It sometimes will modify its argument. Therefore we normally use the GNU version (

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
On Mon, May 7, 2018 at 12:36 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > > On Mon, 7 May 2018, 22:57 Cillian O'Donnell, > wrote: > >> Yeah I'm seeing the same as Joel, at least were further then we were :). >> >> I've been mostly working on the rtems-tester support, so just to g

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Vijay Kumar Banerjee
On Mon, 7 May 2018, 22:57 Cillian O'Donnell, wrote: > Yeah I'm seeing the same as Joel, at least were further then we were :). > > I've been mostly working on the rtems-tester support, so just to give an > update. I spent all day Saturday and today on it. It's taking longer than > expected, re-or

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Cillian O'Donnell
Yeah I'm seeing the same as Joel, at least were further then we were :). I've been mostly working on the rtems-tester support, so just to give an update. I spent all day Saturday and today on it. It's taking longer than expected, re-orienting myself and deciding what is needed and not needed now w

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Vijay Kumar Banerjee
On Mon, 7 May 2018, 20:10 Joel Sherrill, wrote: > > > On Mon, May 7, 2018 at 6:01 AM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> I have added the path to libdwarf here >> > > That worked for me to build but not to link. > > I'm not sure why this rld symbol turned up missing on

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Joel Sherrill
On Mon, May 7, 2018 at 6:01 AM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > I have added the path to libdwarf here > That worked for me to build but not to link. I'm not sure why this rld symbol turned up missing on Centos 7. $

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Vijay Kumar Banerjee
I have added the path to libdwarf here --- diff --git a/tester/covoar/wscript b/tester/covoar/wscript index 55d5ec9..dd4ad83 100644 --- a/tester/covoar/wscript +++ b/tester/covoar/wscript @@ -63,6 +63,7 @@ def build(bld): rtl_includes = [rtemstoolkit, rtemstoolkit + '/elf

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-07 Thread Vijay Kumar Banerjee
On 6 May 2018 at 13:29, Chris Johns wrote: > On 6/5/18 5:28 pm, Vijay Kumar Banerjee wrote: > >> On 6 May 2018 at 08:54, Chris Johns > chr...@rtems.org>> wrote: >> >> Would you please try `waf clean build` to see if rebuilding >> everything fixes this? >> >> still getting the same

Re: Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-06 Thread Chris Johns
On 6/5/18 5:28 pm, Vijay Kumar Banerjee wrote: On 6 May 2018 at 08:54, Chris Johns > wrote: Would you please try `waf clean build` to see if rebuilding everything fixes this? still getting the same error . I'm using g++ 7.3.1 on fedora 27. OK If you h

Fwd: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-06 Thread Vijay Kumar Banerjee
On 6 May 2018 at 08:54, Chris Johns wrote: > On 6/5/18 9:49 am, Chris Johns wrote: > >> On 6/5/18 7:54 am, Vijay Kumar Banerjee wrote: >> >>> On 6 May 2018 at 03:05, Chris Johns >> chr...@rtems.org>> >>> wrote: >>> >>> Could you please check covoar’s wscript has the libdwarf path added? >>>

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
On 6/5/18 9:49 am, Chris Johns wrote: On 6/5/18 7:54 am, Vijay Kumar Banerjee wrote: On 6 May 2018 at 03:05, Chris Johns mailto:chr...@rtems.org>> wrote: Could you please check covoar’s wscript has the libdwarf path added? the path to elftoolchain/libdwarf is not added in covoar Thanks

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
On 6/5/18 7:54 am, Vijay Kumar Banerjee wrote: > On 6 May 2018 at 03:05, Chris Johns > > wrote: > > Could you please check covoar’s wscript has the libdwarf path added? > > the path to elftoolchain/libdwarf is not added in covoar  > Thanks. I am on FreeBSD and it u

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
On 6 May 2018 at 03:05, Chris Johns wrote: > > On 6 May 2018, at 7:04 am, Vijay Kumar Banerjee > wrote: > > > On 6 May 2018 at 02:25, Cillian O'Donnell wrote: > >> >> >> On 5 May 2018 at 21:12, Chris Johns wrote: >> >>> >>> >>> > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: >>> > >>> > Loo

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
> On 6 May 2018, at 7:04 am, Vijay Kumar Banerjee > wrote: > > >> On 6 May 2018 at 02:25, Cillian O'Donnell wrote: >> >> >>> On 5 May 2018 at 21:12, Chris Johns wrote: >>> >>> >>> > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: >>> > >>> > Looks similar to Cillian's failure. Chris wi

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
On 6 May 2018 at 02:25, Cillian O'Donnell wrote: > > > On 5 May 2018 at 21:12, Chris Johns wrote: > >> >> >> > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: >> > >> > Looks similar to Cillian's failure. Chris will have to show me where >> libdwarf comes from. It needs to be supplied with RTEM

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Cillian O'Donnell
On 5 May 2018 at 21:12, Chris Johns wrote: > > > > On 6 May 2018, at 2:44 am, Joel Sherrill wrote: > > > > Looks similar to Cillian's failure. Chris will have to show me where > libdwarf comes from. It needs to be supplied with RTEMS tools for > consistency. > > You need to apply the patches aga

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
> On 6 May 2018, at 2:44 am, Joel Sherrill wrote: > > Looks similar to Cillian's failure. Chris will have to show me where libdwarf > comes from. It needs to be supplied with RTEMS tools for consistency. You need to apply the patches against master. I added libdwarf to master the other day.

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Joel Sherrill
Looks similar to Cillian's failure. Chris will have to show me where libdwarf comes from. It needs to be supplied with RTEMS tools for consistency. On Sat, May 5, 2018, 11:20 AM Vijay Kumar Banerjee wrote: > In file included from ../rtemstoolkit/rld-dwarf.h:29:0, > from ../teste

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
In file included from ../rtemstoolkit/rld-dwarf.h:29:0, from ../tester/covoar/ExecutableInfo.h:14, from ../tester/covoar/DesiredSymbols.h:17, from ../tester/covoar/app_common.h:11, from ../tester/covoar/app_common.cc:40: ../rtemsto

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Joel Sherrill
On Sat, May 5, 2018, 10:57 AM Vijay Kumar Banerjee wrote: > Hello, > > I'm getting this build failure after applying this patch > > --- > Build failed > -> task in 'ccovoar' failed with exit status 1: > {task 140086064254560: cxx app_common.cc -> app_common.cc.1.o} > ['/usr/bin/g++', '-std=c++11

Re: [PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Vijay Kumar Banerjee
Hello, I'm getting this build failure after applying this patch --- Build failed -> task in 'ccovoar' failed with exit status 1: {task 140086064254560: cxx app_common.cc -> app_common.cc.1.o} ['/usr/bin/g++', '-std=c++11', '-O2', '-g', '-Itester/covoar', '-I../tester/covoar', '-Irtemstoolkit', '

[PATCH 2/4] covoar: Use DWARF to map addresses to source files and lines.

2018-05-05 Thread Chris Johns
--- tester/covoar/DesiredSymbols.cc | 122 ++-- tester/covoar/ExecutableInfo.cc | 80 +- tester/covoar/ExecutableInfo.h | 41 +++--- tester/covoar/covoar.cc | 2 +- tester/covoar/wscript | 2 +- 5 files ch