Re: [PATCH 5/7] score: Optimize object lookup

2018-12-09 Thread Chris Johns
On 07/12/2018 01:57, Sebastian Huber wrote: > I used the new test framework Sebastian, this is a general note on the test framework proposal. It looks interesting and what it shows here is great but I currently have no time to spend on this and I feel it deserves more than a brief examination. I

Re: [PATCH 5/7] score: Optimize object lookup

2018-11-27 Thread Sebastian Huber
On 26/11/2018 14:12, Sebastian Huber wrote: The local table no longer needs a NULL pointer entry at array index zero. Adjust all the object iteration loops accordingly. I think this is the only problematic change. Previously the local table was organized like this: Objects_Control

[PATCH 5/7] score: Optimize object lookup

2018-11-26 Thread Sebastian Huber
Use the maximum ID for the ID to object translation. Using the maximum ID gets rid of an additional load from the object information in _Objects_Get(). In addition, object lookups fail for every ID in case the object information is cleared to zero. This makes it a bit more robust during system