Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Joel Sherrill
On Thu, Apr 29, 2021 at 1:37 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 29/04/2021 20:12, Joel Sherrill wrote: > > > I'm not so ok because now the score has symbols for the Classic API > > and pthreads in it. > > > > The point of putting a method shared by both in the

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Sebastian Huber
On 29/04/2021 20:12, Joel Sherrill wrote: I'm not so ok because now the score has symbols for the Classic API and pthreads in it. The point of putting a method shared by both in the score was to avoid contaminating the score with information about the APIs or the the APIs with knowledge of

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Joel Sherrill
I'm not so ok because now the score has symbols for the Classic API and pthreads in it. The point of putting a method shared by both in the score was to avoid contaminating the score with information about the APIs or the the APIs with knowledge of each other. I think we still need separate files

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Gedare Bloom
ok On Thu, Apr 29, 2021 at 7:18 AM Sebastian Huber wrote: > > This may reduce the code size a bit. > --- > cpukit/Makefile.am | 3 +- > cpukit/include/rtems/score/threadimpl.h | 7 > cpukit/posix/src/pthreadself.c | 32 --- >

[PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Sebastian Huber
This may reduce the code size a bit. --- cpukit/Makefile.am | 3 +- cpukit/include/rtems/score/threadimpl.h | 7 cpukit/posix/src/pthreadself.c | 32 --- cpukit/rtems/src/taskself.c | 28 - cpukit/score/src/threadselfid.c