Re: [PATCH v2] bsps/beagle: register i2c device at initialization

2019-09-19 Thread Christian Mauderer
Thanks for the patch. Now it's OK and I pushed it (with an indentation fix). Best regards Christian On 19/09/2019 20:56, Vijay Kumar Banerjee wrote: > > > > On Fri, Sep 20, 2019 at 12:08 AM Christian Mauderer > wrote: > > On 19/09/2019 19:48, Vijay Kumar Baner

Re: [PATCH v2] bsps/beagle: register i2c device at initialization

2019-09-19 Thread Vijay Kumar Banerjee
On Fri, Sep 20, 2019 at 12:08 AM Christian Mauderer wrote: > On 19/09/2019 19:48, Vijay Kumar Banerjee wrote: > > > > > > > > On Thu, Sep 19, 2019 at 10:05 PM Christian Mauderer > > wrote: > > > > Hello Vijay, > > > > sorry for being picky: What happens if some

Re: [PATCH v2] bsps/beagle: register i2c device at initialization

2019-09-19 Thread Christian Mauderer
On 19/09/2019 19:48, Vijay Kumar Banerjee wrote: > > > > On Thu, Sep 19, 2019 at 10:05 PM Christian Mauderer > wrote: > > Hello Vijay, > > sorry for being picky: What happens if something goes wrong during that > initialization? For example: If the syste

Re: [PATCH v2] bsps/beagle: register i2c device at initialization

2019-09-19 Thread Vijay Kumar Banerjee
On Thu, Sep 19, 2019 at 10:05 PM Christian Mauderer wrote: > Hello Vijay, > > sorry for being picky: What happens if something goes wrong during that > initialization? For example: If the system has a configuration where > /dev/i2c0 can't be created. In that case it will just silently fail to > c

Re: [PATCH v2] bsps/beagle: register i2c device at initialization

2019-09-19 Thread Christian Mauderer
Hello Vijay, sorry for being picky: What happens if something goes wrong during that initialization? For example: If the system has a configuration where /dev/i2c0 can't be created. In that case it will just silently fail to create the i2c-0 which maybe leads to odd errors later. There's already

[PATCH v2] bsps/beagle: register i2c device at initialization

2019-09-18 Thread Vijay Kumar Banerjee
--- bsps/arm/beagle/i2c/bbb-i2c.c | 6 +++--- bsps/arm/beagle/include/bsp/i2c.h | 10 -- bsps/arm/beagle/start/bspstart.c | 16 3 files changed, 19 insertions(+), 13 deletions(-) diff --git a/bsps/arm/beagle/i2c/bbb-i2c.c b/bsps/arm/beagle/i2c/bbb-i2c.c index 37b888