Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Joel Sherrill
On 10/30/2014 8:39 AM, Sebastian Huber wrote: On 28/10/14 16:17, Jennifer Averett wrote: +/* Count the number of tasks and sort this load value */ +task_count++; +for (i = 0; i RTEMS_CPUUSAGE_TOP_MAX_LOAD_TASKS; i++) { + if (load_tasks[i]) {

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Gedare Bloom
I missed reviewing this patch earlier, but there are some style problems with it, please fix them on the head. On Tue, Oct 28, 2014 at 11:17 AM, Jennifer Averett jenni...@rtems.org wrote: Module:rtems Branch:master Commit:6031da438d219c6ec5d9d48f1df2aef91710cce3 Changeset:

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Joel Sherrill
FWIW she is jennifer.aver...@rtems.org not jennifer@. --joel On 10/30/2014 9:53 AM, Gedare Bloom wrote: I missed reviewing this patch earlier, but there are some style problems with it, please fix them on the head. On Tue, Oct 28, 2014 at 11:17 AM, Jennifer Averett jenni...@rtems.org wrote:

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Gedare Bloom
The email address came from VC, so it is a problem in the commit setup I guess. On Thu, Oct 30, 2014 at 10:55 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: FWIW she is jennifer.aver...@rtems.org not jennifer@. --joel On 10/30/2014 9:53 AM, Gedare Bloom wrote: I missed reviewing this

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Joel Sherrill
On 10/30/2014 9:55 AM, Gedare Bloom wrote: The email address came from VC, so it is a problem in the commit setup I guess. OK. I will help her double check. Working on multiple machines, I periodically find one that is wrong for myself. :( --joel On Thu, Oct 30, 2014 at 10:55 AM, Joel

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Gedare Bloom
The problem may be a setup issue on git.rtems.org, where it converts from user login to email, I think it might be doing something dumb like just taking login-name @rtems.org On Thu, Oct 30, 2014 at 11:03 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 10/30/2014 9:55 AM, Gedare Bloom

RE: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Jennifer Averett
My name and email are correct in git config. -Original Message- From: devel [mailto:devel-boun...@rtems.org] On Behalf Of Gedare Bloom Sent: Thursday, October 30, 2014 10:08 AM To: Joel Sherrill Cc: Jennifer Averett; rtems-de...@rtems.org Subject: Re: [rtems commit] libmisc: Add top

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Joel Sherrill
] On Behalf Of Gedare Bloom Sent: Thursday, October 30, 2014 10:08 AM To: Joel Sherrill Cc: Jennifer Averett; rtems-de...@rtems.org Subject: Re: [rtems commit] libmisc: Add top to cpuusage. The problem may be a setup issue on git.rtems.org, where it converts from user login to email, I think

RE: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Jennifer Averett
Sent: Thursday, October 30, 2014 9:54 AM To: Jennifer Averett Cc: rtems-de...@rtems.org Subject: Re: [rtems commit] libmisc: Add top to cpuusage. I missed reviewing this patch earlier, but there are some style problems with it, please fix them on the head. On Tue, Oct 28, 2014 at 11:17 AM

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Joel Sherrill
Message- From: devel [mailto:devel-boun...@rtems.org] On Behalf Of Gedare Bloom Sent: Thursday, October 30, 2014 9:54 AM To: Jennifer Averett Cc: rtems-de...@rtems.org Subject: Re: [rtems commit] libmisc: Add top to cpuusage. I missed reviewing this patch earlier, but there are some style