Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 28 May 2018 at 00:49, Joel Sherrill wrote: > It sounds like great progress is being made but this thread is very long > and I am losing track of what needs committing. > > We can start a new thread. :) > Plus there is Chris' work to merge as well. > > How close is everything

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, 28 May 2018, 00:32 Cillian O'Donnell, wrote: > > > On Sun, 27 May 2018, 19:59 Vijay Kumar Banerjee, > wrote: > >> Hello, >> >> The support for letting users input specific symbols >> for coverage analysis is now working in my >>

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sun, 27 May 2018, 19:59 Vijay Kumar Banerjee, wrote: > Hello, > > The support for letting users input specific symbols > for coverage analysis is now working in my > cov-tester-support branch > > https://github.com/thelunatic/rtems-tools/tree/cov-tester-support >

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

Hello, The support for letting users input specific symbols for coverage analysis is now working in my cov-tester-support branch https://github.com/thelunatic/rtems-tools/tree/cov-tester-support Please have a look into the code and test it. The user can input specific symbols with the

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

Yeah I can see the difference in the objdump, it's optimized out though, so not very helpful but the addresses do match the covoar output. That's with -O2. I'll have to rebuild. Vijay you seeing the ... optimized out stuff *

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, May 21, 2018 at 2:12 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 22 May 2018 at 00:33, Joel Sherrill wrote: > >> >> >> On Mon, May 21, 2018, 1:54 PM Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 21 May 2018 at 23:07, Joel

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 22 May 2018 at 00:33, Joel Sherrill wrote: > > > On Mon, May 21, 2018, 1:54 PM Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 21 May 2018 at 23:07, Joel Sherrill wrote: >> >>> >>> >>> On Mon, May 21, 2018, 12:01 PM Vijay Kumar Banerjee < >>>

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, May 21, 2018, 1:54 PM Vijay Kumar Banerjee wrote: > On 21 May 2018 at 23:07, Joel Sherrill wrote: > >> >> >> On Mon, May 21, 2018, 12:01 PM Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 21 May 2018 at 21:42, Joel Sherrill

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 21 May 2018 at 23:07, Joel Sherrill wrote: > > > On Mon, May 21, 2018, 12:01 PM Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 21 May 2018 at 21:42, Joel Sherrill wrote: >> >>> >>> >>> On Mon, May 21, 2018 at 10:13 AM, Vijay Kumar Banerjee <

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 21 May 2018 at 21:42, Joel Sherrill wrote: > > > On Mon, May 21, 2018 at 10:13 AM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 21 May 2018 at 20:37, Joel Sherrill wrote: >> >>> >>> >>> On Mon, May 21, 2018 at 9:52 AM, Vijay Kumar Banerjee

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, May 21, 2018 at 10:13 AM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 21 May 2018 at 20:37, Joel Sherrill wrote: > >> >> >> On Mon, May 21, 2018 at 9:52 AM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 21 May 2018 at 17:39, Joel

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 21 May 2018 at 20:37, Joel Sherrill wrote: > > > On Mon, May 21, 2018 at 9:52 AM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 21 May 2018 at 17:39, Joel Sherrill wrote: >> >>> CPU-rtems5-objdump >>> >>> sparc-rtems5-objdump worked ,

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, May 21, 2018 at 9:52 AM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 21 May 2018 at 17:39, Joel Sherrill wrote: > >> CPU-rtems5-objdump >> >> sparc-rtems5-objdump worked , thanks . > I can see some mismatches in the disassembly . > I'm building sparc

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 21 May 2018 at 17:39, Joel Sherrill wrote: > CPU-rtems5-objdump > > sparc-rtems5-objdump worked , thanks . I can see some mismatches in the disassembly . Probably i386. Aren't you running pc386? > > I'm running sparc > Not sparc/erc32 or Leon > > On Mon, May 21, 2018, 6:35

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

CPU-rtems5-objdump Probably i386. Aren't you running pc386? Not sparc/erc32 or Leon On Mon, May 21, 2018, 6:35 AM Cillian O'Donnell wrote: > > > On Mon, 21 May 2018, 12:18 Vijay Kumar Banerjee, > wrote: > >> On 21 May 2018 at 16:39, Cillian

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, 21 May 2018, 12:18 Vijay Kumar Banerjee, wrote: > On 21 May 2018 at 16:39, Cillian O'Donnell wrote: > >> >> >> On Mon, 21 May 2018, 12:08 Cillian O'Donnell, >> wrote: >> >>> >>> >>> On Mon, 21 May 2018, 11:49 Vijay

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 21 May 2018 at 16:39, Cillian O'Donnell wrote: > > > On Mon, 21 May 2018, 12:08 Cillian O'Donnell, > wrote: > >> >> >> On Mon, 21 May 2018, 11:49 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 21 May 2018 at 11:56, Cillian

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, 21 May 2018, 12:08 Cillian O'Donnell, wrote: > > > On Mon, 21 May 2018, 11:49 Vijay Kumar Banerjee, > wrote: > >> On 21 May 2018 at 11:56, Cillian O'Donnell wrote: >> >>> >>> >>> On Sun, 20 May 2018, 22:33 Vijay

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, 21 May 2018, 11:49 Vijay Kumar Banerjee, wrote: > On 21 May 2018 at 11:56, Cillian O'Donnell wrote: > >> >> >> On Sun, 20 May 2018, 22:33 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 21 May 2018 at 02:29, Cillian

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 21 May 2018 at 11:56, Cillian O'Donnell wrote: > > > On Sun, 20 May 2018, 22:33 Vijay Kumar Banerjee, > wrote: > >> On 21 May 2018 at 02:29, Cillian O'Donnell wrote: >> >>> >>> >>> On Sun, 20 May 2018, 15:35 Vijay Kumar

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sun, 20 May 2018, 22:33 Vijay Kumar Banerjee, wrote: > On 21 May 2018 at 02:29, Cillian O'Donnell wrote: > >> >> >> On Sun, 20 May 2018, 15:35 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 20 May 2018 at 00:53, Vijay

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 21 May 2018 at 02:29, Cillian O'Donnell wrote: > > > On Sun, 20 May 2018, 15:35 Vijay Kumar Banerjee, > wrote: > >> On 20 May 2018 at 00:53, Vijay Kumar Banerjee >> wrote: >> >>> >>> >>> On Sun, 20 May 2018, 00:45

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sun, 20 May 2018, 15:35 Vijay Kumar Banerjee, wrote: > On 20 May 2018 at 00:53, Vijay Kumar Banerjee > wrote: > >> >> >> On Sun, 20 May 2018, 00:45 Cillian O'Donnell, >> wrote: >> >>> It works.. Sorry I was using the

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 20 May 2018 at 00:53, Vijay Kumar Banerjee wrote: > > > On Sun, 20 May 2018, 00:45 Cillian O'Donnell, > wrote: > >> It works.. Sorry I was using the right covoar but the wrong rtems-test. >> Ahh its nice to see the data back in the reports

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sun, 20 May 2018, 00:45 Cillian O'Donnell, wrote: > It works.. Sorry I was using the right covoar but the wrong rtems-test. > Ahh its nice to see the data back in the reports again. Did you manage to > track down 2 exes with the mismatch in symbol size? > Great! so next

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

It works.. Sorry I was using the right covoar but the wrong rtems-test. Ahh its nice to see the data back in the reports again. Did you manage to track down 2 exes with the mismatch in symbol size? On 19 May 2018 at 13:59, Vijay Kumar Banerjee wrote: > On 19 May 2018

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 18:28, Cillian O'Donnell wrote: > > > On Sat, 19 May 2018, 13:28 Vijay Kumar Banerjee, > wrote: > >> On 19 May 2018 at 17:56, Vijay Kumar Banerjee >> wrote: >> >>> On 19 May 2018 at 17:50, Vijay Kumar

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sat, 19 May 2018, 13:28 Vijay Kumar Banerjee, wrote: > On 19 May 2018 at 17:56, Vijay Kumar Banerjee > wrote: > >> On 19 May 2018 at 17:50, Vijay Kumar Banerjee >> wrote: >> >>> On 19 May 2018 at 17:44, Cillian

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 17:56, Vijay Kumar Banerjee wrote: > On 19 May 2018 at 17:50, Vijay Kumar Banerjee > wrote: > >> On 19 May 2018 at 17:44, Cillian O'Donnell wrote: >> >>> >>> >>> On Sat, 19 May 2018, 12:28 Vijay Kumar

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 17:50, Vijay Kumar Banerjee wrote: > On 19 May 2018 at 17:44, Cillian O'Donnell wrote: > >> >> >> On Sat, 19 May 2018, 12:28 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 19 May 2018 at 16:47, Cillian

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sat, 19 May 2018, 12:28 Vijay Kumar Banerjee, wrote: > On 19 May 2018 at 16:47, Cillian O'Donnell wrote: > >> >> God these messages again... at least I'm an expert in fixing these :) >> Vijay I'm only seeing the headings in the report on my

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 16:47, Cillian O'Donnell wrote: > > God these messages again... at least I'm an expert in fixing these :) > Vijay I'm only seeing the headings in the report on my end using your > branch. How are you running it and from where? Is there any changes you >

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 18 May 2018 at 23:24, Vijay Kumar Banerjee wrote: > On 19 May 2018 at 03:29, Joel Sherrill wrote: > >> >> >> On Fri, May 18, 2018 at 4:53 PM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> >>> >>> On Sat, 19 May 2018, 03:06 Joel

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 04:26, Joel Sherrill wrote: > If you run nm on some of the executables, do you see the > Is symbol? We need to.know its type. > I did this on the testsuites find -iname '*.exe' -exec nm -A '{}' \; | grep '\' which returned nothing . am I using the right

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

If you run nm on some of the executables, do you see the Is symbol? We need to.know its type. On Fri, May 18, 2018, 5:24 PM Vijay Kumar Banerjee wrote: > On 19 May 2018 at 03:29, Joel Sherrill wrote: > >> >> >> On Fri, May 18, 2018 at 4:53 PM, Vijay

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 03:29, Joel Sherrill wrote: > > > On Fri, May 18, 2018 at 4:53 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> >> >> On Sat, 19 May 2018, 03:06 Joel Sherrill, wrote: >> >>> >>> >>> On Fri, May 18, 2018 at 4:01 PM, Vijay Kumar

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Fri, May 18, 2018 at 4:53 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > > > On Sat, 19 May 2018, 03:06 Joel Sherrill, wrote: > >> >> >> On Fri, May 18, 2018 at 4:01 PM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 19 May 2018 at 02:29,

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sat, 19 May 2018, 03:06 Joel Sherrill, wrote: > > > On Fri, May 18, 2018 at 4:01 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 19 May 2018 at 02:29, Vijay Kumar Banerjee >> wrote: >> >>> On 19 May 2018 at 01:30, Cillian

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Fri, May 18, 2018 at 4:01 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 19 May 2018 at 02:29, Vijay Kumar Banerjee > wrote: > >> On 19 May 2018 at 01:30, Cillian O'Donnell wrote: >> >>> >>> >>> On Fri, 18 May 2018, 14:55

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 02:29, Vijay Kumar Banerjee wrote: > On 19 May 2018 at 01:30, Cillian O'Donnell wrote: > >> >> >> On Fri, 18 May 2018, 14:55 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> >>> >>> On 18 May 2018 at 19:09,

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 19 May 2018 at 01:30, Cillian O'Donnell wrote: > > > On Fri, 18 May 2018, 14:55 Vijay Kumar Banerjee, > wrote: > >> >> >> On 18 May 2018 at 19:09, Cillian O'Donnell wrote: >> >>> >>> >>> On Fri, 18 May 2018, 12:36 Vijay

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Fri, 18 May 2018, 14:55 Vijay Kumar Banerjee, wrote: > > > On 18 May 2018 at 19:09, Cillian O'Donnell wrote: > >> >> >> On Fri, 18 May 2018, 12:36 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> >>> On 18 May 2018 at 12:30,

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 18 May 2018 at 19:09, Cillian O'Donnell wrote: > > > On Fri, 18 May 2018, 12:36 Vijay Kumar Banerjee, > wrote: > >> >> On 18 May 2018 at 12:30, Cillian O'Donnell wrote: >> >> >>> Cool, you should run it for the full

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Fri, 18 May 2018, 12:36 Vijay Kumar Banerjee, wrote: > > On 18 May 2018 at 12:30, Cillian O'Donnell wrote: > > >> Cool, you should run it for the full testsuite and take a look at that >> report (takes a while.. around 575 tests) >> >>>

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 18 May 2018 at 12:30, Cillian O'Donnell wrote: > Cool, you should run it for the full testsuite and take a look at that > report (takes a while.. around 575 tests) > >> >>> When I try to run the full testsuites it gives the following error . What could be causing this

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Fri, 18 May 2018, 07:46 Vijay Kumar Banerjee, wrote: > On Fri, 18 May 2018, 11:52 Cillian O'Donnell, > wrote: > >> >> >> On Thu, 17 May 2018, 21:32 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> hello, >>> >>> I have

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Fri, 18 May 2018, 11:52 Cillian O'Donnell, wrote: > > > On Thu, 17 May 2018, 21:32 Vijay Kumar Banerjee, > wrote: > >> hello, >> >> I have attached the html report ! >> > > Report looks good! Well done. Was that just for samples. Did the other

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Thu, 17 May 2018, 21:32 Vijay Kumar Banerjee, wrote: > hello, > > I have attached the html report ! > Report looks good! Well done. Was that just for samples. Did the other sections appear in the report if you click through the links? Well it looks good but I

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 18/5/18 8:32 am, Vijay Kumar Banerjee wrote:> > One thing can be done, which I think will solve parsing of the absolute path > of > the library as well. It is to implement the the logic that Chris used in > covoar.cc , into the python script for coverage . Then we can do an > os.path.abspath()

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

hello, I have attached the html report ! Well it looks good but I hardcoded the paths, at least that gave the proper idea of what exactly needs to be done. Now I understand why --rtems-builddir stayed there for a long time , it makes the job simple . Here's a point that needs discussion : 1.

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, 14 May 2018, 23:24 Cillian O'Donnell, wrote: > > > On Mon, 14 May 2018, 09:50 Vijay Kumar Banerjee, > wrote: > >> On 14 May 2018 at 12:10, Cillian O'Donnell wrote: >> >>> >>> >>> On Sun, 13 May 2018, 22:15 Vijay

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, 14 May 2018, 09:50 Vijay Kumar Banerjee, wrote: > On 14 May 2018 at 12:10, Cillian O'Donnell wrote: > >> >> >> On Sun, 13 May 2018, 22:15 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 14 May 2018 at 02:15, Cillian

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Mon, 14 May 2018, 16:46 Joel Sherrill, wrote: > I'll commit this once there is a log message. :) > You want the word 'Fix' is it?... :) > > On Sun, May 13, 2018 at 3:45 PM, Cillian O'Donnell > wrote: > >> --- >> tester/covoar/covoar.cc | 10

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

I'll commit this once there is a log message. :) On Sun, May 13, 2018 at 3:45 PM, Cillian O'Donnell wrote: > --- > tester/covoar/covoar.cc | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/tester/covoar/covoar.cc

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 14 May 2018 at 12:10, Cillian O'Donnell wrote: > > > On Sun, 13 May 2018, 22:15 Vijay Kumar Banerjee, > wrote: > >> On 14 May 2018 at 02:15, Cillian O'Donnell wrote: >> >>> --- >>> tester/covoar/covoar.cc | 10

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On Sun, 13 May 2018, 22:15 Vijay Kumar Banerjee, wrote: > On 14 May 2018 at 02:15, Cillian O'Donnell wrote: > >> --- >> tester/covoar/covoar.cc | 10 +++--- >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> diff --git

Re: [PATCH] covoar.cc: Correct build path checks for multiple executables.

On 14 May 2018 at 02:15, Cillian O'Donnell wrote: > --- > tester/covoar/covoar.cc | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc > index 5c87402..c6b0589 100644 > ---