Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-24 Thread Chris Johns
On 24/5/2023 11:42 pm, Christian MAUDERER wrote: > On 2023-05-24 02:33, Chris Johns wrote: >> On 24/5/2023 9:13 am, Chris Johns wrote: >>> On 23/5/2023 5:30 pm, Christian MAUDERER wrote: Hello Chris, On 2023-05-23 08:53, Chris Johns wrote: > On 23/5/2023 4:25 pm, Christian

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-24 Thread Christian MAUDERER
On 2023-05-24 02:33, Chris Johns wrote: On 24/5/2023 9:13 am, Chris Johns wrote: On 23/5/2023 5:30 pm, Christian MAUDERER wrote: Hello Chris, On 2023-05-23 08:53, Chris Johns wrote: On 23/5/2023 4:25 pm, Christian MAUDERER wrote: Hello Chris, On 2023-05-23 03:36, Chris Johns wrote: Hi, I

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-23 Thread Chris Johns
On 24/5/2023 9:13 am, Chris Johns wrote: > On 23/5/2023 5:30 pm, Christian MAUDERER wrote: >> Hello Chris, >> >> On 2023-05-23 08:53, Chris Johns wrote: >>> On 23/5/2023 4:25 pm, Christian MAUDERER wrote: Hello Chris, On 2023-05-23 03:36, Chris Johns wrote: > Hi, > > I

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-23 Thread Chris Johns
On 23/5/2023 5:30 pm, Christian MAUDERER wrote: > Hello Chris, > > On 2023-05-23 08:53, Chris Johns wrote: >> On 23/5/2023 4:25 pm, Christian MAUDERER wrote: >>> Hello Chris, >>> >>> On 2023-05-23 03:36, Chris Johns wrote: Hi, I have been resolving this by adding: #define

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-23 Thread Christian MAUDERER
Hello Chris, On 2023-05-23 08:53, Chris Johns wrote: On 23/5/2023 4:25 pm, Christian MAUDERER wrote: Hello Chris, On 2023-05-23 03:36, Chris Johns wrote: Hi, I have been resolving this by adding: #define preset_mask *preset_mask_prealloc #define active_mask *active_mask_prealloc as the

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-23 Thread Chris Johns
On 23/5/2023 4:25 pm, Christian MAUDERER wrote: > Hello Chris, > > On 2023-05-23 03:36, Chris Johns wrote: >> Hi, >> >> I have been resolving this by adding: >> >> #define preset_mask *preset_mask_prealloc >> #define active_mask *active_mask_prealloc >> >> as the assignment logic works as is. It

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-23 Thread Christian MAUDERER
Hello Chris, On 2023-05-23 03:36, Chris Johns wrote: Hi, I have been resolving this by adding: #define preset_mask *preset_mask_prealloc #define active_mask *active_mask_prealloc as the assignment logic works as is. It does not catch FD_ZERO which is a shame but is helps avoid us adding a

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-22 Thread Chris Johns
Hi, I have been resolving this by adding: #define preset_mask *preset_mask_prealloc #define active_mask *active_mask_prealloc as the assignment logic works as is. It does not catch FD_ZERO which is a shame but is helps avoid us adding a special case. Chris On 22/5/2023 5:36 pm, Christian

Re: [PATCH rtems-libbsd] ipsec-tools: Fix copying fd_set prior to select

2023-05-22 Thread Christian MAUDERER
Hello, I would like to apply this patch on 5 and 6 branches. I'll create tickets before applying it. Best regards Christian On 2023-05-22 09:36, Christian Mauderer wrote: The racoon session code copies an fd_set from one variable into another prior to calling select. That works well for