RE: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-23 Thread Ryan Long
, September 22, 2021 7:24 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting On 23/9/21 12:35 am, Ryan Long wrote: > I changed the definition of discardBuff to > > char discardBuff[100]{}; char discardBuff[100] = {}; ? > S

Re: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-22 Thread Chris Johns
On 23/9/21 12:35 am, Ryan Long wrote: > I changed the definition of discardBuff to > > char discardBuff[100]{}; char discardBuff[100] = {}; ? > So that every element will be initialized to \0. This function is only used > in TraceReaderLogQEMU.cc, and the values that are passed in are > >

RE: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-22 Thread Ryan Long
ECTION_END "" Neither are close to going over the size of discardBuff, but I can add a check and return false if it does happen to go over that length. -Original Message- From: Chris Johns Sent: Tuesday, September 21, 2021 6:16 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATC

Re: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-21 Thread Chris Johns
On 22/9/21 2:45 am, Ryan Long wrote: > --- > tester/covoar/TraceReaderLogQEMU.cc | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/tester/covoar/TraceReaderLogQEMU.cc > b/tester/covoar/TraceReaderLogQEMU.cc > index c303d08..91ed5c7 100644 > ---