Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

2024-01-04 Thread Kinsey Moore
On Thu, Jan 4, 2024 at 2:24 PM Bernd Moessner wrote: > Dear Kinsey, > > sry for the stupid question. What is the correct way to reference the issue > > [#4981 rtems6 - v1 05/16] FIX: Add > missing default case > > or > > [PATCH rtems6 - v1 05/16] #4981

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

2024-01-04 Thread Joel Sherrill
https://docs.rtems.org/branches/master/eng/vc-users.html#commit-message-guidance If that is missing something, please ask questions and we can address the Software Engineering Guide. --joel On Thu, Jan 4, 2024 at 2:24 PM Bernd Moessner wrote: > Dear Kinsey, > > sry for the stupid question.

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

2024-01-04 Thread Joel Sherrill
On Thu, Jan 4, 2024 at 12:49 PM Kinsey Moore wrote: > All of the patches here need an issue reference. Beyond that, this patch > is good to go in. I'm still reviewing the remainder of the set and I'll > leave the renaming discussion to Aaron. > I have only gotten this far into the patch set but

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

2024-01-04 Thread Bernd Moessner
Dear Kinsey, sry for the stupid question. What is the correct way to reference the issue [#4981 rtems6 - v1 05/16] FIX: Add missing default case or [PATCH rtems6 - v1 05/16] #4981 FIX: Add missing default case ?

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

2024-01-04 Thread Kinsey Moore
All of the patches here need an issue reference. Beyond that, this patch is good to go in. I'm still reviewing the remainder of the set and I'll leave the renaming discussion to Aaron. Kinsey On Thu, Jan 4, 2024 at 12:35 PM wrote: > From: Bernd Moessner > > --- > cpukit/dev/flash/flashdev.c