Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-08-22 Thread Gedare Bloom
By separating this from the zynqmp bsp, there should be some modification of the naming conventions to specify rpu--unless they will share the code files identically. I guess that decision must be made. These files should not be duplicated in the tree simultaneously, as they introduce name clashes

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-08-22 Thread Philip Kirkpatrick
Just a reminder that this patch is ready for review. On Thu, Jun 29, 2023 at 6:36 PM Philip Kirkpatrick < p.kirkpatr...@reflexaerospace.com> wrote: > Took a while to get to but here is a new patch incorporating the feedback. > > Sorry to drop this and run but I'm on vacation for a week as soon

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-29 Thread Philip Kirkpatrick
Took a while to get to but here is a new patch incorporating the feedback. Sorry to drop this and run but I'm on vacation for a week as soon as I send this. So don't expect to see responses from me until July 10th or later. Once I'm back and this is through, expect to see some follow-on patches

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-18 Thread Chris Johns
On 17/6/2023 5:14 am, Gedare Bloom wrote: > On Fri, Jun 16, 2023 at 2:17 AM Philip Kirkpatrick > wrote: >> On Fri, Jun 16, 2023 at 7:14 AM Chris Johns wrote: >>> >>> On 15/6/2023 6:16 pm, Philip Kirkpatrick wrote: Thanks for all the good feedback. RE Joel: I'll fix my sloppy

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-16 Thread Gedare Bloom
On Fri, Jun 16, 2023 at 2:17 AM Philip Kirkpatrick wrote: > > > > On Fri, Jun 16, 2023 at 7:14 AM Chris Johns wrote: >> >> On 15/6/2023 6:16 pm, Philip Kirkpatrick wrote: >> > Thanks for all the good feedback. >> > >> > RE Joel: >> > I'll fix my sloppy formatting that you caught and submit a

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-16 Thread Philip Kirkpatrick
On Fri, Jun 16, 2023 at 7:14 AM Chris Johns wrote: > On 15/6/2023 6:16 pm, Philip Kirkpatrick wrote: > > Thanks for all the good feedback. > > > > RE Joel: > > I'll fix my sloppy formatting that you caught and submit a revised > patch. If > > I'm realistic about my schedule, I probably won't be

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-15 Thread Chris Johns
On 15/6/2023 6:16 pm, Philip Kirkpatrick wrote: > Thanks for all the good feedback. > > RE Joel: > I'll fix my sloppy formatting that you caught and submit a revised patch.  If > I'm realistic about my schedule, I probably won't be able to get to it until > next week. > For xttcps_hw.h, there

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-15 Thread Philip Kirkpatrick
Thanks for all the good feedback. RE Joel: I'll fix my sloppy formatting that you caught and submit a revised patch. If I'm realistic about my schedule, I probably won't be able to get to it until next week. For xttcps_hw.h, there already is one #ifndef __rtems__ around the #includes, but on

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-15 Thread Aaron Nyholm
This looks exciting. As for Versal support from Xilinx's Docs "RPU The real-time processing unit (RPU) Arm Cortex-R5F processor has faster clocking frequencies than the Zynq UltraScale+ MPSoC. The Versal Arm Cortex-R5F processor supports Vector Floating-Point v3 (VFPv3) whereas the Zynq

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Chris Johns
On 14/6/2023 6:08 pm, Philip Kirkpatrick wrote: > This patch adds support for running RTEMS on the RPU (cortex R5) cores of the > ZynqMP.  Thanks for submitting this BSP. It is exciting to see this work and support being added. How different are the ZynqMP RPU cores and the ones on the Versal?

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread mbenson
This is great. I will carve out time to check this out on the ZU3EG and provide feedback if needed. Good job. Sent from my iPhone > On Jun 14, 2023, at 08:49, Joel Sherrill wrote: > >  > Thanks for submitting this. It has been on the wish list for a while. > > My first comment is that

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Kinsey Moore
Overall, this looks like great work! Thanks for contributing! Just a couple of addons to Joel's comments below. On Wed, Jun 14, 2023 at 8:49 AM Joel Sherrill wrote: > > On Wed, Jun 14, 2023 at 3:08 AM Philip Kirkpatrick < > p.kirkpatr...@reflexaerospace.com> wrote: > > diff --git

Re: bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Joel Sherrill
Thanks for submitting this. It has been on the wish list for a while. My first comment is that information needs to be added to the Users Guide on this BSP. Guidance on capabilities, use, and debug is always appreciated by the next user. Remember that often this is where search engines and other

bsps/xilinx-zynqmp : Add BSP for RPU

2023-06-14 Thread Philip Kirkpatrick
This patch adds support for running RTEMS on the RPU (cortex R5) cores of the ZynqMP. This is only a basic BSP and does not yet support the following: - SMP - Cache - MPU Also, everything except for the startup and exception vectors runs out of DRAM, which is slow without cache. At some point