Re: [PATCH] Fix CppCheck errors

Apply to 4.11 and master On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom <ged...@rtems.org> wrote: > Looks OK to me. > > On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan > <martin.gal...@tallertechnologies.com> wrote: >> This patch fixes the following CppCheck errors found

Re: [PATCH] Fix CppCheck errors

Looks OK to me. On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan <martin.gal...@tallertechnologies.com> wrote: > This patch fixes the following CppCheck errors found throughout the code: > > [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of character > ({)

Re: [PATCH] Fix CppCheck errors

On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote: > Joel, > Coordinate your patch/fixes with this patch. (I do prefer the separate > patches that Joel gave. Small atomic commits are better.) > Gedare I thought he'd seen this e-mail :) I agree that small atomic commits are

Re: cppcheck errors

On Tue, Sep 1, 2015 at 5:43 PM, Joel Sherrill wrote: > > > On 9/1/2015 2:10 PM, Martin Galvan wrote: >> >> Hi everyone! >> >> I just ran CppCheck again on a fresh clone of the git repo and saw the >> number of error reports was quite smaller than what I reported before.

Re: [PATCH] Fix CppCheck errors

dare Bloom <ged...@rtems.org> wrote: >> Looks OK to me. >> >> On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan >> <martin.gal...@tallertechnologies.com> wrote: >>> This patch fixes the following CppCheck errors found throughout the code: >>>

Re: [PATCH] Fix CppCheck errors

On 9/2/2015 8:43 AM, Martin Galvan wrote: On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote: Joel, Coordinate your patch/fixes with this patch. (I do prefer the separate patches that Joel gave. Small atomic commits are better.) Gedare I thought he'd seen this e-mail :)

[PATCH] Fix CppCheck errors

This patch fixes the following CppCheck errors found throughout the code: [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of character ({) when these macros are defined: '__cplusplus'. [cpukit/libmisc/dumpbuf/dumpbuf.c:69]: (error) Undefined behavior: Variable 'line_buffer

Re: cppcheck errors

Hi everyone! I just ran CppCheck again on a fresh clone of the git repo and saw the number of error reports was quite smaller than what I reported before. That's because my previous run was on a (quite older) version; most of those must've been fixed already. Some of the error reports remain,

Re: cppcheck errors

On 9/1/2015 2:10 PM, Martin Galvan wrote: Hi everyone! I just ran CppCheck again on a fresh clone of the git repo and saw the number of error reports was quite smaller than what I reported before. That's because my previous run was on a (quite older) version; most of those must've been fixed

Re: cppcheck errors

On Thu, Aug 27, 2015 at 6:38 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 8/27/2015 4:15 PM, Martin Galvan wrote: On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson daniel.gut...@tallertechnologies.com wrote: Maybe we can just provide the list until we provide the fixes? Martín?

Re: cppcheck errors

On Wed, Aug 12, 2015 at 5:43 PM, Daniel Gutson daniel.gut...@tallertechnologies.com mailto:daniel.gut...@tallertechnologies.com wrote: Hi guys, we will be posting patches for a number of errors reported by cppcheck (errors that we can confirm are not false positives

Re: cppcheck errors

On Thu, Aug 27, 2015 at 6:19 PM, Daniel Gutson daniel.gut...@tallertechnologies.com wrote: Please note too that there are some false positives, like the realloc one. Actually, we ruled out most false positives. IIRC that one is an actual bug. Btw, sorry for the Spanish comment there. It means

Re: cppcheck errors

On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson daniel.gut...@tallertechnologies.com wrote: Maybe we can just provide the list until we provide the fixes? Martín? Gladly. Keep in mind we ran cppcheck only on the modules we use (though some things may've slipped in, like nios):

Re: cppcheck errors

will be posting patches for a number of errors reported by cppcheck (errors that we can confirm are not false positives). Please hold on any release. Daniel. -- Daniel F. Gutson Chief Engineering Officer, SPD San Lorenzo 47, 3rd Floor, Office 5

Re: cppcheck errors

On 8/27/2015 4:15 PM, Martin Galvan wrote: On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson daniel.gut...@tallertechnologies.com wrote: Maybe we can just provide the list until we provide the fixes? Martín? Gladly. Keep in mind we ran cppcheck only on the modules we use (though some things

Re: cppcheck errors

will be posting patches for a number of errors reported by cppcheck (errors that we can confirm are not false positives). Please hold on any release. Daniel. -- Daniel F. Gutson Chief Engineering Officer, SPD San Lorenzo 47, 3rd Floor, Office 5

obsolete h8300 was Re: cppcheck errors

On 8/27/2015 4:22 PM, Martin Galvan wrote: On Thu, Aug 27, 2015 at 6:19 PM, Daniel Gutson daniel.gut...@tallertechnologies.com wrote: Please note too that there are some false positives, like the realloc one. Actually, we ruled out most false positives. IIRC that one is an actual bug. Btw,

Re: cppcheck errors

, 2015 at 5:43 PM, Daniel Gutson daniel.gut...@tallertechnologies.com wrote: Hi guys, we will be posting patches for a number of errors reported by cppcheck (errors that we can confirm are not false positives). Please hold on any release. Daniel. -- Daniel F. Gutson Chief Engineering

Re: cppcheck errors

Gutson daniel.gut...@tallertechnologies.com wrote: Hi guys, we will be posting patches for a number of errors reported by cppcheck (errors that we can confirm are not false positives). Please hold on any release. Daniel. -- Daniel F. Gutson Chief Engineering Officer, SPD

Re: cppcheck errors

by cppcheck (errors that we can confirm are not false positives). Please hold on any release. Daniel. -- Daniel F. Gutson Chief Engineering Officer, SPD San Lorenzo 47, 3rd Floor, Office 5 Córdoba, Argentina Phone: +54 351 4217888 / +54 351 4218211 Skype