[PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread G S Niteesh
Replaces the legacy termios API with new termios API (#3034) Replaces the custom PL011 serial driver with RTEMS arm-pl011. Update #3034 --- bsps/arm/raspberrypi/console/console-config.c | 148 bsps/arm/raspberrypi/console/console_select.c | 114

Re: [PATCH] bsp/raspberry: Enabled FDT support for console.

2020-01-03 Thread Niteesh
On Fri, Jan 3, 2020 at 1:51 PM Christian Mauderer wrote: > On 03/01/2020 04:50, Niteesh wrote: > > On Fri, Jan 3, 2020 at 2:26 AM Christian Mauderer > > wrote: > > > > Sorry, it seems I missed some parts in the last mail. Beneath that I > > caused a

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Christian Mauderer
On 03/01/2020 11:11, Niteesh wrote: > Great, please do have a look at the FDT patch I sent today. The FDT patch looks OK too. I thought it's clear when I said that I'll push it together with this one in a few days. > I would like to work on something else now, do you have something > interesting

Re: Error while building the rtems-libbsd

2020-01-03 Thread Christian Mauderer
On 01/01/2020 16:14, Utkarsh Rai wrote: > I have been successful in building the rtems-libbsd using 'python3 > ./waf'. Although, I had to do some weird changes to some of the files in > the libbsd package. (These changes were done as there were several build > errors even after the 'python ./waf'

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
Great, please do have a look at the FDT patch I sent today. I would like to work on something else now, do you have something interesting for me to do? On Fri, Jan 3, 2020 at 3:39 PM Christian Mauderer wrote: > Hello Niteesh, > > looks good to me. The UART works for a Pi1 and a Pi2. The

Glossary of Terms

2020-01-03 Thread Sebastian Huber
Hello, we have currently only two glossary of terms in the RTEMS documentation set: https://docs.rtems.org/branches/master/user/glossary/index.html https://docs.rtems.org/branches/master/c-user/glossary.html We also need one in the RTEMS Software Engineering manual. Sphinx has currently some

RE: [PATCH] user: Add a link for the setup of frdme310arty BSP

2020-01-03 Thread Pragnesh Patel
>-Original Message- >From: Gedare Bloom >Sent: 02 January 2020 21:28 >To: Sebastian Huber >Cc: devel@rtems.org; Pragnesh Patel >Subject: Re: [PATCH] user: Add a link for the setup of frdme310arty BSP > >On Wed, Jan 1, 2020 at 11:21 PM Sebastian Huber > wrote: >> >> On 31/12/2019

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Christian Mauderer
Hello Niteesh, looks good to me. The UART works for a Pi1 and a Pi2. The Framebuffer console doesn't but it doesn't work either before this patch and as far as I can tell you took over the logic correctly. So I don't think this patch will break anything that isn't already broken. I'll give the

Re: Glossary of Terms

2020-01-03 Thread Sebastian Huber
On 03/01/2020 10:42, andrew.butterfi...@cs.tcd.ie wrote: Hello all, and Happy New Year! On 3 Jan 2020, at 08:10, Sebastian Huber wrote: 1. Should we use one shared glossary which is included in all documents? 2. Do we want to use document-specific glossaries and maintain copy-and-paste

Re: [PATCH] bsp/raspberry: Enabled FDT support for console.

2020-01-03 Thread Christian Mauderer
On 03/01/2020 04:50, Niteesh wrote: > On Fri, Jan 3, 2020 at 2:26 AM Christian Mauderer > wrote: > > Sorry, it seems I missed some parts in the last mail. Beneath that I > caused a misunderstanding again. > > On 02/01/2020 20:08, G S Niteesh wrote: > >

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
On Fri, Jan 3, 2020 at 3:48 PM Christian Mauderer wrote: > On 03/01/2020 11:11, Niteesh wrote: > > Great, please do have a look at the FDT patch I sent today. > > The FDT patch looks OK too. I thought it's clear when I said that I'll > push it together with this one in a few days. > Sorry, I

[PATCH 3/3] eng: Rework stakeholder chapter

2020-01-03 Thread Sebastian Huber
--- eng/index.rst| 2 +- eng/prequalification.rst | 11 +++ eng/stakeholders.rst | 24 +++- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/eng/index.rst b/eng/index.rst index 094b1e5..3340e34 100644 --- a/eng/index.rst +++

[PATCH 1/3] common: Add URLs to manuals

2020-01-03 Thread Sebastian Huber
--- common/rtemsdomain.py | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/common/rtemsdomain.py b/common/rtemsdomain.py index 49d0728..018e7ed 100644 --- a/common/rtemsdomain.py +++ b/common/rtemsdomain.py @@ -43,7 +43,19 @@ role_url = { "review":

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Niteesh
I have gone through previous year works and selected a few topics which I found interesting. 1. Basic Support for Trace Compass #3696 . 2. RTEMS testing tool project #2927 . 3. Beagle BSP: Add a flattened device tree based

Re: Requirement Document generator tool

2020-01-03 Thread Sebastian Huber
Hello Jose, On 03/01/2020 11:52, Jose Valdez wrote: Should be in rtems-tools? If so, in which place? I think this is the best place given the information I have. I would need to have more detail before I could provide any specific direction here. All host tools are in rtems-tools so at this

RE: Requirement Document generator tool

2020-01-03 Thread Jose Valdez
Same message with no attachs. -Original Message- From: Jose Valdez Sent: sexta-feira, 3 de janeiro de 2020 10:49 To: 'Gedare Bloom'; Joel Sherrill Cc: devel@rtems.org Subject: RE: Requirement Document generator tool Hello Gedare and Joel, Please see my answers below for both of you (see

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Vijay Kumar Banerjee
Hi Niteesh, A few formatting suggestions: > > diff --git a/bsps/arm/raspberrypi/console/console-config.c > b/bsps/arm/raspberrypi/console/console-config.c > index d2186c918b..4000fd1c50 100644 > --- a/bsps/arm/raspberrypi/console/console-config.c > +++

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Vijay Kumar Banerjee
On Fri, Jan 3, 2020 at 7:30 PM Christian Mauderer wrote: > On 03/01/2020 13:49, Niteesh wrote: > > I have gone through previous year works and selected a few topics which > > I found > > interesting. > > 1. Basic Support for Trace Compass #3696 > > . > > A

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

2020-01-03 Thread Gedare Bloom
On Thu, Jan 2, 2020 at 11:08 PM Sebastian Huber wrote: > > On 03/01/2020 00:24, Gedare Bloom wrote: > > while ( !_Chain_Is_empty( > > _thread->Priority_node.Inherited_priorities ) ) { > > +_ISR_Disable( level ); > > _Thread_Dequeue_priority_node( > >

Re: Builtin memcpy() requirements

2020-01-03 Thread Sebastian Huber
Hello Jonathan, On 20/12/2019 20:03, Jonathan Brandmeyer wrote: Small improvements inline: On Fri, Dec 20, 2019 at 1:25 AM Sebastian Huber > wrote: Hello, while working on a test case for https://devel.rtems.org/ticket/3767 I

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
On Fri, Jan 3, 2020 at 7:32 PM Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > Hi Niteesh, > A few formatting suggestions: > >> >> diff --git a/bsps/arm/raspberrypi/console/console-config.c >> b/bsps/arm/raspberrypi/console/console-config.c >> index d2186c918b..4000fd1c50 100644 >> ---

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Vijay Kumar Banerjee
On Fri, Jan 3, 2020, 8:53 PM Niteesh wrote: > On Fri, Jan 3, 2020 at 7:32 PM Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> Hi Niteesh, >> A few formatting suggestions: >> >>> >>> diff --git a/bsps/arm/raspberrypi/console/console-config.c >>>

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Niteesh
qemu-system-aarch64 doesn't support elf formats too. I tried running them but the qemu is stuck at 0x200. Should I change the cpu type to armv7, but by default Rpi3 should run 32bit applications, but not sure about qemu. On Fri, Jan 3, 2020 at 6:01 PM Niteesh wrote: > On Fri, Jan 3, 2020 at

Re: [PATCH] bsp/raspberrypi: Updated the console API.

2020-01-03 Thread Christian Mauderer
On 03/01/2020 13:31, Niteesh wrote: > On Fri, Jan 3, 2020 at 3:48 PM Christian Mauderer > wrote: > > On 03/01/2020 11:11, Niteesh wrote: > > Great, please do have a look at the FDT patch I sent today. > > The FDT patch looks OK too. I thought it's clear

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Christian Mauderer
On 03/01/2020 13:49, Niteesh wrote: > I have gone through previous year works and selected a few topics which > I found > interesting. > 1. Basic Support for Trace Compass #3696 > . A basic support has been added last year and Sebastian extended that quite a

Re: [PATCH v2 2/2] score: Simplify _Thread_Initialize()

2020-01-03 Thread Gedare Bloom
Looks good. On Thu, Jan 2, 2020 at 11:31 PM Sebastian Huber wrote: > > Allocate new thread queue heads during objects information extend. This > removes an error case and the last dependency on the workspace in > _Thread_Initialize(). > > Update #3835. > --- > cpukit/Makefile.am

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

2020-01-03 Thread Gedare Bloom
On Fri, Jan 3, 2020 at 10:19 AM Joel Sherrill wrote: > > > > On Fri, Jan 3, 2020, 12:08 AM Sebastian Huber > wrote: >> >> On 03/01/2020 00:24, Gedare Bloom wrote: >> > while ( !_Chain_Is_empty( >> > _thread->Priority_node.Inherited_priorities ) ) { >> > +_ISR_Disable( level ); >> >

[PATCH] cpukit/libfs: remove more dead code from pipe/fifo.c

2020-01-03 Thread Gedare Bloom
Dead code identified by Coverity (CID 1456674). The value of ret at line 358 is always 0. --- cpukit/libfs/src/pipe/fifo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpukit/libfs/src/pipe/fifo.c b/cpukit/libfs/src/pipe/fifo.c index 579f118bfd..0a3cbf3d65 100644 ---

Re: [PATCH] cpukit/libfs: remove more dead code from pipe/fifo.c

2020-01-03 Thread Joel Sherrill
Looks good to me. FWIW the one in untar may have to be annotated as ok in the code. They legitimately see a potential race condition but we should document that untar should be allowed to run with no interference. On Fri, Jan 3, 2020, 12:56 PM Gedare Bloom wrote: > Dead code identified by

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Niteesh
Finally, I am able to load IMAGES into Rpi3 using u-boot. But didn't check whether FDT works. I added the AUX driver from my bare-metal project for testing. I'll replace it with NS16550 soon. I loaded the fileio example and it prints the board information. Below is the link to the screenshot

Re: Glossary of Terms

2020-01-03 Thread Gedare Bloom
On Fri, Jan 3, 2020 at 3:25 AM Sebastian Huber wrote: > > On 03/01/2020 10:42, andrew.butterfi...@cs.tcd.ie wrote: > > Hello all, and Happy New Year! > > > >> On 3 Jan 2020, at 08:10, Sebastian Huber > >> wrote: > >> > >> > >> 1. Should we use one shared glossary which is included in all

Re: Requirement Document generator tool

2020-01-03 Thread Joel Sherrill
On Fri, Jan 3, 2020, 4:49 AM Jose Valdez wrote: > Hello Gedare and Joel, > > Please see my answers below for both of you (see JV02012019). > > Please tell me, if you need further clarification. > > Best regards > > José > > -Original Message- > From: Gedare Bloom

sptests/sp19/Makefile in git?

2020-01-03 Thread Gedare Bloom
With master, bootstrap -c deletes testsuites/ada/sptests/sp19/Makefile and shows up in my git status. Is the sp19/Makefile supposed to be under version control or is that a mistake? ___ devel mailing list devel@rtems.org

Re: sptests/sp19/Makefile in git?

2020-01-03 Thread Joel Sherrill
On Fri, Jan 3, 2020 at 12:22 PM Gedare Bloom wrote: > With master, bootstrap -c deletes testsuites/ada/sptests/sp19/Makefile > and shows up in my git status. Is the sp19/Makefile supposed to be > under version control or is that a mistake? > That has to be a mistake. But I don't see it in git

Re: Coding Convention: Sorting Order of Includes?

2020-01-03 Thread Joel Sherrill
On Fri, Jan 3, 2020, 10:53 AM Gedare Bloom wrote: > Hello all, > > Vijay noted in another thread that: > "For RTEMS, I don't see any preference mentioned in the docs for the > order or includes: > https://docs.rtems.org/branches/master/eng/coding-conventions.html > > In libbsd, however, the

Re: Glossary of Terms

2020-01-03 Thread Joel Sherrill
On Fri, Jan 3, 2020, 10:22 AM Gedare Bloom wrote: > On Fri, Jan 3, 2020 at 3:25 AM Sebastian Huber > wrote: > > > > On 03/01/2020 10:42, andrew.butterfi...@cs.tcd.ie wrote: > > > Hello all, and Happy New Year! > > > > > >> On 3 Jan 2020, at 08:10, Sebastian Huber < >

Re: [PATCH 3/3] eng: Rework stakeholder chapter

2020-01-03 Thread Gedare Bloom
On Fri, Jan 3, 2020 at 10:07 AM Joel Sherrill wrote: > > > > On Fri, Jan 3, 2020, 6:31 AM Sebastian Huber > wrote: >> >> --- >> eng/index.rst| 2 +- >> eng/prequalification.rst | 11 +++ >> eng/stakeholders.rst | 24 +++- >> 3 files changed, 19

Re: [PATCH 3/3] eng: Rework stakeholder chapter

2020-01-03 Thread Joel Sherrill
On Fri, Jan 3, 2020, 11:37 AM Gedare Bloom wrote: > On Fri, Jan 3, 2020 at 10:07 AM Joel Sherrill wrote: > > > > > > > > On Fri, Jan 3, 2020, 6:31 AM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> > >> --- > >> eng/index.rst| 2 +- > >>

[PATCH] bsps/irq: fix resource leak in irq-server.c

2020-01-03 Thread Gedare Bloom
Resource leak identified by Coverity (CID 1456675). The value of instances is leaked in case some but not all irq servers are created. It should be stored in bsp_interrupt_server_instances. --- bsps/shared/irq/irq-server.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Christian Mauderer
On 03/01/2020 18:37, Niteesh wrote: > On Fri, Jan 3, 2020 at 7:30 PM Christian Mauderer > wrote: > > On 03/01/2020 13:49, Niteesh wrote: > > I have gone through previous year works and selected a few topics > which > > I found > > interesting. >

Coding Convention: Sorting Order of Includes?

2020-01-03 Thread Gedare Bloom
Hello all, Vijay noted in another thread that: "For RTEMS, I don't see any preference mentioned in the docs for the order or includes: https://docs.rtems.org/branches/master/eng/coding-conventions.html In libbsd, however, the FreeBSD style guide is followed which has a preference for the order

Re: sptests/sp19/Makefile in git?

2020-01-03 Thread Gedare Bloom
OK must be something that got leftover on my filesystem during bootstrapping and switching branches between 4.10 and master. Sorry about the noise. On Fri, Jan 3, 2020 at 11:32 AM Joel Sherrill wrote: > > > > On Fri, Jan 3, 2020 at 12:22 PM Gedare Bloom wrote: >> >> With master, bootstrap -c

Re: [PATCH] cpukit/libfs: remove dead code from pipe/fifo.c

2020-01-03 Thread Joel Sherrill
This looks ok to me. On Fri, Jan 3, 2020, 12:51 PM Gedare Bloom wrote: > Dead code identified by Coverity (CID 1456678). The value of ret > at line 293 is always 0. > --- > cpukit/libfs/src/pipe/fifo.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/cpukit/libfs/src/pipe/fifo.c

[PATCH] cpukit/libfs: remove dead code from pipe/fifo.c

2020-01-03 Thread Gedare Bloom
Dead code identified by Coverity (CID 1456678). The value of ret at line 293 is always 0. --- cpukit/libfs/src/pipe/fifo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpukit/libfs/src/pipe/fifo.c b/cpukit/libfs/src/pipe/fifo.c index b64c0d95b6..579f118bfd 100644 ---

Re: [PATCH 3/3] eng: Rework stakeholder chapter

2020-01-03 Thread Gedare Bloom
Good. I spotted 2 typos that existed from before: On Fri, Jan 3, 2020 at 5:31 AM Sebastian Huber wrote: > > --- > eng/index.rst| 2 +- > eng/prequalification.rst | 11 +++ > eng/stakeholders.rst | 24 +++- > 3 files changed, 19 insertions(+), 18

Re: [PATCH 3/3] eng: Rework stakeholder chapter

2020-01-03 Thread Joel Sherrill
On Fri, Jan 3, 2020, 6:31 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > --- > eng/index.rst| 2 +- > eng/prequalification.rst | 11 +++ > eng/stakeholders.rst | 24 +++- > 3 files changed, 19 insertions(+), 18 deletions(-) > > diff

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

2020-01-03 Thread Joel Sherrill
On Fri, Jan 3, 2020, 12:08 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 03/01/2020 00:24, Gedare Bloom wrote: > > while ( !_Chain_Is_empty( > _thread->Priority_node.Inherited_priorities ) ) { > > +_ISR_Disable( level ); > > _Thread_Dequeue_priority_node( > >

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Niteesh
On Fri, Jan 3, 2020 at 7:30 PM Christian Mauderer wrote: > On 03/01/2020 13:49, Niteesh wrote: > > I have gone through previous year works and selected a few topics which > > I found > > interesting. > > 1. Basic Support for Trace Compass #3696 > > . > > A

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Christian Mauderer
On 03/01/2020 20:17, Niteesh wrote: > Finally, I am able to load IMAGES into Rpi3 using u-boot. But didn't > check whether FDT works. I added the AUX driver from my bare-metal > project for testing. I'll replace it with NS16550 soon. > I loaded the fileio example and it prints the board

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Niteesh
On Sat, Jan 4, 2020 at 1:29 AM Christian Mauderer wrote: > On 03/01/2020 18:37, Niteesh wrote: > > On Fri, Jan 3, 2020 at 7:30 PM Christian Mauderer > > wrote: > > > > On 03/01/2020 13:49, Niteesh wrote: > > > I have gone through previous year works and

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Niteesh
I problem was in uart_probe, and console_select. I totally forgot about console_select changing back to pl011. The application starts without any issues https://ibb.co/PZY5BWr but *rtems_shell_wait_for_input *return unsuccessful, maybe it fails because it calls ioctl and I haven't provided a

Re: What do you want to study in GSOC 2020?

2020-01-03 Thread Niteesh
On Sat, Jan 4, 2020 at 3:34 AM Christian Mauderer wrote: > On 03/01/2020 20:17, Niteesh wrote: > > Finally, I am able to load IMAGES into Rpi3 using u-boot. But didn't > > check whether FDT works. I added the AUX driver from my bare-metal > > project for testing. I'll replace it with NS16550

Re: [PATCH] Updated docs to use the standalone SIS simulator, instead of GDB inbuilt SIS for the erc32 BSP.

2020-01-03 Thread Niteesh
Just a reminder, it's almost been a week since I sent the patch. I also sent it a month ago, but it slipped from everyone's eyes. On Thu, Jan 2, 2020 at 9:45 PM Gedare Bloom wrote: > looks good to me. > > On Fri, Dec 27, 2019 at 5:02 AM G S Niteesh wrote: > > > > --- > >