[PATCH] shell: Fixing bug in line editing of the shell with CTRL-U.

2020-09-25 Thread Frank Kuehndel
This patch fixes a tiny bug in the command line editing of the RTEMS shell. Typing CTRL-U in the shell should remove all characters left of the cursor. After pressing CTRL-U, the current implementation does wrongly place the cursor at the end of the line instead at its beginning. To reproduce

[PATCH v2 3/9] score: Gather message queue control initialization

2020-09-25 Thread Sebastian Huber
Initialize the structure in a single code block after the error checks and calculations. Update #4007. --- cpukit/score/src/coremsg.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/cpukit/score/src/coremsg.c b/cpukit/score/src/coremsg.c index

[PATCH v2 4/9] score: Improve _CORE_message_queue_Initialize()

2020-09-25 Thread Sebastian Huber
Return a status code and differentiate between error conditions. Update #4007. --- cpukit/include/rtems/score/coremsgimpl.h | 29 cpukit/include/rtems/score/status.h | 6 + cpukit/posix/src/mqueueopen.c| 17 +++---

[PATCH v2 8/9] rtems: Add rtems_message_queue_construct()

2020-09-25 Thread Sebastian Huber
In contrast to message queues created by rtems_message_queue_create(), the message queues constructed by this directive use a user-provided message buffer storage area. Add RTEMS_MESSAGE_QUEUE_BUFFER() to define a message buffer type for message buffer storage areas. Update #4007. ---

[PATCH v2 9/9] validation: Test rtems_message_queue_construct()

2020-09-25 Thread Sebastian Huber
Update #4007. --- .../testsuites/validation/validation-0.yml|1 + .../validation/tc-message-construct-errors.c | 1868 + 2 files changed, 1869 insertions(+) create mode 100644 testsuites/validation/tc-message-construct-errors.c diff --git

[PATCH v2 5/9] score: Simplify CORE_message_queue_Buffer

2020-09-25 Thread Sebastian Huber
Merge CORE_message_queue_Buffer structure into CORE_message_queue_Buffer_control. Use a zero-length array for the actual message buffer. This reduces the structure size on all targets. Update #4007. --- cpukit/include/rtems/confdefs/wkspace.h | 2 +- cpukit/include/rtems/rtems/msgmp.h

[PATCH v2 1/9] score: Use RTEMS_ALIGN_UP()

2020-09-25 Thread Sebastian Huber
Update #4007. --- cpukit/score/src/coremsg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cpukit/score/src/coremsg.c b/cpukit/score/src/coremsg.c index fc6f9eba03..af8dbd6583 100644 --- a/cpukit/score/src/coremsg.c +++ b/cpukit/score/src/coremsg.c @@ -51,7 +51,6 @@

[PATCH v2 0/9] Add rtems_message_queue_construct()

2020-09-25 Thread Sebastian Huber
In contrast to message queues created by rtems_message_queue_create(), the message queues constructed by this directive use a user-provided message buffer storage area. Add RTEMS_MESSAGE_QUEUE_BUFFER() to define a message buffer type for message buffer storage areas. v2: Fix MESSAGE_SIZE_LIMIT

[PATCH v2 7/9] rtems: Remove Message_queue_Control::attribute_set

2020-09-25 Thread Sebastian Huber
Add Message_queue_Control::is_global if RTEMS_MULTIPROCESSING is defined. This reduces the Message_queue_Control size in standard RTEMS configurations. Update #4007. --- cpukit/include/rtems/rtems/messagedata.h | 6 -- cpukit/libmisc/monitor/mon-queue.c | 16 +++-

[PATCH v2 2/9] score: Fix allocation size calculation

2020-09-25 Thread Sebastian Huber
The previous multiplication error check is broken on 64-bit machines. Use the recommended check from SEI CERT C Coding Standard, "INT30-C. Ensure that unsigned integer operations do not wrap". Make sure the message size computation does not overflow. Update #4007. ---

[PATCH v2 6/9] score: Add

2020-09-25 Thread Sebastian Huber
Move the CORE_message_queue_Buffer definition to a separate header file to be able to use it independent of the remaining Message Queue Handler API. Change license to BSD-2-Clause according to file history. Update #3053. Update #4007. --- cpukit/headers.am | 1 +

BSP_CONSOLE_MINOR option for Zynq board with new build system

2020-09-25 Thread Jan.Sommer
Hello, I am currently making my first steps with the new build system and so far it is amazing. Especially, the inheritance option is very handy for maintaining different configurations. Therefore, a big thank you to Sebastian and everyone else involved. I ran into a smaller problem when

Re: [PATCH v4] Test for clock_nanosleep() with CLOCK_MONOTONIC option

2020-09-25 Thread Utkarsh Rai
Hello, Can someone please review this. I would like to work on the suggested changes over the weekend. On Mon, Sep 21, 2020 at 8:45 PM Utkarsh Rai wrote: > From: Utkarsh > > Closes #3890 > > Signed-off-by: Utkarsh Rai > --- > spec/build/testsuites/psxtests/grp.yml| 2 + >

Re: BSP_CONSOLE_MINOR option for Zynq board with new build system

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:08, Gedare Bloom wrote: Yes, this could be a potential problem in several BSPs. I used a script to convert the BSP options, but to detect if it was an integer or boolean type was just an heuristic. In order to fix this, you first have to find the build specification item of the

[PATCH v1 0/8] AArch64 port and BSPs

2020-09-25 Thread Kinsey Moore
This patch set includes changes to move several required drivers into bsps/shared so that they can be used by both AArch32(known in RTEMS as "arm") and AArch64 as well as possibly other future architectures. The changes made in breaking out these drivers have been tested on 10 or so affected BSPs

[PATCH v1 5/8] bsps/shared: Add PSCI-based bspreset implementation

2020-09-25 Thread Kinsey Moore
This adds a bsp_reset implementation based on the ARM PSCI specification often present in ARMv8 systems. --- bsps/shared/start/bspreset-psci.c | 48 +++ 1 file changed, 48 insertions(+) create mode 100644 bsps/shared/start/bspreset-psci.c diff --git

[PATCH v1 6/8] score: Add AArch64 port

2020-09-25 Thread Kinsey Moore
This adds a CPU port for AArch64(ARMv8) with support for exceptions and interrupts. --- cpukit/include/rtems/score/tls.h | 2 +- .../cpu/aarch64/aarch64-context-validate.S| 295 ++ .../aarch64-context-volatile-clobber.S| 90 +++

[PATCH v1 8/8] bsps: Add Cortex-A53 ILP32 BSP variant

2020-09-25 Thread Kinsey Moore
This adds an AArch64 ILP32 BSP variant based on Qemu's Cortex-A53 emulation with interrupt support using GICv3 and clock support using the ARM GPT. --- bsps/aarch64/shared/start/linkcmds.base | 4 -- bsps/aarch64/shared/start/start.S | 16 +

[PATCH v1 2/8] spec: Add missing spintrcritical24 definition

2020-09-25 Thread Kinsey Moore
--- spec/build/bsps/tstnointrcrit.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/build/bsps/tstnointrcrit.yml b/spec/build/bsps/tstnointrcrit.yml index 0460aaabb3..46f7d974c8 100644 --- a/spec/build/bsps/tstnointrcrit.yml +++ b/spec/build/bsps/tstnointrcrit.yml @@ -24,6 +24,7 @@

[PATCH v1 7/8] bsps: Add Cortex-A53 LP64 basic BSP

2020-09-25 Thread Kinsey Moore
This adds an AArch64 basic BSP based on Qemu's Cortex-A53 emulation with interrupt support using GICv3 and clock support using the ARM GPT. --- bsps/aarch64/a53/console/console.c| 61 ++ bsps/aarch64/a53/include/bsp.h| 74 +++ bsps/aarch64/a53/include/bsp/irq.h

[PATCH v1 4/8] bsps: Break out AArch32 GICv3 support

2020-09-25 Thread Kinsey Moore
This breaks out AArch32-specific code so that the shared GICv3 code can be reused by other architectures. --- bsps/arm/beagle/irq/irq.c | 1 + bsps/arm/csb336/irq/irq.c | 1 + bsps/arm/csb337/irq/irq.c | 1 +

[PATCH v1 3/8] bsps: Break out AArch32 portions of GPT driver

2020-09-25 Thread Kinsey Moore
This breaks AArch32-specific portions of the ARM GPT driver into their own file so that the generic code can be moved for reuse by other architectures. --- bsps/arm/imx/headers.am | 1 + bsps/arm/imx/include/bsp.h| 2 - bsps/arm/imx/start/bspstart.c

[PATCH v1 1/8] Move ARM PL011 UART driver

2020-09-25 Thread Kinsey Moore
This UART driver is now needed for BSPs other than ARM. --- bsps/arm/headers.am| 2 -- bsps/arm/raspberrypi/console/console-config.c | 2 +- bsps/arm/realview-pbx-a9/include/bsp/console.h | 2 +- bsps/arm/xen/console/console.c

Re: [PATCH] user: Add migration hints from old build system

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:12, Gedare Bloom wrote: +Migration from Autoconf/Automake + + +The Autoconf/Automake based build system used a ``configure`` command to +configure a single BSP and ``make`` to build it. The ``configure`` command is You can make multiple BSPs,

Re: [PATCH] shell: Fixing bug in line editing of the shell with CTRL-U.

2020-09-25 Thread Joel Sherrill
On Fri, Sep 25, 2020, 10:06 AM Gedare Bloom wrote: > On Fri, Sep 25, 2020 at 3:11 AM Frank Kuehndel > wrote: > > > > This patch fixes a tiny bug in the command line editing of the RTEMS > shell. Typing CTRL-U in the shell should remove all characters left of the > cursor. After pressing CTRL-U,

RE: BSP_CONSOLE_MINOR option for Zynq board with new build system

2020-09-25 Thread Jan.Sommer
Thanks, I will have a look at it and check if your changes fix the issue. Have a nice week-end, Jan > -Original Message- > From: Sebastian Huber > Sent: Friday, September 25, 2020 4:14 PM > To: Sommer, Jan ; devel@rtems.org > Subject: Re: BSP_CONSOLE_MINOR option for Zynq board with

Re: [PATCH 7/8] rtems: Remove Message_queue_Control::attribute_set

2020-09-25 Thread Gedare Bloom
On Thu, Sep 24, 2020 at 10:35 PM Sebastian Huber wrote: > > On 24/09/2020 18:45, Gedare Bloom wrote: > > > There should be an mptest added for global mq > This should be already covered by tests mp09 .. mp13. I wasn't clear. Should we test global mq with this 'construct' feature also?

Re: BSP_CONSOLE_MINOR option for Zynq board with new build system

2020-09-25 Thread Gedare Bloom
On Fri, Sep 25, 2020 at 8:13 AM Sebastian Huber wrote: > > Hello Jan, > > On 25/09/2020 15:36, jan.som...@dlr.de wrote: > > Hello, > > > > I am currently making my first steps with the new build system and so far > > it is amazing. > > Especially, the inheritance option is very handy for

Re: [PATCH] user: Add migration hints from old build system

2020-09-25 Thread Gedare Bloom
On Thu, Sep 24, 2020 at 11:44 PM Sebastian Huber wrote: > > Update #3818. > --- > user/bld/index.rst | 84 -- > 1 file changed, 82 insertions(+), 2 deletions(-) > > diff --git a/user/bld/index.rst b/user/bld/index.rst > index b47cee8..376475c 100644 >

Re: [PATCH 7/8] rtems: Remove Message_queue_Control::attribute_set

2020-09-25 Thread Joel Sherrill
On Thu, Sep 24, 2020 at 7:13 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Add Message_queue_Control::is_global if RTEMS_MULTIPROCESSING is defined. > This > reduces the Message_queue_Control size in standard RTEMS configurations. > > Update #4007. > --- >

Re: BSP_CONSOLE_MINOR option for Zynq board with new build system

2020-09-25 Thread Sebastian Huber
Hello Jan, On 25/09/2020 15:36, jan.som...@dlr.de wrote: Hello, I am currently making my first steps with the new build system and so far it is amazing. Especially, the inheritance option is very handy for maintaining different configurations. Therefore, a big thank you to Sebastian and

Re: [PATCH] shell: Fixing bug in line editing of the shell with CTRL-U.

2020-09-25 Thread Gedare Bloom
On Fri, Sep 25, 2020 at 3:11 AM Frank Kuehndel wrote: > > This patch fixes a tiny bug in the command line editing of the RTEMS shell. > Typing CTRL-U in the shell should remove all characters left of the cursor. > After pressing CTRL-U, the current implementation does wrongly place the >

Re: BSP_CONSOLE_MINOR option for Zynq board with new build system

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:14, Gedare Bloom wrote: On Fri, Sep 25, 2020 at 9:11 AM Sebastian Huber wrote: On 25/09/2020 17:08, Gedare Bloom wrote: Yes, this could be a potential problem in several BSPs. I used a script to convert the BSP options, but to detect if it was an integer or boolean type

[PATCH v1 1/2] tester: Add a53_lp64_qemu.ini

2020-09-25 Thread Kinsey Moore
--- tester/rtems/testing/bsps/a53_lp64_qemu.ini | 38 + 1 file changed, 38 insertions(+) create mode 100644 tester/rtems/testing/bsps/a53_lp64_qemu.ini diff --git a/tester/rtems/testing/bsps/a53_lp64_qemu.ini b/tester/rtems/testing/bsps/a53_lp64_qemu.ini new file mode

[PATCH v1 2/2] tester: Add a53_ilp32_qemu.ini

2020-09-25 Thread Kinsey Moore
--- tester/rtems/testing/bsps/a53_ilp32_qemu.ini | 38 1 file changed, 38 insertions(+) create mode 100644 tester/rtems/testing/bsps/a53_ilp32_qemu.ini diff --git a/tester/rtems/testing/bsps/a53_ilp32_qemu.ini b/tester/rtems/testing/bsps/a53_ilp32_qemu.ini new file mode

Re: [PATCH 7/8] rtems: Remove Message_queue_Control::attribute_set

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:00, Gedare Bloom wrote: On Thu, Sep 24, 2020 at 10:35 PM Sebastian Huber wrote: On 24/09/2020 18:45, Gedare Bloom wrote: There should be an mptest added for global mq This should be already covered by tests mp09 .. mp13. I wasn't clear. Should we test global mq with this

Re: BSP_CONSOLE_MINOR option for Zynq board with new build system

2020-09-25 Thread Gedare Bloom
On Fri, Sep 25, 2020 at 9:11 AM Sebastian Huber wrote: > > On 25/09/2020 17:08, Gedare Bloom wrote: > > >> Yes, this could be a potential problem in several BSPs. I used a script > >> to convert the BSP options, but to detect if it was an integer or > >> boolean type was just an heuristic. In

[PATCH v1 1/2] cpu-supplement: Fix formatting and missing words

2020-09-25 Thread Kinsey Moore
--- cpu-supplement/arm.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cpu-supplement/arm.rst b/cpu-supplement/arm.rst index 63aa532..26d88ea 100644 --- a/cpu-supplement/arm.rst +++ b/cpu-supplement/arm.rst @@ -34,7 +34,7 @@ for the values. Count Leading Zeroes

[PATCH v1 2/2] Add AArch64 documentation

2020-09-25 Thread Kinsey Moore
--- cpu-supplement/aarch64.rst | 129 + user/bsps/aarch64/a53.rst | 26 user/bsps/bsps-aarch64.rst | 2 +- 3 files changed, 156 insertions(+), 1 deletion(-) create mode 100644 cpu-supplement/aarch64.rst create mode 100644

Configure options not in waf

2020-09-25 Thread Joel Sherrill
Hi There may be more but so far, the generated default config.ini does not appear to have settings which correspond to --enable-profiling or --enable-cxx. What is the way to manage these settings in waf? --joel ___ devel mailing list devel@rtems.org

Re: [PATCH 7/8] rtems: Remove Message_queue_Control::attribute_set

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:42, Joel Sherrill wrote: diff --git a/cpukit/libmisc/monitor/mon-queue.c b/cpukit/libmisc/monitor/mon-queue.c index 9430797c6c..aadfcd3989 100644 --- a/cpukit/libmisc/monitor/mon-queue.c +++ b/cpukit/libmisc/monitor/mon-queue.c @@ -16,7 +16,21 @@

Re: [PATCH v1 6/8] score: Add AArch64 port

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:27, Kinsey Moore wrote: diff --git a/cpukit/include/rtems/score/tls.h b/cpukit/include/rtems/score/tls.h index 65a49d87be..8c15eee569 100644 --- a/cpukit/include/rtems/score/tls.h +++ b/cpukit/include/rtems/score/tls.h @@ -85,7 +85,7 @@ typedef struct TLS_Thread_control_block {

Re: Configure options not in waf

2020-09-25 Thread Joel Sherrill
On Fri, Sep 25, 2020, 11:11 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 25/09/2020 17:39, Joel Sherrill wrote: > > > Hi > > > > There may be more but so far, the generated default config.ini does > > not appear to have settings which correspond to --enable-profiling or >

RE: [PATCH v1 6/8] score: Add AArch64 port

2020-09-25 Thread Kinsey Moore
-Original Message- From: Sebastian Huber Sent: Friday, September 25, 2020 11:20 To: Kinsey Moore ; devel@rtems.org Subject: Re: [PATCH v1 6/8] score: Add AArch64 port On 25/09/2020 17:27, Kinsey Moore wrote: > diff --git a/cpukit/include/rtems/score/tls.h >

Re: configure options translated to waf config.ini?

2020-09-25 Thread Gedare Bloom
On Thu, Sep 24, 2020 at 1:33 PM Chris Johns wrote: > > On 25/9/20 2:48 am, Joel Sherrill wrote: > > I can't find any documentation which guides translating a > > RTEMS configure command into the appropriate set of > > options in a config.ini file for waf. The only example I could > > find has

Re: Configure options not in waf

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:39, Joel Sherrill wrote: Hi There may be more but so far, the generated default config.ini does not appear to have settings which correspond to --enable-profiling or --enable-cxx. The --enable-profiling is RTEMS_PROFILING. I will add it to the migration section. C++ is

Re: [PATCH v1 6/8] score: Add AArch64 port

2020-09-25 Thread Sebastian Huber
On 25/09/2020 17:27, Kinsey Moore wrote: diff --git a/cpukit/score/cpu/aarch64/aarch64-context-validate.S b/cpukit/score/cpu/aarch64/aarch64-context-validate.S new file mode 100644 index 00..afd339ad85 --- /dev/null +++ b/cpukit/score/cpu/aarch64/aarch64-context-validate.S @@ -0,0

Re: Configure options not in waf

2020-09-25 Thread Sebastian Huber
On 25/09/2020 18:36, Joel Sherrill wrote: On Fri, Sep 25, 2020, 11:11 AM Sebastian Huber > wrote: On 25/09/2020 17:39, Joel Sherrill wrote: > Hi > > There may be more but so far, the generated default config.ini does > not

Re: [PATCH 7/8] rtems: Remove Message_queue_Control::attribute_set

2020-09-25 Thread Gedare Bloom
On Fri, Sep 25, 2020 at 10:21 AM Sebastian Huber wrote: > > On 25/09/2020 17:42, Joel Sherrill wrote: > > > diff --git a/cpukit/libmisc/monitor/mon-queue.c > > b/cpukit/libmisc/monitor/mon-queue.c > > index 9430797c6c..aadfcd3989 100644 > > --- a/cpukit/libmisc/monitor/mon-queue.c

Re: qoriq_e6500_32 with smp - compiler error

2020-09-25 Thread Joel Sherrill
On Fri, Sep 25, 2020, 2:36 PM Gedare Bloom wrote: > When I build the qoriq_e6500_32 with SMP enabled in the new build > system, I hit this error: > [ 77/4070] Compiling bsps/powerpc/shared/cache/cache.c > In file included from ../../../bsps/powerpc/shared/cache/cache.c:319: >

Re: [PATCH] Confstr Patches

2020-09-25 Thread Joel Sherrill
This is the last discussion of the patch I could find. Have you made these changes? Also if it is going to go on the master, the waf build side needs updating. For the near future, both build systems will be in place so we can ensure the transition is smooth and doesn't introduce anything.

qoriq_e6500_32 with smp - compiler error

2020-09-25 Thread Gedare Bloom
When I build the qoriq_e6500_32 with SMP enabled in the new build system, I hit this error: [ 77/4070] Compiling bsps/powerpc/shared/cache/cache.c In file included from ../../../bsps/powerpc/shared/cache/cache.c:319: ../../../bsps/powerpc/include/../../../bsps/shared/cache/cacheimpl.h:92:2:

Re: [PATCH v1 6/8] score: Add AArch64 port

2020-09-25 Thread Joel Sherrill
On Fri, Sep 25, 2020, 1:45 PM Kinsey Moore wrote: > -Original Message- > From: Sebastian Huber > Sent: Friday, September 25, 2020 11:20 > To: Kinsey Moore ; devel@rtems.org > Subject: Re: [PATCH v1 6/8] score: Add AArch64 port > > On 25/09/2020 17:27, Kinsey Moore wrote: > > > diff

Removed 'unicode' keyword from pkgconfig.py

2020-09-25 Thread Stephen Clark
I have attached a patch to remove the use of the 'unicode' keyword from the pkgconfig.py file. This addresses #4094, where this same patch has been attached. I was able to run the sb-set-builder script on the master, so I don't believe this problem exists on that branch. Thanks, Stephen Clark

Re: Removed 'unicode' keyword from pkgconfig.py

2020-09-25 Thread Chris Johns
On 26/9/20 8:13 am, Stephen Clark wrote: > I have attached a patch to remove the use of the ‘unicode’ keyword from the > pkgconfig.py file. > > This addresses #4094, where this same patch has been attached. > > I was able to run the sb-set-builder script on the master, so I don’t believe > this