Re: Out of tree builds with waf?

2020-11-08 Thread Sebastian Huber 

On 05/11/2020 19:02, Sebastian Huber wrote:


On 05/11/2020 18:27, Sebastian Huber wrote:



On 05/11/2020 18:22, Sebastian Huber wrote:

On 05/11/2020 18:16, Andrew Butterfield wrote:


 I'm not a waf expert, but might this section in their book help?

https://waf.io/book/#_fundamental_waf_commands 



Can variables `top` and `out` in the example there be manipulated 
to do want you want?


Yes, the --top and --out options works somehow, but I get a warning 
like this:


Waf: Entering directory 
`/home/EB/sebastian_h/src/rtems-source-builder/tmp/build/sparc/erc32'
CWD /home/EB/sebastian_h/src/rtems-source-builder/tmp is not under 
/home/EB/sebastian_h/src/rtems, forcing --targets=* (run distclean?)


Also the documentation says "Though Waf may be called from any 
folder containing a /wscript/ file,", so I am not sure if this is 
really supported what I am doing.


What works is something like this:

./waf configure --out $PWD/tmp/xxx/build

called from the source tree. However, this has some side-effects.

1. A .waf* directory is created in the source tree (this is an issue 
with a read-only source tree).


2. Waf somehow remembers this configuration. You can call "./waf" to 
build it. So, there must be some hidden state in the source tree. 
This is not really an out of tree build. You cannot have multiple 
independent build trees.


This happens if I use a read-only source tree:

~/tmp/out-of-tree > pwd
/home/EB/sebastian_h/tmp/out-of-tree
~/tmp/out-of-tree > ~/src/rtems/waf --top $HOME/src/rtems-read-only 
--out $PWD/build configure --rtems-config $PWD/config.ini
Setting top to   : 
/home/EB/sebastian_h/src/rtems-read-only
Setting out to   : 
/home/EB/sebastian_h/tmp/out-of-tree/build

Configure board support package (BSP)    : sparc/erc32
Checking for program 'sparc-rtems6-gcc'  : 
/opt/rtems/6/bin/sparc-rtems6-gcc
Checking for program 'sparc-rtems6-g++'  : 
/opt/rtems/6/bin/sparc-rtems6-g++
Checking for program 'sparc-rtems6-ar'   : 
/opt/rtems/6/bin/sparc-rtems6-ar
Checking for program 'sparc-rtems6-ld'   : 
/opt/rtems/6/bin/sparc-rtems6-ld
Checking for program 'ar'    : 
/opt/rtems/6/bin/sparc-rtems6-ar
Checking for program 'g++, c++'  : 
/opt/rtems/6/bin/sparc-rtems6-g++
Checking for program 'ar'    : 
/opt/rtems/6/bin/sparc-rtems6-ar
Checking for program 'gas, gcc'  : 
/opt/rtems/6/bin/sparc-rtems6-gcc
Checking for program 'ar'    : 
/opt/rtems/6/bin/sparc-rtems6-ar
Checking for program 'gcc, cc'   : 
/opt/rtems/6/bin/sparc-rtems6-gcc
Checking for program 'ar'    : 
/opt/rtems/6/bin/sparc-rtems6-ar

Checking for asm flags '-MMD'    : yes
Checking for c flags '-MMD'  : yes
Checking for cxx flags '-MMD'    : yes
Traceback (most recent call last):
  File 
"/home/EB/sebastian_h/src/rtems/.waf-2.0.20-36f5354d605298f6a89c09e0c7ef6c1d/waflib/Scripting.py", 
line 119, in waf_entry_point

    run_commands()
  File 
"/home/EB/sebastian_h/src/rtems/.waf-2.0.20-36f5354d605298f6a89c09e0c7ef6c1d/waflib/Scripting.py", 
line 182, in run_commands

    ctx=run_command(cmd_name)
  File 
"/home/EB/sebastian_h/src/rtems/.waf-2.0.20-36f5354d605298f6a89c09e0c7ef6c1d/waflib/Scripting.py", 
line 173, in run_command

    ctx.execute()
  File 
"/home/EB/sebastian_h/src/rtems/.waf-2.0.20-36f5354d605298f6a89c09e0c7ef6c1d/waflib/Configure.py", 
line 101, in execute

    env.store(os.path.join(Context.run_dir,Options.lockfile))
  File 
"/home/EB/sebastian_h/src/rtems/.waf-2.0.20-36f5354d605298f6a89c09e0c7ef6c1d/waflib/ConfigSet.py", 
line 146, in store

    Utils.writef(filename,''.join(buf))
  File 
"/home/EB/sebastian_h/src/rtems/.waf-2.0.20-36f5354d605298f6a89c09e0c7ef6c1d/waflib/Utils.py", 
line 160, in writef

    with open(fname,m)as f:
IOError: [Errno 13] Permission denied: 
'/home/EB/sebastian_h/src/rtems-read-only/.lock-waf_linux2_build'


This error can be fixed with the "--no-lock-in-top --no-lock-in-run" 
options. The


CWD /home/EB/sebastian_h/src/rtems-source-builder/tmp is not under 
/home/EB/sebastian_h/src/rtems, forcing --targets=* (run distclean?)


warning can be avoided using "--targets=*". So, with a couple of extra 
options it seems to be possible to do an out of tree build with 
read-only sources.


--
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier: 
https://embedded-brains.de/datenschutzerklaerung/

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems 8/8] jffs2: Replace non-ASCII copyright character

2020-11-08 Thread Christian Mauderer 

On 09/11/2020 07:58, Sebastian Huber wrote:

On 07/11/2020 14:23, Christian Mauderer wrote:

diff --git a/cpukit/libfs/src/jffs2/include/linux/jffs2.h 
b/cpukit/libfs/src/jffs2/include/linux/jffs2.h

index a18b719f49..202cb46b8d 100644
--- a/cpukit/libfs/src/jffs2/include/linux/jffs2.h
+++ b/cpukit/libfs/src/jffs2/include/linux/jffs2.h
@@ -1,8 +1,8 @@
  /*
   * JFFS2 -- Journalling Flash File System, Version 2.
   *
- * Copyright © 2001-2007 Red Hat, Inc.
- * Copyright © 2004-2010 David Woodhouse
+ * Copyright (c) 2001-2007 Red Hat, Inc.
+ * Copyright (c) 2004-2010 David Woodhouse

This code is imported from Linux. Do we really have to change this?



Hello Sebastian,

like already stated in the introduction mail: I'm not really sure about 
this one and about patch 6 and 7 myself because they touch imported 
code. So no problem if we don't add the last three ones.


Best regards

Christian

--

embedded brains GmbH
Christian MAUDERER
Dornierstr. 4
82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] libtests/dl06: Add -lm

2020-11-08 Thread Sebastian Huber 

On 09/11/2020 02:23, Chris Johns wrote:


On 3/11/20 3:39 am, Sebastian Huber wrote:

There is probably something wrong with this test program.  If it is compiled
without function/data sections, no optimization, and no linker garbage
collection, then there is an undefined reference to atan2() and tan().

These symbols are referenced in the loaded module ...

https://git.rtems.org/rtems/tree/testsuites/libtests/dl06/dl06-o2.c

This test gets rtems-ld with the RAP format to collect the atan1 and tan code
into the loaded module. They should not be present in the base image. The libm
library is used because it is _not_ part of the standard libraries linked and is
available everywhere.


Fix this issue by adding -lm.

Is the error linking the base kernel image or the RAP loadable module?

If it is the loadable module and this is how you add the libraries to be
searched to the rtems-ld command then the fix is needed and there is no problem.
If the error was in the base kernel image then I suggest something else is wrong
because those symbols should not be present in the base image. If the build
system can support options for just rtems-ld then adding it there would be good.


The error is in this command:


[4044/4050] Processing link: 
build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-o1.o 
build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-o2.o 
build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-tar.o 
build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/init.o 
build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl-load.o 
build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-sym.o -> 
build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06.exe
08:21:03 runner ['/build/rtems/6/bin/arm-rtems6-gcc', '-qnolinkcmds', 
'-T', 'linkcmds.realview_pbx_a9_qemu', 
'/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-o1.o', 
'/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-o2.o', 
'/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-tar.o', 
'/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/init.o', 
'/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl-load.o', 
'/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-sym.o', 
'-o/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06.exe', 
'-Wl,--wrap=printf', '-Wl,--wrap=puts', '-L.', '-lrtemscpu', 
'-lrtemsbsp', '-lrtemstest', '-qrtems', '-march=armv7-a', '-mthumb', 
'-mfpu=neon', '-mfloat-abi=hard', '-mtune=cortex-a9', 
'-L/home/EB/sebastian_h/git-rtems-6/bsps/arm/shared/start', 
'-L/home/EB/sebastian_h/git-rtems-6/bsps/arm/realview-pbx-a9/start']
/build/rtems/6/lib/gcc/arm-rtems6/10.2.1/../../../../arm-rtems6/bin/ld: 
/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-o2.o: 
in function `dl_o2_func2':
/home/EB/sebastian_h/git-rtems-6/testsuites/libtests/dl06/dl06-o2.c:31: 
undefined reference to `atan2'
/build/rtems/6/lib/gcc/arm-rtems6/10.2.1/../../../../arm-rtems6/bin/ld: 
/home/EB/sebastian_h/git-rtems-6/build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl06/dl06-o2.o: 
in function `dl_o2_func3':


/home/EB/sebastian_h/git-rtems-6/testsuites/libtests/dl06/dl06-o2.c:37: 
undefined reference to `tan'


I used the following config.ini:

[arm/realview_pbx_a9_qemu]
BUILD_LIBTESTS = True
OPTIMIZATION_FLAGS = -O0 -g
LDFLAGS =



More of a concern is no error. I wonder if the code is being inlined when there
is FPU support. Maybe the test needs to create a library linking to it to be
more robust?

Using these functions without -fno-builtin is not really robust.

--
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier: 
https://embedded-brains.de/datenschutzerklaerung/

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems 8/8] jffs2: Replace non-ASCII copyright character

2020-11-08 Thread Sebastian Huber 

On 07/11/2020 14:23, Christian Mauderer wrote:


diff --git a/cpukit/libfs/src/jffs2/include/linux/jffs2.h 
b/cpukit/libfs/src/jffs2/include/linux/jffs2.h
index a18b719f49..202cb46b8d 100644
--- a/cpukit/libfs/src/jffs2/include/linux/jffs2.h
+++ b/cpukit/libfs/src/jffs2/include/linux/jffs2.h
@@ -1,8 +1,8 @@
  /*
   * JFFS2 -- Journalling Flash File System, Version 2.
   *
- * Copyright © 2001-2007 Red Hat, Inc.
- * Copyright © 2004-2010 David Woodhouse
+ * Copyright (c) 2001-2007 Red Hat, Inc.
+ * Copyright (c) 2004-2010 David Woodhouse

This code is imported from Linux. Do we really have to change this?

--
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier: 
https://embedded-brains.de/datenschutzerklaerung/

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Breaking Long Lines

2020-11-08 Thread Sebastian Huber 

On 09/11/2020 01:52, Chris Johns wrote:


On 6/11/20 7:11 pm, Sebastian Huber wrote:

Hello,

for breaking long lines we have currently:

"Should be replaced with

.. code-block:: c

   for (
     initialization = statement;
     a + really + longish + statement + that + evaluates + to <
     a + boolean;
     another + statement++
   ) {
     z = a + really + longish + statement + that + needs +
     two + lines + gets + indented + four + more +
     spaces + on + the + second + and + subsequent +
     lines + and + broken + up + at + operators;
   }

Note that indentations should add 2 nesting levels (4 space characters, not 
tabs)."

Do we really need two indent levels for breaking long lines in block statements?
I would just say that the continuation of a broken line is indented by one
level. The example would look like this (please note the change in the for loop
"a + boolean"):

.. code-block:: c

   for (
     initialization = statement;
     a + really + longish + statement + that + evaluates + to <
   a + boolean;
     another + statement++
   ) {
     z = a + really + longish + statement + that + needs +
   two + lines + gets + indented + four + more +
   spaces + on + the + second + and + subsequent +
   lines + and + broken + up + at + operators;

I sometimes add parentheses to aid indenting:

   z = (a + really + longish + stat
  
lines + and + broken + up + at + operators);

Emacs automatically indents to the opening `(`. This is mentioned in the GNU
coding standard. We however have this statement in our standard ...

  Avoid excess parentheses. Learn the operator precedence. rules.


Yes, and I think this is a good rule.

My question is if we really should indent by two levels for the 
continuation of long lines.


variable = ...

foo bar continuation ...

vs.

variable = ...

foo bar continuation ...

I never noticed the first style in the RTEMS sources and was a bit 
surprised of this text.


I also missed the recommendation to place the operators as the last 
token, but I will do this now.


--
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier: 
https://embedded-brains.de/datenschutzerklaerung/

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v2 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-11-08 Thread Niteesh G. S. 
Hello,

Pinging again incase this patch missed your attention.

Thanks,
Niteesh.

On Tue, Nov 3, 2020 at 11:49 PM G S Niteesh Babu 
wrote:

> Added a basic test for the implemented RTEMS OFW
> API.
> ---
>  spec/build/testsuites/libtests/grp.yml   |   2 +
>  spec/build/testsuites/libtests/ofw01.yml |  21 +++
>  testsuites/libtests/ofw01/init.c | 187 +++
>  testsuites/libtests/ofw01/ofw01.doc  |  29 
>  testsuites/libtests/ofw01/ofw01.scn  |   2 +
>  testsuites/libtests/ofw01/some.c |  72 +
>  testsuites/libtests/ofw01/some.dts   |  76 +
>  testsuites/libtests/ofw01/some.h |  15 ++
>  8 files changed, 404 insertions(+)
>  create mode 100644 spec/build/testsuites/libtests/ofw01.yml
>  create mode 100644 testsuites/libtests/ofw01/init.c
>  create mode 100644 testsuites/libtests/ofw01/ofw01.doc
>  create mode 100644 testsuites/libtests/ofw01/ofw01.scn
>  create mode 100644 testsuites/libtests/ofw01/some.c
>  create mode 100644 testsuites/libtests/ofw01/some.dts
>  create mode 100644 testsuites/libtests/ofw01/some.h
>
> diff --git a/spec/build/testsuites/libtests/grp.yml
> b/spec/build/testsuites/libtests/grp.yml
> index b9ca014b0d..1aa136854a 100644
> --- a/spec/build/testsuites/libtests/grp.yml
> +++ b/spec/build/testsuites/libtests/grp.yml
> @@ -316,6 +316,8 @@ links:
>uid: write
>  - role: build-dependency
>uid: writev
> +- role: build-dependency
> +  uid: ofw01
>  type: build
>  use-after:
>  - rtemstest
> diff --git a/spec/build/testsuites/libtests/ofw01.yml
> b/spec/build/testsuites/libtests/ofw01.yml
> new file mode 100644
> index 00..8517c58bad
> --- /dev/null
> +++ b/spec/build/testsuites/libtests/ofw01.yml
> @@ -0,0 +1,21 @@
> +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> +build-type: test-program
> +cflags: []
> +copyrights:
> +- Copyright (C) 2020 Niteesh G S
> +cppflags: []
> +cxxflags: []
> +enabled-by: true
> +features: c cprogram
> +includes: []
> +ldflags:
> +- -Wl,--wrap=bsp_fdt_get
> +links: []
> +source:
> +- testsuites/libtests/ofw01/init.c
> +- testsuites/libtests/ofw01/some.c
> +stlib: []
> +target: testsuites/libtests/ofw01.exe
> +type: build
> +use-after: []
> +use-before: []
> diff --git a/testsuites/libtests/ofw01/init.c
> b/testsuites/libtests/ofw01/init.c
> new file mode 100644
> index 00..82ee5eb11f
> --- /dev/null
> +++ b/testsuites/libtests/ofw01/init.c
> @@ -0,0 +1,187 @@
> +/* SPDX-License-Identifier: BSD-2-Clause */
> +
> +/*
> + * Copyright (C) <2020> Niteesh G S 
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *notice, this list of conditions and the following disclaimer in the
> + *documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS
> BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
> BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
> THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#ifdef HAVE_CONFIG_H
> +#include "config.h"
> +#endif
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#include "some.h"
> +
> +#define BUF_SIZE 100
> +
> +const char rtems_test_name[] = "OFW 01";
> +
> +const void *__wrap_bsp_fdt_get(void);
> +const void *__real_bsp_fdt_get(void);
> +
> +const void *__wrap_bsp_fdt_get(void)
> +{
> +  if (some_bin != NULL) {
> +return _bin[0];
> +  }
> +
> +  return __real_bsp_fdt_get();
> +}
> +
> +static void Init(rtems_task_argument arg)
> +{
> +  int rv;
> +  phandle_t d;
> +  phandle_t l;
> +  phandle_t t;
> +  phandle_t c;
> +  phandle_t a;
> +  phandle_t b;
> +  phandle_t q;
> +  phandle_t root;
> +  phandle_t temp;
> +  uint32_t *arr;
> +  char buf[BUF_SIZE];
> +  char *bufp;
> +  ssize_t buf_len;
> +  rtems_ofw_memory_area reg;
> +  rtems_ofw_memory_area regs[2];
> +  rtems_vector_number intr;
> +  rtems_vector_number intrs[2];
> +  TEST_BEGIN();
> +  buf_len = sizeof(buf);
> +  /*
> +   * Cannot use fdt_path_offset to compare because
> +

[PATCH rtems 7/8] bsp/atsam: Replace non-ASCII characters

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

Note that this replacement is pure guess. It has been done using a
unicode converter tool that spit out the pTq. That is most likely a math
notation for some vector operation.
---
 bsps/arm/atsam/contrib/libraries/libchip/source/aes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsps/arm/atsam/contrib/libraries/libchip/source/aes.c 
b/bsps/arm/atsam/contrib/libraries/libchip/source/aes.c
index 010e7cf8d1..27f543218f 100644
--- a/bsps/arm/atsam/contrib/libraries/libchip/source/aes.c
+++ b/bsps/arm/atsam/contrib/libraries/libchip/source/aes.c
@@ -249,7 +249,7 @@ void AES_SetGcmHash(uint32_t *hash)
 
 /**
  * \brief Get The four 32-bit Tag which contain the final 128-bit GCM
- * Authentication tag ��T�� when GCM processing is complete.
+ * Authentication tag pTq when GCM processing is complete.
  * \param tag point to the word of the tag.
  */
 void AES_GetGcmTag(uint32_t *tag)
-- 
2.29.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems 6/8] bsp/atsam: Remove non-ASCII chars for microseconds

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

---
 .../contrib/libraries/libboard/source/board_memories.c | 10 ++
 .../atsam/contrib/libraries/libchip/source/sdramc.c|  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/bsps/arm/atsam/contrib/libraries/libboard/source/board_memories.c 
b/bsps/arm/atsam/contrib/libraries/libboard/source/board_memories.c
index e2f04caa8c..354196ab95 100644
--- a/bsps/arm/atsam/contrib/libraries/libboard/source/board_memories.c
+++ b/bsps/arm/atsam/contrib/libraries/libboard/source/board_memories.c
@@ -196,7 +196,8 @@ void BOARD_ConfigureSdram(void)
SDRAMC->SDRAMC_MDR = BOARD_Sdram_Config.sdramc_mdr;
 #endif /* __rtems__ */
 
-   /* 4. A minimum pause of 200 ��s is provided to precede any signal 
toggle.*/
+   /* 4. A minimum pause of 200 microseconds is provided to precede any
+   signal toggle.*/
for (i = 0; i < 10; i++);
 
/* 5. (1)A NOP command is issued to the SDRAM devices. The application 
must
@@ -277,10 +278,11 @@ void BOARD_ConfigureSdram(void)
 
/* 11. Write the refresh rate into the count field in the SDRAMC Refresh
Timer register. (Refresh rate = delay between refresh cycles).
-   The SDRAM device requires a refresh every 15.625 ��s or 7.81 ��s.
+   The SDRAM device requires a refresh every 15.625 or 7.81 microseconds.
With a 100 MHz frequency, the Refresh Timer Counter Register must be set
-   with the value 1562(15.625 ��s x 100 MHz) or 781(7.81 ��s x 100 MHz). */
-   // For IS42S16100E, 2048 refresh cycle every 32ms, every 15.625 ��s
+   with the value 1562(15.625 us x 100 MHz) or 781(7.81 us x 100 MHz). */
+   /* For IS42S16100E, 2048 refresh cycle every 32ms, every 15.625
+   microseconds. */
/* ((32 x 10(^-3))/2048) x150 x (10^6) */
 #ifndef __rtems__
SDRAMC->SDRAMC_TR = 1562;
diff --git a/bsps/arm/atsam/contrib/libraries/libchip/source/sdramc.c 
b/bsps/arm/atsam/contrib/libraries/libchip/source/sdramc.c
index ab5f2d8ec8..aca4a4448e 100644
--- a/bsps/arm/atsam/contrib/libraries/libchip/source/sdramc.c
+++ b/bsps/arm/atsam/contrib/libraries/libchip/source/sdramc.c
@@ -128,8 +128,8 @@ extern void SDRAMC_Configure(SSdramc_Memory *pMemory,
SDRAMC->SDRAMC_MDR = SDRAMC_MDR_MD_SDRAM;
 
/* Step 4 */
-   /* A minimum pause of 200 ��s is provided to precede any signal toggle.
-  (6 core cycles per iteration) */
+   /* A minimum pause of 200 microseconds is provided to precede any signal
+  toggle. (6 core cycles per iteration) */
for (dw = 0; dw < ((dwClockFrequency / 100) * 200 / 6); dw++);
 
/* Step 5. */
-- 
2.29.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems 3/8] bsps: Replace non-ASCII bullet points

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

---
 bsps/shared/grlib/can/occan.c | 4 ++--
 bsps/shared/grlib/spw/grspw.c | 8 
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/bsps/shared/grlib/can/occan.c b/bsps/shared/grlib/can/occan.c
index 59b4f234f6..84402b8809 100644
--- a/bsps/shared/grlib/can/occan.c
+++ b/bsps/shared/grlib/can/occan.c
@@ -855,8 +855,8 @@ static int pelican_start(occan_priv *priv){
 #endif
 
/* core already in reset mode,
-*  � Exit reset mode 
-*  � Enter Single/Dual mode filtering.
+*  * Exit reset mode
+*  * Enter Single/Dual mode filtering.
 */
WRITE_REG(priv, >regs->mode, (priv->single_mode << 3));
 
diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c
index 2e1e8e90e9..1b50cc642f 100644
--- a/bsps/shared/grlib/spw/grspw.c
+++ b/bsps/shared/grlib/spw/grspw.c
@@ -1475,10 +1475,10 @@ static rtems_device_driver grspw_control(
 
/* Get timeout from userspace
 *  timeout:
-*   �  -1 = Default timeout
-*   �  less than -1 = forever
-*   �  0   = no wait, proceed if link is up
-*   �  positive = specifies number of system clock 
ticks that 
+*   *  -1 = Default timeout
+*   *  less than -1 = forever
+*   *  0   = no wait, proceed if link is up
+*   *  positive = specifies number of system clock 
ticks that
 *   startup will wait for link to 
enter ready mode.
 */
timeout = (int)ioarg->buffer;
-- 
2.29.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems 2/8] bsps: Replace non-ASCII trademark symbol

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

---
 bsps/arm/atsam/contrib/libraries/libboard/include/gmii.h | 2 +-
 bsps/arm/lm3s69xx/start/bspstart.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bsps/arm/atsam/contrib/libraries/libboard/include/gmii.h 
b/bsps/arm/atsam/contrib/libraries/libboard/include/gmii.h
index e346143452..e9dc31e1e4 100644
--- a/bsps/arm/atsam/contrib/libraries/libboard/include/gmii.h
+++ b/bsps/arm/atsam/contrib/libraries/libboard/include/gmii.h
@@ -52,7 +52,7 @@
 #define GMII_ECR 0x18  // Expanded Control Register
 #define GMII_ICSR0x1B  // Interrupt Control/Status Register
 #define GMII_FC  0x1C  // Function Control
-#define GMII_LCSR0x1D  // LinkMD� Control/Status Register
+#define GMII_LCSR0x1D  // LinkMD(R) Control/Status Register
 #define GMII_PC1R0x1E  // PHY Control 1 Register
 #define GMII_PC2R0x1F  // PHY Control 2 Register
 
diff --git a/bsps/arm/lm3s69xx/start/bspstart.c 
b/bsps/arm/lm3s69xx/start/bspstart.c
index ea73b1e1c2..43b7b826bf 100644
--- a/bsps/arm/lm3s69xx/start/bspstart.c
+++ b/bsps/arm/lm3s69xx/start/bspstart.c
@@ -39,7 +39,7 @@ static void init_main_osc(void)
   syscon->rcc2 = rcc2;
 
   /*
-   As per a note in Stellaris� LM4F120H5QR Microcontroller Data
+   As per a note in Stellaris(R) LM4F120H5QR Microcontroller Data
Sheet on page 219: "When transitioning the system clock
configuration to use the MOSC as the fundamental clock source, the
MOSCDIS bit must be set prior to reselecting the MOSC or an
-- 
2.29.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems 0/8] Replace non ASCII-Characters in source files

2020-11-08 Thread Christian Mauderer 
Hello,

this patch set is a follow up of the discussion in this mail thread:

https://lists.rtems.org/pipermail/devel/2020-November/063092.html

It replaces a lot of non-ASCII characters that slipped into our code
base over the years. Note that I'm not sure whether the last three
patches are a good idea. They touch imported code and especially the
jffs2 stuff might get updated from upstream sources. So maybe keeping
the non-ASCII stuff there might is a better choice.

Best regards

Christian


___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems 4/8] bsp/mpc83xx: Fix non-ASCII characters

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

---
 bsps/powerpc/include/mpc83xx/mpc83xx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsps/powerpc/include/mpc83xx/mpc83xx.h 
b/bsps/powerpc/include/mpc83xx/mpc83xx.h
index f48a5ce675..9613abd365 100644
--- a/bsps/powerpc/include/mpc83xx/mpc83xx.h
+++ b/bsps/powerpc/include/mpc83xx/mpc83xx.h
@@ -668,7 +668,7 @@ typedef struct m83xxUSB_DRRegisters_ {
   volatile uint32_t cdpr1; /* 0x3_1140 Crypto-channel 1 current descriptor 
pointer register R 0x___ 14.6.1.3/14-90 */
   volatile uint32_t */
 0x3_1180--0x3_11BF
-  DBn /*   volatile; uint32_t ff1, */ /* 0x3_1148 Crypto-channel 1 fetch FIFO 
address register W 0x___ 14.6.1.4/14-90 Crypto-channel 1 
descriptor buffers [0�7] R 0x___ 14.6.1.5/14-91 */
+  DBn /*   volatile; uint32_t ff1, */ /* 0x3_1148 Crypto-channel 1 fetch FIFO 
address register W 0x___ 14.6.1.4/14-90 Crypto-channel 1 
descriptor buffers [0..7] R 0x___ 14.6.1.5/14-91 */
   /* Channel 2-4: FIXME: same layout as channel 1*/
   /* Data Encryption Standard Execution Unit (DEU) */
   volatile uint32_t deumr; /* 0x3_2000 DEU mode register R/W 
0x___ 14.5.2.1/14-35 */
-- 
2.29.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems 1/8] bsps: Replace non-ASCII copyright character

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

---
 bsps/arm/lm3s69xx/console/console-config.c | 2 +-
 bsps/arm/lm3s69xx/console/uart.c   | 2 +-
 bsps/arm/lm3s69xx/i2c/ssi.c| 2 +-
 bsps/arm/lm3s69xx/include/bsp/io.h | 2 +-
 bsps/arm/lm3s69xx/include/bsp/irq.h| 2 +-
 bsps/arm/lm3s69xx/include/bsp/lm3s69xx.h   | 2 +-
 bsps/arm/lm3s69xx/include/bsp/ssi.h| 2 +-
 bsps/arm/lm3s69xx/include/bsp/syscon.h | 2 +-
 bsps/arm/lm3s69xx/start/bspstart.c | 2 +-
 bsps/arm/lm3s69xx/start/io.c   | 2 +-
 bsps/arm/lm3s69xx/start/syscon.c   | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/bsps/arm/lm3s69xx/console/console-config.c 
b/bsps/arm/lm3s69xx/console/console-config.c
index b702f0cd66..bce7a624aa 100644
--- a/bsps/arm/lm3s69xx/console/console-config.c
+++ b/bsps/arm/lm3s69xx/console/console-config.c
@@ -1,5 +1,5 @@
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * Copyright (c) 2011 Sebastian Huber.  All rights reserved.
  *
diff --git a/bsps/arm/lm3s69xx/console/uart.c b/bsps/arm/lm3s69xx/console/uart.c
index 67a85f4e96..f9e55dd362 100644
--- a/bsps/arm/lm3s69xx/console/uart.c
+++ b/bsps/arm/lm3s69xx/console/uart.c
@@ -1,5 +1,5 @@
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * Copyright (c) 2011 Sebastian Huber.  All rights reserved.
  *
diff --git a/bsps/arm/lm3s69xx/i2c/ssi.c b/bsps/arm/lm3s69xx/i2c/ssi.c
index 9469c611f0..3b4e8fca9c 100644
--- a/bsps/arm/lm3s69xx/i2c/ssi.c
+++ b/bsps/arm/lm3s69xx/i2c/ssi.c
@@ -1,5 +1,5 @@
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * The license and distribution terms for this file may be
  * found in the file LICENSE in this distribution or at
diff --git a/bsps/arm/lm3s69xx/include/bsp/io.h 
b/bsps/arm/lm3s69xx/include/bsp/io.h
index 3e3846e1c6..6dea463a56 100644
--- a/bsps/arm/lm3s69xx/include/bsp/io.h
+++ b/bsps/arm/lm3s69xx/include/bsp/io.h
@@ -7,7 +7,7 @@
  */
 
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * The license and distribution terms for this file may be
  * found in the file LICENSE in this distribution or at
diff --git a/bsps/arm/lm3s69xx/include/bsp/irq.h 
b/bsps/arm/lm3s69xx/include/bsp/irq.h
index dd49728881..ca7a462f7f 100644
--- a/bsps/arm/lm3s69xx/include/bsp/irq.h
+++ b/bsps/arm/lm3s69xx/include/bsp/irq.h
@@ -7,7 +7,7 @@
  */
 
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * Copyright (c) 2011 Sebastian Huber.  All rights reserved.
  *
diff --git a/bsps/arm/lm3s69xx/include/bsp/lm3s69xx.h 
b/bsps/arm/lm3s69xx/include/bsp/lm3s69xx.h
index 623b6ca45e..0a4a80760d 100644
--- a/bsps/arm/lm3s69xx/include/bsp/lm3s69xx.h
+++ b/bsps/arm/lm3s69xx/include/bsp/lm3s69xx.h
@@ -7,7 +7,7 @@
  */
 
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * Copyright (c) 2011 Sebastian Huber.  All rights reserved.
  *
diff --git a/bsps/arm/lm3s69xx/include/bsp/ssi.h 
b/bsps/arm/lm3s69xx/include/bsp/ssi.h
index 66d5302655..7463a19825 100644
--- a/bsps/arm/lm3s69xx/include/bsp/ssi.h
+++ b/bsps/arm/lm3s69xx/include/bsp/ssi.h
@@ -7,7 +7,7 @@
  */
 
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * The license and distribution terms for this file may be
  * found in the file LICENSE in this distribution or at
diff --git a/bsps/arm/lm3s69xx/include/bsp/syscon.h 
b/bsps/arm/lm3s69xx/include/bsp/syscon.h
index 2904138f4d..67ff69c50e 100644
--- a/bsps/arm/lm3s69xx/include/bsp/syscon.h
+++ b/bsps/arm/lm3s69xx/include/bsp/syscon.h
@@ -7,7 +7,7 @@
  */
 
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * The license and distribution terms for this file may be
  * found in the file LICENSE in this distribution or at
diff --git a/bsps/arm/lm3s69xx/start/bspstart.c 
b/bsps/arm/lm3s69xx/start/bspstart.c
index da3029e58c..ea73b1e1c2 100644
--- a/bsps/arm/lm3s69xx/start/bspstart.c
+++ b/bsps/arm/lm3s69xx/start/bspstart.c
@@ -3,7 +3,7 @@
  */
 
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * The license and distribution terms for this file may be
  * found in the file LICENSE in this distribution or at
diff --git a/bsps/arm/lm3s69xx/start/io.c b/bsps/arm/lm3s69xx/start/io.c
index b476e7b6dd..0f41f137dd 100644
--- a/bsps/arm/lm3s69xx/start/io.c
+++ b/bsps/arm/lm3s69xx/start/io.c
@@ -1,5 +1,5 @@
 /*
- * Copyright � 2013 Eugeniy Meshcheryakov 
+ * Copyright (c) 2013 Eugeniy Meshcheryakov 
  *
  * The license and distribution terms for this file may be
  * found in the file LICENSE in this distribution or at
diff --git a/bsps/arm/lm3s69xx/start/syscon.c b/bsps/arm/lm3s69xx/start/syscon.c
index 1f5a1a3596..60064c3102 100644
---

[PATCH rtems 8/8] jffs2: Replace non-ASCII copyright character

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

---
 cpukit/libfs/src/jffs2/include/linux/jffs2.h | 4 ++--
 cpukit/libfs/src/jffs2/src/acl.h | 2 +-
 cpukit/libfs/src/jffs2/src/build.c   | 4 ++--
 cpukit/libfs/src/jffs2/src/compr.c   | 8 
 cpukit/libfs/src/jffs2/src/compr.h   | 4 ++--
 cpukit/libfs/src/jffs2/src/compr_rtime.c | 4 ++--
 cpukit/libfs/src/jffs2/src/compr_rubin.c | 4 ++--
 cpukit/libfs/src/jffs2/src/compr_zlib.c  | 4 ++--
 cpukit/libfs/src/jffs2/src/debug.c   | 4 ++--
 cpukit/libfs/src/jffs2/src/debug.h   | 4 ++--
 cpukit/libfs/src/jffs2/src/dir-rtems.c   | 8 
 cpukit/libfs/src/jffs2/src/erase.c   | 4 ++--
 cpukit/libfs/src/jffs2/src/fs-rtems.c| 8 
 cpukit/libfs/src/jffs2/src/gc.c  | 4 ++--
 cpukit/libfs/src/jffs2/src/jffs2_fs_i.h  | 4 ++--
 cpukit/libfs/src/jffs2/src/jffs2_fs_sb.h | 4 ++--
 cpukit/libfs/src/jffs2/src/nodelist.c| 2 +-
 cpukit/libfs/src/jffs2/src/nodelist.h| 2 +-
 cpukit/libfs/src/jffs2/src/nodemgmt.c| 2 +-
 cpukit/libfs/src/jffs2/src/os-rtems.h| 4 ++--
 cpukit/libfs/src/jffs2/src/read.c| 2 +-
 cpukit/libfs/src/jffs2/src/readinode.c   | 2 +-
 cpukit/libfs/src/jffs2/src/scan.c| 2 +-
 cpukit/libfs/src/jffs2/src/summary.h | 2 +-
 cpukit/libfs/src/jffs2/src/write.c   | 2 +-
 cpukit/libfs/src/jffs2/src/xattr.h   | 2 +-
 26 files changed, 48 insertions(+), 48 deletions(-)

diff --git a/cpukit/libfs/src/jffs2/include/linux/jffs2.h 
b/cpukit/libfs/src/jffs2/include/linux/jffs2.h
index a18b719f49..202cb46b8d 100644
--- a/cpukit/libfs/src/jffs2/include/linux/jffs2.h
+++ b/cpukit/libfs/src/jffs2/include/linux/jffs2.h
@@ -1,8 +1,8 @@
 /*
  * JFFS2 -- Journalling Flash File System, Version 2.
  *
- * Copyright © 2001-2007 Red Hat, Inc.
- * Copyright © 2004-2010 David Woodhouse 
+ * Copyright (c) 2001-2007 Red Hat, Inc.
+ * Copyright (c) 2004-2010 David Woodhouse 
  *
  * Created by David Woodhouse 
  *
diff --git a/cpukit/libfs/src/jffs2/src/acl.h b/cpukit/libfs/src/jffs2/src/acl.h
index 2e2b5745c3..1114691c70 100644
--- a/cpukit/libfs/src/jffs2/src/acl.h
+++ b/cpukit/libfs/src/jffs2/src/acl.h
@@ -1,7 +1,7 @@
 /*
  * JFFS2 -- Journalling Flash File System, Version 2.
  *
- * Copyright © 2006  NEC Corporation
+ * Copyright (c) 2006  NEC Corporation
  *
  * Created by KaiGai Kohei 
  *
diff --git a/cpukit/libfs/src/jffs2/src/build.c 
b/cpukit/libfs/src/jffs2/src/build.c
index d35bc83bbb..ce9e258404 100644
--- a/cpukit/libfs/src/jffs2/src/build.c
+++ b/cpukit/libfs/src/jffs2/src/build.c
@@ -3,8 +3,8 @@
 /*
  * JFFS2 -- Journalling Flash File System, Version 2.
  *
- * Copyright © 2001-2007 Red Hat, Inc.
- * Copyright © 2004-2010 David Woodhouse 
+ * Copyright (c) 2001-2007 Red Hat, Inc.
+ * Copyright (c) 2004-2010 David Woodhouse 
  *
  * Created by David Woodhouse 
  *
diff --git a/cpukit/libfs/src/jffs2/src/compr.c 
b/cpukit/libfs/src/jffs2/src/compr.c
index a9e821a6a1..e9d5667116 100644
--- a/cpukit/libfs/src/jffs2/src/compr.c
+++ b/cpukit/libfs/src/jffs2/src/compr.c
@@ -3,11 +3,11 @@
 /*
  * JFFS2 -- Journalling Flash File System, Version 2.
  *
- * Copyright © 2001-2007 Red Hat, Inc.
- * Copyright © 2004-2010 David Woodhouse 
- * Copyright © 2004 Ferenc Havasi ,
+ * Copyright (c) 2001-2007 Red Hat, Inc.
+ * Copyright (c) 2004-2010 David Woodhouse 
+ * Copyright (c) 2004 Ferenc Havasi ,
  * University of Szeged, Hungary
- * Copyright © 2013 embedded brains GmbH 
+ * Copyright (c) 2013 embedded brains GmbH 
  *
  * Created by Arjan van de Ven 
  *
diff --git a/cpukit/libfs/src/jffs2/src/compr.h 
b/cpukit/libfs/src/jffs2/src/compr.h
index e6226e7258..cdf2c5c85a 100644
--- a/cpukit/libfs/src/jffs2/src/compr.h
+++ b/cpukit/libfs/src/jffs2/src/compr.h
@@ -1,9 +1,9 @@
 /*
  * JFFS2 -- Journalling Flash File System, Version 2.
  *
- * Copyright © 2004   Ferenc Havasi ,
+ * Copyright (c) 2004   Ferenc Havasi ,
  *   University of Szeged, Hungary
- * Copyright © 2004-2010 David Woodhouse 
+ * Copyright (c) 2004-2010 David Woodhouse 
  *
  * For licensing information, see the file 'LICENCE' in this directory.
  *
diff --git a/cpukit/libfs/src/jffs2/src/compr_rtime.c 
b/cpukit/libfs/src/jffs2/src/compr_rtime.c
index c8313ed234..c434c0b74f 100644
--- a/cpukit/libfs/src/jffs2/src/compr_rtime.c
+++ b/cpukit/libfs/src/jffs2/src/compr_rtime.c
@@ -3,8 +3,8 @@
 /*
  * JFFS2 -- Journalling Flash File System, Version 2.
  *
- * Copyright © 2001-2007 Red Hat, Inc.
- * Copyright © 2004-2010 David Woodhouse 
+ * Copyright (c) 2001-2007 Red Hat, Inc.
+ * Copyright (c) 2004-2010 David Woodhouse 
  *
  * Created by Arjan van de Ven 
  *
diff --git a/cpukit/libfs/src/jffs2/src/compr_rubin.c 
b/cpukit/libfs/src/jffs2/src/compr_rubin.c
index 91a1f354f5..d47f293eaa 100644
--- a/cpukit/libfs/src/jffs2/src/compr_rubin.c
+++ b/cpukit/libfs/src/jffs2/src/compr_rubin.c
@@ -3,8 +3,8 @@
 /*
  * JFFS2 --

Re: [PATCH rtems 0/8] Replace non ASCII-Characters in source files

2020-11-08 Thread Christian Mauderer 
PS: In case the patches make problems due to some odd mail encoding: I
also pushed them as a branch here:

https://gitlab.com/c-mauderer/rtems/-/tree/cm/20201107_replace_non-ASCII


On 07/11/2020 14:23, Christian Mauderer wrote:
> Hello,
> 
> this patch set is a follow up of the discussion in this mail thread:
> 
> https://lists.rtems.org/pipermail/devel/2020-November/063092.html
> 
> It replaces a lot of non-ASCII characters that slipped into our code
> base over the years. Note that I'm not sure whether the last three
> patches are a good idea. They touch imported code and especially the
> jffs2 stuff might get updated from upstream sources. So maybe keeping
> the non-ASCII stuff there might is a better choice.
> 
> Best regards
> 
> Christian
> 
> 
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems 5/8] bsp/rtl22xx: Fix non-ASCII character

2020-11-08 Thread Christian Mauderer 
From: Christian Mauderer 

---
 bsps/arm/rtl22xx/console/uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsps/arm/rtl22xx/console/uart.c b/bsps/arm/rtl22xx/console/uart.c
index 2952e74508..c4ddd18b2c 100644
--- a/bsps/arm/rtl22xx/console/uart.c
+++ b/bsps/arm/rtl22xx/console/uart.c
@@ -262,7 +262,7 @@ static int _BSP_get_char(void)
 BSP_polling_getchar_function_type BSP_poll_char = _BSP_get_char;
 
 /*
- * init USART 0��8 bit, 1 Stop,No checkout, BPS115200
+ * init USART 0: 8 bit, 1 Stop,No checkout, BPS115200
  */
 void UART0_Ini(void)
 {
-- 
2.29.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] libtests/dl06: Add -lm

2020-11-08 Thread Chris Johns 
On 3/11/20 3:39 am, Sebastian Huber wrote:
> There is probably something wrong with this test program.  If it is compiled
> without function/data sections, no optimization, and no linker garbage
> collection, then there is an undefined reference to atan2() and tan().

These symbols are referenced in the loaded module ...

https://git.rtems.org/rtems/tree/testsuites/libtests/dl06/dl06-o2.c

This test gets rtems-ld with the RAP format to collect the atan1 and tan code
into the loaded module. They should not be present in the base image. The libm
library is used because it is _not_ part of the standard libraries linked and is
available everywhere.

> Fix this issue by adding -lm.

Is the error linking the base kernel image or the RAP loadable module?

If it is the loadable module and this is how you add the libraries to be
searched to the rtems-ld command then the fix is needed and there is no problem.
If the error was in the base kernel image then I suggest something else is wrong
because those symbols should not be present in the base image. If the build
system can support options for just rtems-ld then adding it there would be good.

More of a concern is no error. I wonder if the code is being inlined when there
is FPU support. Maybe the test needs to create a library linking to it to be
more robust?

Chris

> ---
>  spec/build/testsuites/libtests/dl06.yml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/spec/build/testsuites/libtests/dl06.yml 
> b/spec/build/testsuites/libtests/dl06.yml
> index 2f5d4ab08d..e1bbd006c9 100644
> --- a/spec/build/testsuites/libtests/dl06.yml
> +++ b/spec/build/testsuites/libtests/dl06.yml
> @@ -42,7 +42,8 @@ ldflags: []
>  links: []
>  prepare-build: null
>  prepare-configure: null
> -stlib: []
> +stlib:
> +- m
>  type: build
>  use-after: []
>  use-before: []
> 
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Blockers for Cutover to Waf

2020-11-08 Thread Chris Johns 
On 6/11/20 2:46 am, Joel Sherrill wrote:
> On Thu, Nov 5, 2020, 9:39 AM Sebastian Huber 
>  > wrote:
> On 05/11/2020 16:35, Joel Sherrill wrote:
> > and https://devel.rtems.org/ticket/4145
> > 
> > need to be addressed or automated tests will fail.
> This only needs to be updated if someone updates the RTEMS commit in the
> build set or does it pick up the latest RTEMS?
> 
> That's probably ok for the RSB kernel packages but at least Chris should 
> speak up. 

I will try and find some time to look at this.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Breaking Long Lines

2020-11-08 Thread Chris Johns 
On 6/11/20 7:11 pm, Sebastian Huber wrote:
> Hello,
> 
> for breaking long lines we have currently:
> 
> "Should be replaced with
> 
> .. code-block:: c
> 
>   for (
>     initialization = statement;
>     a + really + longish + statement + that + evaluates + to <
>     a + boolean;
>     another + statement++
>   ) {
>     z = a + really + longish + statement + that + needs +
>     two + lines + gets + indented + four + more +
>     spaces + on + the + second + and + subsequent +
>     lines + and + broken + up + at + operators;
>   }
> 
> Note that indentations should add 2 nesting levels (4 space characters, not 
> tabs)."
> 
> Do we really need two indent levels for breaking long lines in block 
> statements?
> I would just say that the continuation of a broken line is indented by one
> level. The example would look like this (please note the change in the for 
> loop
> "a + boolean"):
> 
> .. code-block:: c
> 
>   for (
>     initialization = statement;
>     a + really + longish + statement + that + evaluates + to <
>   a + boolean;
>     another + statement++
>   ) {
>     z = a + really + longish + statement + that + needs +
>   two + lines + gets + indented + four + more +
>   spaces + on + the + second + and + subsequent +
>   lines + and + broken + up + at + operators;

I sometimes add parentheses to aid indenting:

  z = (a + really + longish + stat
 
   lines + and + broken + up + at + operators);

Emacs automatically indents to the opening `(`. This is mentioned in the GNU
coding standard. We however have this statement in our standard ...

 Avoid excess parentheses. Learn the operator precedence. rules.

Chris

>   }
> 
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel