Re: [PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

On Mon, Mar 15, 2021 at 5:14 PM Chris Johns wrote: > > On 16/3/21 10:07 am, Joel Sherrill wrote: > > On Mon, Mar 15, 2021 at 6:01 PM Chris Johns > > wrote: > > On 16/3/21 6:55 am, Joel Sherrill wrote: > > > > > > > > > On Mon, Mar 15, 2021 at 2:46 PM

Re: All (18) RSB tool failures on rtems6 (details on m68k)

Hello Joel, I updated the tools today. Maybe the error disappeared. It builds fine using openSUSE Leap 15.2. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08

Re: [rtems commit] pwdgrp.c: Fix Unchecked return value from library ( CID #1255518)

On 16/03/2021 12:30, Sebastian Huber wrote: On 08/03/2021 21:56, Joel Sherrill wrote: Module:    rtems Branch:    master Commit:    55ba229d228d1b7372256978828c573dd0af56d4 Changeset:http://git.rtems.org/rtems/commit/?id=55ba229d228d1b7372256978828c573dd0af56d4 Author:    Ryan Long Date:  

[PATCH] sp14: Fix for SMP or robust thread dispatch

Close #4343. --- testsuites/sptests/sp14/task1.c | 5 + 1 file changed, 5 insertions(+) diff --git a/testsuites/sptests/sp14/task1.c b/testsuites/sptests/sp14/task1.c index e1b80c71b4..07657272dc 100644 --- a/testsuites/sptests/sp14/task1.c +++ b/testsuites/sptests/sp14/task1.c @@ -36,8

Re: [PATCH 0/4] Import and Port Beagle pinmux driver

Hello Gedare, moving the pinmux driver from libbsd to RTEMS is a good direction. It avoids the double initialization of the pins that we currently have for that BSP. I planned to test the patches in the next few days. Best regards Christian Am 15.03.21 um 21:04 schrieb Gedare Bloom:

[PATCH rtems-docs v2 3/6] rtems-docs: Edit command to install toolsuite

Edit edit sample output of tool suite installation. Edit command to check if C cross compiler works and sample output of this command. --- user/start/tools.rst | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/user/start/tools.rst

[PATCH rtems-docs v2 1/6] rtems-docs: Update installation prefix

--- user/start/prefixes.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/user/start/prefixes.rst b/user/start/prefixes.rst index 67255d0..826ce85 100644 --- a/user/start/prefixes.rst +++ b/user/start/prefixes.rst @@ -40,7 +40,7 @@ applications and systems. You

[PATCH rtems-docs v2 5/6] rtems-docs: Edit command to test BSP and sample output

--- user/start/bsp-test.rst | 49 +++-- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/user/start/bsp-test.rst b/user/start/bsp-test.rst index 9243f5d..cad6f23 100644 --- a/user/start/bsp-test.rst +++ b/user/start/bsp-test.rst @@ -30,37 +30,42

[PATCH rtems-docs v2 4/6] rtems-docs: Edit command to build BSP and

Edit sample output output as well substituting "5" with "6" with regards to the current branch. --- user/start/bsp-build.rst | 74 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/user/start/bsp-build.rst b/user/start/bsp-build.rst index

[PATCH rtems-docs v2 6/6] rtems-docs: Edit commands to build first app

--- user/start/app.rst | 110 ++--- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/user/start/app.rst b/user/start/app.rst index 8900f78..8cbf6fc 100644 --- a/user/start/app.rst +++ b/user/start/app.rst @@ -8,7 +8,7 @@ Build Your

[PATCH rtems-docs v2 2/6] rtems-docs: Update command for offline download

Changed command from ../source-builder/sb-set-builder --source-only-download 5/rtems-sparc to ../source-builder/sb-set-builder --source-only-download 6/rtems-sparc. Updated sample output as well --- user/start/sources.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [rtems commit] pwdgrp.c: Fix Unchecked return value from library ( CID #1255518)

On 08/03/2021 21:56, Joel Sherrill wrote: Module:rtems Branch:master Commit:55ba229d228d1b7372256978828c573dd0af56d4 Changeset:http://git.rtems.org/rtems/commit/?id=55ba229d228d1b7372256978828c573dd0af56d4 Author:Ryan Long Date: Tue Mar 2 11:46:02 2021 -0500 pwdgrp.c:

Re: [PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

On Tue, 16 Mar 2021, 1:37 am Gedare Bloom, wrote: > This one looks ok to me, Niteesh? > +1 The below question is not related to this patch. Out of interest, I started going through the code and I am a bit confused in the following statement

Re: [PATCH 6/6] rtems-docs: Edit commands to build first app

Regarding the patch to add instructions on how to set up a patch message in which file should I create this patch or make changes? On Mon, Mar 15, 2021 at 8:57 PM Gedare Bloom wrote: > Hi Ida, > > On Mon, Mar 15, 2021 at 1:50 PM Gedare Bloom wrote: > > > > Hi Ida, > > > > did you send the

Re: All (18) RSB tool failures on rtems6 (details on m68k)

On 16/03/2021 15:19, Joel Sherrill wrote: Anyway, everything is bad on track except for the known issues of rtems-bsp-tester and mips on FreeBSD. To build mips on FreeBSD you have to use the GNU sed. According to the GCC build instructions this is mandatory in general to build GCC. --

RE: [PATCH 2/3] covoar: Improve findCoverageMap error message

This patch no longer applies assuming that the latest revision of my earlier patch, "covoar: Handle periods in symbols from objdump", is accepted. -Original Message- From: Alex White Sent: Friday, March 12, 2021 11:14 AM To: devel@rtems.org Cc: Alex White Subject: [PATCH 2/3] covoar:

RE: [rtems commit] pwdgrp.c: Fix Unchecked return value from library ( CID #1255518)

I found this error yesterday, when doing more testing based on Chris's feedback. I've taken out the _Assert_Unused_variable_equals() in pwdgrp.c and replaced it with just a (void). The test passed afterwards, but Joel wants me to test it a little further. I'll get the patch in to fix that by

[PATCH v3] covoar: Handle periods in symbols from objdump

Occasionally the compiler will generate symbols that look similar to symbols defined in RTEMS code except that they contain some suffix. These symbol suffixes are only found in the ELF symbol table; the symbols appear to be normal in the DWARF info. This appears to be happening on all

RE: [PATCH 0/3] Add spidev driver for Xilinx AXI Quad SPI device

Could someone also please have a look at this patchset. When this goes through, I would like to backport this, the cadence-spi driver and the spi shell command of Christian to rtems5. Best regards, Jan > -Original Message- > From: Sommer, Jan > Sent: Wednesday, March 10, 2021 9:15

[PATCH 2/3] rtems: Allow initially locked MrsP semaphores

Rejecting initially locked MrsP semaphores was due to a limitiation of the early limitiation of the MrsP protocol. This limitation no longer exists. --- cpukit/include/rtems/rtems/sem.h | 3 --- cpukit/include/rtems/score/mrspimpl.h | 28 +--

[PATCH 3/3] rtems: Improve semaphore create error checks

Do not mix checks for different error indicators (RTEMS_NOT_DEFINED and RTEMS_INVALID_NUMBER). This simplifies the specification of rtems_semaphore_create(). --- cpukit/rtems/src/semcreate.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH 1/3] rtems: Require RTEMS_PRIORITY for MrsP semaphores

MrsP semaphores are a generalization of the priority ceiling semaphores for SMP configurations. Priority ceiling semaphores are required to use the priority task wait queue discipline. Require this discipline also for MrsP semaphores. Close #4347. --- cpukit/include/rtems/rtems/sem.h

Re: All (18) RSB tool failures on rtems6 (details on m68k)

Thanks. I will spin them again. What ended up working was removing the installed tools from a previous hash, all downloaded source, all logs, and the RSB build directory. I suspect it was a hiccup on binutils of some kind. What is puzzling is that it didn't happen on the FreeBSD or Ubuntu

RE: [PATCH] sp14: Fix for SMP or robust thread dispatch

This fixes the issues on AArch64 and ARM, thanks! Kinsey -Original Message- From: devel On Behalf Of Sebastian Huber Sent: Tuesday, March 16, 2021 06:20 To: devel@rtems.org Subject: [PATCH] sp14: Fix for SMP or robust thread dispatch Close #4343. --- testsuites/sptests/sp14/task1.c |

Re: code reformatting was Re: Regarding gsoc project 3860

Am 15.03.21 um 23:05 schrieb Gedare Bloom: On Mon, Mar 15, 2021 at 6:44 AM Joel Sherrill wrote: On Mon, Mar 15, 2021 at 4:20 AM Hesham Almatary wrote: Hello Ayushman and Ida, Usually, if multiple students really want to work on a particular project (and can't/don't want to choose

Re: [rtems commit] pwdgrp.c: Fix Unchecked return value from library ( CID #1255518)

On Tue, Mar 16, 2021 at 9:15 AM Ryan Long wrote: > I found this error yesterday, when doing more testing based on Chris's > feedback. I've taken out the _Assert_Unused_variable_equals() in pwdgrp.c > and replaced it with just a (void). The test passed afterwards, but Joel > wants me to test it a

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021 at 9:25 AM Alex White wrote: > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > These symbol suffixes are only found in the ELF symbol table; the > symbols appear to be normal in the

Re: [PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

On Tue, Mar 16, 2021 at 1:15 AM Niteesh G. S. wrote: > > > > On Tue, 16 Mar 2021, 1:37 am Gedare Bloom, wrote: >> >> This one looks ok to me, Niteesh? > > +1 > > The below question is not related to this patch. > > Out of interest, I started going through the code and I am a bit confused in >

[PATCH] Add configuration option for single processor applications

This change sets the value of number of processor as 1 for a single processor application. Useful when trying to run a single processor application on a multi processor scheduler. --- cpukit/include/rtems/confdefs/scheduler.h | 4 1 file changed, 4 insertions(+) diff --git

Re: All (18) RSB tool failures on rtems6 (details on m68k)

On Tue, Mar 16, 2021 at 9:39 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 16/03/2021 15:23, Sebastian Huber wrote: > > > On 16/03/2021 15:19, Joel Sherrill wrote: > > > >> > >> Anyway, everything is bad on track except for the known issues of > >> rtems-bsp-tester and mips

Re: [PATCH 6/6] rtems-docs: Edit commands to build first app

$ cd rtems-docs $ grep -r "Creating a Patch" --exclude-dir=build eng/vc-users.rts:Creating a Patch On Tue, Mar 16, 2021 at 2:28 AM Ida Delphine wrote: > > Regarding the patch to add instructions on how to set up a patch message in > which file should I create this patch or make changes? > > On

Re: All (18) RSB tool failures on rtems6 (details on m68k)

On 16/03/2021 15:59, Joel Sherrill wrote: On Tue, Mar 16, 2021 at 9:39 AM Sebastian Huber > wrote: On 16/03/2021 15:23, Sebastian Huber wrote: > On 16/03/2021 15:19, Joel Sherrill wrote: > >> >> Anyway, everything is bad on

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021 at 8:25 AM Alex White wrote: > > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > These symbol suffixes are only found in the ELF symbol table; the > symbols appear to be normal in the

RE: [PATCH v2] user/bsps: Mention fixed console baud rate for zynq

Thanks. Pushed to master. > -Original Message- > From: Gedare Bloom > Sent: Monday, March 15, 2021 11:08 PM > To: Joel Sherrill > Cc: Sommer, Jan ; rtems-de...@rtems.org > > Subject: Re: [PATCH v2] user/bsps: Mention fixed console baud rate for zynq > > Yeah go ahead, thanks Jan. > >

[PATCH] RTEMS 5.2: rtems: Allow RTEMS_PRIORITY for MrsP semaphores

In order to improve the compatibility of RTEMS 5.2 with future version of RTEMS which fixed #4346 allow MrsP semaphores to be created with RTEMS_PRIORITY. Close #4347. --- cpukit/rtems/src/semcreate.c | 7 ++- testsuites/sptests/spmrsp01/init.c | 6 -- 2 files changed, 6

Re: All (18) RSB tool failures on rtems6 (details on m68k)

On 16/03/2021 15:23, Sebastian Huber wrote: On 16/03/2021 15:19, Joel Sherrill wrote: Anyway, everything is bad on track except for the known issues of rtems-bsp-tester and mips on FreeBSD. To build mips on FreeBSD you have to use the GNU sed. According to the GCC build instructions this is

Re: [PATCH] RTEMS 5.2: rtems: Allow RTEMS_PRIORITY for MrsP semaphores

On Tue, Mar 16, 2021 at 8:01 AM Sebastian Huber wrote: > > In order to improve the compatibility of RTEMS 5.2 with future version > of RTEMS which fixed #4346 allow MrsP semaphores to be created with minor note, this "fixed #4346" might get picked up by the Trac hook, I'm not sure. Otherwise I

Re: [PATCH 3/3] rtems: Improve semaphore create error checks

These 3 look good to me On Tue, Mar 16, 2021 at 7:58 AM Sebastian Huber wrote: > > Do not mix checks for different error indicators (RTEMS_NOT_DEFINED and > RTEMS_INVALID_NUMBER). This simplifies the specification of > rtems_semaphore_create(). > --- > cpukit/rtems/src/semcreate.c | 10

Re: [PATCH] Add configuration option for single processor applications

On 16/03/2021 16:45, Richi Dubey wrote: This change sets the value of number of processor as 1 for a single processor application. Useful when trying to run a single processor application on a multi processor scheduler. I think this patch is superfluous. In which scenario do you think it is

Re: [PATCH rtems-docs] eng/vc-users: Set up patch message with repo name

Yay!!! Thanks for the feedback. Will try building the docs. On Tue, 16 Mar 2021, 8:08 pm Gedare Bloom, wrote: > Hi Ida, > > I have built and checked the output, it looks good but I did make a > tiny change to remove HEAD^ with ... to be a bit non-specific, and > fixed a typo in your commit

Re: [PATCH rtems-docs v2 3/6] rtems-docs: Edit command to install toolsuite

On Tue, Mar 16, 2021 at 12:16 PM Ida Delphine wrote: > > I ran the commands and copied and pasted wherever there were mismatches > especially with respect to the version numbers. > OK, I noticed some inconsistencies and was wondering. It would be better to provide the actual output for the

Re: [PATCH rtems-docs] eng/vc-users: Set up patch message with repo name

Hi Ida, I have built and checked the output, it looks good but I did make a tiny change to remove HEAD^ with ... to be a bit non-specific, and fixed a typo in your commit message. I would however like you to confirm that you can build the docs :) as your next step, it is best to confirm that

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

> I have lost of the context of why covoar would like to strip the suffixes and > use only the base symbol name. Could you please explain why this is being > done? Sure. The symbol names in the DWARF info never contain these suffixes. Covoar strips the suffixes while reading the objdump output

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

I’m not sure if I have seen an example of method split into more than one piece. It has been a while since I made this fix. A specific test executable that shows the suffixes is testsuites/libtests/block08.exe, but most (if not all) of them should have symbols like this from what I can tell.

Potential GSoC Project - Covoar Change C-isms to C++

Hi I know GSoC students are looking for projects so I thought I would post about a couple that have come up recently and don't have tickets and better write ups. The covoar tool in rtems-tools was originally written to use C style IO (e.g. fprintf) instead of C++ streams and C style strings

Potential GSoC Project(s) - Improve Test Coverage

Hi I know GSoC students are looking for projects so I thought I would post about a couple that have come up recently and don't have tickets and better write ups. This likely can be done by multiple students and all code should be in C. One must be able to run the RTEMS Test Suite and produce

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 2:05 am, Alex White wrote: > I’m not sure if I have seen an example of method split into more than one > piece. > It has been a while since I made this fix. > > A specific test executable that shows the suffixes is > testsuites/libtests/block08.exe, but most (if not all) of them

Re: [PATCH rtems-docs v2 3/6] rtems-docs: Edit command to install toolsuite

I ran the commands and copied and pasted wherever there were mismatches especially with respect to the version numbers. Should I resend the patchset with a better commit message? On Tue, 16 Mar 2021, 6:50 pm Gedare Bloom, wrote: > Hi Ida, > > Since the patches now indicate rtems-docs, you

[PATCH rtems-docs] eng/vc-users: Set up patch message with repo name

From: Meh Mbeh Ida Delphine Added instructions on how to set up a patch messahe with a repo name. Author:Meh Mbeh Ida Delphine Date: Tue Mar 16 19:11:23 2021 +0100 --- eng/vc-users.rst | 8 1 file changed, 8 insertions(+) diff --git a/eng/vc-users.rst b/eng/vc-users.rst

Re: [PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

On 17/3/21 2:14 am, Gedare Bloom wrote: > On Tue, Mar 16, 2021 at 1:15 AM Niteesh G. S. wrote: >> On Tue, 16 Mar 2021, 1:37 am Gedare Bloom, wrote: >>> >>> This one looks ok to me, Niteesh? >> >> +1 >> >> The below question is not related to this patch. >> >> Out of interest, I started going

Re: [PATCH rtems-docs v2 3/6] rtems-docs: Edit command to install toolsuite

Hi Ida, Since the patches now indicate rtems-docs, you don't need to include that in the commit message. Instead, it is recommended to put the manual directory name that is modified as the first part of the commit, e.g., "user: bump version 5 to 6 in start/tools.rst" More below: On Tue, Mar 16,

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

Assuming I'm sending a v4 of this patch out, should I add the explanation of the compiler-generated suffixes to the commit message or perhaps as a comment in the code? Alex > -Original Message- > From: devel On Behalf Of Alex White > Sent: Tuesday, March 16, 2021 3:32 PM > To: Chris

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

> Do any non-compiler-generated symbols include "."? Yes, according to the output of nm: $ i386-rtems6-nm build/i386/pc686/testsuites/libtests/block08.exe | grep " \." 0011bdd2 t .check_stack_switch I don't think there are any function symbols that include ".", though. > > Are there symbols

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 8:16 am, Alex White wrote: > Assuming I'm sending a v4 of this patch out, should I add the explanation of > the compiler-generated suffixes to the commit message or perhaps as a comment > in the code? Yes if you think it helps. In the end what you are doing makes the tool work and

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021, 4:47 PM Alex White wrote: > > Do any non-compiler-generated symbols include "."? > > Yes, according to the output of nm: > > $ i386-rtems6-nm build/i386/pc686/testsuites/libtests/block08.exe | grep " > \." > 0011bdd2 t .check_stack_switch > > I don't think there are any

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 9:56 am, Joel Sherrill wrote: > On Tue, Mar 16, 2021, 4:47 PM Alex White > wrote: > > > Do any non-compiler-generated symbols include "."? > > Yes, according to the output of nm: > > $ i386-rtems6-nm

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021, 7:15 PM Chris Johns wrote: > On 17/3/21 8:16 am, Alex White wrote: > > Assuming I'm sending a v4 of this patch out, should I add the > explanation of the compiler-generated suffixes to the commit message or > perhaps as a comment in the code? > > Yes if you think it helps.