Re: #3860 - GSoC enquiries

2021-04-07 Thread Sebastian Huber
On 07/04/2021 09:03, Chris Johns wrote: Would it be pragmatic to review these cases and change the standard? I sent a patch to review the format changes done by clang-format recently: https://lists.rtems.org/pipermail/devel/2021-April/066311.html It doesn't look that bad from my point of

Re: #3860 - GSoC enquiries

2021-04-07 Thread Chris Johns
On 7/4/21 3:01 pm, Sebastian Huber wrote: > On 06/04/2021 18:12, Gedare Bloom wrote: > >> On Mon, Apr 5, 2021 at 10:37 PM Sebastian Huber >>   wrote: >>> On 04/04/2021 22:18, Joel Sherrill wrote: >>> On Sun, Apr 4, 2021 at 2:25 PM Ida Delphine >>> > wrote:

Re: [PATCH] covoar: Fix NULL check of wrong variable

2021-04-07 Thread Joel Sherrill
Repeating what I added to the ticket: CID #1399602 is about a NULL reference in the same method which traces back to the incorrect variable being checked. Coverity didn't realize it was the wrong variable but did find something wrong that could lead to a NULL pointer dereference. Check me

Re: [PATCH v5 0/4] Unused value Coverity issues

2021-04-07 Thread Gedare Bloom
Thanks, the set looks good On Wed, Apr 7, 2021 at 6:24 AM Ryan Long wrote: > > Hi, > > Here are the patches with the recommended changes. > > Thanks, > Ryan > > Ryan Long (4): > main_cp.c: Unused value (CID #1255344) > print-ls.c: Unused value (CID #1255346) > fastlz.c: Unused value (CID

[PATCH] covoar: Fix NULL check of wrong variable

2021-04-07 Thread Alex White
In Explanations::writeNotFound() there were two NULL checks of the `fileName` variable where only one is needed. The second check has been changed to a NULL check of `notFoundFile` to match the original intent. Closes #4377 --- tester/covoar/Explanations.cc | 4 ++-- 1 file changed, 2

Re: #4328: New APIs added to POSIX Standard (2021)

2021-04-07 Thread Matthew Joyce
Hi Dr. Joel, Could you please point me to where I can find the API tracking CSV file? Thank you! Sincerely, Matt On Tue, Apr 6, 2021 at 8:29 PM Joel Sherrill wrote: > > > > On Thu, Apr 1, 2021 at 8:06 AM Gedare Bloom wrote: >> >> On Thu, Apr 1, 2021 at 6:21 AM Matthew Joyce wrote: >> > >>

[PATCH v5 0/4] Unused value Coverity issues

2021-04-07 Thread Ryan Long
Hi, Here are the patches with the recommended changes. Thanks, Ryan Ryan Long (4): main_cp.c: Unused value (CID #1255344) print-ls.c: Unused value (CID #1255346) fastlz.c: Unused value (CID #1399751) disp_hcms29xx.c: Unused value (CID #1399752) bsps/shared/dev/display/disp_hcms29xx.c

[PATCH v5 2/4] print-ls.c: Unused value (CID #1255346)

2021-04-07 Thread Ryan Long
CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340 --- cpukit/libmisc/shell/print-ls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/libmisc/shell/print-ls.c b/cpukit/libmisc/shell/print-ls.c index 15702b4..95a2cdf 100644 ---

[PATCH v5 1/4] main_cp.c: Unused value (CID #1255344)

2021-04-07 Thread Ryan Long
CID 1255344: Unused value in copy(). Closes #4339 --- cpukit/libmisc/shell/main_cp.c | 32 1 file changed, 32 insertions(+) diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c index cddbc95..913ece1 100644 ---

[PATCH v5 4/4] disp_hcms29xx.c: Unused value (CID #1399752)

2021-04-07 Thread Ryan Long
CID 1399752: Unused value in disp_hcms29xx_update_task(). Closes #4342 --- bsps/shared/dev/display/disp_hcms29xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/dev/display/disp_hcms29xx.c b/bsps/shared/dev/display/disp_hcms29xx.c index 740aa56..5ad7063

[PATCH v5 3/4] fastlz.c: Unused value (CID #1399751)

2021-04-07 Thread Ryan Long
CID 1399751: Unused value in fastlz2_compress(). Closes #4341 --- cpukit/libdl/fastlz.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/cpukit/libdl/fastlz.c b/cpukit/libdl/fastlz.c index 3c9d6f6..7257c98 100644 --- a/cpukit/libdl/fastlz.c +++

Re: #3860 - GSoC enquiries

2021-04-07 Thread Ida Delphine
Hello, In case I succeed with this project will I be required to do some documentation on how it works? On Wed, Apr 7, 2021 at 9:51 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 07/04/2021 09:03, Chris Johns wrote: > > > Would it be pragmatic to review these cases and

Re: [PATCH] posix-compliance: Update tracking spreadsheet to v12

2021-04-07 Thread Gedare Bloom
ok, but do you need to be replacing these versions or can you provide one version that you update? I guess, the modifications will be quite bad when you add new columns, but updating/adding rows would be much smaller changes? Just a thought. On Tue, Apr 6, 2021 at 5:28 PM Joel Sherrill wrote: >

Re: [PATCH] posix-compliance: Update tracking spreadsheet to v12

2021-04-07 Thread Gedare Bloom
On Wed, Apr 7, 2021 at 10:31 AM Joel Sherrill wrote: > > > > On Wed, Apr 7, 2021, 11:25 AM Gedare Bloom wrote: >> >> ok, but do you need to be replacing these versions or can you provide >> one version that you update? >> >> I guess, the modifications will be quite bad when you add new columns,

[PATCH rtems-net-legacy v3] nfsclient: Build nfsclient from the top level netlegacy script

2021-04-07 Thread Vijay Kumar Banerjee
--- netlegacy.py | 31 ++ nfsclient/wscript | 56 --- wscript | 2 +- 3 files changed, 28 insertions(+), 61 deletions(-) delete mode 100644 nfsclient/wscript diff --git a/netlegacy.py b/netlegacy.py index

Re: [PATCH] covoar: Fix NULL check of wrong variable (CID #1399602)

2021-04-07 Thread Gedare Bloom
ok On Wed, Apr 7, 2021 at 11:47 AM Alex White wrote: > > CID 1399602: Dereference null return value in > Explanations::writeNotFound(). > > In Explanations::writeNotFound() there were two NULL checks of the > `fileName` variable where only one is needed. The second check has been > changed to a

Re: [PATCH] posix-compliance: Update tracking spreadsheet to v12

2021-04-07 Thread Joel Sherrill
On Wed, Apr 7, 2021, 11:25 AM Gedare Bloom wrote: > ok, but do you need to be replacing these versions or can you provide > one version that you update? > > I guess, the modifications will be quite bad when you add new columns, > but updating/adding rows would be much smaller changes? Just a >

Re: #3860 - GSoC enquiries

2021-04-07 Thread Gedare Bloom
On Wed, Apr 7, 2021 at 10:11 AM Ida Delphine wrote: > > Hello, > > In case I succeed with this project will I be required to do some > documentation on how it works? > Yes, in general we expect students to produce documentation while they work on also creating code. I think the direction we're

[PATCH rtems-net-legacy] netlegacy: Use os.path instead of hardcoded Unix like path

2021-04-07 Thread Vijay Kumar Banerjee
--- netlegacy.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/netlegacy.py b/netlegacy.py index 05cb78a..ddd1db3 100644 --- a/netlegacy.py +++ b/netlegacy.py @@ -37,7 +37,7 @@ exclude_headers = ['rtems-bsd-user-space.h', 'rtems-bsd-kernel-space.h'] for

[PATCH] covoar: Fix NULL check of wrong variable (CID #1399602)

2021-04-07 Thread Alex White
CID 1399602: Dereference null return value in Explanations::writeNotFound(). In Explanations::writeNotFound() there were two NULL checks of the `fileName` variable where only one is needed. The second check has been changed to a NULL check of `notFoundFile` to match the original intent. Closes

Re: How to build and run RTEMS Shell

2021-04-07 Thread Gedare Bloom
On Wed, Apr 7, 2021 at 2:13 PM Eshan Dhawan wrote: > > > > On Sun, Apr 4, 2021 at 8:01 PM Joel Sherrill wrote: >> >> >> >> On Sun, Apr 4, 2021, 4:38 AM Eshan Dhawan wrote: >>> >>> Hello Everyone, >>> How Do I build RTEMS Shell over sparc/leon3 ?? >> >> >> It is always built and the sample

Re: How to build and run RTEMS Shell

2021-04-07 Thread Eshan Dhawan
On Sun, Apr 4, 2021 at 8:01 PM Joel Sherrill wrote: > > > On Sun, Apr 4, 2021, 4:38 AM Eshan Dhawan wrote: > >> Hello Everyone, >> How Do I build RTEMS Shell over sparc/leon3 ?? >> > > It is always built and the sample fileio is a good program to use it with. > > Any documentation or Blog I

Gsoc 2021 : Packaging Lua project proposal Draft 1

2021-04-07 Thread Eshan Dhawan
Hello everyone, I have added a link to the draft of my project Proposal on packaging programming language for gsoc 2021. I would Request everyone to Review it and help me improve it. Link: https://docs.google.com/document/d/1J4J114C3CrCKEV2L5vgobT-mE0f2xQx2waJTrQ0tNLQ/edit?usp=sharing -- Thanks

Re: [PATCH rtems-libbsd] Import telnetd from RTEMS repository

2021-04-07 Thread Vijay Kumar Banerjee
On Mon, Apr 5, 2021 at 3:48 PM Gedare Bloom wrote: > > push this if no one complains by Wednesday > > I think we should keep this telnetd and the legacy one in sync for > now, and consider them as a good candidate for a new > 'rtems-net-services' repository. > Thanks. Pushed. > On Mon, Mar 29,

Re: Standalone repository for libnetworking stack

2021-04-07 Thread Vijay Kumar Banerjee
On Mon, Apr 5, 2021 at 4:09 PM Gedare Bloom wrote: > > On Tue, Mar 23, 2021 at 2:12 PM Vijay Kumar Banerjee wrote: > > > > On Tue, Mar 23, 2021 at 1:10 PM Gedare Bloom wrote: > > > > > > On Tue, Mar 23, 2021 at 12:34 PM Joel Sherrill wrote: > > > > > > > > > > > > > > > > On Tue, Mar 23, 2021

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-04-07 Thread Vijay Kumar Banerjee
On Wed, Apr 7, 2021 at 7:56 PM Niteesh G. S. wrote: > > Hello Vijay, > > On Sun, Mar 28, 2021 at 1:42 AM Vijay Kumar Banerjee wrote: >> >> Hi Niteesh, >> >> Thanks for the patch. I have some questions below. >> >> On Mon, Mar 22, 2021 at 11:48 AM G S Niteesh Babu >> wrote: >> > >> > Refactored

Re: [PATCH rtems-libbsd] Import telnetd from RTEMS repository

2021-04-07 Thread Sebastian Huber
On 08/04/2021 03:17, Vijay Kumar Banerjee wrote: On Mon, Apr 5, 2021 at 3:48 PM Gedare Bloom wrote: push this if no one complains by Wednesday I think we should keep this telnetd and the legacy one in sync for now, and consider them as a good candidate for a new 'rtems-net-services'

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-04-07 Thread Niteesh G. S.
Hello Vijay, On Sun, Mar 28, 2021 at 1:42 AM Vijay Kumar Banerjee wrote: > Hi Niteesh, > > Thanks for the patch. I have some questions below. > > On Mon, Mar 22, 2021 at 11:48 AM G S Niteesh Babu > wrote: > > > > Refactored the i2c driver to parse register values from the device > > tree

Re: #3860 - GSoC enquiries

2021-04-07 Thread Ida Delphine
Hello everyone, Here is the link to my GSoC proposal. Will love if you leave comments on ways I could make it better or any corrections (Especially the *Proposesd Schedule* section so that I will be sure about my project deliverables when inputting them).