Re: [PATCH] bsps/shared/ofw: Fix coverity defects

2021-04-29 Thread Gedare Bloom
On Wed, Apr 28, 2021 at 9:04 PM Niteesh G. S. wrote: > > > > On Thu, Apr 29, 2021 at 12:50 AM Gedare Bloom wrote: >> >> On Wed, Apr 28, 2021 at 11:30 AM G S Niteesh Babu >> wrote: >> > >> > This patch adds asserts to fix coverity defects >> > 1) CID 1474437 (Out-of-bounds access) >> > 2) CID

Re: [PATCH rtems] cpukit/Makefile.am: Remove remaining LIBNETWORKING files

2021-04-29 Thread Gedare Bloom
ok On Thu, Apr 29, 2021 at 10:07 AM Vijay Kumar Banerjee wrote: > > --- > cpukit/Makefile.am | 43 --- > cpukit/configure.ac | 1 - > 2 files changed, 44 deletions(-) > > diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am > index

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-29 Thread Gedare Bloom
On Thu, Apr 29, 2021 at 9:59 AM Gedare Bloom wrote: > > On Thu, Apr 29, 2021 at 3:14 AM Robin Müller > wrote: > > > > I replaced the file in rtems_waf manually but it still throws the same > > error: > > > > [1/2] Compiling build/conf_check_995d7bdd1834199278843e9a51c37759/test.c > > > >

Re: [PATCH] c-user: CONFIGURE_BSP_PREREQUISITE_DRIVERS

2021-04-29 Thread Gedare Bloom
ok On Thu, Apr 29, 2021 at 7:02 AM Sebastian Huber wrote: > > Replace copy and paste with a provide a proper description. > --- > c-user/config/bsp-related.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/c-user/config/bsp-related.rst

[PATCH] c-user: CONFIGURE_BSP_PREREQUISITE_DRIVERS

2021-04-29 Thread Sebastian Huber
Replace copy and paste with a provide a proper description. --- c-user/config/bsp-related.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/c-user/config/bsp-related.rst b/c-user/config/bsp-related.rst index 4b6848d..45f31a8 100644 --- a/c-user/config/bsp-related.rst +++

Re: [PATCH] riscv/console: Updated the console-config.c file

2021-04-29 Thread Gedare Bloom
Hesham, please review. I'm not certain. On Wed, Apr 28, 2021 at 7:23 AM Somesh Deshmukh wrote: > > - Parsing the sub-node should be available generic not specific to Freedom > Arty310 board. If we remove the Freedom Arty macro now, it will lose > backward compatibility.The proposed change

Re: [PATCH] riscv/start: Startup sequence update.

2021-04-29 Thread Gedare Bloom
looks good. someone using riscv can build/test and push, any takers? On Wed, Apr 28, 2021 at 7:55 AM Somesh Deshmukh wrote: > > - The current startup sequence performs the call to the bsp_fdt_copy() and > then > performs memset to the BSS region. In bsp_fdt_copy(), RTEMS allocates > memory

[PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Sebastian Huber
This may reduce the code size a bit. --- cpukit/Makefile.am | 3 +- cpukit/include/rtems/score/threadimpl.h | 7 cpukit/posix/src/pthreadself.c | 32 --- cpukit/rtems/src/taskself.c | 28 - cpukit/score/src/threadselfid.c

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Gedare Bloom
ok On Thu, Apr 29, 2021 at 7:18 AM Sebastian Huber wrote: > > This may reduce the code size a bit. > --- > cpukit/Makefile.am | 3 +- > cpukit/include/rtems/score/threadimpl.h | 7 > cpukit/posix/src/pthreadself.c | 32 --- >

Re: [PATCH rtems] cpukit/Makefile.am: Remove remaining LIBNETWORKING files

2021-04-29 Thread Vijay Kumar Banerjee
On Thu, Apr 29, 2021 at 10:13 AM Gedare Bloom wrote: > > ok > Pushed. Thanks. > On Thu, Apr 29, 2021 at 10:07 AM Vijay Kumar Banerjee wrote: > > > > --- > > cpukit/Makefile.am | 43 --- > > cpukit/configure.ac | 1 - > > 2 files changed, 44

Re: [PATCH] c-user: Reformat configuration option constraints

2021-04-29 Thread Gedare Bloom
ok On Wed, Apr 28, 2021 at 11:30 PM Sebastian Huber wrote: > > If only one constraint is present, then use a single sentence, otherwise > use a list for the constraints. Format the constraints so that the line > length limit is maintained. > --- > c-user/config/bdbuf.rst | 94

[PATCH rtems] cpukit/Makefile.am: Remove remaining LIBNETWORKING files

2021-04-29 Thread Vijay Kumar Banerjee
--- cpukit/Makefile.am | 43 --- cpukit/configure.ac | 1 - 2 files changed, 44 deletions(-) diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am index b0df610bed..44ab945778 100644 --- a/cpukit/Makefile.am +++ b/cpukit/Makefile.am @@ -1372,15 +1372,6 @@

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-29 Thread Gedare Bloom
On Thu, Apr 29, 2021 at 3:14 AM Robin Müller wrote: > > I replaced the file in rtems_waf manually but it still throws the same error: > > [1/2] Compiling build/conf_check_995d7bdd1834199278843e9a51c37759/test.c > > ['C:/Users/Robin/Documents/RTEMS/rtems-tools/rtems/6/bin/sparc-rtems6-gcc.exe', >

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Sebastian Huber
On 29/04/2021 20:12, Joel Sherrill wrote: I'm not so ok because now the score has symbols for the Classic API and pthreads in it. The point of putting a method shared by both in the score was to avoid contaminating the score with information about the APIs or the the APIs with knowledge of

Re: [PATCH] riscv/start: Startup sequence update.

2021-04-29 Thread Sebastian Huber
On 29/04/2021 20:18, Hesham Almatary wrote: I would place the device tree in a noinit section. That is probably a better solution. It should also be documented in this start.S file what are the assumptions about parameters coming from the bootloader since it is not obvious. +1 The recent

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Joel Sherrill
On Thu, Apr 29, 2021 at 1:37 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 29/04/2021 20:12, Joel Sherrill wrote: > > > I'm not so ok because now the score has symbols for the Classic API > > and pthreads in it. > > > > The point of putting a method shared by both in the

Re: [PATCH] riscv/console: Updated the console-config.c file

2021-04-29 Thread Hesham Almatary
On Wed, 28 Apr 2021 at 15:23, Somesh Deshmukh wrote: > > - Parsing the sub-node should be available generic not specific to Freedom > Arty310 board. If we remove the Freedom Arty macro now, it will lose > backward compatibility.The proposed change will retain the backward > compatibility

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-29 Thread Chris Johns
On 30/4/21 5:01 am, Robin Müller wrote: > Yes that is the prefix. The rtems.h file is definitely located at the location > in the warning and it works on older commit of rtems_waf (where gccdeps.py is > not used). > I briefly looked through the gccdeps.py file and it is doing some string >

Re: [PATCH] riscv/start: Startup sequence update.

2021-04-29 Thread Gedare Bloom
On Thu, Apr 29, 2021 at 11:53 AM Sebastian Huber wrote: > > > On 28/04/2021 15:55, Somesh Deshmukh wrote: > > +/* Clear .bss */ > > +LADDRa0, bsp_section_bss_begin > > +li a1, 0 > > +LADDRa2, bsp_section_bss_size > > +call memset > > + > > #ifdef BSP_START_COPY_FDT_FROM_U_BOOT

Re: [PATCH] riscv/start: Startup sequence update.

2021-04-29 Thread Hesham Almatary
On Thu, 29 Apr 2021 at 20:07, Gedare Bloom wrote: > > On Thu, Apr 29, 2021 at 11:53 AM Sebastian Huber > wrote: > > > > > > On 28/04/2021 15:55, Somesh Deshmukh wrote: > > > +/* Clear .bss */ > > > +LADDRa0, bsp_section_bss_begin > > > +li a1, 0 > > > +LADDRa2,

Re: [PATCH] riscv/console: Updated the console-config.c file

2021-04-29 Thread somesh deshmukh
On Thu, Apr 29, 2021 at 10:59 PM Hesham Almatary < hesham.almat...@cl.cam.ac.uk> wrote: > On Wed, 28 Apr 2021 at 15:23, Somesh Deshmukh > wrote: > > > > - Parsing the sub-node should be available generic not specific to > Freedom > > Arty310 board. If we remove the Freedom Arty macro now, it

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-29 Thread Vijay Kumar Banerjee
Hi all, On Thu, Apr 29, 2021 at 3:01 PM Chris Johns wrote: > > On 30/4/21 5:01 am, Robin Müller wrote: > > Yes that is the prefix. The rtems.h file is definitely located at the > > location > > in the warning and it works on older commit of rtems_waf (where gccdeps.py > > is > > not used). >

Re: [PATCH] riscv/start: Startup sequence update.

2021-04-29 Thread Hesham Almatary
On Wed, 28 Apr 2021 at 15:55, Somesh Deshmukh wrote: > > - The current startup sequence performs the call to the bsp_fdt_copy() and > then > performs memset to the BSS region. In bsp_fdt_copy(), RTEMS allocates > memory for bsp_fdt_blob into BSS region which is yet to initialize. With >

Re: [PATCH] riscv/start: Startup sequence update.

2021-04-29 Thread Sebastian Huber
On 28/04/2021 15:55, Somesh Deshmukh wrote: +/* Clear .bss */ +LADDR a0, bsp_section_bss_begin +li a1, 0 +LADDR a2, bsp_section_bss_size +call memset + #ifdef BSP_START_COPY_FDT_FROM_U_BOOT mv a0, a1 callbsp_fdt_copy #endif How did you test this? The above

Re: [PATCH v2] Use alias for rtems_task_self() and pthread_self()

2021-04-29 Thread Joel Sherrill
I'm not so ok because now the score has symbols for the Classic API and pthreads in it. The point of putting a method shared by both in the score was to avoid contaminating the score with information about the APIs or the the APIs with knowledge of each other. I think we still need separate files

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-29 Thread Robin Müller
Yes that is the prefix. The rtems.h file is definitely located at the location in the warning and it works on older commit of rtems_waf (where gccdeps.py is not used). I briefly looked through the gccdeps.py file and it is doing some string stripping operations. Maybe that is the issue but I am

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-29 Thread Robin Müller
I replaced the file in rtems_waf manually but it still throws the same error: [1/2] Compiling build/conf_check_995d7bdd1834199278843e9a51c37759/test.c ['C:/Users/Robin/Documents/RTEMS/rtems-tools/rtems/6/bin/sparc-rtems6-gcc.exe', '-mcpu=cypress',

Re: tcpreplay for testing network stacks

2021-04-29 Thread Christian MAUDERER
Am 29.04.21 um 00:54 schrieb Vijay Kumar Banerjee: On Wed, Apr 28, 2021 at 3:27 PM Chris Johns wrote: On 29/4/21 3:00 am, Vijay Kumar Banerjee wrote: On Wed, Apr 28, 2021 at 10:49 AM Christian Mauderer wrote: Hello Vijay, On 28/04/2021 18:25, Vijay Kumar Banerjee wrote: On Wed, Apr

Re: tcpreplay for testing network stacks

2021-04-29 Thread Chris Johns
On 29/4/21 4:30 pm, Christian MAUDERER wrote: > Am 29.04.21 um 00:54 schrieb Vijay Kumar Banerjee: >> On Wed, Apr 28, 2021 at 3:27 PM Chris Johns wrote: >>> >>> >>> >>> On 29/4/21 3:00 am, Vijay Kumar Banerjee wrote: On Wed, Apr 28, 2021 at 10:49 AM Christian Mauderer wrote: >