posix function (read/write) unusual beavior

2014-07-21 Thread Gabriel Ibarra
Hi, I have a simple loopback program in my board (bsp lpc_176x), It reads information from a tty and returns it through the same tty (using POSIX functions), I tested it sending characters with a PC's terminal and I saw the ECHO on the terminal, I found an unusual behavior with some bsp

Re: capture engine use of workspace_allocate

2014-07-21 Thread Gedare Bloom
Either account for it in workspace sizing or use malloc. On principle, I guess any dynamic allocated memory that isn't mandatory to get RTEMS to work should come from malloc. -Gedare On Mon, Jul 21, 2014 at 10:41 AM, Jennifer Averett jennifer.aver...@oarcorp.com wrote: The capture engine

Re: capture engine use of workspace_allocate

2014-07-21 Thread Joel Sherrill
On July 21, 2014 10:44:15 AM CDT, Gedare Bloom ged...@rtems.org wrote: Either account for it in workspace sizing or use malloc. On principle, I guess any dynamic allocated memory that isn't mandatory to get RTEMS to work should come from malloc. With one malloc and two workspace allocates, I

[PATCH 3/3] rbtree: Do not set node off-tree in extract

2014-07-21 Thread Sebastian Huber
--- cpukit/score/include/rtems/score/rbtree.h | 11 +-- cpukit/score/src/rbtreeextract.c | 3 --- testsuites/sptests/sprbtree01/init.c | 5 + 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/cpukit/score/include/rtems/score/rbtree.h

[PATCH 2/3] rbtree: Remove superfluous NULL pointer checks

2014-07-21 Thread Sebastian Huber
--- cpukit/score/include/rtems/score/rbtree.h | 7 +++ cpukit/score/src/rbtree.c | 3 --- cpukit/score/src/rbtreeextract.c | 10 -- cpukit/score/src/rbtreeinsert.c | 3 --- testsuites/sptests/sprbtree01/init.c | 3 --- 5 files changed, 3

[PATCH 1/3] rbtree: Format

2014-07-21 Thread Sebastian Huber
--- cpukit/score/src/rbtree.c| 7 +- cpukit/score/src/rbtreeextract.c | 152 +-- cpukit/score/src/rbtreefind.c| 7 +- cpukit/score/src/rbtreeinsert.c | 69 ++ cpukit/score/src/rbtreeiterate.c | 12 ++--

Re: [PATCH 1/3] rbtree: Format

2014-07-21 Thread Joel Sherrill
There could be something wrong here but I don't see it on a quick review. On 7/21/2014 11:31 AM, Sebastian Huber wrote: --- cpukit/score/src/rbtree.c| 7 +- cpukit/score/src/rbtreeextract.c | 152 +-- cpukit/score/src/rbtreefind.c| 7 +-

[PATCH v2] RTEMS: Add multilibs for ARM

2014-07-21 Thread Sebastian Huber
This change is necessary to support Cortex-M4 and Cortex-R based chips in RTEMS. This patch should be applied to GCC 4.8, 4.9 and mainline. I do not have write access, so in case this gets approved, please commit it for me. gcc/ChangeLog 2014-07-21 Sebastian Huber

Re: [PATCH 1/3] rbtree: Format

2014-07-21 Thread Gedare Bloom
One issue with rbtree formatting is in some places if/while conditional expressions are put on the same line as the conditional statement. We should prefer to put them explicitly on separate lines, since that is the prevailing style of score and I have added such a convention to our style wiki