Re: [PATCH 05/11] Modify FREEBSD USB keyboard drivers for use in RTEMS

2017-05-16 Thread Sebastian Huber
On 15/05/17 19:26, Kevin Kirspel wrote: +#ifndef __rtems__ kern_yield(PRI_UNCHANGED); +#else /* __rtems__ */ + sched_yield(); +#endif /* __rtems__ */ Please add a kern_yield() instead. diff --git a/freebsd/sys/sys/proc.h b/freebsd/sys/sys/proc.h

Re: [PATCH 08/11] Add LPC32XX touch screen driver

2017-05-16 Thread Sebastian Huber
On 15/05/17 19:26, Kevin Kirspel wrote: diff --git a/rtemsbsd/sys/dev/input/touchscreen/tsc_lpc32xx.c b/rtemsbsd/sys/dev/input/touchscreen/tsc_lpc32xx.c new file mode 100644 index 000..e52f545 --- /dev/null +++ b/rtemsbsd/sys/dev/input/touchscreen/tsc_lpc32xx.c @@ -0,0 +1,403 @@ +/* + *

Re: [PATCH 04/11] Add USB UGEN support for RTEMS

2017-05-16 Thread Sebastian Huber
Patch 03/11 is missing. I was not able to apply the patch series. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available

Re: RTEMS MAP_SHARED support expansion

2017-05-16 Thread Sebastian Huber
On 16/05/17 21:28, Kirspel, Kevin wrote: The second approach includes the first approach but adds support for RTEMS device drivers. We would need to add a mmap handler to “rtems_driver_address_table”. The “IMFS_device_handlers” would add a mmap handler to device_mmap(). We would need a new

Re: [PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

2017-05-16 Thread Sebastian Huber
On 17/05/17 00:40, Chris Johns wrote: On 16/05/2017 18:35, Sebastian Huber wrote: On 16/05/17 10:28, Chris Johns wrote: What we do need to do is make sure the test results express the true state. If a test is broken it should fail. If it is tagged an expected-fail we do not consider it a

Re: RTEMS MAP_SHARED support expansion

2017-05-16 Thread Gedare Bloom
On Tue, May 16, 2017 at 3:28 PM, Kirspel, Kevin wrote: > I would like to expand support for MAP_SHARED in mmap(). I would like to > run a few ideas by the group to see which direction to go. I really only > need to expand MAP_SHARED support for some LIBBSD drivers that

Re: [PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

2017-05-16 Thread Gedare Bloom
On Tue, May 16, 2017 at 6:40 PM, Chris Johns wrote: > On 16/05/2017 18:35, Sebastian Huber wrote: >> >> On 16/05/17 10:28, Chris Johns wrote: >>> >>> What we do need to do is make sure the test results express the true >>> state. If a test is broken it should fail. If it is

Re: [PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

2017-05-16 Thread Chris Johns
On 16/05/2017 18:35, Sebastian Huber wrote: On 16/05/17 10:28, Chris Johns wrote: What we do need to do is make sure the test results express the true state. If a test is broken it should fail. If it is tagged an expected-fail we do not consider it a regression. Loosing test coverage simply

Re: [PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

2017-05-16 Thread Chris Johns
On 16/05/2017 18:32, Sebastian Huber wrote: On 16/05/17 10:28, Chris Johns wrote: >You >wanted more tests to run in the SMP mode if SMP is enabled. Now only 36 >tests are left over. I think it is a reasonable expectation when you build an SMP RTEMS the tests run with SMP enabled using all

RTEMS MAP_SHARED support expansion

2017-05-16 Thread Kirspel, Kevin
I would like to expand support for MAP_SHARED in mmap(). I would like to run a few ideas by the group to see which direction to go. I really only need to expand MAP_SHARED support for some LIBBSD drivers that I want to create. There are two approaches I can take. The first approach is to

RE: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Kirspel, Kevin
After doing some research, the GCC default __builtin_popcount functions are slower than the FREEBSD versions (roughly 3.5x slower according to some tests I saw online). If someone adds the -mpopcnt compile option, then it means that there is a CPU instruction to perform the task. I think we

Re: Offlist - Introduce Yourself to Community

2017-05-16 Thread Gedare Bloom
On Mon, May 15, 2017 at 3:38 PM, aditya upadhyay wrote: > Hello All, > > I have ported the code of inttypes library and i have tested methods related > to inttypes.h in hello world test. It is working. Then i made a separate As a proof-of-concept, this is fine. You'll need to

Re: GSOC student suggestion about bug fixs

2017-05-16 Thread Gedare Bloom
Please have a look through the open tickets: https://devel.rtems.org/query You may also consider requesting a Coverity Scan account and triage some of Coverity's reported defects: https://scan.coverity.com/ For Coverity, you would create your account and request access to the RTEMS project.

Re: [PATCH 0/3] Split off powerpcspe from rs6000 port

2017-05-16 Thread Joel Sherrill
On Tue, May 16, 2017 at 8:48 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 16/05/17 15:45, Joel Sherrill wrote: > >> >> >> On Tue, May 16, 2017 at 8:28 AM, Sebastian Huber < >> sebastian.hu...@embedded-brains.de > ed-brains.de>> wrote: >> >>

Re: [PATCH 0/3] Split off powerpcspe from rs6000 port

2017-05-16 Thread Sebastian Huber
On 16/05/17 15:45, Joel Sherrill wrote: On Tue, May 16, 2017 at 8:28 AM, Sebastian Huber > wrote: FYI I guess for RTEMS we should use "powerpcspe-rtems*-*". Is it possible to use the RTEMS "powerpc"

Re: [PATCH 0/3] Split off powerpcspe from rs6000 port

2017-05-16 Thread Joel Sherrill
On Tue, May 16, 2017 at 8:28 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > FYI > > I guess for RTEMS we should use "powerpcspe-rtems*-*". Is it possible to > use the RTEMS "powerpc" directories with such a target? We had an > "arm-rtemseabi*" maybe due to some

Fwd: [PATCH 0/3] Split off powerpcspe from rs6000 port

2017-05-16 Thread Sebastian Huber
FYI I guess for RTEMS we should use "powerpcspe-rtems*-*". Is it possible to use the RTEMS "powerpc" directories with such a target? We had an "arm-rtemseabi*" maybe due to some configure/automake limitations. So, maybe "powerpc-rtemsspe*"? Forwarded Message Subject:

Re: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Sebastian Huber
On 16/05/17 15:18, Kirspel, Kevin wrote: Sorry. I pulled that header file from memory which these days is losing its effectiveness. So, should we put the bitcount changes in sys/types.h like FREEBSD? If so, I will submit a patch tonew...@sourceware.org. How long does it take to get the

RE: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Kirspel, Kevin
Sorry. I pulled that header file from memory which these days is losing its effectiveness. So, should we put the bitcount changes in sys/types.h like FREEBSD? If so, I will submit a patch to new...@sourceware.org. How long does it take to get the patch reviewed by the newlib mailing list?

Re: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Sebastian Huber
On 16/05/17 14:56, Kirspel, Kevin wrote: Should we put this in cdefs.h like FREEBSD? In FreeBSD the __bitcount*() functions are defined in . -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09

RE: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Kirspel, Kevin
Should we put this in cdefs.h like FREEBSD? Kevin Kirspel Electrical Engineer - Sr. Staff Idexx Roswell 235 Hembree Park Drive Roswell GA 30076 Tel: (770)-510- ext. 81642 Direct: (770)-688-1642 Fax: (770)-510-4445 -Original Message- From: Sebastian Huber

Re: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Sebastian Huber
On 16/05/17 14:15, Kirspel, Kevin wrote: For now, could we just include this in rtems-libbsd until newlib gets updated? Getting this change into Newlib shouldn't be a problem. You can use something like this to update the RSB if you have the Newlib Git commit:

RE: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Kirspel, Kevin
For now, could we just include this in rtems-libbsd until newlib gets updated? Kevin Kirspel Electrical Engineer - Sr. Staff Idexx Roswell 235 Hembree Park Drive Roswell GA 30076 Tel: (770)-510- ext. 81642 Direct: (770)-688-1642 Fax: (770)-510-4445 -Original Message- From: Sebastian

Re: GSOC student suggestion about bug fixs

2017-05-16 Thread Sebastian Huber
On 16/05/17 03:51, Sichen Zhao wrote: Strictly speaking it's a suggestion not a bug, and no ticket about it. I think RTEMS-libbsd can add the simplebus or other FreeBSD bus, not only the nexus bus. It may good at RTEMS-libbsd driver development. simplebus is already supported. -- Sebastian

Re: [PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

2017-05-16 Thread Sebastian Huber
On 16/05/17 10:28, Chris Johns wrote: >You >wanted more tests to run in the SMP mode if SMP is enabled. Now only 36 >tests are left over. I think it is a reasonable expectation when you build an SMP RTEMS the tests run with SMP enabled using all available cores. No, we don't run the tests

Re: [PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

2017-05-16 Thread Chris Johns
On 16/5/17 5:54 pm, Sebastian Huber wrote: > On 13/05/17 00:30, Chris Johns wrote: >> On 12/5/17 8:24 pm, Sebastian Huber wrote: >>> Mark tests that require review due to >>> CONFIGURE_DISABLE_SMP_CONFIGURATION. >> If a test fails it fails. I feel the test results need to correctly >> express the

Re: [PATCH] Update 3001 broke build for non SMP BSPs. Build failed when compiling default-configuration.c

2017-05-16 Thread Sebastian Huber
I fixed it like this: https://git.rtems.org/rtems/commit/?id=0b8084c2980144c11d1ef42dc92c79417a903d35 On 16/05/17 04:32, Kevin Kirspel wrote: --- cpukit/sapi/include/confdefs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100755 => 100644

Re: [PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

2017-05-16 Thread Sebastian Huber
On 13/05/17 00:30, Chris Johns wrote: On 12/5/17 8:24 pm, Sebastian Huber wrote: Mark tests that require review due to CONFIGURE_DISABLE_SMP_CONFIGURATION. If a test fails it fails. I feel the test results need to correctly express the failures and we should not masks them in the way. I do not

Re: [PATCH 07/11] Add bitcount inlinesfor RTEMS. These are found in FREEBSDs types.h

2017-05-16 Thread Sebastian Huber
Hello Kevin, I know it is considerable more work, but this should move into Newlib. The #ifdef __POPCNT__ #define __bitcount64(x) __builtin_popcountll((__uint64_t)(x)) needs GCC support. This __POPCNT__ is a clang feature. I don't know which version of GCC supports these builtins, but it