Re: [PATCH 21/21] score: Simplify _Thread_Initialize()

Hello Gedare, thanks for the review. On 02/01/2020 19:25, Gedare Bloom wrote: It seems like this function could be refactored to call _Objects_Allocate_unlimited() if the _Objects_Allocate_unlimited() is given a callback function to initialize in case of an Extend. May be something to consider.

Re: [PATCH 05/21] score: Simplify FP context allocation

On 02/01/2020 18:46, Gedare Bloom wrote: On Mon, Dec 16, 2019 at 7:28 AM Sebastian Huber wrote: Use the stack area to allocate the FP context. This considerably simplifies the application configuration since the task count no longer influences the configured work space size. With this change

[PATCH v2 0/2] Support statically allocated threads

This partial patch set addresses a review comment from Gedare Bloom: https://lists.rtems.org/pipermail/devel/2020-January/056710.html Sebastian Huber (2): score: Add _Objects_Allocate_with_extend() score: Simplify _Thread_Initialize() cpukit/Makefile.am | 1 + cpuki

[PATCH v2 1/2] score: Add _Objects_Allocate_with_extend()

Update #3835. --- cpukit/include/rtems/score/objectimpl.h| 34 cpukit/score/src/objectallocateunlimited.c | 36 +- 2 files changed, 44 insertions(+), 26 deletions(-) diff --git a/cpukit/include/rtems/score/objectimpl.h b/cpukit/include

[PATCH v2 2/2] score: Simplify _Thread_Initialize()

Allocate new thread queue heads during objects information extend. This removes an error case and the last dependency on the workspace in _Thread_Initialize(). Update #3835. --- cpukit/Makefile.am | 1 + cpukit/include/rtems/score/thread.h| 10 - cpukit/score

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

On 03/01/2020 00:24, Gedare Bloom wrote: while ( !_Chain_Is_empty( &the_thread->Priority_node.Inherited_priorities ) ) { +_ISR_Disable( level ); _Thread_Dequeue_priority_node( ((Thread_Priority_node*)_Chain_First( &the_thread->Priority_node.Inherited_priorities

Re: [PATCH 02/21] score: Simplify thread stack allocation

On 02/01/2020 18:34, Gedare Bloom wrote: diff --git a/cpukit/score/src/threadstackallocate.c b/cpukit/score/src/threadstackallocate.c index fd89d7f07f..722de7bfd6 100644 --- a/cpukit/score/src/threadstackallocate.c +++ b/cpukit/score/src/threadstackallocate.c @@ -1,11 +1,11 @@ /** * @file -

Re: [PATCH] bsp/raspberry: Enabled FDT support for console.

On Fri, Jan 3, 2020 at 2:26 AM Christian Mauderer wrote: > Sorry, it seems I missed some parts in the last mail. Beneath that I > caused a misunderstanding again. > > On 02/01/2020 20:08, G S Niteesh wrote: > > Replaced the older console api with newer FDT based > > console driver. > > Replaces t

[PATCH] bsp/raspberrypi: Enable FDT support.

This commit adds FDT support to the BSP. --- bsps/arm/raspberrypi/include/bsp.h| 4 c/src/lib/libbsp/arm/raspberrypi/Makefile.am | 1 + c/src/lib/libbsp/arm/raspberrypi/configure.ac | 13 + 3 files changed, 18 insertions(+) diff --git a/bsps/arm/raspberrypi/include

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

Sorry I should also clarify, PIP stands for "Priority Inheritance Protocol" On Thu, Jan 2, 2020 at 4:33 PM Gedare Bloom wrote: > Hi Mathew, > > Yes. I reworked the 4.10 priority inheritance mechanism in late 2018, post > 4.10.2. The changes should go into 4.10.3 if that gets cut. With the 4.10 >

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

Hi Mathew, Yes. I reworked the 4.10 priority inheritance mechanism in late 2018, post 4.10.2. The changes should go into 4.10.3 if that gets cut. With the 4.10 head using the reworked priority inheritance, there is a NULL pointer access in case of using priority discipline but non-priority-inherit

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

This patch is for 4.10. A user reported a problem they saw in testing. I believe this will fix the problem. On Thu, Jan 2, 2020 at 4:25 PM Gedare Bloom wrote: > > The PIP modifications from #3359 introduced new data structures > to track priority inheritance. Prioritized mutexes without PIP > sha

Re: [PATCH] cpukit/score: avoid NULL and races in priority mutex

This piqued my interest due to an issue we ran into several months ago. Just so I can better understand this, what is "PIP"? Are you referring to maybe Priority Inversion Protection? On Thu, Jan 2, 2020 at 5:25 PM Gedare Bloom wrote: > The PIP modifications from #3359 introduced new data struc

[PATCH] cpukit/score: avoid NULL and races in priority mutex

The PIP modifications from #3359 introduced new data structures to track priority inheritance. Prioritized mutexes without PIP share some of the code paths, and may result in NULL pointer accesses. This patch checks for NULL, and also adds ISR critical sections to an uncovered corner case during th

Re: [PATCH] bsp/raspberry: Enabled FDT support for console.

Sorry, it seems I missed some parts in the last mail. Beneath that I caused a misunderstanding again. On 02/01/2020 20:08, G S Niteesh wrote: > Replaced the older console api with newer FDT based > console driver. > Replaces the custom pl011 driver with RTEMS arm-pl011 > driver. > --- > bsps/arm/

[PATCH] bsp/raspberry: Enabled FDT support for console.

Replaced the older console api with newer FDT based console driver. Replaces the custom pl011 driver with RTEMS arm-pl011 driver. --- bsps/arm/raspberrypi/console/console-config.c | 156 bsps/arm/raspberrypi/console/console_select.c | 114 bsps/arm/raspberrypi/console

Re: [PATCH v5] Raspberrypi: updated the console interface.

On 02/01/2020 18:29, Niteesh wrote: > I have described my changes below, just let me know what you think? I > will send > in the patch once you are happy with it. > On Thu, Jan 2, 2020 at 10:07 PM Christian Mauderer > wrote: > > There is a whitespace error: > >

Re: [PATCH 21/21] score: Simplify _Thread_Initialize()

On Mon, Dec 16, 2019 at 7:28 AM Sebastian Huber wrote: > > Allocate new thread queue heads during objects information extend. This > removes an error case and the last dependency on the workspace in > _Thread_Initialize(). > > Update #3835. > --- > cpukit/Makefile.am | 1

Re: [PATCH 05/21] score: Simplify FP context allocation

On Mon, Dec 16, 2019 at 7:28 AM Sebastian Huber wrote: > > Use the stack area to allocate the FP context. This considerably > simplifies the application configuration since the task count no longer > influences the configured work space size. With this change the stack > space size is overestima

Re: [PATCH 02/21] score: Simplify thread stack allocation

On Mon, Dec 16, 2019 at 7:28 AM Sebastian Huber wrote: > > Remove superfluous Thread_Control::Start::stack member. > > Update #3835. > --- > cpukit/include/rtems/score/stackimpl.h | 10 ++ > cpukit/include/rtems/score/thread.h | 2 -- > cpukit/include/rtems/score/threadimpl.h | 17 -

Re: [PATCH v5] Raspberrypi: updated the console interface.

I have described my changes below, just let me know what you think? I will send in the patch once you are happy with it. On Thu, Jan 2, 2020 at 10:07 PM Christian Mauderer wrote: > There is a whitespace error: > > > git am ~/\[PATCH\ v5\]\ Raspberrypi:\ updated\ the\ console\ > interface..eml > A

Re: Requirement Document generator tool

Hello José et al., I have only a few points I would like clarified, below: On Mon, Dec 16, 2019 at 3:35 PM Joel Sherrill wrote: > > > > On Mon, Dec 16, 2019 at 7:29 AM Jose Valdez wrote: >> >> Hello Chris, >> >> Thank you for your reply. >> >> Please find below my answers. >> >> José >> >>

Re: [PATCH v5] Raspberrypi: updated the console interface.

There is a whitespace error: > git am ~/\[PATCH\ v5\]\ Raspberrypi:\ updated\ the\ console\ interface..eml Applying: Raspberrypi: updated the console interface. /home/christian/rtems/rtems-bbb/.git/modules/rtems/rebase-apply/patch:732: trailing whitespace. * @name Bus to Physical address translat

Re: What do you want to study in GSOC 2020?

On Mon, Dec 30, 2019 at 2:47 PM Christian Mauderer wrote: > > On 30/12/2019 15:45, Niteesh wrote: > > On Mon, Dec 30, 2019 at 7:14 PM Christian Mauderer > > wrote: > > > > On 30/12/2019 07:25, Niteesh wrote: > > > > > > > > > On Mon, Dec 30, 2019 at 4:44

Re: [PATCH] Updated docs to use the standalone SIS simulator, instead of GDB inbuilt SIS for the erc32 BSP.

looks good to me. On Fri, Dec 27, 2019 at 5:02 AM G S Niteesh wrote: > > --- > user/start/bsp-test.rst | 4 +- > user/tools/tester.rst | 144 > 2 files changed, 132 insertions(+), 16 deletions(-) > > diff --git a/user/start/bsp-test.rst b/user/start/b

Re: [PATCH] user: Add a link for the setup of frdme310arty BSP

On Wed, Jan 1, 2020 at 11:21 PM Sebastian Huber wrote: > > On 31/12/2019 10:55, Pragnesh Patel wrote: > >> -Original Message- > >> From: Pragnesh Patel > >> Sent: 29 November 2019 19:14 > >> To:sebastian.hu...@embedded-brains.de > >> Cc:devel@rtems.org; Pragnesh Patel > >> Subject: [PATCH]

Re: [PATCH v5] Raspberrypi: updated the console interface.

On 02/01/2020 14:24, Niteesh wrote: > Christian, did you take a look at this? Not yet. I'm not always reachable during my vacation. This is only hobby time ;-) I'll try to take a look soon. > > On Wed, 1 Jan, 2020, 2:45 PM G S Niteesh, > wrote: > > Replaced the o

Re: [PATCH v5] Raspberrypi: updated the console interface.

Christian, did you take a look at this? On Wed, 1 Jan, 2020, 2:45 PM G S Niteesh, wrote: > Replaced the older console api with newer FDT based > console driver. > Replaces the custom pl011 driver with RTEMS arm-pl011 > driver. > --- > bsps/arm/raspberrypi/console/console-config.c | 161