RSB error in MSYS2 MinGW

Hi, I built arm compiler with"../source-builder/sb-set-builder --dry-run --with-download 6/rtems-arm", and got the errors: config: tools/rtems-gdb-head.cfg error: shell macro failed: sh -c "/mingw64/bin/python2-config --ldflags | awk 'BEGIN{FS=\" \"}/python/{for(i=1;i<>

RE: [PATCH 5/8] libtest: Allow assert checks during test begin

-Original Message- From: devel On Behalf Of Sebastian Huber Sent: Friday, November 13, 2020 04:08 To: devel@rtems.org Subject: [PATCH 5/8] libtest: Allow assert checks during test begin > Allow assert checks in test begin actions and setup fixture methods. > --- >

Re: [PATCH v2 2/2] libtests/ofw01: Added a test for RTEMS OFW

On Fri, Nov 20, 2020 at 2:50 PM Christian Mauderer < christian.maude...@embedded-brains.de> wrote: > On a last test before I wanted to push it, I found a problem (sorry). On > BSPs that rely on a FDT the test doesn't work: > No problem :). > You wrap bsp_fdt_get and return another FDT. So as

Re: [PATCH] rtems: Delete rtems_object_id_api_maximum_class()

On 20/11/2020 18:56, Joel Sherrill wrote: It should be implemented. File a ticket if you don't want to do it now. But don't delete it. It should be there for completeness. I would have thought there was code that iterated over all the APIs and classes and used it. What is being used instead?

Re: [PATCH] rtems: Delete rtems_object_id_api_maximum_class()

It should be implemented. File a ticket if you don't want to do it now. But don't delete it. It should be there for completeness. I would have thought there was code that iterated over all the APIs and classes and used it. What is being used instead? On Fri, Nov 20, 2020 at 11:47 AM Sebastian

[PATCH] rtems: Delete rtems_object_id_api_maximum_class()

This function has no implementation. It is documented in the RTEMS Classic API Guide. --- cpukit/include/rtems/rtems/object.h | 17 - 1 file changed, 17 deletions(-) diff --git a/cpukit/include/rtems/rtems/object.h b/cpukit/include/rtems/rtems/object.h index

Re: [PATCH 2/3] score: Add CONFIGURE_INIT_TASK_STORAGE_SIZE

On 20/11/2020 17:51, Gedare Bloom wrote: >> +#if CONFIGURE_INIT_TASK_STACK_SIZE > CONFIGURE_MINIMUM_TASK_STACK_SIZE >> +  #define _CONFIGURE_INIT_TASK_STACK_EXTRA \ >> +    ( CONFIGURE_INIT_TASK_STACK_SIZE - CONFIGURE_MINIMUM_TASK_STACK_SIZE ) > In some other places, we

Re: [PATCH 2/3] score: Add CONFIGURE_INIT_TASK_STORAGE_SIZE

On Fri, Nov 20, 2020 at 9:42 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > On 20/11/2020 17:35, Gedare Bloom wrote: > >> +#else /* CONFIGURE_INIT_TASK_STORAGE_SIZE */ > >> + > >> +#ifndef CONFIGURE_INIT_TASK_STACK_SIZE > >> + #define CONFIGURE_INIT_TASK_STACK_SIZE >

Re: [PATCH 11/20] rtems: Move _Partition_Is_buffer_on_boundary()

On Fri, Nov 20, 2020 at 9:38 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > On 20/11/2020 17:10, Gedare Bloom wrote: > > >> -/** > >> - * @brief Checks whether is on a valid buffer boundary for the_partition. > >> - * > >> - * This function returns TRUE if the_buffer is on a

Re: [PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

On Fri, Nov 20, 2020 at 9:28 AM Sebastian Huber wrote: > > On 20/11/2020 17:15, Gedare Bloom wrote: > > >> +static bool _Partition_Is_buffer_size_aligned( size_t buffer_size ) > > Nit: I never saw this before, but this isn't what "aligned" means. > > Aligned means you start something at a

Re: Proposal for hardware configuration dependent performance limits

On Thu, Nov 19, 2020 at 4:51 PM Chris Johns wrote: > > On 19/11/20 7:26 pm, Sebastian Huber wrote: > > Hello Chris, > > > > On 17/11/2020 22:43, Chris Johns wrote: > > > >> > >> On 17/11/20 6:14 pm, Sebastian Huber wrote: > >>> On 16/11/2020 23:42, Chris Johns wrote: > On 16/11/20 5:40 pm,

Re: [PATCH 2/3] score: Add CONFIGURE_INIT_TASK_STORAGE_SIZE

On 20/11/2020 17:35, Gedare Bloom wrote: +#else /* CONFIGURE_INIT_TASK_STORAGE_SIZE */ + +#ifndef CONFIGURE_INIT_TASK_STACK_SIZE + #define CONFIGURE_INIT_TASK_STACK_SIZE CONFIGURE_MINIMUM_TASK_STACK_SIZE +#endif + +#if CONFIGURE_INIT_TASK_STACK_SIZE > CONFIGURE_MINIMUM_TASK_STACK_SIZE +

Re: [PATCH 11/20] rtems: Move _Partition_Is_buffer_on_boundary()

On 20/11/2020 17:10, Gedare Bloom wrote: -/** - * @brief Checks whether is on a valid buffer boundary for the_partition. - * - * This function returns TRUE if the_buffer is on a valid buffer - * boundary for the_partition, and FALSE otherwise. I think keep these two lines. This function is

Re: [PATCH 2/3] score: Add CONFIGURE_INIT_TASK_STORAGE_SIZE

On Fri, Nov 20, 2020 at 1:31 AM Sebastian Huber wrote: > > In order to better support applications which use the new > rtems_task_construct() directive add the > CONFIGURE_INIT_TASK_STORAGE_SIZE configuration option. If this option > is specified, then the Classic API initialization task is

Re: [PATCH 13/20] rtems: Move _Partition_Is_buffer_area_aligned()

On 20/11/2020 17:24, Sebastian Huber wrote: On 20/11/2020 17:18, Gedare Bloom wrote: On Fri, Nov 20, 2020 at 6:34 AM Sebastian Huber wrote: On 20/11/2020 14:31, Joel Sherrill wrote: Wasn't there Doxygen above it? No. Needs comments I think a one liner function with a very descriptive

Re: [PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

On 20/11/2020 17:15, Gedare Bloom wrote: +static bool _Partition_Is_buffer_size_aligned( size_t buffer_size ) Nit: I never saw this before, but this isn't what "aligned" means. Aligned means you start something at a specific multiple. This is checking if the buffer_size is a multiple of the

Re: [PATCH] c-user: Add CONFIGURE_INIT_TASK_STORAGE_SIZE

ok On Fri, Nov 20, 2020 at 2:36 AM Sebastian Huber wrote: > > Close #4181. > --- > c-user/config/classic-init-task.rst | 52 - > 1 file changed, 51 insertions(+), 1 deletion(-) > > diff --git a/c-user/config/classic-init-task.rst >

Re: [PATCH 13/20] rtems: Move _Partition_Is_buffer_area_aligned()

On 20/11/2020 17:18, Gedare Bloom wrote: On Fri, Nov 20, 2020 at 6:34 AM Sebastian Huber wrote: On 20/11/2020 14:31, Joel Sherrill wrote: Wasn't there Doxygen above it? No. Needs comments I think a one liner function with a very descriptive name needs no comments if it is placed in a

Re: Code coverage via GCOV

On Fri, Nov 20, 2020 at 7:47 AM Sebastian Huber wrote: > > > On 20/11/2020 15:46, Sebastian Huber wrote: > > On 10/11/2020 13:58, Sebastian Huber wrote: > > > >> Hello, > >> > >> I reviewed a bit how the code coverage information is produced by GCC > >> and what libgcov does. I think if we want

Re: [PATCH 13/20] rtems: Move _Partition_Is_buffer_area_aligned()

On Fri, Nov 20, 2020 at 6:34 AM Sebastian Huber wrote: > > On 20/11/2020 14:31, Joel Sherrill wrote: > > > Wasn't there Doxygen above it? > No. > > > > Needs comments > > I think a one liner function with a very descriptive name needs no > comments if it is placed in a source file: > > static

Re: [PATCH 15/20] rtems: Move _Partition_Allocate()

I agree, this one doesn't need a comment, it is quite clear. On Fri, Nov 20, 2020 at 7:08 AM Sebastian Huber wrote: > > On 20/11/2020 15:04, Joel Sherrill wrote: > > > Why are the comments being deleted? > > > > I assume this is happening in all of the patches of this type. Please > > don't do

Re: [PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

On Fri, Nov 20, 2020 at 4:16 AM Sebastian Huber wrote: > > It is only used by rtems_partition_create(). Fix integer type. > --- > cpukit/include/rtems/rtems/partimpl.h | 7 --- > cpukit/rtems/src/partcreate.c | 5 + > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff

Re: [PATCH 11/20] rtems: Move _Partition_Is_buffer_on_boundary()

On Fri, Nov 20, 2020 at 4:16 AM Sebastian Huber wrote: > > It is used only by rtems_partition_return_buffer().Make the PTCB the > first parameter. > --- > cpukit/include/rtems/rtems/partimpl.h | 22 -- > cpukit/rtems/src/partreturnbuffer.c | 17 - > 2

Re: [PATCH 09/20] rtems: Remove _Partition_Destroy()

On Fri, Nov 20, 2020 at 4:15 AM Sebastian Huber wrote: > > It was a trivial function call wrapper used only in one place. > --- > cpukit/include/rtems/rtems/partimpl.h | 7 --- > cpukit/rtems/src/partdelete.c | 2 +- > 2 files changed, 1 insertion(+), 8 deletions(-) > > diff --git

Re: Code coverage via GCOV

On 20/11/2020 15:46, Sebastian Huber wrote: On 10/11/2020 13:58, Sebastian Huber wrote: Hello, I reviewed a bit how the code coverage information is produced by GCC and what libgcov does. I think if we want to use GCOV in RTEMS to get code coverage in all system states, then we need some

Re: Code coverage via GCOV

On 10/11/2020 13:58, Sebastian Huber wrote: Hello, I reviewed a bit how the code coverage information is produced by GCC and what libgcov does. I think if we want to use GCOV in RTEMS to get code coverage in all system states, then we need some tweaks in GCC:

Re: [PATCH 15/20] rtems: Move _Partition_Allocate()

On 20/11/2020 15:04, Joel Sherrill wrote: Why are the comments being deleted? I assume this is happening in all of the patches of this type. Please don't do that. The comment is deleted since the function moves from a header file to a source file and it is a trivial one liner function with

Re: [PATCH 15/20] rtems: Move _Partition_Allocate()

Why are the comments being deleted? I assume this is happening in all of the patches of this type. Please don't do that. On Fri, Nov 20, 2020 at 5:16 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > It is only used by rtems_partition_create(). > --- >

Re: [PATCH 13/20] rtems: Move _Partition_Is_buffer_area_aligned()

On 20/11/2020 14:31, Joel Sherrill wrote: Wasn't there Doxygen above it? No. Needs comments I think a one liner function with a very descriptive name needs no comments if it is placed in a source file: static bool _Partition_Is_buffer_area_aligned( const void *starting_address ) {  

Re: [PATCH 18/20] rtems: Remove EVENT_SETS_NONE_PENDING

On 20/11/2020 14:30, Joel Sherrill wrote: On Fri, Nov 20, 2020, 5:16 AM Sebastian Huber > wrote: This define was only used in one place. ---  cpukit/include/rtems/rtems/eventimpl.h | 8 +---  1 file changed, 1 insertion(+), 7

Re: [PATCH 13/20] rtems: Move _Partition_Is_buffer_area_aligned()

Wasn't there Doxygen above it? Needs comments On Fri, Nov 20, 2020, 5:16 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > It is only used by rtems_partition_create(). > --- > cpukit/include/rtems/rtems/partimpl.h | 7 --- > cpukit/rtems/src/partcreate.c | 5 + >

Re: [PATCH 19/20] rtems: Remove unused _Event_Timeout()

Ok On Fri, Nov 20, 2020, 5:16 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > --- > cpukit/include/rtems/rtems/eventimpl.h | 8 > 1 file changed, 8 deletions(-) > > diff --git a/cpukit/include/rtems/rtems/eventimpl.h > b/cpukit/include/rtems/rtems/eventimpl.h > index

Re: [PATCH 18/20] rtems: Remove EVENT_SETS_NONE_PENDING

On Fri, Nov 20, 2020, 5:16 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > This define was only used in one place. > --- > cpukit/include/rtems/rtems/eventimpl.h | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git

Re: [PATCH] eng: Rework and clarify Doxygen Guidelines

On 19/11/2020 17:28, Joel Sherrill wrote: Is there guidance on embedding figures? dot, plantuml, mscgen? I don't recall if there are actual graphic images embedded. But if there are, we should have source in some acceptable open format. Good question, I only see some uses of @dot in the

[PATCH 16/20] rtems: Canonicalize task event file documentation

--- cpukit/include/rtems/rtems/eventdata.h | 3 ++- cpukit/include/rtems/rtems/eventimpl.h | 2 +- cpukit/rtems/src/eventmp.c | 8 +--- cpukit/rtems/src/eventreceive.c| 5 +++-- cpukit/rtems/src/eventseize.c | 5 +++-- cpukit/rtems/src/eventsend.c | 8

[PATCH 18/20] rtems: Remove EVENT_SETS_NONE_PENDING

This define was only used in one place. --- cpukit/include/rtems/rtems/eventimpl.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/cpukit/include/rtems/rtems/eventimpl.h b/cpukit/include/rtems/rtems/eventimpl.h index 9ccee0adbd..c65c202de4 100644 ---

[PATCH 12/20] rtems: Move _Partition_Is_buffer_size_aligned()

It is only used by rtems_partition_create(). Fix integer type. --- cpukit/include/rtems/rtems/partimpl.h | 7 --- cpukit/rtems/src/partcreate.c | 5 + 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h

[PATCH 19/20] rtems: Remove unused _Event_Timeout()

--- cpukit/include/rtems/rtems/eventimpl.h | 8 1 file changed, 8 deletions(-) diff --git a/cpukit/include/rtems/rtems/eventimpl.h b/cpukit/include/rtems/rtems/eventimpl.h index c65c202de4..dc56ad2127 100644 --- a/cpukit/include/rtems/rtems/eventimpl.h +++

[PATCH 15/20] rtems: Move _Partition_Allocate()

It is only used by rtems_partition_create(). --- cpukit/include/rtems/rtems/partimpl.h | 12 cpukit/rtems/src/partcreate.c | 5 + 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h

[PATCH 17/20] rtems: Remove unused EVENT_CURRENT

--- cpukit/include/rtems/rtems/eventimpl.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/cpukit/include/rtems/rtems/eventimpl.h b/cpukit/include/rtems/rtems/eventimpl.h index 141ea46082..9ccee0adbd 100644 --- a/cpukit/include/rtems/rtems/eventimpl.h +++

[PATCH 13/20] rtems: Move _Partition_Is_buffer_area_aligned()

It is only used by rtems_partition_create(). --- cpukit/include/rtems/rtems/partimpl.h | 7 --- cpukit/rtems/src/partcreate.c | 5 + 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h b/cpukit/include/rtems/rtems/partimpl.h index

[PATCH 09/20] rtems: Remove _Partition_Destroy()

It was a trivial function call wrapper used only in one place. --- cpukit/include/rtems/rtems/partimpl.h | 7 --- cpukit/rtems/src/partdelete.c | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h

[PATCH 11/20] rtems: Move _Partition_Is_buffer_on_boundary()

It is used only by rtems_partition_return_buffer().Make the PTCB the first parameter. --- cpukit/include/rtems/rtems/partimpl.h | 22 -- cpukit/rtems/src/partreturnbuffer.c | 17 - 2 files changed, 16 insertions(+), 23 deletions(-) diff --git

[PATCH 07/20] rtems: Move _Partition_Free_buffer()

It is only used by rtems_partition_return_buffer(). --- cpukit/include/rtems/rtems/partimpl.h | 13 - cpukit/rtems/src/partreturnbuffer.c | 9 + 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h

[PATCH 08/20] rtems: Remove _Partition_Free()

It was a trivial function call wrapper used only in one place. --- cpukit/include/rtems/rtems/partimpl.h | 14 -- cpukit/rtems/src/partdelete.c | 2 +- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h

[PATCH 05/20] rtems: Update partition documentation

--- cpukit/include/rtems/rtems/partdata.h | 91 ++- cpukit/include/rtems/rtems/partimpl.h | 24 ++- 2 files changed, 84 insertions(+), 31 deletions(-) diff --git a/cpukit/include/rtems/rtems/partdata.h b/cpukit/include/rtems/rtems/partdata.h index

[PATCH 20/20] rtems: Update event documentation

--- cpukit/include/rtems/rtems/eventdata.h | 6 ++ cpukit/include/rtems/rtems/eventimpl.h | 86 ++ 2 files changed, 79 insertions(+), 13 deletions(-) diff --git a/cpukit/include/rtems/rtems/eventdata.h b/cpukit/include/rtems/rtems/eventdata.h index

[PATCH 14/20] rtems: Move _Partition_Initialize()

It is only used by rtems_partition_create(). Fix integer types. --- cpukit/include/rtems/rtems/partimpl.h | 25 - cpukit/rtems/src/partcreate.c | 25 + 2 files changed, 25 insertions(+), 25 deletions(-) diff --git

[PATCH 06/20] rtems: Move _Partition_Allocate_buffer()

It is only used by rtems_partition_get_buffer(). --- cpukit/include/rtems/rtems/partimpl.h | 14 -- cpukit/rtems/src/partgetbuffer.c | 6 ++ 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/cpukit/include/rtems/rtems/partimpl.h

[PATCH 10/20] rtems: Move _Partition_Is_buffer_valid()

It is used only in one place. Make the PTCB the first parameter. --- cpukit/include/rtems/rtems/partimpl.h | 23 --- cpukit/rtems/src/partreturnbuffer.c | 18 +- 2 files changed, 17 insertions(+), 24 deletions(-) diff --git

[PATCH 03/20] libio: Move to RTEMS implementation group

--- cpukit/include/rtems/libio.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpukit/include/rtems/libio.h b/cpukit/include/rtems/libio.h index f1c9eea51b..18141c3d3c 100644 --- a/cpukit/include/rtems/libio.h +++ b/cpukit/include/rtems/libio.h @@ -1260,6 +1260,8 @@ int

[PATCH 02/20] doxygen: Use common syntax for groups

--- bsps/shared/doxygen.h | 8 cpukit/doxygen/top-level-groups.h | 7 --- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/bsps/shared/doxygen.h b/bsps/shared/doxygen.h index 28bd4990f7..d3679c2f3d 100644 --- a/bsps/shared/doxygen.h +++

[PATCH 04/20] rtems: Canonicalize partition file documentation

--- cpukit/include/rtems/rtems/partdata.h | 3 ++- cpukit/include/rtems/rtems/partimpl.h | 3 ++- cpukit/rtems/src/part.c | 5 +++-- cpukit/rtems/src/partcreate.c | 5 +++-- cpukit/rtems/src/partdelete.c | 8 +--- cpukit/rtems/src/partgetbuffer.c | 8

[PATCH 00/20] Apply new Doxygen guidelines

Adjust some high level Doxygen groups and rework the Partition Manager and Events according to the new Doxygen guidelines. Sebastian Huber (20): doxygen: Rename Internal to Implementation doxygen: Use common syntax for groups libio: Move to RTEMS implementation group rtems: Canonicalize

[PATCH 01/20] doxygen: Rename Internal to Implementation

Use a top-level implementation group to gather implementation related files. The use of "Impl" is shorter and matches with the *impl.h file names. --- cpukit/doxygen.h | 4 ++-- cpukit/doxygen/top-level-groups.h| 4 ++-- cpukit/include/rtems/confdefs.h |

Re: Doubt in rtems_task_wake_after

Yes, it does. I should have thought about that. Thank you. On Thu, Nov 19, 2020 at 11:42 PM Gedare Bloom wrote: > On Wed, Nov 18, 2020 at 11:13 PM Richi Dubey wrote: > > > > Hi, > > > > In the program tm24, the Init task creates only 1 HIGH task that > executes (after Init task finishes) the

[PATCH] c-user: Add CONFIGURE_INIT_TASK_STORAGE_SIZE

Close #4181. --- c-user/config/classic-init-task.rst | 52 - 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/c-user/config/classic-init-task.rst b/c-user/config/classic-init-task.rst index 4d3bf81..dc07068 100644 --- a/c-user/config/classic-init-task.rst

Re: [PATCH v2 2/2] libtests/ofw01: Added a test for RTEMS OFW

On a last test before I wanted to push it, I found a problem (sorry). On BSPs that rely on a FDT the test doesn't work: You wrap bsp_fdt_get and return another FDT. So as soon as one driver of the BSP needs the original FDT, that driver won't work any more. I think I remember that problem

[PATCH 1/3] Avoid INTERNAL_ERROR_RTEMS_INIT_TASK_ENTRY_IS_NULL

Replace a runtime check with a compile time assertion. This makes the INTERNAL_ERROR_RTEMS_INIT_TASK_ENTRY_IS_NULL obsolete. Update #4181. --- cpukit/include/rtems/confdefs/inittask.h| 13 ++ cpukit/include/rtems/score/interr.h | 2 +- cpukit/rtems/src/taskinitusers.c

[PATCH 2/3] score: Add CONFIGURE_INIT_TASK_STORAGE_SIZE

In order to better support applications which use the new rtems_task_construct() directive add the CONFIGURE_INIT_TASK_STORAGE_SIZE configuration option. If this option is specified, then the Classic API initialization task is constructed with rtems_task_construct(). Update #4181. ---

[PATCH 0/3] Add CONFIGURE_INIT_TASK_STORAGE_SIZE

Currently, the Classic API initialization task is created with rtems_task_create(). In order to better support applications which use the new rtems_task_construct() directive add the CONFIGURE_INIT_TASK_STORAGE_SIZE configuration option which constructs the Classic API initialization task with

[PATCH 3/3] validation: Use CONFIGURE_INIT_TASK_STORAGE_SIZE

Update #4181. --- testsuites/validation/ts-default.h | 109 +++-- 1 file changed, 40 insertions(+), 69 deletions(-) diff --git a/testsuites/validation/ts-default.h b/testsuites/validation/ts-default.h index 0f7db65a8e..ba994cdd1a 100644 ---

Re: [PATCH rtems v3 0/7] Add imxrt BSP

Thanks for the reviews. I pushed the patches with changes like discussed. Best regards Christian Am 19.11.20 um 09:51 schrieb Christian Mauderer: Hello, again an updated version. There haven't been relevant changes beneath patch 3 (some follow up ones in 7) so I'm only sending patch 3.