Re: [PATCH] powerpc/shared: ISA bus bridge fails to enable the openpic irq

2021-02-06 Thread Chris Johns
On 7/2/21 9:42 am, Joel Sherrill wrote: > -  if ( currentBoard == MVME_2300 ) { > +  if ( currentBoard == MVME_2300 || currentBoard == > MVME_2600_2700_W_MVME761 ) { >      /* nothing to do for W83C553 bridge */ >      known_cpi_isa_bridge = 1; >    } > > I think the patch

Re: [PATCH] powerpc/shared: ISA bus bridge fails to enable the openpic irq

2021-02-06 Thread Chris Johns
On 7/2/21 9:42 am, Joel Sherrill wrote: > On Sat, Feb 6, 2021, 2:09 PM mailto:chr...@rtems.org>> > wrote: > > From: Chris Johns mailto:chr...@rtems.org>> > > - The call to enable the openpic irq for the ISA bridge falls >   because the IRQ used is offset by the ISA bus signals and >

Re: [PATCH] powerpc/shared: ISA bus bridge fails to enable the openpic irq

2021-02-06 Thread Joel Sherrill
On Sat, Feb 6, 2021, 2:09 PM wrote: > From: Chris Johns > > - The call to enable the openpic irq for the ISA bridge falls > because the IRQ used is offset by the ISA bus signals and > the openpic call expects an IRA relative to it's signals. > Falls to fails What's IRA And its not it's

[PATCH] powerpc/shared: ISA bus bridge fails to enable the openpic irq

2021-02-06 Thread chrisj
From: Chris Johns - The call to enable the openpic irq for the ISA bridge falls because the IRQ used is offset by the ISA bus signals and the openpic call expects an IRA relative to it's signals. - Add the MVME 2600/2700 to the list is an ISA bridge. Closes #4231 ---

[PATCH v2 3/4] bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative

2021-02-06 Thread G S Niteesh Babu
Refactored recursive rtems_ofw_get_effective_phandle into a iterative function. --- bsps/shared/ofw/ofw.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index 886ad0252b..78576ecf45 100644 --- a/bsps/shared/ofw/ofw.c +++

[PATCH v2 4/4] bsps/shared/ofw: Bug fixes

2021-02-06 Thread G S Niteesh Babu
Fixed bugs in rtems_ofw_get_prop, rtems_ofw_get_prop_len and removed hardcoded value. --- bsps/shared/ofw/ofw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index 78576ecf45..1c3a81785d 100644 --- a/bsps/shared/ofw/ofw.c

[PATCH v2 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

2021-02-06 Thread G S Niteesh Babu
Update since v1: Using strlcpy instead of memcpy The following series of patches fix bugs and coverity reported defect in bsps/shared/ofw.c. G S Niteesh Babu (4): bsps/shared/ofw: Fix coverity reported defects bsps/shared/ofw: Use strlcpy instead of strncpy bsps/shared/ofw: Make

[PATCH v2 1/4] bsps/shared/ofw: Fix coverity reported defects

2021-02-06 Thread G S Niteesh Babu
Fixed use after free and null pointer dereference defects FIXES: 1) CID 1472601 (NULL_RETURNS) 2) CID 1472600 (USE_AFTER_FREE) 3) CID 1472599 (USE_AFTER_FREE) 4) CID 1472598 (USE_AFTER_FREE) 5) CID 1472596 (USE_AFTER_FREE) The below two defects have to marked false positive 1) CID 1472597

[PATCH v2 2/4] bsps/shared/ofw: Use strlcpy instead of strncpy

2021-02-06 Thread G S Niteesh Babu
Changed rtems_ofw_get_prop to use strlcpy instead of strncpy to ensure the buffer is null terminated incase of overflow. --- bsps/shared/ofw/ofw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index

Remaining Waf Conversion Tickets for Community and GSoC Students

2021-02-06 Thread Joel Sherrill
Hi While potential GSoC students are becoming more familiar with RTEMS and the community,, I wanted to pass along a few tickets that we would appreciate having resolved. https://devel.rtems.org/ticket/4124 - bsp tester needs to be switched to waf https://devel.rtems.org/ticket/4145 - RSB: Update

Re: Completed Hello World task

2021-02-06 Thread Gedare Bloom
Hi Sanskar, Welcome! Please send me a git-patch of your change to RTEMS. We generally underspecify our project descriptions on purpose. The scope that can be accomplished in the timeframe varies depending on individual student experience and skills. So, we like to let the students explore the

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

2021-02-06 Thread Gedare Bloom
On Sat, Feb 6, 2021 at 1:59 AM Christian Mauderer wrote: > On 06/02/2021 06:02, Niteesh G. S. wrote: > > Hello Christian, > > > > On Sat, Feb 6, 2021 at 2:33 AM Christian Mauderer > > wrote: > > > > On 05/02/2021 19:22, Gedare Bloom wrote: > > > > > > >

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

2021-02-06 Thread Christian Mauderer
On 06/02/2021 06:02, Niteesh G. S. wrote: Hello Christian, On Sat, Feb 6, 2021 at 2:33 AM Christian Mauderer > wrote: On 05/02/2021 19:22, Gedare Bloom wrote: > > > On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu mailto:niteesh...@gmail.com>