Re: [PATCH] rld-cc: Add -target to recognised cflags

Ping On Wed, 24 Mar 2021 at 09:57, Hesham Almatary wrote: > -target *-*-* flag is necessary for LLVM/Clang while cross-compiling > --- > rtemstoolkit/rld-cc.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rtemstoolkit/rld-cc.cpp b/rtemstoolkit/rld-cc.cpp > index bb03ff6..b424214 10

Re: [PATCH RSB 5 v2] gdb-9-1: Add patch to fix linker error with gcc10

On Tue, Mar 30, 2021 at 10:45 PM Chris Johns wrote: > > On 31/3/21 3:29 pm, Vijay Kumar Banerjee wrote: > > On Tue, Mar 30, 2021 at 10:24 PM Chris Johns wrote: > >> > >> OK for 5 the branch. > >> > > Thanks. will it be ok for master as well? I have created a cloned > > ticket for master: #4367. >

Re: [PATCH RSB 5 v2] gdb-9-1: Add patch to fix linker error with gcc10

On 31/3/21 3:29 pm, Vijay Kumar Banerjee wrote: > On Tue, Mar 30, 2021 at 10:24 PM Chris Johns wrote: >> >> OK for 5 the branch. >> > Thanks. will it be ok for master as well? I have created a cloned > ticket for master: #4367. Master is more complicated because what we have currently does not bu

Re: [PATCH 2/2] rtl-allocator.c: Put dereferences after nullcheck

+1 ... but it is blocked by the 1/2 patch until that is resolved or a v2 patch set is created. On 31/3/21 4:05 am, Gedare Bloom wrote: > ok > > On Tue, Mar 30, 2021 at 10:57 AM Ryan Long wrote: >> >> ping >> >> -Original Message- >> From: Ryan Long >> Sent: Monday, March 22, 2021 12:08

Re: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails

On 31/3/21 4:08 am, Gedare Bloom wrote: > This looks ok. I'm wondering however if these rtems_rtl_lock () ever > should fail in practice, should it be an assert? Just wondering. Good question, I cannot remember. Maybe a better solution is to move to a statically allocated lock using the newer inte

Re: [PATCH RSB 5 v2] gdb-9-1: Add patch to fix linker error with gcc10

Hi Chris, On Tue, Mar 30, 2021 at 10:24 PM Chris Johns wrote: > > OK for 5 the branch. > Thanks. will it be ok for master as well? I have created a cloned ticket for master: #4367. > It was a really great piece of work by everyone to sort this out. I have > recently been hit by 4 separate cases

Re: [PATCH RSB 5 v2] gdb-9-1: Add patch to fix linker error with gcc10

OK for 5 the branch. It was a really great piece of work by everyone to sort this out. I have recently been hit by 4 separate cases of this change in gcc10 effecting code. Thanks Chris On 31/3/21 11:19 am, Vijay Kumar Banerjee wrote: > Close #4366 > --- > rtems/config/tools/rtems-gdb-9.1-1.cfg

Re: [rtems-tools commit] rld-process: Add named tempfile constructor

Hi, When I looked at this on vc@ I saw it is broken. I am sorry I did not pick this up in the review. On 31/3/21 5:20 am, Joel Sherrill wrote: > Module:rtems-tools > Branch:master > Commit:420d7a13672991a1480d06ac02190f2976b9253b > Changeset: > http://git.rtems.org/rtems-tools/commit

Re: Ticket#3889 updated

I have both of the options and i tried to built it with BUILD_TESTS and PSXTESTS and the test didn't build. Is there anything else that could alter how rtems is built? Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Tuesday, March 30, 2021 3:29 PM, Gedare Bloom wrote:

Re: [PATCH RSB 5] gdb-9-1: Add patch for linker error

On Tue, Mar 30, 2021 at 4:52 PM Joel Sherrill wrote: > > > > On Tue, Mar 30, 2021, 5:23 PM Vijay Kumar Banerjee wrote: >> >> On Tue, Mar 30, 2021 at 4:18 PM Joel Sherrill wrote: >> > >> > It is preferred not to add patches to our repos when you can reference the >> > upstream to fetch it. You s

[PATCH RSB 5 v2] gdb-9-1: Add patch to fix linker error with gcc10

Close #4366 --- rtems/config/tools/rtems-gdb-9.1-1.cfg | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rtems/config/tools/rtems-gdb-9.1-1.cfg b/rtems/config/tools/rtems-gdb-9.1-1.cfg index 99e6571..1d14a20 100644 --- a/rtems/config/tools/rtems-gdb-9.1-1.cfg +++ b/rtems/config/tools/rtems-g

Re: Ticket#3889 updated

my waf file look like this $cat config.ini [sparc/leon3] BUILD_TESTS=True for rebuilding the bsp I ran: ./waf configure ./waf Zack Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Tuesday, March 30, 2021 9:02 PM, Gedare Bloom wrote: > On Tue, Mar 30, 2021 at 2:41 PM zack

Re: [PATCH RSB 5] gdb-9-1: Add patch for linker error

On Tue, Mar 30, 2021, 5:23 PM Vijay Kumar Banerjee wrote: > On Tue, Mar 30, 2021 at 4:18 PM Joel Sherrill wrote: > > > > It is preferred not to add patches to our repos when you can reference > the upstream to fetch it. You should be able to reference the URL where the > "raw" view of the patch

Re: [PATCH RSB 5] gdb-9-1: Add patch for linker error

On Tue, Mar 30, 2021 at 4:18 PM Joel Sherrill wrote: > > It is preferred not to add patches to our repos when you can reference the > upstream to fetch it. You should be able to reference the URL where the "raw" > view of the patch is. > Thanks for reviewing. The issue with that was that I was g

Re: [PATCH RSB 5] gdb-9-1: Add patch for linker error

It is preferred not to add patches to our repos when you can reference the upstream to fetch it. You should be able to reference the URL where the "raw" view of the patch is. On Tue, Mar 30, 2021 at 4:56 PM Vijay Kumar Banerjee wrote: > Close #4366 > --- > rtems/config/tools/rtems-gdb-9.1-1.cfg

[PATCH RSB 5] gdb-9-1: Add patch for linker error

Close #4366 --- rtems/config/tools/rtems-gdb-9.1-1.cfg| 3 + .../patches/gdb-9-1-linker-error-fix.diff | 67 +++ 2 files changed, 70 insertions(+) create mode 100644 source-builder/patches/gdb-9-1-linker-error-fix.diff diff --git a/rtems/config/tools/rtems-gdb-9.1-1.

[PATCH 2/3] misc/wscript: Specify C language version

CentOS 7 has gcc 4.8 which defaults to C90 and this results in warnings for code that is valid C99 but not C90. --- misc/wscript | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/misc/wscript b/misc/wscript index 521eddf..21e7f75 100644 --- a/misc/wscript +++ b/misc/wscript @@

[PATCH 3/3] trace/wscript: Specify C language version

CentOS 7 has gcc 4.8 which defaults to C90 and this results in warnings for code that is valid C99 but not C90. --- trace/wscript | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/trace/wscript b/trace/wscript index 53a1ab4..a3dd5d5 100644 --- a/trace/wscript +++ b/trace/wsc

[PATCH 1/3] rtems-bin2c.c: Define _GNU_SOURCE for strnlen()

--- misc/bin2c/rtems-bin2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/bin2c/rtems-bin2c.c b/misc/bin2c/rtems-bin2c.c index 7ed79dd..397f2ad 100644 --- a/misc/bin2c/rtems-bin2c.c +++ b/misc/bin2c/rtems-bin2c.c @@ -25,6 +25,7 @@ * */ +#define _GNU_SOURCE // for strnlen #includ

Re: Ticket#3889 updated

On Tue, Mar 30, 2021 at 2:41 PM zack_on_the_speed_chanel wrote: > > I have both of the options and i tried to built it with BUILD_TESTS and > PSXTESTS and the test didn't build. Is there anything else that could alter > how rtems is built? > After you set them to True, did you re-run waf config

Re: Ticket#3889 updated

On Tue, Mar 30, 2021, 14:40 zack_on_the_speed_chanel < zack_on_the_speed_cha...@protonmail.ch> wrote: > I have both of the options and i tried to built it with BUILD_TESTS and > PSXTESTS and the test didn't build. Is there anything else that could > alter how rtems is built? > Those options shoul

Re: Ticket#3889 updated

I did build the leon3 bsp and I still don't see the psxtimer02 as an executable. Is there a way build a test from source? I have the sources for psxtest02. Also i'm thinking that it could be due to the fact that i don't have posix tests enabled. Is there a way that to enable posix? Thanks Zack

Re: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails

This looks ok. I'm wondering however if these rtems_rtl_lock () ever should fail in practice, should it be an assert? Just wondering. On Tue, Mar 30, 2021 at 10:58 AM Ryan Long wrote: > > ping > > -Original Message- > From: Ryan Long > Sent: Monday, March 22, 2021 12:08 PM > To: devel@rt

Re: [PATCH 2/2] rtl-allocator.c: Put dereferences after nullcheck

ok On Tue, Mar 30, 2021 at 10:57 AM Ryan Long wrote: > > ping > > -Original Message- > From: Ryan Long > Sent: Monday, March 22, 2021 12:08 PM > To: devel@rtems.org > Cc: Ryan Long > Subject: [PATCH 2/2] rtl-allocator.c: Put dereferences after nullcheck > > CID 1444139: Dereference null

RE: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails

ping -Original Message- From: Ryan Long Sent: Monday, March 22, 2021 12:08 PM To: devel@rtems.org Cc: Ryan Long Subject: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails CID 1444138: Dereference null return value in rtems_rtl_obj_find_file(). Closes #4332 --- cpukit/lib

RE: [PATCH 2/2] rtl-allocator.c: Put dereferences after nullcheck

ping -Original Message- From: Ryan Long Sent: Monday, March 22, 2021 12:08 PM To: devel@rtems.org Cc: Ryan Long Subject: [PATCH 2/2] rtl-allocator.c: Put dereferences after nullcheck CID 1444139: Dereference null return value in rtems_rtl_alloc_hook(). Closes #4333 --- cpukit/libdl/r

Re: [PATCH rtems-net-legacy 1/2] Remove RTEMS_NETWORKING checks

On Tue, Mar 30, 2021 at 10:40 AM Vijay Kumar Banerjee wrote: > > Hi, > > > On Tue, Mar 30, 2021 at 7:53 AM Gedare Bloom wrote: > > > > On Mon, Mar 29, 2021 at 7:42 PM Vijay Kumar Banerjee > > wrote: > > > > > > ping :) > > > > > > On Tue, Mar 23, 2021 at 2:10 PM Vijay Kumar Banerjee > > > wro

Re: [PATCH rtems-net-legacy 1/2] Remove RTEMS_NETWORKING checks

Hi, On Tue, Mar 30, 2021 at 7:53 AM Gedare Bloom wrote: > > On Mon, Mar 29, 2021 at 7:42 PM Vijay Kumar Banerjee wrote: > > > > ping :) > > > > On Tue, Mar 23, 2021 at 2:10 PM Vijay Kumar Banerjee > > wrote: > > > > > > * Remove nfsclient wscript and build from netlegacy.py > > > --- > > > b

Re: [PATCH rtems-net-legacy] leon, greth: added support for variable sized descriptor table sizes

thanks, go ahead On Tue, Mar 30, 2021 at 9:52 AM Vijay Kumar Banerjee wrote: > > From: Daniel Hellstrom > > The descriptor table size is equal to its alignment and set when > configuring the HW IP through VHDL generics. This SW patch simply > probes the HW how large the RX/TX descrip

Re: GSoC Project- BSP Executable Conversion

Hi Daman, On Sat, Mar 27, 2021 at 12:00 AM Daman Bir Singh wrote: > > Hello, > > Another project I am interested in is ticket #3302, Build System conversion > of BSP Config (.cfg) files to pkg-config (.pc) files. Please guide me which > one is more relevant for GSOC'21 and how to start working

Re: [PATCH 1/3] covoar: Catch exceptional case

alright. (Succumbing to the war of attrition.) On Tue, Mar 30, 2021 at 9:20 AM Alex White wrote: > > ping > > On Fri, Mar 12, 2021 at 11:14 AM Alex White wrote: > > > > --- > > tester/covoar/ExecutableInfo.cc | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/tester/covo

Re: [PATCH rtems-net-legacy 2/2] greth.c: Pull RTEMS commit for variable size descriptor

Hi, On Tue, Mar 30, 2021 at 7:57 AM Gedare Bloom wrote: > > On Tue, Mar 23, 2021 at 2:10 PM Vijay Kumar Banerjee wrote: > > > > RTEMS commit hash: 053b17ce8e3f710167e9ec3f44b37756cbdcbec0 > Please preserve the git authorship information. Sent a new patch with the proper authorship information an

[PATCH rtems-net-legacy] leon, greth: added support for variable sized descriptor table sizes

From: Daniel Hellstrom The descriptor table size is equal to its alignment and set when configuring the HW IP through VHDL generics. This SW patch simply probes the HW how large the RX/TX descriptor tables are and adjusts accordingly. The number of descriptors actual used are

Any Lost Patches?

Hi There has been a flurry of patches which, quite frankly, have made the core developers delighted and a bit overwhelmed. If you have a patch outstanding that you think has slipped through the cracks, please ping the patch and let's make sure it gets the review it needs. Hopefully there won't b

Re: [PATCH rtems-docs] common/latex.py: use distro module for python3.5 and up

On Tue, Mar 30, 2021 at 8:01 AM Gedare Bloom wrote: > > Go ahead; platform.dist is deprecated/removed, and this is the right > replacement to make with backward compat to 2 via > platform.linux_distribution(). > Yes, I have also tested with 2 to ensure it's building. Thanks for the review. Pushed

Re: [PATCH rtems-docs v3] networking: Rename to legacy networking

On Tue, Mar 30, 2021 at 7:43 AM Gedare Bloom wrote: > > Yes, go ahead with this doco patch. > Thanks. Pushed. > On Mon, Mar 29, 2021 at 7:41 PM Vijay Kumar Banerjee wrote: > > > > On Fri, Mar 26, 2021 at 5:26 PM Joel Sherrill wrote: > > > > > > > > > > > > On Fri, Mar 26, 2021, 5:53 PM Vijay Ku

Re: Ticket#3889 updated

BUILD_TESTS and BUILD_PSXTESTS are two options that if either is True it should build psxclock02. On Tue, Mar 30, 2021 at 9:20 AM zack_on_the_speed_chanel wrote: > > I did build the leon3 bsp and I still don't see the psxtimer02 as an > executable. Is there a way build a test from source? I hav

Re: [PATCH rtems-libbsd 1/5] rtemsbsd: Add mv643xx nexus ethernet driver

Hi all, On Tue, Mar 30, 2021 at 1:12 AM Chris Johns wrote: > > On 30/3/21 6:08 pm, Till Straumann wrote: > > None of these additions to libbsd.py -- except for mv643xx_nexus.c > > are in my patches. Note, however, that my pull-request is on top of > > another branch (on request/suggestion by Hein

RE: [PATCH 1/3] covoar: Catch exceptional case

ping On Fri, Mar 12, 2021 at 11:14 AM Alex White wrote: > > --- >  tester/covoar/ExecutableInfo.cc | 10 ++ >  1 file changed, 10 insertions(+) > > diff --git a/tester/covoar/ExecutableInfo.cc b/tester/covoar/ExecutableInfo.cc > index 187bb77..5a730fd 100644 > --- a/tester/covoar/Executabl

RE: [PATCH 3/3] covoar: Fix overflow of high PC address

On Tue, Mar 30, 2021 at 10:09 AM Gedare Bloom wrote: > > looks ok. what happens if the high_pc is 1? Just wondering. Good question. :) I believe a zero-sized AddressRange is constructed and added to that symbol's CoverageMap. It is possibly wasteful, but should not cause a crash or anything.

Re: [PATCH 3/3] covoar: Fix overflow of high PC address

looks ok. what happens if the high_pc is 1? Just wondering. On Tue, Mar 30, 2021 at 8:45 AM Alex White wrote: > > ping > > On Fri, Mar 12, 2021 at 11:14 AM Alex White wrote: > > > > This fixes an integer overflow that would occur if a function's high PC > > address were zero in the DWARF info. >

RE: [PATCH 0/3] Add spidev driver for Xilinx AXI Quad SPI device

Thanks, pushed to master. I will prepare the tickets and patches for backporting next. Best regards, Jan > -Original Message- > From: Gedare Bloom > Sent: Tuesday, March 30, 2021 4:12 PM > To: Sommer, Jan > Cc: devel@rtems.org > Subject: Re: [PATCH 0/3] Add spidev driver for Xilinx

Re: [PATCH 3/3] covoar: Fix overflow of high PC address

ping On Fri, Mar 12, 2021 at 11:14 AM Alex White wrote: > > This fixes an integer overflow that would occur if a function's high PC > address were zero in the DWARF info. > --- >  tester/covoar/ExecutableInfo.cc | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/tester/covoar/Executabl

Re: [PATCH] Open firmware: restore FDT in ofw01 to avoid test timeout

Hello Jiri and Joel, I tested the patch on the i.MXRT BSP and it runs fine. Therefore I pushed it. @Jiri: Thanks for the patch. Best regards Christian Am 28.03.21 um 17:43 schrieb Joel Sherrill: On Sun, Mar 28, 2021, 7:56 AM Jiri Gaisler > wrote: The ofw01 t

Re: [PATCH 0/3] Add spidev driver for Xilinx AXI Quad SPI device

This is all xilinx-zynq/zynqmp stuff. It has sat for several weeks now with no comment, go ahead and merge it. The backport of the driver is probably fine, the shell command will need review--they'll both need tickets for backport also. Gedare On Tue, Mar 30, 2021 at 2:01 AM wrote: > > Just a s

Re: [PATCH rtems-docs] common/latex.py: use distro module for python3.5 and up

Go ahead; platform.dist is deprecated/removed, and this is the right replacement to make with backward compat to 2 via platform.linux_distribution(). On Mon, Mar 29, 2021 at 7:43 PM Vijay Kumar Banerjee wrote: > > Hi, > Sorry for too many pings at once :) > > Thanks. > > On Tue, Mar 23, 2021 at 2

Re: [PATCH rtems-net-legacy 2/2] greth.c: Pull RTEMS commit for variable size descriptor

On Tue, Mar 23, 2021 at 2:10 PM Vijay Kumar Banerjee wrote: > > RTEMS commit hash: 053b17ce8e3f710167e9ec3f44b37756cbdcbec0 Please preserve the git authorship information. > --- > bsps/shared/grlib/net/greth.c | 22 +++--- > 1 file changed, 15 insertions(+), 7 deletions(-) > > di

Re: [PATCH rtems-net-legacy 1/2] Remove RTEMS_NETWORKING checks

On Mon, Mar 29, 2021 at 7:42 PM Vijay Kumar Banerjee wrote: > > ping :) > > On Tue, Mar 23, 2021 at 2:10 PM Vijay Kumar Banerjee wrote: > > > > * Remove nfsclient wscript and build from netlegacy.py > > --- > > bsps/powerpc/mpc55xxevb/net/smsc9218i.c | 4 +-- > > libmisc/dummy-networking.c

Re: [PATCH rtems-docs v3] networking: Rename to legacy networking

Yes, go ahead with this doco patch. On Mon, Mar 29, 2021 at 7:41 PM Vijay Kumar Banerjee wrote: > > On Fri, Mar 26, 2021 at 5:26 PM Joel Sherrill wrote: > > > > > > > > On Fri, Mar 26, 2021, 5:53 PM Vijay Kumar Banerjee wrote: > >> > >> Hi Joel, > >> > >> On Fri, Mar 26, 2021, 16:46 Joel Sherri

RE: [PATCH 0/3] Add spidev driver for Xilinx AXI Quad SPI device

Just a short bump for this patch. > -Original Message- > From: Sommer, Jan > Sent: Wednesday, March 10, 2021 9:15 PM > To: devel@rtems.org > Cc: Sommer, Jan > Subject: [PATCH 0/3] Add spidev driver for Xilinx AXI Quad SPI device > > This patchset adds a spidev driver for the Xilinx AXI Q

Re: [PATCH rtems-docs v2] User/BSPs/Beagle: Add JTAG debugger section

Hello Gedare and Chris, thanks for the review. I pushed the patch. Best regards Christian Am 30.03.21 um 09:19 schrieb Chris Johns: And me. Thanks. Chris On 30/3/21 7:47 am, Gedare Bloom wrote: looks fine to me On Mon, Mar 29, 2021 at 1:12 PM Christian Mauderer wrote: --- user/bsps/a

Re: [PATCH rtems-docs v2] User/BSPs/Beagle: Add JTAG debugger section

And me. Thanks. Chris On 30/3/21 7:47 am, Gedare Bloom wrote: > looks fine to me > > On Mon, Mar 29, 2021 at 1:12 PM Christian Mauderer wrote: >> >> --- >> user/bsps/arm/beagle.rst | 67 ++-- >> 1 file changed, 65 insertions(+), 2 deletions(-) >> >> diff --g

Re: [PATCH rtems 01/18] Broke low-level parts of mv643xx_eth driver into separate files

On 30/3/21 6:03 pm, Till Straumann wrote: > Hi Chris. > > On 3/30/21 4:16 AM, Chris Johns wrote: >> Hi, >> >> Thanks for bring this to our attention. >> >> I have pinged Till via github about the patches. >> >> There is no point adding these to master because the legacy stack has moved >> so >> a

Re: [PATCH rtems-libbsd 1/5] rtemsbsd: Add mv643xx nexus ethernet driver

On 30/3/21 6:08 pm, Till Straumann wrote: > None of these additions to libbsd.py -- except for mv643xx_nexus.c > are in my patches. Note, however, that my pull-request is on top of > another branch (on request/suggestion by Heinz Junkes): 'RTEMS:5-freebsd-12'. Thanks, that is what I thought. I thi

Re: [PATCH rtems 03/18] verified that we can compile with MVETH_TESTING and MVETH_DEBUG

On 30/3/21 5:58 pm, Till Straumann wrote: > This emailing of patches is too confusing and time-consuming for me. That is a shame, it is the process we have. > The tip of my branch which I submitted as a pull request > (c77e67ef3cbf71e27ac5daa6a4c4b5acb4f4ba0e) > does not #define MVETH_DEBUG. Int